[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287686#comment-15287686
]
Hudson commented on MAPREDUCE-6657:
---
SUCCESS: Integrated in Hadoop-trunk-Commit #9807 (See
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285726#comment-15285726
]
Junping Du commented on MAPREDUCE-6657:
---
The test failure is not related.
007 patch LGTM. +1.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285495#comment-15285495
]
Haibo Chen commented on MAPREDUCE-6657:
---
Tests timed out, don't think it is related to this
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285376#comment-15285376
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284987#comment-15284987
]
Haibo Chen commented on MAPREDUCE-6657:
---
Updated the patch with Junping's comments on adding a
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283178#comment-15283178
]
Junping Du commented on MAPREDUCE-6657:
---
bq. I think the HDFS change is trivial and it would be
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283023#comment-15283023
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283020#comment-15283020
]
Robert Kanter commented on MAPREDUCE-6657:
--
I chatted with [~haibochen]. I think the HDFS
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283005#comment-15283005
]
Daniel Templeton commented on MAPREDUCE-6657:
-
[~haibochen], thanks. As long as you file
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282996#comment-15282996
]
Haibo Chen commented on MAPREDUCE-6657:
---
Thanks a lot for your remarks, [~djp]. For this jira, I
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281517#comment-15281517
]
Junping Du commented on MAPREDUCE-6657:
---
bq. Do you think we should create a subclass of
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280928#comment-15280928
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280712#comment-15280712
]
Haibo Chen commented on MAPREDUCE-6657:
---
Sorry for misunderstanding your previous comments. Do
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280564#comment-15280564
]
Junping Du commented on MAPREDUCE-6657:
---
Thanks for updating the patch, [~haibochen].
My above
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280516#comment-15280516
]
Haibo Chen commented on MAPREDUCE-6657:
---
Thanks very much for your review, [~djp]. I have
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280426#comment-15280426
]
Junping Du commented on MAPREDUCE-6657:
---
Thanks [~haibochen] for the patch.
The hard code of
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280098#comment-15280098
]
Daniel Templeton commented on MAPREDUCE-6657:
-
OK. Latest patch looks good to me.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258990#comment-15258990
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258981#comment-15258981
]
Haibo Chen commented on MAPREDUCE-6657:
---
isNameNodeUnavailable() might be a little too broad as
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258894#comment-15258894
]
Daniel Templeton commented on MAPREDUCE-6657:
-
Can we make the method name should be
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256711#comment-15256711
]
Ray Chiang commented on MAPREDUCE-6657:
---
Maybe rename it to "checkNameNodeNotStartedYet" or just
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256699#comment-15256699
]
Daniel Templeton commented on MAPREDUCE-6657:
-
Looks good, [~haibochen]. One thing I just
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251175#comment-15251175
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251038#comment-15251038
]
Haibo Chen commented on MAPREDUCE-6657:
---
Thanks [~templedf] and @Ray Chiang for your reviews. I
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250774#comment-15250774
]
Ray Chiang commented on MAPREDUCE-6657:
---
Reviewed the latest patch. Looks good. +1
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250546#comment-15250546
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250484#comment-15250484
]
Daniel Templeton commented on MAPREDUCE-6657:
-
Thanks, [~haibochen]. Some comments:
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250435#comment-15250435
]
Daniel Templeton commented on MAPREDUCE-6657:
-
I think you uploaded the wrong patch. :)
>
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250356#comment-15250356
]
Haibo Chen commented on MAPREDUCE-6657:
---
Unit test failures are unrelated to this patch
> job
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249127#comment-15249127
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248625#comment-15248625
]
Haibo Chen commented on MAPREDUCE-6657:
---
updated the test method according to [~templedf]'s
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247698#comment-15247698
]
Daniel Templeton commented on MAPREDUCE-6657:
-
The message says that the server should
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246860#comment-15246860
]
Haibo Chen commented on MAPREDUCE-6657:
---
Thanks a lot for you comments, [~templedf] I have added
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246282#comment-15246282
]
Daniel Templeton commented on MAPREDUCE-6657:
-
Thanks for the patch, [~haibochen].
I hate
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212135#comment-15212135
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211473#comment-15211473
]
Hadoop QA commented on MAPREDUCE-6657:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
36 matches
Mail list logo