[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2020-08-13 Thread Kihwal Lee (Jira)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177385#comment-17177385 ] Kihwal Lee commented on MAPREDUCE-7069: --- This should have made to other release branches.

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435900#comment-16435900 ] Hudson commented on MAPREDUCE-7069: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13984

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435838#comment-16435838 ] Jason Lowe commented on MAPREDUCE-7069: --- +1 lgtm as well. The two unit tests that are failing

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435733#comment-16435733 ] Shane Kumpf commented on MAPREDUCE-7069: Thanks, [~Jim_Brennan]. The latest patch lgtm, +1

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434641#comment-16434641 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], unit test is unrelated.  This is ready for

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434615#comment-16434615 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434225#comment-16434225 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], [~shaneku...@gmail.com], thanks again for

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434026#comment-16434026 ] Jim Brennan commented on MAPREDUCE-7069: I can do this for some of them, but the base

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434021#comment-16434021 ] Jason Lowe commented on MAPREDUCE-7069: --- Given this is XML and not HTML I think we should avoid

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433948#comment-16433948 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], [~shaneku...@gmail.com], thanks for the

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-11 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433947#comment-16433947 ] Shane Kumpf commented on MAPREDUCE-7069: Circling back. Successfully tested with the 006 patch

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-10 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433057#comment-16433057 ] Shane Kumpf commented on MAPREDUCE-7069: Thanks for the patch [~Jim_Brennan]! I'm working on

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-10 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433021#comment-16433021 ] Jason Lowe commented on MAPREDUCE-7069: --- Thanks for updating the patch! We're getting close.

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432873#comment-16432873 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], this is ready for review.  > Add ability

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432861#comment-16432861 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-10 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432416#comment-16432416 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe] thanks for the review!  I've addressed your

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431378#comment-16431378 ] Jason Lowe commented on MAPREDUCE-7069: --- Thanks for updating the patch! Looks like

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-09 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430549#comment-16430549 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], I think this is ready for review - the unit

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429175#comment-16429175 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428799#comment-16428799 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-06 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428382#comment-16428382 ] Jim Brennan commented on MAPREDUCE-7069: I put up a new patch that fixes the

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427808#comment-16427808 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-04 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425908#comment-16425908 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe] thanks for the thorough review.  Much

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425770#comment-16425770 ] Jason Lowe commented on MAPREDUCE-7069: --- Thanks for the patch! It's a bit odd and inefficient

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-03 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424557#comment-16424557 ] Jim Brennan commented on MAPREDUCE-7069: [~jlowe], I believe this is ready for review.  The

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424543#comment-16424543 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-03 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424178#comment-16424178 ] Jim Brennan commented on MAPREDUCE-7069: Fixed the checkstyle issues and put up a new patch. 

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423263#comment-16423263 ] Hadoop QA commented on MAPREDUCE-7069: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually

2018-04-02 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422913#comment-16422913 ] Jim Brennan commented on MAPREDUCE-7069: Currently using Configuration.getPropsWithPrefix()