[jira] [Work logged] (MAPREDUCE-7317) Add latency information in FileOutputCommitter.mergePaths
[
https://issues.apache.org/jira/browse/MAPREDUCE-7317?focusedWorklogId=542670=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542670
]
ASF GitHub Bot logged work on MAPREDUCE-7317:
-
Author: ASF GitHub Bot
Created on: 27/Jan/21 06:17
Start Date: 27/Jan/21 06:17
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768060327
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 56m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 46s | | trunk passed |
| +1 :green_heart: | compile | 0m 46s | | trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | checkstyle | 0m 38s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 45s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 1s | | branch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 25s | | trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 23s | | trunk passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +0 :ok: | spotbugs | 1m 20s | | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 18s | | trunk passed |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 32s | | the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 32s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | checkstyle | 0m 26s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 31s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no
whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 45s | | patch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | findbugs | 1m 20s | | the patch passed |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 2s | | hadoop-mapreduce-client-core in
the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | | The patch does not
generate ASF License warnings. |
| | | 139m 4s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2624/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2624 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 70605f252ffa 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 80c7404b519 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2624/3/testReport/ |
| Max. process+thread count | 1676 (vs. ulimit of 5500) |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
U:
[jira] [Commented] (MAPREDUCE-7070) Batch calls to RackResolver from AM
[
https://issues.apache.org/jira/browse/MAPREDUCE-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272595#comment-17272595
]
Hadoop QA commented on MAPREDUCE-7070:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
59s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
7s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
32s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
51s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
51s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
50s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
19m 34s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
50s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
12s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs
config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
15s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
27s{color} |
{color:red}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/51/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt{color}
| {color:red} hadoop-yarn-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 6m
24s{color} |
{color:red}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/51/artifact/out/patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt{color}
| {color:red} root in the patch failed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 6m 24s{color}
|
{color:red}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/51/artifact/out/patch-compile-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt{color}
| {color:red} root in the patch failed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 5m
56s{color} |
{color:red}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/51/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt{color}
| {color:red} root in the patch failed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 5m
[jira] [Work logged] (MAPREDUCE-7317) Add latency information in FileOutputCommitter.mergePaths
[ https://issues.apache.org/jira/browse/MAPREDUCE-7317?focusedWorklogId=542620=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542620 ] ASF GitHub Bot logged work on MAPREDUCE-7317: - Author: ASF GitHub Bot Created on: 27/Jan/21 04:00 Start Date: 27/Jan/21 04:00 Worklog Time Spent: 10m Work Description: HeartSaVioR commented on pull request #2624: URL: https://github.com/apache/hadoop/pull/2624#issuecomment-768006743 Thanks for suggestion. Reflected review comment. The most of add/delete lines are simply indentation change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 542620) Time Spent: 1h 20m (was: 1h 10m) > Add latency information in FileOutputCommitter.mergePaths > - > > Key: MAPREDUCE-7317 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7317 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: client >Reporter: Jungtaek Lim >Priority: Minor > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > We have been observed some occurrences of huge delay from file output > committer V1, where file output committer V2 is not an option. > While the root cause should have investigated on our side, there's another > issue that there's insufficient information to debug. Most likely the huge > delay comes from mergePaths, but the class only provides the "debug" log > message to log the call itself with parameters, nothing else. mergePaths has > been called recursively which is harder to trace how much latency specific > directory takes to merge. > It would be nice and not intrusive to add latency info in mergePath, so that > we can see how much latency specific directory takes to merge, only when > debug log is enabled. > (Ideally it'd be nice if we can log warn message when the call takes huge > time to process, but I don't have the proper threshold for the "huge time", > so I'd avoid dealing with it altogether here.) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7070) Batch calls to RackResolver from AM
[ https://issues.apache.org/jira/browse/MAPREDUCE-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272540#comment-17272540 ] Zhankun Tang commented on MAPREDUCE-7070: - [~gphillips], Thanks for the contribution! Is it better to develop a new "MRRackResolver" which decouple this from YARN? In that case, the MR application can run on a YARN version without YARN-9332. > Batch calls to RackResolver from AM > --- > > Key: MAPREDUCE-7070 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7070 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: applicationmaster, performance >Reporter: Greg Phillips >Priority: Minor > Attachments: MAPREDUCE-7070.patch > > > TaskAttemptImpl calls RackResolver once for every split location. This > results in many shells being spawned by the Application Master when the > topology script is enabled. The worst case scenario would entail one call to > the topology script for each Datanode. The NameNode is also topology aware, > and uses batch calls to the topology script to improve performance. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Work logged] (MAPREDUCE-7317) Add latency information in FileOutputCommitter.mergePaths
[
https://issues.apache.org/jira/browse/MAPREDUCE-7317?focusedWorklogId=542494=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542494
]
ASF GitHub Bot logged work on MAPREDUCE-7317:
-
Author: ASF GitHub Bot
Created on: 26/Jan/21 22:58
Start Date: 26/Jan/21 22:58
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2624:
URL: https://github.com/apache/hadoop/pull/2624#issuecomment-767882952
Use DurationInfo in a try-with-resources; it will log start and end with
timings @ debug
```java
try (DurationInfo d = new DurationInfo(LOG,
"Aborting commit ID %s to path %s", uploadId, destKey)) {
writeOperations.abortMultipartCommit(destKey, uploadId);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 542494)
Time Spent: 1h 10m (was: 1h)
> Add latency information in FileOutputCommitter.mergePaths
> -
>
> Key: MAPREDUCE-7317
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7317
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
>Reporter: Jungtaek Lim
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We have been observed some occurrences of huge delay from file output
> committer V1, where file output committer V2 is not an option.
> While the root cause should have investigated on our side, there's another
> issue that there's insufficient information to debug. Most likely the huge
> delay comes from mergePaths, but the class only provides the "debug" log
> message to log the call itself with parameters, nothing else. mergePaths has
> been called recursively which is harder to trace how much latency specific
> directory takes to merge.
> It would be nice and not intrusive to add latency info in mergePath, so that
> we can see how much latency specific directory takes to merge, only when
> debug log is enabled.
> (Ideally it'd be nice if we can log warn message when the call takes huge
> time to process, but I don't have the proper threshold for the "huge time",
> so I'd avoid dealing with it altogether here.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
