[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335217#comment-15335217
]
Akira AJISAKA commented on MAPREDUCE-6542:
--
+1, committing this.
> HistoryViewer use
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333964#comment-15333964
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333849#comment-15333849
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks [~ajisakaa] remind. I update the patch.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333672#comment-15333672
]
Akira AJISAKA commented on MAPREDUCE-6542:
--
Thank you for the update. Would you add
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333610#comment-15333610
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333546#comment-15333546
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v15.patch for review
> HistoryViewer
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333541#comment-15333541
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks [~ajisakaa]. I update the patch
>
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330132#comment-15330132
]
Akira AJISAKA commented on MAPREDUCE-6542:
--
In addition, would you fix the checkstyle
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330111#comment-15330111
]
Akira AJISAKA commented on MAPREDUCE-6542:
--
Thanks [~piaoyu zhang] for the long work and
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330020#comment-15330020
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~ajisakaa], wanna spread a little review
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322782#comment-15322782
]
Daniel Templeton commented on MAPREDUCE-6542:
-
{{FAST_DATE_FORMAT}} is fine. I was also
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322599#comment-15322599
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322270#comment-15322270
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks [~templedf]. Did you mean I should change
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320652#comment-15320652
]
Daniel Templeton commented on MAPREDUCE-6542:
-
Thanks for the updated patch, [~piaoyu
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320354#comment-15320354
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320321#comment-15320321
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v13.patch for review
> HistoryViewer
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318555#comment-15318555
]
zhangyubiao commented on MAPREDUCE-6542:
[~templedf],thanks. it's my mistake. base the v10
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317368#comment-15317368
]
Daniel Templeton commented on MAPREDUCE-6542:
-
Thanks for the updated patch, [~piaoyu
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244614#comment-15244614
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235071#comment-15235071
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v12.patch for review
> HistoryViewer
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181471#comment-15181471
]
zhangyubiao commented on MAPREDUCE-6542:
[~djp], Could you please review the code ? :)
>
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180100#comment-15180100
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122877#comment-15122877
]
zhangyubiao commented on MAPREDUCE-6542:
[~djp],Thanks for response. Hopefully you can review
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120154#comment-15120154
]
Junping Du commented on MAPREDUCE-6542:
---
Sorry for late response, [~piaoyu zhang]. I haven't get
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115267#comment-15115267
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115184#comment-15115184
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v10.patch for review. git revision
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082283#comment-15082283
]
zhangyubiao commented on MAPREDUCE-6542:
[~djp] ,Is it OK for commit?
> HistoryViewer use
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075093#comment-15075093
]
zhangyubiao commented on MAPREDUCE-6542:
[~vinodkv],Is it OK for commit?
> HistoryViewer use
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064277#comment-15064277
]
Daniel Templeton commented on MAPREDUCE-6542:
-
+1 (non-binding) Nicely done, [~piaoyu
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062914#comment-15062914
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], one last change:
* Please
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063604#comment-15063604
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063082#comment-15063082
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063477#comment-15063477
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v9.patch for review.
> HistoryViewer
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052050#comment-15052050
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks a lot for [~templedf] for patient guidance.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052051#comment-15052051
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542-v8.patch for review
> HistoryViewer
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052083#comment-15052083
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], that patch looks pretty
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045030#comment-15045030
]
Daniel Templeton commented on MAPREDUCE-6542:
-
Nicely done, [~piaoyu zhang]. The last
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043750#comment-15043750
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks [~templedf], I summit MAPREDUCE-6542-v7.patch
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043780#comment-15043780
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034276#comment-15034276
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], looks great. I'm not sure
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033760#comment-15033760
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks a lot for [~templedf]'s guide.
{code}
@Test
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033748#comment-15033748
]
Junping Du commented on MAPREDUCE-6542:
---
Moving target releases to 2.6.4.
> HistoryViewer use
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032209#comment-15032209
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], making good progress! Now
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030116#comment-15030116
]
Junping Du commented on MAPREDUCE-6542:
---
Hi, can we move this out of 2.6.3? Thanks!
>
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026954#comment-15026954
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026837#comment-15026837
]
zhangyubiao commented on MAPREDUCE-6542:
[~templedf],Thanks a lot for review. I learn so much
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022639#comment-15022639
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], thanks! Looks like you
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021960#comment-15021960
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021854#comment-15021854
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks for Daniel Templeton's answer. I update
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018754#comment-15018754
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], that looks like a
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015463#comment-15015463
]
zhangyubiao commented on MAPREDUCE-6542:
Hi,[~templedf]. Last patch I don't give a unit test.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010725#comment-15010725
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010781#comment-15010781
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010517#comment-15010517
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks for [~templedf]'s answer. I update
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011090#comment-15011090
]
Daniel Templeton commented on MAPREDUCE-6542:
-
Thanks, [~piaoyu zhang]. Looks good to me.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011094#comment-15011094
]
Daniel Templeton commented on MAPREDUCE-6542:
-
BTW, you should look at the checkstyle
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007177#comment-15007177
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], the risk there is moving a
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006385#comment-15006385
]
zhangyubiao commented on MAPREDUCE-6542:
[~templedf],thanks for your help. Just Like you
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005935#comment-15005935
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], thanks for the new patch.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004003#comment-15004003
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003953#comment-15003953
]
zhangyubiao commented on MAPREDUCE-6542:
[~djp] Thank you for your help.
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002265#comment-15002265
]
Junping Du commented on MAPREDUCE-6542:
---
Hi [~piaoyu zhang], thanks for the patch! The
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002310#comment-15002310
]
Hadoop QA commented on MAPREDUCE-6542:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000814#comment-15000814
]
zhangyubiao commented on MAPREDUCE-6542:
[~templedf] Should I add the method into StringUtils
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001428#comment-15001428
]
zhangyubiao commented on MAPREDUCE-6542:
[~templedf] you are right. I search the
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000875#comment-15000875
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], I'd rather keep the method
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999565#comment-14999565
]
Daniel Templeton commented on MAPREDUCE-6542:
-
As it is currently written, this patch
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996543#comment-14996543
]
Daniel Templeton commented on MAPREDUCE-6542:
-
Looks fine to me. Please remove the import
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996505#comment-14996505
]
zhangyubiao commented on MAPREDUCE-6542:
MAPREDUCE-6542.patch for review
> HistoryViewer use
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997459#comment-14997459
]
Naganarasimha G R commented on MAPREDUCE-6542:
--
Thanks for working on this issue [~piaoyu
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996787#comment-14996787
]
Daniel Templeton commented on MAPREDUCE-6542:
-
[~piaoyu zhang], looks better. What's the
[
https://issues.apache.org/jira/browse/MAPREDUCE-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996710#comment-14996710
]
zhangyubiao commented on MAPREDUCE-6542:
Thanks Daniel Templeton to review.I remove the
72 matches
Mail list logo
