[Differential] [Updated, 1,254 lines] D3517: New: MarbleAddQCH.cmake for creating an API dox QCH file during the build

kossebau updated this revision to Diff 8817. kossebau added a comment. update to newer version of ECMAddQCH REPOSITORY R34 Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3517?vs=8606=8817 BRANCH addQCH REVISION DETAIL https://phabricator.kde.org/D3517 AFFECTED FILES

[Differential] [Request, 1,175 lines] D3517: New: MarbleAddQCH.cmake for creating an API dox QCH file during the build

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser, shentey. REVISION SUMMARY Custom copy of upcoming ECMAddQCH.cmake, see https://phabricator.kde.org/D2854 for existing issues and open questions. TEST PLAN Marble.qch generated by this:

[Differential] [Request, 102 lines] D3369: Install a pri file, so qmake-based projects just need: QT += Marble

kossebau created this revision. kossebau added a reviewer: Marble. REPOSITORY rMARBLE Marble BRANCH installPriFile REVISION DETAIL https://phabricator.kde.org/D3369 AFFECTED FILES src/lib/marble/CMakeLists.txt tools/version/update-version-number.py EMAIL PREFERENCES

[Differential] [Request, 36 lines] D3358: Set RPATH to custom dirs of own and foreign libs; no linking to build dir

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser, shentey. REVISION SUMMARY When installing marble to a non-standard system directory the executable loader needs to be informed about the location of the marble libraries. Until now for marble executables

[Differential] [Request, 1,399 lines] D3316: Remove implicit sharing from GeoDataFeature & subclasses

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, rahn. REVISION SUMMARY Also integrate pimpl classes of more subclasses by subclassing from GeoDataFeaturePrivate Implict sharing conflicts with parentship properties on members of some subclasses REPOSITORY

[Differential] [Updated, 466 lines] D3094: Support for translations with bundled apps, for now Marble Maps

kossebau updated this revision to Diff 7556. kossebau added a comment. Do not fail on install without make bundle_translations before, more README REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3094?vs=7493=7556 BRANCH startFixingCustomLang REVISION

[Differential] [Request, 433 lines] D3094: Support for translations with bundled apps, for now Marble Maps

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, shentey. REVISION SUMMARY A new Script download-pos.sh allows to get marble_qt po files either for trunk, stable or a tag, either all or a certain language. Example: data/lang/download-pos.sh trunk de To be used

[Differential] [Updated, 6 lines] D2969: Unbreak TestGeoDataCopy

kossebau updated this revision to Diff 7179. kossebau added a comment. update to latest master REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2969?vs=7163=7179 BRANCH unbreakTestGeoDataCopy REVISION DETAIL https://phabricator.kde.org/D2969

[Differential] [Request, 6 lines] D2969: Unbreak TestGeoDataCopy

kossebau created this revision. kossebau added reviewers: Marble, shentey. REVISION SUMMARY https://phabricator.kde.org/rMARBLEb1a507ba5d9e2386bc2dd4b2432569910a5e030e changed GeoDataPlacemark::coordinate() to use p()->m_geometry->latLonAltBox().center() instead of

[Differential] [Request, 951 lines] D2951: Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D

kossebau created this revision. kossebau added a reviewer: Marble. REVISION SUMMARY - enforces constness some more (see issue spotted with GeoDataTrack::extendedData()) - delivers inline-ness of the access methods - code should be more familiar to Qt developers REPOSITORY rMARBLE Marble

[Differential] [Request, 1,312 lines] D2828: Split GeoPolygonGraphicsItem class into subtypes Bathymetry, Building, Normal

kossebau created this revision. kossebau added reviewers: Marble, shentey, nienhueser, rahn. REVISION SUMMARY GeoPolygonGraphicsItem has special code paths for polygons of buildings or bathymetry which complicate the logic (and also bring a small price at runtime, due to repeated checks or

[Differential] [Request, 846 lines] D2780: Introducing GeoSceneAbstractTileProjection for tile x/y <-> lonlat

kossebau created this revision. kossebau added a reviewer: Marble. REVISION SUMMARY INITIAL WORKING PROTOTYPE - please give feedback on draft In the current code in some places hard assumptions are made about the projection used by the tile material. Also are calculations duplicated.

[Differential] [Request, 110 lines] D2684: Add and use OsmPlacemarkData::findTag(const QString& key)

kossebau created this revision. kossebau added reviewers: Marble, shentey, nienhueser, sanjibanb. REVISION SUMMARY Some code getting data from OsmPlacemarkData instances currently does a double-lookup with data.containsTagKey(x) & data.tagValue(x). As OsmPlacemarkData already exposes begin

[Differential] [Request, 134 lines] D2598: Do not hardcode font for street styles to Arial, but use generic map font

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, sanjibanb. REVISION SUMMARY - make static methods member methods for access to members (e.g. default font member) - remove default arg value QFont(QLatin1String("Arial") - reuse same QFont object more

[Differential] [Request, 28 lines] D2408: AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration

kossebau created this revision. kossebau added reviewers: Marble, rahn. REVISION SUMMARY In the first recursive call there is no need to recalculate whether the currentCoords parameter of AzimuthalProjectionPrivate::findHorizon(...) is hidden by the globe, because that information is

[Differential] [Updated, 586 lines] D2373: Fix build-ability of installed examples

kossebau updated this revision to Diff 5776. kossebau added a comment. Do not install MarblePlacemarkModel.h and sources of examples which rely on that REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2373?vs=5744=5776 BRANCH fixInstalledExamples

[Differential] [Request, 583 lines] D2373: Fix build-ability of installed examples

kossebau created this revision. kossebau added reviewers: Marble, rahn, sanjibanb, shentey, nienhueser. REVISION SUMMARY - creates fake headers in marble/ prefix in the build dir for headers which are not in lib/marble in the sources, to simulate install paths - update all installed

[Differential] [Updated, 624 lines] D2354: Initial rewrite of worldclock plasmoid and a new worldmap plasma "wallpaper"

kossebau updated this revision to Diff 5705. kossebau added a comment. fixed license key for wallpaper plugin REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2354?vs=5682=5705 BRANCH restorePlasmoid REVISION DETAIL https://phabricator.kde.org/D2354

[Marble-devel] [Differential] [Request, 636 lines] D2354: Initial rewrite of worldclock plasmoid and a new worldmap plasma "wallpaper"

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser, sanjibanb. REVISION SUMMARY - installs a plasma-specific marble qml plugin in a private namespace - exposes the property "radius" on MarbleQuickItem - removes unused, but now conflicting Q_PLUGIN_METADATA

[Marble-devel] [Differential] [Request, 195 lines] D2309: Only export symbols from the libraries that should be exported

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY Using generate_export_header instead manually written export headers should improve coverage across platforms. Size of stripped libmarblewidget-qt5 reduced on Linux e.g. from 11077592

[Marble-devel] [Differential] [Request, 196 lines] D2297: More generic namespace for plugins: org.kde.marble <- org.kde.edu.marble

kossebau created this revision. kossebau added reviewers: Marble, sanjibanb, rahn, nienhueser. REPOSITORY rMARBLE Marble BRANCH removeEduFromNamespaces REVISION DETAIL https://phabricator.kde.org/D2297 AFFECTED FILES examples/cpp/marbleQuick2/main.cpp

[Marble-devel] [Differential] [Request, 534 lines] D2282: Make render positions an enum instead of string-based values

kossebau created this revision. kossebau added reviewers: Marble, rahn, shentey, nienhueser. REVISION SUMMARY Allows build-time check of values used and is faster at runtime, due to comparing bits instead of strings (lists) REPOSITORY rMARBLE Marble BRANCH makeRenderPositionsAnEnum

[Marble-devel] [Differential] [Request, 138 lines] D2279: GeoPainter: consistent qreal-based API, separate regionFromPixmapRect()

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, rahn, shentey. REVISION SUMMARY GeoPainter API had a mixture of int and qreal-based methods, and internally was inconsistently relaying to int or qreal-based QPainter methods. Regions used for painting rects

[Marble-devel] [Differential] [Request, 45 lines] D2147: Fix building without D-Bus (and make it optional)

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, rahn. REVISION SUMMARY - centralize control in a single var MARBLE_NO_DBUS (following pattern of MARBLE_NO_WEBKITWIDGETS) - move setting option BUILD_WITH_DBUS before finding of deps, so it can influence what is

[Marble-devel] [Differential] [Request, 30 lines] D2141: Fix off-by-one/one positioning by GeoPainter::drawEllipse/Rectangle

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY GeoPainter::drawEllipse() & GeoPainter::drawRect() both take the parameters width & height as qreal type, but if !isGeoProjected they do the actual rendering calls using int based

[Marble-devel] [Differential] [Request, 8 lines] D2138: Fix default crosshair having an offset

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY Code assumed all images used for the crosshair have a size of 21x21. The default image though is a PNG of a pre-rendered crosshair with a shadow, which thus is not of that size. That

[Marble-devel] [Differential] [Updated, 216 lines] D2076: Add runner for geo uris

kossebau updated this revision to Diff 4957. kossebau added a comment. Removed bogus zoomlevel setting REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2076?vs=4922=4957 BRANCH addGeoUriRunner REVISION DETAIL https://phabricator.kde.org/D2076

[Marble-devel] [Differential] [Request, 24 lines] D2088: Fix mainwindow titles: do not prepend ourselves the appname

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY The appname is appended by the platform (integration) usually, so that only results in duplication. Also fix code to now show the map in the title on start. REPOSITORY rMARBLE Marble

[Marble-devel] [Differential] [Request, 38 lines] D2087: Drop search and routing results on planet change (QWidget tools only)

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY A more complete solution could perhaps cache the results per planet. So when switching back to a planet, the last search & routing results could be used again. TEST PLAN Switching between

[Marble-devel] [Differential] [Request, 228 lines] D2076: Add runner for geo uris

kossebau created this revision. kossebau added reviewers: Marble, rahn, nienhueser. REVISION SUMMARY Supports only geo uris with CRS mathcing the current globe REPOSITORY rMARBLE Marble BRANCH addGeoUriRunner REVISION DETAIL https://phabricator.kde.org/D2076 AFFECTED FILES

[Marble-devel] [Differential] [Request, 595 lines] D1995: Restore TestGeoDataCoordinates' testFromStringDMS & testFromStringDM

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, rahn. REVISION SUMMARY Those tests had been disabled due to running too long, given the high number of permutations created. A possible solution would be to run the test only on a random subset of those. 5% on

[Marble-devel] [Differential] [Request, 31 lines] D1941: Fix compiling with Qt < 5.4

kossebau created this revision. kossebau added reviewers: nienhueser, rahn. kossebau set the repository for this revision to rMARBLE Marble. kossebau added a project: Marble. REVISION SUMMARY QVector::removeAll/QVector::removeOne were only added in Qt 5.4. So use custom implementation with

[Marble-devel] [Differential] [Updated, 42 lines] D1763: Fix extraction of Qt translation-based strings

kossebau updated the summary for this revision. kossebau updated this revision to Diff 4203. kossebau added a comment. Looking closer, there seems more not correct than just the outdated $XGETTEXT_QT. REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE

[Marble-devel] [Differential] [Request, 55 lines] D1764: Fix loading and setting of translations in KDEMarble app

kossebau created this revision. kossebau added reviewers: Marble, nienhueser, rahn. kossebau set the repository for this revision to rMARBLE Marble. REVISION SUMMARY Qt translations for the libs and plugin need to be actively loaded not only in the QtMarble app, but also in the KDEMarble app.

[Marble-devel] [Differential] [Request, 4 lines] D1763: Fix extraction of Qt translation-based strings

kossebau created this revision. kossebau added subscribers: Marble, nienhueser, aspotashev, yurchor, aacid. kossebau set the repository for this revision to rMARBLE Marble. REVISION SUMMARY To extract Qt tr translatable strings from C++ files for Qt5-based projects $EXTRACT_TR_STRINGS needs

[Marble-devel] [Differential] [Request, 356 lines] D1608: Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)

kossebau created this revision. kossebau added reviewers: rahn, nienhueser. REVISION SUMMARY Currently there is a mix of both signals/slots and Q_SIGNALS/Q_SLOTS. Given Marble is also promoted as library, it seems to make sense to standardize on Q_SIGNALS/Q_SLOTS, and for consistency do

[Marble-devel] [Differential] [Request, 16 lines] D1474: Settle on var names ANDROID_SDK_ROOT/ANDROID_NDK_ROOT

kossebau created this revision. kossebau added reviewers: nienhueser, rahn. REVISION SUMMARY Motivated by https://mail.kde.org/pipermail/kde-android/2016-April/48.html Would update wiki page, once committed. REPOSITORY rMARBLE Marble BRANCH settleOnNDKSDKRootName REVISION DETAIL

[Marble-devel] [Differential] [Updated, 219 lines] D1560: Marble Maps: Limit PinchArea to map view

kossebau updated this revision to Diff 3698. kossebau added a comment. Next try with basing against the other diff REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1560?vs=3697=3698 BRANCH mapFixes2 REVISION DETAIL https://phabricator.kde.org/D1560

[Marble-devel] [Differential] [Request, 221 lines] D1560: Marble Maps: Limit PinchArea to map view

kossebau created this revision. kossebau added a reviewer: nienhueser. REVISION SUMMARY Pinching accidentally on the bottom dialog resulted in zooming of the map REPOSITORY rMARBLE Marble BRANCH mapFixes2 REVISION DETAIL https://phabricator.kde.org/D1560 AFFECTED FILES

[Marble-devel] [Differential] [Updated, 2 lines] D1559: Remove unused property RoutingManager.selectedPlacemark

kossebau updated this revision to Diff 3696. kossebau added a comment. revert result of arc not doing what I wanted it to do REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1559?vs=3695=3696 BRANCH mapFixes REVISION DETAIL

[Marble-devel] [Differential] [Updated, 221 lines] D1559: Remove unused property RoutingManager.selectedPlacemark

kossebau updated this revision to Diff 3695. kossebau added a comment. - Remove unused property RoutingManager.selectedPlacemark - Marble Maps: Limit PinchArea to map view REPOSITORY rMARBLE Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1559?vs=3694=3695 BRANCH

[Marble-devel] [Differential] [Request, 2 lines] D1559: Remove unused property RoutingManager.selectedPlacemark

kossebau created this revision. kossebau added a reviewer: nienhueser. REVISION SUMMARY Could not see it being read somewhere TEST PLAN MarbleMaps works as before when adding places to the route REPOSITORY rMARBLE Marble BRANCH mapFixes REVISION DETAIL

[Marble-devel] [Differential] [Request, 20 lines] D1505: Fix mimetype file installation (needs ECM & KDEInstallDirs)

kossebau created this revision. kossebau added reviewers: rahn, nienhueser. REVISION SUMMARY find_package( SharedMimeInfo) relies on some FindSharedMimeInfo.cmake file as sharedmimeinfo does not come itself with cmake config files. ECM provides a FindSharedMimeInfo.cmake file. Not sure

[Marble-devel] [Differential] [Request, 10 lines] D1500: Restore linking of libmarblewidget to Phonon

kossebau created this revision. kossebau added reviewers: rahn, nienhueser. REVISION SUMMARY Seems that was lost during the Qt5 port. Nobody missed it yet? :) REPOSITORY rMARBLE Marble BRANCH linkMarbleWidgetAgainToPhonon REVISION DETAIL https://phabricator.kde.org/D1500 AFFECTED

[Marble-devel] [Differential] [Request, 45 lines] D1492: Register Marble app, part & thumbnailer for application/vnd.geo+json

kossebau created this revision. kossebau added reviewers: rahn, nienhueser. REVISION SUMMARY Don't be shy, tell the system that Marble has a plugin for handling geojson :) TEST PLAN Created a sample file with the example from en.wikipedia.org/wiki/GeoJSON My shared-mime-info has

[Marble-devel] [Differential] [Request, 10 lines] D1473: Fix Android packaging scripts to only pick respective own app binary

kossebau created this revision. kossebau added reviewers: nienhueser, rahn. REVISION SUMMARY Currently both Behaim and Marble Maps get both binaries into the created apk packages. Second commit allows trailing dir separator on path passed to create-apk.py (like happens with

[Marble-devel] [Differential] [Updated, 391 lines] D1438: Use Qt5::* notation with target_link_libraries, & PUBLIC/PRIVATE interfacesRemove the few explicit Qt5 include dirs, not needed

kossebau updated this revision to Diff 3404. kossebau added a comment. Fixed Android builds & made libastro completely Qt-less Updating D1438: Use Qt5::* notation with target_link_libraries, & PUBLIC/PRIVATE interfaces

[Marble-devel] [Differential] [Request, 8 lines] D1439: Remove unused WITH_KF5 cmake var

kossebau created this revision. kossebau added a reviewer: nienhueser. REVISION SUMMARY Seems that was only temporarily used, correct? Could not find any place where this is checked. REPOSITORY rMARBLE Marble BRANCH removeUnusedWITH_KF5 REVISION DETAIL

[Marble-devel] [Differential] [Request, 310 lines] D1438: Use Qt5::* notation with target_link_libraries, & PUBLIC/PRIVATE interfacesRemove the few explicit Qt5 include dirs, not needed

kossebau created this revision. kossebau added reviewers: rahn, nienhueser. REVISION SUMMARY Qt5::* notation is the usual way to refer to the imported cmake targets representing the Qt5 modules/libs. The ${Qt5*_LIBRARIES} might be from the transitional mode, right? PUBLIC & PRIVATE

[Marble-devel] [Differential] [Request, 32 lines] D1431: Fix: use qreal, not double in RouteSimulationPositionProviderPlugin

kossebau created this revision. kossebau added reviewers: nienhueser, rahn. REVISION SUMMARY unbreaks build on platforms where qreal is float REPOSITORY rMARBLE Marble BRANCH moreQRealLessDouble REVISION DETAIL https://phabricator.kde.org/D1431 AFFECTED FILES