Re: [Maria-developers] 23b70146c16: MDEV-6268 SPIDER table with no COMMENT clause causes queries to wait forever

2019-07-04 Thread kentoku
lue of @spider_parents > on the connecting host. > > This is it, it'll prevent self-connects, both direct and indirect via a > chain of spider tables. > > Because @spider_parents variable is user-visible, better to use a > different name for it, something that has a smaller chance of ca

Re: [Maria-developers] a2520676ba1: MDEV-16249 CHECKSUM TABLE for a spider table is not parallel and saves all data in memory in the spider head by default

2019-06-06 Thread kentoku
um from remote servers and Spider just uses this value. Some cases a checksum table command returns NULL from remote servers to Spider. Spider should use this result as is. This is the reason that a checksum can be NULL in Spider. > > } > > if (stats.records && stats.records < 2

Re: [Maria-developers] Creating test cases for Spider

2017-01-18 Thread kentoku
Hi! > I have now merged 10.2-spider tree with the latest 10.2 tree, which > includes the new HASH and better support for gcov. Thanks! I'll pull and test it. Regards, Kentoku 2017-01-18 21:14 GMT+09:00 Michael Widenius <michael.widen...@gmail.com>: > Hi! > >> I wi

Re: [Maria-developers] Working on spider patches, MDEV-7701

2016-11-30 Thread kentoku
nction has possibility of causing out of memory error. That's why this function returns int. > I added HA_CAN_MULTISTEP_MERGE as a flag to DB_TYPE_MRG_MYISAM, which > allwoed me to make the above tests and the following identical ones > much > simpler. ok. And now everyone can create myisa

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-30 Thread kentoku
ke this part clear. This test is create table with insert ignore test. So I am expecting warnings. Previous test is create table with insert test, so I don't think the insert data should be changed. But is it looks unclear? Should I add any comments? Thanks, Kentoku 2016-11-25 0:18 GMT+09:0

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-30 Thread kentoku
Hi! > All spider tests now passes in 10.2 Great! > This fails as the above variable doesn't yet exists. > I will update the test results as soon the variable exists again. ok. Thanks, Kentoku 2016-11-25 0:55 GMT+09:00 Michael Widenius <michael.widen...@gmail.com>: > Hi!

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-30 Thread kentoku
Hi! > Better to instead test MYSQL versions than have a define that is > always declared. > With current code, the last #else in spd_param.cc will never be used: You right and I'll add code of testing MYSQL versions in Spider code later. Thanks, Kentoku 2016-11-24 23:07 GMT+09:0

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-29 Thread kentoku
Hi! > If this is ok, I will add this and close MDEV-7700 It looks connect string is visible, but never used. This is different from what I think. I just added patch for connect string to MDEV-7698. Please review it. This changes do not cause error for federated_partition test. Thanks, Kent

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-24 Thread kentoku
priority. Connect strings of partition are the second priority. Connect string of table is the third priority. > Can you create a patch that will not cause federated_partiton.test to fail? Yes, I think I can. I'll create it. Thanks, Kentoku 2016-11-24 23:07 GMT+09:00 Michael Widenius <mi

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-23 Thread kentoku
ON) && MYSQL_VERSION_ID >= 10 > > Which is always true in MariaDB 10.x Is this in Spider code, right? This is needed for supporting other versions. Spider still supports MySQL 5.5. Thanks, Kentoku 2016-11-22 3:25 GMT+09:00 Michael Widenius <michael.widen...@gmail.

Re: [Maria-developers] Working on spider patches, MDEV-7698

2016-11-23 Thread kentoku
Hi Monty! Thank you for starting this task. I appreciate it. > Kentoku, do you have patches for the test files, or should I just take > them from the above spider branch or from somewhere else ? I just attached test files into MDEV-7698. Please use it. And please let me know if you get a

Re: [Maria-developers] Please review MDEV-8140 patch

2015-11-09 Thread kentoku
Hi Sergey, Cheng! Thanks to Cheng for making the patch! > This patch looks good. Kentoku, will you take care of it and apply to your > tree? > Or should we apply it directly to 10.0? Please apply it directly to 10.0 this time. Thanks, Kentoku 2015-11-09 19:15 GMT+09:00 Sergey Voj

Re: [Maria-developers] nginx sources in mroonga

2014-11-03 Thread kentoku
Hi Alexander, Sergei Golubchik is asking why we have complete nginx sources inside mroonga? Can you remove them please? I just removed them and pushed. nginx is not needed bundled Mroonga. Thanks, Kentoku 2014-11-03 17:48 GMT+09:00 Alexander Barkov b...@mnogosearch.org: Hi Kentoku

Re: [Maria-developers] Buildbot trees for spider and mroonga

2014-02-09 Thread kentoku
:~maria-captains/maria/10.0-spider is already made by Sergey. May I use this? Thanks, Kentoku 2014/1/31 Alexander Barkov b...@mariadb.org: Hi Kentoku, Currently you use your own trees for Mroonga and Spider development, e.g. bzr+ssh://bazaar.launchpad.net/~mroonga/maria/mroonga/ Would you

Re: [Maria-developers] metadata_lock_info plugin

2013-12-10 Thread kentoku
behalf. I just fixed and pushed. Please start the merge process. Thanks, Kentoku 2013/12/10 Sergey Vojtovich s...@mariadb.org Hi Kentoku, looks great now. Just one minor thing: rev.3914 overwrites mdl.h with DOS line endings (CRLF), which are not permitted by coding guidelines. If you fix

Re: [Maria-developers] metadata_lock_info plugin

2013-12-10 Thread kentoku
, Kentoku 2013/12/10 Sergey Vojtovich s...@mariadb.org Hi Kentoku, On Tue, Dec 10, 2013 at 11:38:15PM +0900, kentoku wrote: Hi Sergey, looks great now. Just one minor thing: rev.3914 overwrites mdl.h with DOS line endings (CRLF), which are not permitted by coding guidelines. Sorry

Re: [Maria-developers] metadata_lock_info plugin

2013-12-08 Thread kentoku
Hi Sergey, I just pushed again. Please review it. lp:~kentokushiba/maria/10.0.6-metadata_lock_info Thanks, Kentoku 2013/11/8 Sergey Vojtovich s...@mariadb.org Hi Kentoku, On Fri, Nov 08, 2013 at 04:18:51AM +0900, kentoku wrote: Hi Sergey, please find iterator prototype attached. I

Re: [Maria-developers] metadata_lock_info plugin

2013-11-07 Thread kentoku
. What is the other option you're considering? On debug build, MDL_ticket class has enum_mdl_duration. I think this enum_mdl_duration can use for non debug build, if remove #ifndef DBUG_OFF for enum_mdl_duration. How do you think about it? Thanks, Kentoku 2013/11/7 Sergey Vojtovich s...@mariadb.org

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-10-07 Thread kentoku
or partially applied. It was virtually committed and will be fully committed and available after the node recovery. So, it looks like it's ok to return an error in this specific case. Thank you for reviewing! Thanks, Kentoku 2013/10/5 Sergei Golubchik s...@mariadb.org Hi, kentoku! On Oct

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-10-04 Thread kentoku
It is better to be able to commit through Spider node. Currently it is impossible, but I think it is possible if xid_cache_delete is skipped when xa commit get an error from a storage engine. Could you please tell me your opinion? Thanks, Kentoku 2013/10/5 Sergei Golubchik s...@mariadb.org Hi, Kentoku

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-09-29 Thread kentoku
Hi Sergey, Thank you for your information. I could reproduce. I tried to fix it and pushed it. Thanks, Kentoku 2013/9/27 Sergey Vojtovich s...@mariadb.org Hi Kentoku, BUILD/compile-amd64-debug-max cd mysql-test cat t/AAA.test --source include/have_innodb.inc install soname

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-09-27 Thread kentoku
build options and command line options that you used? Thanks, Kentoku 2013/9/27 Sergey Vojtovich s...@mariadb.org Hi Kentoku, On Wed, Sep 25, 2013 at 02:53:17AM +0900, kentoku wrote: Hi Sergey, The above should have been fixed back in the beginning of 2012. Which MariaDB revision

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-09-24 Thread kentoku
. Can you reproduce this failure yet? Thanks, Kentoku 2013/9/24 Sergey Vojtovich s...@mariadb.org Hi Kentoku, On Thu, Sep 19, 2013 at 11:47:33PM +0900, kentoku wrote: Hi Sergey, I'm afraid fixing rnd_end() callers in the server may stall for a long time. O.K. No need to fix

Re: [Maria-developers] Questions re MDEV-4736 and MDEV-4739 (was Re: Spider's installation sql file)

2013-09-19 Thread kentoku
total_ha_2pc 1 was true, opt_bin_log was false. Does it help you? Thanks, Kentoku 2013/9/19 Sergey Vojtovich s...@mariadb.org Hi Kentoku, I'm adding MariaDB developers to CC. On Thu, Sep 19, 2013 at 01:19:13AM +0900, kentoku wrote: Hi Sergey, But what kind of errors are possible in your

Re: [Maria-developers] [Gsoc] Regex enhancements Project

2013-05-04 Thread kentoku
Hi Sudheera and Sergei, Sudheera, How much do you want to prepare for this project before starting GSOC? Serugei, How can I and other people help this project after starting GSOC? Is it same as now? Thanks, Kentoku 2013/4/21 Sudheera Palihakkara catchsudhe...@gmail.com Hi Kentoku

Re: [Maria-developers] [Gsoc] Regex enhancements Project

2013-05-04 Thread kentoku
, Kentoku 2013/5/4 Sergei Golubchik s...@askmonty.org Hi, Kentoku! On May 05, kentoku wrote: Hi Sudheera and Sergei, Sudheera, How much do you want to prepare for this project before starting GSOC? Serugei, How can I and other people help this project after starting GSOC

Re: [Maria-developers] [Gsoc] Regex enhancements Project

2013-04-21 Thread kentoku
Hi Sergei, Is this project already started? Thanks, Kentoku 2013/4/21 Sudheera Palihakkara catchsudhe...@gmail.com Hi Kentoku, Oniguruma is looking great. But I can't find if the following features are implemented on Oniguruma or not(even the Wikipedia page doesn't have those

Re: [Maria-developers] [Gsoc] Regex enhancements Project

2013-04-20 Thread kentoku
to use it. Thanks, Kentoku 2013/4/20 Sudheera Palihakkara catchsudhe...@gmail.com Hello Sir, I've been working on this project for the past couple of days. I found that there are few good regex libraries suitable for this task. Considering the requirements I think PCRE, ICU regex and RGX

Re: [Maria-developers] online alter table in MariaDB?

2010-09-19 Thread kentoku
Hi Zardosht, I don't know progress of online alter table in MariaDB. But, you can do online alter table by using Vertical Partitioning Storage Engine. Please see http://www.slideshare.net/Kentoku/spider-muc2010-20100414 P.26 How to change the schema Thanks, Kentoku 2010/9/16 Zardosht Kasheff

Re: [Maria-developers] per-partition attributes in the CREATE TABLE

2010-05-12 Thread kentoku
ENGINE=innodb innodb_YYY=3, PARTITION pt2 ENGINE=pbxt pbxt_ZZZ=4 ); pt1 options are innodb_XXX=1 innodb_YYY=3 and pt2 options are pbxt_XXX=2 pbxt_ZZZ=4 - example end - What do you think about my opinion? Thanks, Kentoku 2010/5/12 Michael Widenius mo...@askmonty.org: Hi