Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-13 Thread Aleksey Midenkov
Sergey, On Wed, Mar 13, 2019 at 9:48 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Mar 13, Aleksey Midenkov wrote: > > On Wed, Mar 13, 2019 at 9:01 PM Sergei Golubchik > wrote: > > > On Mar 13, Aleksey Midenkov wrote: > > > > > > > > > > Query_log_event() can already store microseconds, see

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-13 Thread Sergei Golubchik
Hi, Aleksey! On Mar 13, Aleksey Midenkov wrote: > On Wed, Mar 13, 2019 at 9:01 PM Sergei Golubchik wrote: > > On Mar 13, Aleksey Midenkov wrote: > > > > > > > > Query_log_event() can already store microseconds, see Q_HRNOW flag. > > > > So better to add them to Rows_log_event, if needed. > > > >

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-13 Thread Aleksey Midenkov
Sergei, On Wed, Mar 13, 2019 at 9:01 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Mar 13, Aleksey Midenkov wrote: > > > > > > Query_log_event() can already store microseconds, see Q_HRNOW flag. > > > So better to add them to Rows_log_event, if needed. > > > > > > But I don't quite

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-13 Thread Sergei Golubchik
Hi, Aleksey! On Mar 13, Aleksey Midenkov wrote: > > > > Query_log_event() can already store microseconds, see Q_HRNOW flag. > > So better to add them to Rows_log_event, if needed. > > > > But I don't quite understand why it's needed. > > In scope of MDEV-16370 slave adds history record. Master

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-13 Thread Aleksey Midenkov
Andrei, thanks for explanation! Agree with you and Sergei on that topic. Sergei, On Tue, Mar 12, 2019 at 9:04 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Mar 12, Aleksey Midenkov wrote: > > Hi, Sergei, > > > > Thank you for observations! This task is in progress. While doing it I > >

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-12 Thread Sergei Golubchik
Hi, Aleksey! On Mar 12, Aleksey Midenkov wrote: > Hi, Sergei, > > Thank you for observations! This task is in progress. While doing it I > found out that RBR doesn't replicate timestamp fractions. That is: it > gets seconds from event timestamp marker and adds fractions from > system time. This

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-12 Thread andrei . elkin
Aleksey, hello. > Hi, Sergei, > > Thank you for observations! This task is in progress. While doing it I found > out that RBR doesn't replicate timestamp fractions. > That is: it gets seconds from event timestamp marker and adds fractions from > system time. This causes bugs in System

Re: [Maria-developers] 14c2f90ad08: Idempotent INSERT events for system versioning

2019-03-12 Thread Aleksey Midenkov
Hi, Sergei, Thank you for observations! This task is in progress. While doing it I found out that RBR doesn't replicate timestamp fractions. That is: it gets seconds from event timestamp marker and adds fractions from system time. This causes bugs in System Versioning. More on it in Bug 6 here: