[Maria-developers] GSoC-2020 Query

2020-02-28 Thread Krishna Maheshwari
Hello, Everyone! I am new here and in open source too. I got to know about MariaDB through GSoC. I have intermediate level of knowledge in sql and have experience working in languages such as c, c++ and java. I did go through the list of tasks mentioned in the mariaDB GSoC 2020, and I was in

Re: [Maria-developers] 256753e8ae8: Clean up and speed up interfaces for binary row logging

2020-02-28 Thread Sergei Golubchik
Hi, Michael! Just a few comments, see below On Feb 28, Michael Widenius wrote: > revision-id: 256753e8ae8 (mariadb-10.5.0-269-g256753e8ae8) > parent(s): 9fd961cf687 > author: Michael Widenius > committer: Michael Widenius > timestamp: 2020-02-26 16:05:53 +0200 > message: > > Clean up and

Re: [Maria-developers] 5ae74b4823a: mysqld --help will now load mysqld.options table

2020-02-28 Thread Michael Widenius
Hi! On Fri, Feb 28, 2020 at 4:37 PM Sergei Golubchik wrote: > > Hi, Michael! > > --- a/sql/mysqld.cc > > +++ b/sql/mysqld.cc > > @@ -8511,8 +8511,8 @@ static void option_error_reporter(enum loglevel > > level, const char *format, ...) > >va_start(args, format); > > > >/* Don't print

Re: [Maria-developers] 5ae74b4823a: mysqld --help will now load mysqld.options table

2020-02-28 Thread Sergei Golubchik
Hi, Michael! On Feb 28, Michael Widenius wrote: > revision-id: 5ae74b4823a (mariadb-10.5.0-274-g5ae74b4823a) > parent(s): ee73f2c6e71 > author: Michael Widenius > committer: Michael Widenius > timestamp: 2020-02-26 16:05:54 +0200 > message: > > mysqld --help will now load mysqld.options table

Re: [Maria-developers] 044dfaff670: Replace handler::primary_key_is_clustered() with handler::ha_is_clustered_key()

2020-02-28 Thread Sergei Golubchik
Hi, Michael! On Feb 28, Michael Widenius wrote: > revision-id: 044dfaff670 (mariadb-10.5.0-275-g044dfaff670) > parent(s): 5ae74b4823a > author: Michael Widenius > committer: Michael Widenius > timestamp: 2020-02-26 16:05:55 +0200 > message: > > Replace handler::primary_key_is_clustered() with