Hi Georg,
Can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-9415
ConnectSE crashes on INSERT statements inside the ODBC driver,
while UPDATE, SELECT, DELETE work fine.
Any ideas how to track down the problem?
Thanks.
___
M
Hi Georg,
a gentle reminder :)
Thanks.
On 01/27/2016 10:17 AM, Alexander Barkov wrote:
Hi Georg,
Can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-9415
ConnectSE crashes on INSERT statements inside the ODBC driver,
while UPDATE, SELECT, DELETE work fine.
Any
Hello Jan.
a gentle reminder ;)
Thanks.
On 01/26/2016 04:35 PM, Alexander Barkov wrote:
Hi Jan,
can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-8691
Otto managed to get a stack trace from mips machine.
It seems to crash inside InnoDB.
Thanks.
#3
#4
Hello Sergei,
Please review a fix for MDEV-9371.
I'd suggest to push it to 10.0 instead of 5.5,
as MySQL fixed this bug in 5.6 (not 5.5).
Also, I think it's worthy to backport MDEV-9332 to 10.0 as well,
because the patch for MDEV-9371 touches the test which
we modified in MDEV-9332.
Thanks!
Hi Sergei,
Please review a patch for MDEV-9521.
Thanks.
diff --git a/mysql-test/r/type_date.result b/mysql-test/r/type_date.result
index 4e299ec..31add0f 100644
--- a/mysql-test/r/type_date.result
+++ b/mysql-test/r/type_date.result
@@ -440,3 +440,38 @@ id select_type table type possible_keys k
Hi Sergei,
On 02/09/2016 05:01 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 09, Alexander Barkov wrote:
Hello Sergei,
Please review a fix for MDEV-9371.
I'd suggest to push it to 10.0 instead of 5.5,
as MySQL fixed this bug in 5.6 (not 5.5).
I think 5.5 is fine. It's cle
Hi Monty,
Please have a look into the latest comments in MDEV-9541 on how
PostgreSQL, SQL Server, Oracle 11i and MySQL-5.7 work when
comparing temporal data types.
There is no a general rule. Every vendor implements it in a different way.
1. PostgreSQL almost follows the standard, which disall
Hi Sergei,
Please review a patch for MDEV-7231.
Thanks.
diff --git a/include/m_ctype.h b/include/m_ctype.h
index a552226..ee49e94 100644
--- a/include/m_ctype.h
+++ b/include/m_ctype.h
@@ -533,6 +533,7 @@ struct my_charset_handler_st
extern MY_CHARSET_HANDLER my_charset_8bit_handler;
extern
Hi Sergei,
On 02/18/2016 06:45 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 18, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-7231.
Sorry, I cannot understand what parts of this patch are fixing MDEV-7231
and what is fixing charset issue.
Could you please split
Hi Sergei,
On 02/18/2016 07:02 PM, Alexander Barkov wrote:
Hi Sergei,
On 02/18/2016 06:45 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 18, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-7231.
Sorry, I cannot understand what parts of this patch are fixing MDEV
Hello Monty, all,
We discussed this with Sergei and both think that it will be a good idea
to deprecate this syntax:
SELECT a'test';
where 'a' is an identifier and 'test' its alias.
This is a non-standard way, and it conflicts with some other important
standard SQL grammar. See below.
Ty
Hi Monty,
On 02/25/2016 12:26 PM, Michael Widenius wrote:
Hi!
Hello Monty, all,
We discussed this with Sergei and both think that it will be a good idea
to deprecate this syntax:
SELECT a'test';
where 'a' is an identifier and 'test' its alias.
Is this dependent on if there is a space
Hi Sergei,
On 02/26/2016 11:19 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 12, Alexander Barkov wrote:
Hello Sergei,
I'm sending a new version for Type_handler and INET6 for your review.
There are three patches attached.
1. inet6-v65-prepare.diff.gz
Includes preparatory ch
Hello Sergei,
On 02/27/2016 12:53 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 12, Alexander Barkov wrote:
Hello Sergei,
I'm sending a new version for Type_handler and INET6 for your review.
There are three patches attached.
1. inet6-v65-prepare.diff.gz
Includes prepar
really uses single quoted strings as aliases.
What do you think about this?
Please also find comments inline:
On 02/27/2016 12:11 AM, Michael Widenius wrote:
Hi!
On 25 Feb 2016 19:16, "Alexander Barkov" mailto:b...@mariadb.org>> wrote:
>> As ' and " are identica
Hello Monty, Sergei,
Can you please have a look into:
http://buildbot.askmonty.org/buildbot/builders/kvm-deb-precise-amd64/builds/5724
Can you please give any suggestions about what we can do to fix the
problem with main.delayed failing sporadically?
This problem is blocking us badly in Debian
Hi Elena,
can you please review a patch for MDEV-9709?
I'm quite sure about the code change, it's trivial.
Please have a look into the tests.
Thanks.
diff --git a/mysql-test/r/type_float.result b/mysql-test/r/type_float.result
index e7267f0..3da5484 100644
--- a/mysql-test/r/type_float.result
++
V-9711
> <https://jira.mariadb.org/browse/MDEV-9711>).
> Apparently, this project does not require thorough understanding of the
> Server Internal code and the Instructions highlighted by Alexander
> Barkov on how to implement this are straight forward.
> I will be submitting a
Hello Melisa,
On 03/16/2016 10:22 PM, Melissa Rose wrote:
> Thanks for the kind response Alexander Barkov: I have already build the
> Server from source and I am looking at some character sets in string/*.c
> files and how they are implemented.
Excellent.
> I have also written and
Hi Binarus,
On 03/16/2016 06:13 PM, Binarus wrote:
>> I just wanted to split the task into these steps:
>>
>> 1. Default and _bin collations.
>>This is what MDEV-9711 is about.
>>
>> 2. Unicode Collation Algorithm (UCA) based collations
>>(e.g. utf8_unicode_nopad_ci)
>>
>>
>> 3. The rest (
Hi Binarus,
On 03/16/2016 07:02 PM, Binarus wrote:
> Alexander,
>
> I'd like to continue our conversation from Maria-discuss.
Sure.
>
>>> - I have found my_strnxfrm_unicode in the same file and will need more time
>>> to make my opinion of how difficult it will be
>>> (I don't know what a we
Hello Sergei,
Please review a patch for:
MDEV-9653 Assertion `length || !scale' failed in uint
my_decimal_length_to_precision(uint, uint, bool)
Thanks!
diff --git a/mysql-test/r/func_hybrid_type.result b/mysql-test/r/func_hybrid_type.result
index 95a8a82..29f9f46 100644
--- a/mysql-test/r/func_h
Hi Sergei,
On 03/17/2016 01:14 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 17, Alexander Barkov wrote:
>>>
>>> why is it NOT_FIXED_DEC? it seems to me that it has to be 0 here.
>>
>> Perhaps my example in the comments made you think that
>>
Hello Olivier,
a few tests are failing in the main 10.1 tree on Linux:
connect.xml
connect.xml_grant
connect.xml_html
connect.xml_mdev5261
connect.xml_mult
Can you please have a look?
Thanks!
___
Mailing list: https://launchpad.net/~maria-developers
Hi Sergei,
On 03/17/2016 01:16 AM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 16, Alexander Barkov wrote:
>> Hello Sergei,
>>
>> Please review a patch for:
>>
>> MDEV-9653 Assertion `length || !scale' failed in uint
>> my_decimal_
own aggregation code. I don't want to touch them
in this fix. Let's do them separately.
Note, I also removed Item_func_case::agg_str_lengths().
It was a dead code.
Thanks.
On 03/17/2016 03:06 PM, Alexander Barkov wrote:
> Hi Sergei,
>
> On 03/17/2016 01:14 PM, Sergei Gol
Hello Daniil,
On 03/16/2016 05:21 PM, Даниил Медведев wrote:
> Hi, I am Daniil Medvedev from Lomonosov Moscow State University, a 3rd
> year student, pursuing my bachelor’s degree in Computer Science.
> I was interested in project idea NO PAD Collations, and I wish to
> contribute to MariaDB usin
Hi Sergei,
On 03/16/2016 09:51 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Feb 08, Alexander Barkov wrote:
>> Hello Sergei,
>>
>> Please review a patch for MDEV-9369.
>>
>> Briefly, it fixes cmp_item::cmp() to return three possible values:
>>
lease take over the problem from this point?
Thanks.
On 03/21/2016 12:54 PM, Alexander Barkov wrote:
> Hi Olivier,
>
>
> On 03/20/2016 02:10 AM, Olivier Bertrand wrote:
>> Hello Alexander,
>>
>> Le 19/03/2016 14:59, Alexander Barkov a écrit :
>>> Hi Oliv
Hello Sergei,
Please review a patch for MDEV-9516.
Thanks.
diff --git a/mysql-test/suite/sys_vars/r/innodb_thread_sleep_delay_basic.result b/mysql-test/suite/sys_vars/r/innodb_thread_sleep_delay_basic.result
index 0335db8..ebb9955 100644
--- a/mysql-test/suite/sys_vars/r/innodb_thread_sleep_dela
Hi Sergei,
It fixes the reported crash, and additionally
inconsistencies when comparing temporal columns to empty strings:
In some cases it returned rows, in other cases it returned no rows,
depending on:
- the engine
- the type of comparison arguments (columns vs literals).
- presence of an inde
Hi Sergei,
On 03/22/2016 09:33 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 22, Alexander Barkov wrote:
>> Hi Sergei,
>>
>> It fixes the reported crash, and additionally
>> inconsistencies when comparing temporal columns to empty strings:
>>
Hi Sergei,
On 03/22/2016 09:48 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 22, Alexander Barkov wrote:
>> On 03/22/2016 09:33 PM, Sergei Golubchik wrote:
>>> Hi, Alexander!
>>>
>>> On Mar 22, Alexander Barkov wrote:
>>>>
Hello Sergei,
Please have a look into a draft fix for MDEV-9712.
The problem happens because in 10.1 execution time for various
recursive stages (like walk, update_used_table and
propagate_equal_fields) in NULLIF is O(recursion_level^2),
because complexity is doubled on every recursion level
wh
Hi Sergei,
please review a patch for MDEV-8360.
Btw, shouldn't we remove:
#define HA_END_SPACE_ARE_EQUAL 512
in ./include/my_base.h ?
It's not really needed.
Thanks.
commit 75ae61719e43dd0924b3a0cc5c9b588b82daeec8
Author: Alexander Barkov
Date: Fri Mar 25 13:50:41
Hi Sergei,
Please review a partial patch for MDEV-6353.
It removes my_mbcharlen() in all remaining pieces of the code,
except LOAD DATA and SELECT INTO OUTFILE.
I'll do LOAD DATA and SELECT INTO OUTFILE in a separate patch.
Thanks.
___
Mailing lis
Hi Sergei,
Please review a patch fixing MDEV-9811 and MDEV-9824.
They are prerequisites for:
MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring
Thanks.
commit afe22406280634cb97ce4c0943db24033fb7d3bc
Author: Alexander Barkov
Date: Tue Mar 29 15:39:15 2016 +0400
MDEV-9811 LOAD DATA
uthor: Alexander Barkov
Date: Mon Mar 28 11:05:51 2016 +0400
MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring, part 1.
Fixing the debug_sync and create_options related code not to use my_mbcharlen():
- debug_sync_token() now uses cs->cset->scan().
Passing the end of
Hi Sergei,
Please review a patch for MDEV-9842.
This is a prerequisite for:
MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring
Thanks.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
U
Hi Sergei,
Please review a patch for MDEV-9842.
This is a prerequisite for:
MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring
Thanks.
commit 4d615db357a5b513c915ab677afd130a0673f0da
Author: Alexander Barkov
Date: Fri Apr 1 14:53:00 2016 +0400
MDEV-9842 LOAD DATA INFILE does not
Hi Sergei,
Please review a patch for MDEV-9823.
This is a prerequisite for the current sprint task:
MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring
Thanks.
commit 9b6bcea8894474bb0d660a11ac21c1f64d12099f
Author: Alexander Barkov
Date: Mon Apr 4 14:03:42 2016 +0400
MDEV-9823
Hi Sergei,
On 04/05/2016 03:48 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Apr 04, Alexander Barkov wrote:
>> Hi Sergei,
>>
>> Please review a patch for MDEV-9823.
>>
>> This is a prerequisite for the current sprint task:
>> MDEV-6353 my_ism
Hello Sergei,
On 03/30/2016 08:41 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Mar 30, Alexander Barkov wrote:
>> commit 4ab28aca964fa646aa55676db813dbed66b83093
>> Author: Alexander Barkov
>> Date: Mon Mar 28 11:05:51 2016 +0400
>>
>> M
().
On 04/16/2016 09:02 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 09, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-9521.
Thanks.
What the commit comment will be for this change?
Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
Hello Sergei,
please review a patch for MDEV-9745.
This is actually a backport of MDEV-9653 from 10.1 to 5.5.
Thanks.
commit 2a39621c1343f4c29c69647d151441d171fb3e7b
Author: Alexander Barkov
Date: Tue Apr 19 16:56:41 2016 +0400
MDEV-9745 Crash with CASE WHEN TRUE THEN COALESCE(CAST
Hi Sergei,
Please review a patch for MDEV-9372.
Thanks.
commit b3df1c60a294fe906ca5dba804ee0c1f218a1728
Author: Alexander Barkov
Date: Wed Apr 20 12:08:36 2016 +0400
MDEV-9372 select 100 between 1 and 9223372036854775808 returns false
Integer comparison of INT expressions with
Hello,
I noticed that UTC_TIME, UTC_DATE, UTC_DATETIME are reserved keywords:
MariaDB [test]> SELECT * FROM utc_time;
ERROR 1064 (42000): You have an error in your SQL syntax; check the
manual that corresponds to your MariaDB server version for the right
syntax to use near 'utc_time' at line
Hi Sergei,
On 04/25/2016 08:42 PM, s...@mariadb.org wrote:
revision-id: c204e9bd63e7f6ce40e83b1f7fc0b4607a131009
(mariadb-10.0.24-43-gc204e9b)
parent(s): ce38adddfa91949b30956abd0e4cab201effcdef
author: Sergei Golubchik
committer: Sergei Golubchik
timestamp: 2016-04-25 18:41:31 +0200
message:
Hi Daniil,
Congratulations! Nice to have you onboard!
On 05/02/2016 10:09 AM, Sergei Golubchik wrote:
Hi, Даниил!
On May 02, Даниил Медведев wrote:
Hello everyone!
I was selected for GSoC to work with MariaDB, with task NO PAD Collatons.
Congratulations!
Me profile on github is medvdani
Hi Sergei,
If I run this query:
SELECT 1 UNION SELECT 2 INTO OUTFILE 'test.txt';
It creates a file 'test.txt' with this content:
1
2
Looks fine so far.
Now if I do "rm test.txt" and execute another query (with parentheses):
(SELECT 1) UNION (SELECT 2 INTO OUTFILE 'test.txt');
it still pu
Hi,
On 05/04/2016 12:52 AM, Alexander Barkov wrote:
Hi Sergei,
If I run this query:
SELECT 1 UNION SELECT 2 INTO OUTFILE 'test.txt';
It creates a file 'test.txt' with this content:
1
2
Looks fine so far.
Now if I do "rm test.txt" and execute another query
Hi Sergei,
Thanks for the review!
On 04/27/2016 06:24 PM, Sergei Golubchik wrote:
Hi, Alexander!
The approach is fine. Two comments below:
The remaining heavy piece of the code is:
Item* propagate_equal_fields(THD *thd, const Context &ctx, COND_EQUAL *cond)
{
Context cmpctx(ANY_S
Hi Sergei,
Please review a patch for MDEV-10030, which is a part of
MDEV-8909 union parser cleanup.
Thanks!
commit 0f4f2e3b5ebabce1308c45772785aec084092674
Author: Alexander Barkov
Date: Thu May 5 12:29:36 2016 +0400
MDEV-10030 sql_yacc.yy: Split table_expression and remove PROCEDURE
Hi Sergei,
On 05/05/2016 11:27 PM, Sergei Golubchik wrote:
Hi, Alexander!
Sure, that's ok. A couple of comments below:
On May 05, Alexander Barkov wrote:
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index a6bbfc8..0d8bfb3 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_sele
Hi Sergei,
Please review a patch for MDEV-10036.
This is the next step for:
MDEV-8909 union parser cleanup
Thanks!
diff --git a/mysql-test/r/limit_rows_examined.result b/mysql-test/r/limit_rows_examined.result
index 318039d..cce8ee5 100644
--- a/mysql-test/r/limit_rows_examined.result
+++ b
Hi Sergei,
On 05/08/2016 12:39 PM, Sergei Golubchik wrote:
Hi, Alexander!
On May 06, Alexander Barkov wrote:
On May 05, Alexander Barkov wrote:
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index a6bbfc8..0d8bfb3 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_select.cc
@@ -988,6 +988,7
Hi Sergei,
On 05/10/2016 11:07 AM, Sergei Golubchik wrote:
Hi, Alexander!
On May 06, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-10036.
This is the next step for:
MDEV-8909 union parser cleanup
Looks ok, I think (it's difficult to review parser patches :).
Hello Sergei,
Please review the next step for
MDEV-8909 union parser cleanup
Now it's MDEV-10051, and it fixes subselects.
Note, I decided to fix derived tables in a separate patch later.
So there will be one more patch blocking MDEV-8909.
Thanks!
diff --git a/mysql-test/r/parser.result b/my
Hi Sanja, Sergei,
Sanja, you asked me to review a patch for MDEV-10035:
revision-id: 4ffe2295e78538dde93df078421726f0c5a7d2a2
(mariadb-10.2.0-29-g4ffe229)
parent(s): b79944950e5e5db40cf7ad49061edf5f105512c4
committer: Oleksandr Byelkin
timestamp: 2016-05-15 15:25:33 +0200
message:
I earlier
Hi Sergei,
On 05/16/2016 10:35 AM, Sergei Golubchik wrote:
Hi, Oleksandr!
On May 16, Oleksandr Byelkin wrote:
On 16.05.2016 06:00, Alexander Barkov wrote:
Hi Sanja, Sergei,
Sanja, you asked me to review a patch for MDEV-10035:
revision-id: 4ffe2295e78538dde93df078421726f0c5a7d2a2
(mariadb
Hi Sergei,
Thanks for review.
On 05/09/2016 10:30 PM, Sergei Golubchik wrote:
Hi, Alexander!
TL;DR: looks fine. Few minor comments, see below.
On Apr 08, Alexander Barkov wrote:
diff --git a/include/m_ctype.h b/include/m_ctype.h
index c892d576..bb633f8 100644
--- a/include/m_ctype.h
+++ b
Hello Sergei,
Please review a patch for MDEV-10101.
Thanks.
diff --git a/mysql-test/r/parser.result b/mysql-test/r/parser.result
index 920fdfe..a35109d 100644
--- a/mysql-test/r/parser.result
+++ b/mysql-test/r/parser.result
@@ -930,17 +930,27 @@ ERROR HY000: Invalid use of group function
SELE
Hi Sergei,
Please review MDEV-10124
Thanks.
Here's the story of the related code:
1. The original patch from Wax
commit: 0b505fb437eedd1b31c99888247c2259539c095b
date: Tue Mar 18 03:07:40 2003
opt_gorder_clause reused the regular order_clause,
which already had some protection against ROLLU
Hi Sergei,
Please review a patch for MDEV-8909.
It removes some old remainders that are not needed anymore.
Thanks.
diff --git a/sql/sql_lex.cc b/sql/sql_lex.cc
index adc443a..28add87 100644
--- a/sql/sql_lex.cc
+++ b/sql/sql_lex.cc
@@ -2455,7 +2455,6 @@ bool st_select_lex::mark_as_dependent(TH
Hello Sergei,
This script:
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a VARCHAR(30), b DOUBLE);
INSERT INTO t1 values(' ', MATCH (a) AGAINST('' IN
BOOLEAN MODE));
SELECT * FROM t1;
returns:
+-+--+
| a | b|
+---
Hi Sergei,
On 06/08/2016 11:58 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 08, Alexander Barkov wrote:
This script:
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a VARCHAR(30), b DOUBLE);
INSERT INTO t1 values(' ', MATCH (a) AGAINST('' IN
BO
Hi Sergei,
Please review a patch for MDEV-10181.
Thanks!
diff --git a/mysql-test/r/ctype_recoding.result b/mysql-test/r/ctype_recoding.result
index c84da0d..2555749 100644
--- a/mysql-test/r/ctype_recoding.result
+++ b/mysql-test/r/ctype_recoding.result
@@ -277,9 +277,40 @@ CREATE TABLE t1 ( a V
Hi Sergei,
Please review a patch for mdev-10020.
The problem was that the loop in get_func_mm_tree()
accessed an improperly initialized instance of String,
which is a bzero'ed part of the in_vector::base array.
Strings in in_vector::base are initialized
in Item_func_in::fix_length_and_dec():
in
Hello Sergei,
Please review a patch for mdev-9524.
Thanks.
diff --git a/mysql-test/r/events_1.result b/mysql-test/r/events_1.result
index e03ccf51..4e7ff52 100644
--- a/mysql-test/r/events_1.result
+++ b/mysql-test/r/events_1.result
@@ -469,6 +469,26 @@ DROP EVENT ev1;
SHOW EVENTS;
Db Name D
Hi Sergei,
On 06/20/2016 05:44 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 20, Alexander Barkov wrote:
Hello Sergei,
Please review a patch for mdev-9524.
Thanks.
diff --git a/sql/event_data_objects.cc b/sql/event_data_objects.cc
index 09256a3..45fca08 100644
--- a/sql
Hi Serg.
Please review a patch for MDEV-10236.
Thanks.
commit bb3afc8aea61bc090a1119be0a1dad32d9dc8feb
Author: Alexander Barkov
Date: Wed Jun 22 16:30:15 2016 +0400
MDEV-10236 Where expression with NOT function gives incorrect result
diff --git a/mysql-test/r/null.result b/mysql-test/r
Hello Sergei,
Please review a patch fixing:
MDEV-8502 DECIMAL accepts out of range DEFAULT values
MDEV-10277 Redundant NOTE when inserting '0.1 ' into a DECIMAL(2,1)
column
Thanks.
commit 21c77129a072e244d5cc7956d8739c8d21e86af4
Author: Alexander Barkov
Date: Fri Jun 24 12:
Hi Sergei,
On 06/26/2016 11:24 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 22, Alexander Barkov wrote:
Hi Serg.
Please review a patch for MDEV-10236.
Thanks.
commit bb3afc8aea61bc090a1119be0a1dad32d9dc8feb
Author: Alexander Barkov
Date: Wed Jun 22 16:30:15 2016 +0400
MDEV
Hi Sergei,
Please review a patch for mdev-8919.
Thanks!
commit f683cd85b3ba14aa7a40bf774dd2a0e0d5dd4d6f
Author: Alexander Barkov
Date: Mon Jul 4 13:29:58 2016 +0400
MDEV-8919 Wrong result for CAST(999.0)
diff --git a/mysql-test/r/cast.result b/mysql-test/r/cast.result
Hello Alexey,
Can you please review a patch for MDEV-10468?
Thanks!
diff --git a/mysql-test/r/func_group.result b/mysql-test/r/func_group.result
index ac076ec..ae16eb7 100644
--- a/mysql-test/r/func_group.result
+++ b/mysql-test/r/func_group.result
@@ -2270,3 +2270,15 @@ t2_id GROUP_CONCAT(IF (
Hi Serg,
Please review a patch for MDEV-10500.
Thanks.
diff --git a/mysql-test/r/func_group.result b/mysql-test/r/func_group.result
index ac076ec..0253548 100644
--- a/mysql-test/r/func_group.result
+++ b/mysql-test/r/func_group.result
@@ -2270,3 +2270,30 @@ t2_id GROUP_CONCAT(IF (t6.b, t6.f, t5.
Hi Sergei,
On 08/08/2016 03:17 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Aug 03, Alexander Barkov wrote:
diff --git a/sql/item_sum.cc b/sql/item_sum.cc
index adf48f6..03600b7 100644
--- a/sql/item_sum.cc
+++ b/sql/item_sum.cc
@@ -1762,7 +1762,7 @@ double Item_sum_std::val_real
Hi Sergei,
On 08/08/2016 03:35 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Aug 08, Alexander Barkov wrote:
Hi Serg,
Please review a patch for MDEV-10500.
Thanks.
I think it's a caller's job to test for null_value.
Apparently, sometimes it tests for the return value being N
Hi Sergei,
Here's a new patch, returning DBL_MAX in case of inf.
Thanks!
On 08/08/2016 03:17 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Aug 03, Alexander Barkov wrote:
diff --git a/sql/item_sum.cc b/sql/item_sum.cc
index adf48f6..03600b7 100644
--- a/sql/item_sum.cc
+++
Hello Sergei,
Please review a patch for mdev-10702.diff
Thanks!
diff --git a/mysql-test/r/ps_ddl.result b/mysql-test/r/ps_ddl.result
index dec0d12..fc18322 100644
--- a/mysql-test/r/ps_ddl.result
+++ b/mysql-test/r/ps_ddl.result
@@ -2542,3 +2542,32 @@ EXECUTE stmt3;
EXECUTE stmt3;
DEALLOCATE
Hello Sergey and Igor,
You recently closed MDEV-10057 and MDEV-10058, but forgot to add tests.
- MDEV-10057 does not have tests at all.
- MDEV-10058 has only the parser related test,
but does not have this test:
EXPLAIN SELECT * FROM (WITH a AS (SELECT * FROM t1) SELECT * FROM t2
NATURAL JOIN
Hi Sergei,
On 08/31/2016 06:55 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 02, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-8909.
It removes some old remainders that are not needed anymore.
Found this in my mailbox, and MDEV-8909 is still "In-Review&quo
On 09/07/2016 01:31 PM, Sergey Petrunia wrote:
On Wed, Sep 07, 2016 at 10:24:09AM +0400, Alexander Barkov wrote:
Hello Sergey and Igor,
You recently closed MDEV-10057 and MDEV-10058, but forgot to add tests.
- MDEV-10057 does not have tests at all.
- MDEV-10058 has only the parser related
Hello Sergei,
Please review.
Thanks!
commit 6c49030635a36380606948c198dcfd4a6bf2ffc3
Author: Alexander Barkov
Date: Wed Sep 21 12:29:09 2016 +0400
MDEV-10425 Assertion `collation.derivation == DERIVATION_IMPLICIT' failed in Item_func_conv_charset::fix_length_and_dec()
MDEV-
Hello Monty.
I checked your patch for MDEV-6112 multiple triggers per table.
Here are some quick notes. I'll send a detailed review separately.
1. It would be nice to push refactoring changes in separate patch:
a. do sql_mode_t refactoring
b. "trg_idx -> Trigger *" refactoring
c. opt_d
Hello Igor,
I was rebasing bb-10.2-compatibility on top of the latest 10.2 and
noticed this grammar change:
create_select_query_specification:
- SELECT_SYM create_select_part2 create_select_part3
create_select_part4
+ SELECT_SYM opt_with_clause create_select_part2 create_
_name))
> -return 1;
> - return 0;
> -}
> + if (!count) // If no more triggers
> + {
> +/*
> + TODO: Probably instead of removing .TRG file we should move
> + to archive directory but this should be done as part of
> +
Hello Igor,
This patch:
commit 2cfc450bf78c2d951729d1a0e8f731c0d987b1d5
Author: Igor Babaev
Date: Tue Feb 9 12:35:59 2016 -0800
seems to have introduced this bug:
MDEV-11081 Cursor fetches NULL for aggregate functions
Can you please have a look?
Thanks!
_
Hello Ian,
In 10.2 we made a few changes under terms of these bug reports:
MDEV-9874 LOAD XML INFILE does not handle well broken multi-byte characters
MDEV-9823 LOAD DATA INFILE silently truncates incomplete byte sequences
MDEV-9842 LOAD DATA INFILE does not work well with a TEXT column when
us
Hello Alexey,
Please review a patch for 10.3 for
MDEV-10811 Change design from "Item is Type_handler" to "Item has
Type_handler
Thanks.
commit bd9af31224d74fc40a4f72608216a09c6f4ef133
Author: Alexander Barkov
Date: Thu Sep 15 12:03:45 2016 +0400
MDEV-10811 Change de
Hello Sergei,
Please review a patch for MDEV-11219.
Thanks!
diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc
index a222335..b79de4b 100644
--- a/sql/item_cmpfunc.cc
+++ b/sql/item_cmpfunc.cc
@@ -2553,7 +2553,7 @@ Item_func_nullif::fix_length_and_dec()
See also class Item_func_nullif
Hello Monty,
I'm done with:
MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations
But I'd like to move a certain part of MDEV-10577 into a separate patch.
I created an MDEV entry for this:
MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as
methods to Column_definition
Hello Sanja, Elena, Wlad,
Sanja, please review a patch for MDEV-10780.
The patch is for 10.1. I could not reproduce it in 10.0.
But it should be safe to push it into 10.0 anyway.
This patch is most likely fixing MDEV-10806 (assigned to Sanja)
and MDEV-10910 (assigned to Elena).
Thanks!
diff --
Hello Elena,
On 11/09/2016 08:38 PM, Elena Stepanova wrote:
Hi Bar, Sanja,
On 11/09/2016 06:28 PM, Alexander Barkov wrote:
Hello Sanja, Elena, Wlad,
Sanja, please review a patch for MDEV-10780.
The patch is for 10.1. I could not reproduce it in 10.0.
But it should be safe to push it into
Hello Sanja,
On 11/10/2016 01:13 AM, Oleksandr Byelkin wrote:
Hi, Alexander!
On 09.11.2016 16:28, Alexander Barkov wrote:
Hello Sanja, Elena, Wlad,
Sanja, please review a patch for MDEV-10780.
The patch is for 10.1. I could not reproduce it in 10.0.
But it should be safe to push it into
Hello Alexey,
Please review a patch for MDEV-11294.
Thanks!
commit 73f69b23465d2a1d4f4e9bc73b3efcae78c66cdc
Author: Alexander Barkov
Date: Wed Nov 16 13:24:28 2016 +0400
MDEV-11294 Move definitions of Derivation, DTCollation, Type_std_attributes from field.h and item.h to sql_type.h
Hello Alexey,
Please review a patch for MDEV-11292 (for 10.3).
Thanks.
diff --git a/sql/item_strfunc.cc b/sql/item_strfunc.cc
index acd3d74..f02b66c 100644
--- a/sql/item_strfunc.cc
+++ b/sql/item_strfunc.cc
@@ -3621,51 +3621,13 @@ String *Item_func_weight_string::val_str(String *str)
}
-St
Hi,
sorry, I used a wrong MDEV number in a mistake.
Please disregard this letter, I'll send a correct one in a moment.
On 11/17/2016 06:58 AM, Alexander Barkov wrote:
Hello Alexey,
Please review a patch for MDEV-11292 (for 10.3).
T
Hello Alexey,
Please review a patch for MDEV-11298 (for 10.3).
Thanks.
diff --git a/sql/item_strfunc.cc b/sql/item_strfunc.cc
index acd3d74..f02b66c 100644
--- a/sql/item_strfunc.cc
+++ b/sql/item_strfunc.cc
@@ -3621,51 +3621,13 @@ String *Item_func_weight_string::val_str(String *str)
}
-S
Hello Alexey,
Please review a patch for:
MDEV-11302 Add class Type_ext_attributes and
Type_handler::join_type_ext_attributes()
A detailed description can be found in the task ticket:
https://jira.mariadb.org/browse/MDEV-11302
This patch also fixes the problems reported in:
MDEV-9405 Hybrid
501 - 600 of 634 matches
Mail list logo
