Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > Is this because the table ta_l is connected to a remote table trough > spider that already has the > rows in it ? Yes. > If yes, then it would be good to have a comment about this is in the > test and also insert > data that is different from the original one to make this part clear.

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > All spider tests now passes in 10.2 Great! > This fails as the above variable doesn't yet exists. > I will update the test results as soon the variable exists again. ok. Thanks, Kentoku 2016-11-25 0:55 GMT+09:00 Michael Widenius : > Hi! > > On Thu, Nov 24,

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > Better to instead test MYSQL versions than have a define that is > always declared. > With current code, the last #else in spd_param.cc will never be used: You right and I'll add code of testing MYSQL versions in Spider code later. Thanks, Kentoku 2016-11-24 23:07 GMT+09:00 Michael

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > If this is ok, I will add this and close MDEV-7700 It looks connect string is visible, but never used. This is different from what I think. I just added patch for connect string to MDEV-7698. Please review it. This changes do not cause error for federated_partition test. Thanks, Kentoku

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Thu, Nov 24, 2016 at 8:21 PM, kentoku wrote: > Hi! > >> In which case is it lost ? >> Can you add a test to federated_partition.test that shows in which case the >> connection information is lost? > > when create a table like the following > > create table tbl_a( >

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > In which case is it lost ? > Can you add a test to federated_partition.test that shows in which case the > connection information is lost? when create a table like the following create table tbl_a( col_a int, primary key(col_a) )engine=myisam connection 'some settings for whole table'

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Thu, Nov 24, 2016 at 5:18 PM, Michael Widenius wrote: > Hi! > > On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote: >> Hi Monty! >> >> Thank you for starting this task. I appreciate it. >> >>> Kentoku, do you have patches for the test

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote: > Hi Monty! > > Thank you for starting this task. I appreciate it. > >> Kentoku, do you have patches for the test files, or should I just take >> them from the above spider branch or from somewhere else ? > > I just

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 4:31 PM, kentoku wrote: > Hi Monty! > > Please see comment at 2016-05-07 19:15 for patches for MariaDB 10.2. > >> I don't think this it will work removing the usage of p_elem->connect_string >> >> This is because each partition may have a

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi Monty! Please see comment at 2016-05-07 19:15 for patches for MariaDB 10.2. > I don't think this it will work removing the usage of p_elem->connect_string > > This is because each partition may have a different connect string. I understand this behavior. But I don't think this overwriting

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi Monty! Thank you for starting this task. I appreciate it. > Kentoku, do you have patches for the test files, or should I just take > them from the above spider branch or from somewhere else ? I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! Now working on MDEV-7700 Spiral patch 002_mariadb-10.0.15.spider.diff +++ ./002_mariadb-10.1.8-spider/sql/ha_partition.cc2015-10-14 01:48:53.392665313 +0900 @@ -327,7 +327,9 @@ void ha_partition::init_handler_variable m_file_buffer= NULL; m_name_buffer_ptr= NULL; m_engine_array=

[Maria-developers] Working on spider patches, MDEV-7698

Hi! I have now started to work on the spider patches for MariaDB 10.2, MDEV-7698. I have moved all code from maria-10.1-spider to a new branch maria-10.2-spider and added some more patches. I have closed all related MDEV's in MDEV-7698 that is now included in 10.2-spider. While doing this, I