On Thu, Apr 12, 2018 at 07:22:56PM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
>
> On Apr 12, Sergey Petrunia wrote:
> > > diff --git a/sql/item_strfunc.h b/sql/item_strfunc.h
> > > index 18cda491efd..49de5568696 100644
> > > --- a/sql/item_strfunc.h
> > > +++ b/sql/item_strfunc.h
> > > @@ -1748,
On Thu, Apr 12, 2018 at 07:45:37PM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
>
> Forgot to mention it in my first reply, sorry
>
> On Apr 12, Sergey Petrunia wrote:
> > > diff --git a/sql/item.h b/sql/item.h
> > > index 9574bdc63bf..e391e7810c4 100644
> > > --- a/sql/item.h
> > > +++ b/sql/ite
Hi, Sergey!
On Apr 13, Sergey Petrunia wrote:
> > >
> > > Please add a note that this is not the "_rowid" that we support in
> > > the parser.
> >
> > I used the terminology that you introduced, that is
> > "keep_current_rowid".
> >
> > But if you don't mind, I'd rather rename keep_current_rowi
3 matches
Mail list logo