Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
On 2012/10/14 12:44 PM, Damon McDougall wrote: > On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing wrote: >> All, >> >> I think we are in a messy situation, and we need to reach some agreement >> as to how to proceed. This has been discussed a bit in this thread: >> >> http://sourceforge.net/mailarchi

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
On 2012/10/14 4:49 PM, Jae-Joon Lee wrote: > I'd agree with Eric on most of his points. > > On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing wrote: >> If some of the PEP8 commits include genuine bug-fixes that need to be in >> v1.2.x, then these fixes should be made via PRs directly against v1.2.x. >

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Jae-Joon Lee
I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing wrote: > If some of the PEP8 commits include genuine bug-fixes that need to be in > v1.2.x, then these fixes should be made via PRs directly against v1.2.x. I think it is not a good idea to have a PR that mix

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Thomas Kluyver
On 14 October 2012 21:22, Eric Firing wrote: > 3) The potential disagreement is over whether the PEP8 changes should be > cherry-picked into v1.2.x, or simply left in master. I favor the latter > course. I'm not familiar with matplotlib's merge strategy, but I'd agree with you that making those

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
On 2012/10/14 12:44 PM, Damon McDougall wrote: > On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing wrote: >> All, >> >> I think we are in a messy situation, and we need to reach some agreement >> as to how to proceed. This has been discussed a bit in this thread: >> >> http://sourceforge.net/mailarchi

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Damon McDougall
On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing wrote: > All, > > I think we are in a messy situation, and we need to reach some agreement > as to how to proceed. This has been discussed a bit in this thread: > > http://sourceforge.net/mailarchive/forum.php?thread_name=507AFDC6.8000801%40hawaii.edu&

[matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
All, I think we are in a messy situation, and we need to reach some agreement as to how to proceed. This has been discussed a bit in this thread: http://sourceforge.net/mailarchive/forum.php?thread_name=507AFDC6.8000801%40hawaii.edu&forum_name=matplotlib-devel The name of that thread did not r

Re: [matplotlib-devel] PEP8 github label

2012-10-14 Thread Eric Firing
On 2012/10/14 12:17 AM, Damon McDougall wrote: > On Sun, Oct 14, 2012 at 2:23 AM, Eric Firing wrote: >> That would be my preference; but has Mike written anything about where PEP8 >> changes should go? > > All I can find is this: https://github.com/matplotlib/matplotlib/pull/1153 > Thanks. It's