Re: [matplotlib-devel] Question about getters and setters.

2015-05-15 Thread Brian Granger
OK i have the MEP for this on my todo list... On Thu, May 14, 2015 at 5:47 AM, Benjamin Root wrote: > You could start up a Pull Request describing a MEP that would outline how > traitlets would be used. The discussion can go on there to flesh out the > concepts and the guidance documentation. On

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Neil Girdhar
Come to think of it, I think the inheritance of draw and fill attributes that happen along the path would take advantage of traitlets if you guys decide to go that route. On Fri, May 15, 2015 at 11:40 AM, Neil Girdhar wrote: > Okay, I'm going to wait for more feedback. An hour of design can be

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Neil Girdhar
Okay, I'm going to wait for more feedback. An hour of design can be worth ten hours of implementation :) On Fri, May 15, 2015 at 11:11 AM, Thomas Caswell wrote: > I would advocate for calling yours something different. path.Path is > really a container for a Bezier curve and is probably best l

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Thomas Caswell
I would advocate for calling yours something different. path.Path is really a container for a Bezier curve and is probably best left as simple as possible. There is probably an interesting discussion about right is-a and has-a relations between Path, FancyPath (don't use that name!), and FancyAr

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Neil Girdhar
On Fri, May 15, 2015 at 10:53 AM, Thomas Caswell wrote: > A few very quick comments (just skimmed the docstrings) > > We already have a mpl.path.Path class, please don't shadow that. > I read the Path class and based mine on that. The problem is that I want to be able to place nodes along the p

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Thomas Caswell
A few very quick comments (just skimmed the docstrings) We already have a mpl.path.Path class, please don't shadow that. Is your `Path` going to be an `Artist` that is responsible for drawing it's self or does in serve a role like the existing `Path` in that it is used by other artists as part of

Re: [matplotlib-devel] Incorporating TikZ into Matplotlib

2015-05-15 Thread Neil Girdhar
I have a draft proposal of the long term goal for what an interface could look like for drawing arrows between coordinates or nodes. I based the design on the tikz manual (http://pgf.sourceforge.net/pgf_CVS.pdf), so it might help to flip through that to get an idea for the basis of this design. I

Re: [matplotlib-devel] Fix a warning in recent versions of Clang

2015-05-15 Thread Diego Novillo
On Fri, May 15, 2015 at 7:59 AM, Thomas Caswell wrote: > What version of the source are you working off of? The location of those > headers was recently moved and they no longer exist on master. I was looking at the file in trunk, but the patch is on an older version (1.3.0). Thanks. Diego.

Re: [matplotlib-devel] Fix a warning in recent versions of Clang

2015-05-15 Thread Thomas Caswell
Diego, Thank you for looking in to this. What version of the source are you working off of? The location of those headers was recently moved and they no longer exist on master. I have opened a PR with this patch ( https://github.com/matplotlib/matplotlib/pull/4431) and it should go in for the c

[matplotlib-devel] Fix a warning in recent versions of Clang

2015-05-15 Thread Diego Novillo
Clang will soon start emitting warnings for mismatch uses of new and delete. In testing this upcoming feature of Clang, I found a mismatched new/delete pair in matplotlib. I've applied the following patch in my local tree, but I see that the problem still exists in trunk. The problem here is tha