Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-06-01 Thread Andrew Straw
Eric Firing wrote: > Andrew Straw wrote: >> The slight API change is that spine.set_color() is now >> spine.set_edgecolor(). > > But spine.set_color() is much more natural and easy to remember, so > maybe it can be restored: Good idea. I just re-added Spine.set_color() and changed the example ba

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-06-01 Thread Eric Firing
Andrew Straw wrote: > Thanks everyone for the feedback. I have made Spine subclass Patch in > svn r7170, which I just committed. This resulted in a slight API > change, but addresses most of the more substantial points raised. > > The slight API change is that spine.set_color() is now > spine.set

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-06-01 Thread Andrew Straw
Thanks everyone for the feedback. I have made Spine subclass Patch in svn r7170, which I just committed. This resulted in a slight API change, but addresses most of the more substantial points raised. The slight API change is that spine.set_color() is now spine.set_edgecolor(). More below. > On

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-30 Thread Jae-Joon Lee
Andrew, Another issue. The zorder of the spine artists is set to 0 by default. I notice that you're changing the zorder of its artist attribute, but note that it has no effect as what matter is the zorder of the spine itself. As a related issue to what John mentioned, I think one option you can d

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-28 Thread John Hunter
On Wed, May 27, 2009 at 11:33 AM, Andrew Straw wrote: > I've gone ahead and committed my arbitrary spine location implementation > to the trunk (svn r7144). I'd appreciate it if you could kick the tires. > To get you started, try the new demo: > examples/pylab_examples/spine_placement_demo.py I j

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-27 Thread Jae-Joon Lee
Thanks a lot Andrew. This looks great. I'm just reporting some of issues I encountered in a hope that you can address these (I'll also take a look if have chance). * cla() does not reset spines (positions, color, etc). I think it is better to be reset, since all other things are. For example, c

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-27 Thread John Hunter
On Wed, May 27, 2009 at 12:53 PM, Eric Firing wrote: > No problem--it can be done later, no rush. Your replacement of the > frame with spines is a *big* improvement. Thank you for the great work. Yes, this looks great -- thanks again Andrew. Something that would be nice would be a Formatter t

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-27 Thread Eric Firing
Andrew Straw wrote: > Andrew Straw wrote: >> I believe I addressed all the issues raised with the patch I emailed the >> list last week and I tried to avoid any breakage. Thanks to all who >> commented -- you made this a better implementation. > > Upon further reflection, I realize I didn't add an

Re: [matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-27 Thread Andrew Straw
Andrew Straw wrote: > I believe I addressed all the issues raised with the patch I emailed the > list last week and I tried to avoid any breakage. Thanks to all who > commented -- you made this a better implementation. Upon further reflection, I realize I didn't add any Axes convenience methods a

[matplotlib-devel] arbitrary spine locations in svn trunk

2009-05-27 Thread Andrew Straw
I've gone ahead and committed my arbitrary spine location implementation to the trunk (svn r7144). I'd appreciate it if you could kick the tires. To get you started, try the new demo: examples/pylab_examples/spine_placement_demo.py I believe I addressed all the issues raised with the patch I email