Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-17 Thread Jason Grout
On 09/17/2010 03:04 AM, Eric Firing wrote: > On 09/16/2010 09:27 PM, Jason Grout wrote: >> >> >> I see the change that you made (keep the old order for linux, do the new >> thing for everything else). This seems like a bad thing to do. Looking >> at setjmp.h, it includes features.h. features.h

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-17 Thread John Hunter
On Fri, Sep 17, 2010 at 3:04 AM, Eric Firing wrote: > Before making that change, I verified that at least on my linux system, > Python.h defines those two variables the same way that features.h does, > so the redefinition would be harmless if we did not undefine the > variables. I don't think we

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-17 Thread Eric Firing
On 09/16/2010 09:27 PM, Jason Grout wrote: > On 9/17/10 1:57 AM, Eric Firing wrote: >> On 09/16/2010 08:21 PM, Christoph Gohlke wrote: >>> >>> >>> On 9/16/2010 8:15 PM, Jason Grout wrote: On 9/16/10 10:00 PM, Eric Firing wrote: > On 09/16/2010 04:12 PM, Jason Grout wrote: >> On 9/16/10

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-17 Thread Jason Grout
On 9/17/10 1:57 AM, Eric Firing wrote: > On 09/16/2010 08:21 PM, Christoph Gohlke wrote: >> >> >> On 9/16/2010 8:15 PM, Jason Grout wrote: >>> On 9/16/10 10:00 PM, Eric Firing wrote: On 09/16/2010 04:12 PM, Jason Grout wrote: > On 9/16/10 9:03 PM, Jason Grout wrote: >> On 9/16/10 8:00

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 08:21 PM, Christoph Gohlke wrote: > > > On 9/16/2010 8:15 PM, Jason Grout wrote: >> On 9/16/10 10:00 PM, Eric Firing wrote: >>> On 09/16/2010 04:12 PM, Jason Grout wrote: On 9/16/10 9:03 PM, Jason Grout wrote: > On 9/16/10 8:00 PM, Eric Firing wrote: > I tested y

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 08:45 PM, Jason Grout wrote: > On 9/16/10 11:16 PM, Eric Firing wrote: >> On 09/16/2010 05:15 PM, Jason Grout wrote: >>> On 9/16/10 10:00 PM, Eric Firing wrote: On 09/16/2010 04:12 PM, Jason Grout wrote: > On 9/16/10 9:03 PM, Jason Grout wrote: >> On 9/16/10 8:00 PM, Eric

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 11:16 PM, Eric Firing wrote: > On 09/16/2010 05:15 PM, Jason Grout wrote: >> On 9/16/10 10:00 PM, Eric Firing wrote: >>> On 09/16/2010 04:12 PM, Jason Grout wrote: On 9/16/10 9:03 PM, Jason Grout wrote: > On 9/16/10 8:00 PM, Eric Firing wrote: > I tested your patch

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Christoph Gohlke
On 9/16/2010 8:15 PM, Jason Grout wrote: > On 9/16/10 10:00 PM, Eric Firing wrote: >> On 09/16/2010 04:12 PM, Jason Grout wrote: >>> On 9/16/10 9:03 PM, Jason Grout wrote: On 9/16/10 8:00 PM, Eric Firing wrote: >>> I tested your patch with Ubuntu 10.10, and it failed. The problem is

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 05:15 PM, Jason Grout wrote: > On 9/16/10 10:00 PM, Eric Firing wrote: >> On 09/16/2010 04:12 PM, Jason Grout wrote: >>> On 9/16/10 9:03 PM, Jason Grout wrote: On 9/16/10 8:00 PM, Eric Firing wrote: >>> I tested your patch with Ubuntu 10.10, and it failed. The problem is

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 10:15 PM, Jason Grout wrote: >> Sure does. Your patch with that modification is committed to branch and >> trunk, 8706, 8707. Thank you! >> > > Did someone check on Windows? I was hoping things wouldn't break in > WrapPython.h when I switched the order of includes, but you never know

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 10:00 PM, Eric Firing wrote: > On 09/16/2010 04:12 PM, Jason Grout wrote: >> On 9/16/10 9:03 PM, Jason Grout wrote: >>> On 9/16/10 8:00 PM, Eric Firing wrote: >>> >> I tested your patch with Ubuntu 10.10, and it failed. The problem is >> that something is including setjmp.h befor

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 04:12 PM, Jason Grout wrote: > On 9/16/10 9:03 PM, Jason Grout wrote: >> On 9/16/10 8:00 PM, Eric Firing wrote: >> > I tested your patch with Ubuntu 10.10, and it failed. The problem is > that something is including setjmp.h before libpng.h tries to do so via > pngconf.h,

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 9:03 PM, Jason Grout wrote: > On 9/16/10 8:00 PM, Eric Firing wrote: > I tested your patch with Ubuntu 10.10, and it failed. The problem is that something is including setjmp.h before libpng.h tries to do so via pngconf.h, resulting in an error as the compiler trips over t

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 8:00 PM, Eric Firing wrote: >>> I tested your patch with Ubuntu 10.10, and it failed. The problem is >>> that something is including setjmp.h before libpng.h tries to do so via >>> pngconf.h, resulting in an error as the compiler trips over the >>> following: >> > > Python.h includes py

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 01:04 PM, Jason Grout wrote: > On 9/16/10 5:24 PM, Eric Firing wrote: >> On 09/16/2010 09:50 AM, Jason Grout wrote: >>> As a follow-up, I've implemented the patch for CXX and also patches for >>> the other files which do not include Python.h first here: >>> >>> http://github.com/jason

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
On 9/16/10 5:24 PM, Eric Firing wrote: > On 09/16/2010 09:50 AM, Jason Grout wrote: >> As a follow-up, I've implemented the patch for CXX and also patches for >> the other files which do not include Python.h first here: >> >> http://github.com/jasongrout/matplotlib/commit/a961c299f5d589dae87e06caf5

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Eric Firing
On 09/16/2010 09:50 AM, Jason Grout wrote: > As a follow-up, I've implemented the patch for CXX and also patches for > the other files which do not include Python.h first here: > > http://github.com/jasongrout/matplotlib/commit/a961c299f5d589dae87e06caf54975eb657ebf3b > > > I've also attached the p

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
As a follow-up, I've implemented the patch for CXX and also patches for the other files which do not include Python.h first here: http://github.com/jasongrout/matplotlib/commit/a961c299f5d589dae87e06caf54975eb657ebf3b I've also attached the patch. This patch gets rid of the warnings about rede

Re: [matplotlib-devel] compiling on Solaris (and going against the python API)

2010-09-16 Thread Jason Grout
Apologies for the long message---I've really tried to be precise and complete. On 7/7/10 10:23 AM, Jason Grout wrote: > David Kirkby discovered that a recent SVN version of matplotlib did not > compile when he was testing a new matplotlib for inclusion in Sage. A > bug was opened here: > > https

[matplotlib-devel] compiling on Solaris

2010-07-07 Thread Jason Grout
David Kirkby discovered that a recent SVN version of matplotlib did not compile when he was testing a new matplotlib for inclusion in Sage. A bug was opened here: https://sourceforge.net/tracker/?func=detail&aid=3022815&group_id=80706&atid=560720 It appears that a patch has been committed to 1