Re: [matplotlib-devel] dropped spine support

2009-05-22 Thread John Hunter
On Fri, May 22, 2009 at 9:35 AM, Andrew Straw wrote: > Based on Jae-Joon's comment, I was thinking of making .frame a property > that raised an Error describing to get .spines instead... That avoids > the getattr issues, but I think depends on Artist being a new style class. This is a much bette

Re: [matplotlib-devel] dropped spine support

2009-05-22 Thread Andrew Straw
John Hunter wrote: > On Thu, May 21, 2009 at 10:08 PM, Jae-Joon Lee wrote: > > >> 2) Axes.frame >> Is it okay to simply drop this attribute? Any code that access this >> attribute will raise an exception. For example, some of my code in >> mpl_toolkits.axes_grid access this attribute, althoug

Re: [matplotlib-devel] dropped spine support

2009-05-22 Thread John Hunter
On Thu, May 21, 2009 at 10:08 PM, Jae-Joon Lee wrote: > 2) Axes.frame >  Is it okay to simply  drop this attribute? Any code that access this > attribute will raise an exception. For example, some of my code in > mpl_toolkits.axes_grid access this attribute, although a fix would be > very trivial

Re: [matplotlib-devel] dropped spine support

2009-05-21 Thread Jae-Joon Lee
I just had a quick at the patch and it looks good. I have two minor issues. 1) API change in Axes.get_xaxis_transform & get_yaxis_transform. The default keyword argument which=None raises an exception. Maybe you meant which="grid"? 2) Axes.frame Is it okay to simply drop this attribute? Any

Re: [matplotlib-devel] dropped spine support

2009-05-21 Thread John Hunter
On Thu, May 21, 2009 at 7:47 PM, Eric Firing wrote: > Andrew Straw wrote: >> I've implemented initial support for "dropped spines". This is motivated >> by the ability to draw figures that look like >> http://jeb.biologists.org/cgi/content/full/211/3/341/FIG7 . I'm >> attaching the patches and an

Re: [matplotlib-devel] dropped spine support

2009-05-21 Thread Eric Firing
Andrew Straw wrote: > I've implemented initial support for "dropped spines". This is motivated > by the ability to draw figures that look like > http://jeb.biologists.org/cgi/content/full/211/3/341/FIG7 . I'm > attaching the patches and an image created by the new example. > > This is a somewhat i