Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-15 Thread Eric Firing
Jason R. Coombs wrote: > It appears that the docstring.py module somehow got omitted from the rev5 > patch (I was working from two different machines, and one didn't have it > added to SVN). > > So I'm attaching missing_docstring.patch which is a patch against the latest > trunk to include the lat

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-15 Thread Jason R. Coombs
Jason R. Coombs Cc: matplotlib development list Subject: Re: [matplotlib-devel] kwdoc processing with decorators Jason R. Coombs wrote: > I'm about to upload a new patch that implements some of the ideas John and > Darren have sent. Would you mind running the performance tests against

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-14 Thread Jason R. Coombs
I believe this corrects the issue. Please let me know if you encounter any additional issues. Regards, Jason -Original Message- From: Eric Firing [mailto:efir...@hawaii.edu] Sent: Thursday, 13 August, 2009 21:33 To: Jason R. Coombs Cc: matplotlib development list Subject: Re: [matplotlib-de

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-14 Thread Jason R. Coombs
bject: Re: [matplotlib-devel] kwdoc processing with decorators Jason R. Coombs wrote: > I'm about to upload a new patch that implements some of the ideas John and > Darren have sent. Would you mind running the performance tests against that > one also? This new change has the po

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-14 Thread Jouni K . Seppänen
Eric Firing writes: > 3) Question: how does this affect startup time? Jouni tested two > approaches to his work, and the decorator approach was significantly > slower. No, actually the difference was barely measurable. The reason I chose the boilerplate approach of generating source files i

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Eric Firing
Jason R. Coombs wrote: > I'm about to upload a new patch that implements some of the ideas John and > Darren have sent. Would you mind running the performance tests against that > one also? This new change has the potential to increase performance drag. Jason, There is a problem with rev4, runni

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Eric Firing
Jason R. Coombs wrote: I'm about to upload a new patch that implements some of the ideas John and Darren have sent. Would you mind running the performance tests against that one also? This new change has the potential to increase performance drag. I tested it; performance still is not a proble

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Eric Firing
Jason R. Coombs wrote: > I'm about to upload a new patch that implements some of the ideas John and > Darren have sent. Would you mind running the performance tests against that > one also? This new change has the potential to increase performance drag. > > Jason I'll test it, but it might be a

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Jason R. Coombs
mailto:efir...@hawaii.edu] > Sent: Thursday, 13 August, 2009 15:37 > To: John Hunter > Cc: Jason R. Coombs; Darren Dale; matplotlib development list > Subject: Re: [matplotlib-devel] kwdoc processing with decorators > > > I tested the startup time for r7480 before and after th

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Eric Firing
John Hunter wrote: > On Thu, Aug 13, 2009 at 1:08 PM, Eric Firing wrote: > >> Ideally, all the docstring manipulations would be done once at the time of >> installation or of compilation to .pyc, not at every mpl startup. I think >> that doing it at compilation time is impossible, given python's

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread John Hunter
On Thu, Aug 13, 2009 at 1:08 PM, Eric Firing wrote: > Ideally, all the docstring manipulations would be done once at the time of > installation or of compilation to .pyc, not at every mpl startup.  I think > that doing it at compilation time is impossible, given python's fundamental > design, so t

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Eric Firing
Jason R. Coombs wrote: > >> -Original Message- >> From: Darren Dale [mailto:dsdal...@gmail.com] >> >> On Thu, Aug 13, 2009 at 7:44 AM, John Hunter wrote: >>> On Wed, Aug 12, 2009 at 7:12 AM, John Hunter >> wrote: >> I appreciate how much time has gone into the patch, but this impacts >> so

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Jason R. Coombs
John, This seems like a good idea. I wanted to prove and vet the decorators first, shake out any emergent issues, and then consider enhancements that the new structure might enable. While I was working through this, I was surprised when I saw how the kwdocd was assembled from the various modules

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Jason R. Coombs
> -Original Message- > From: Darren Dale [mailto:dsdal...@gmail.com] > > On Thu, Aug 13, 2009 at 7:44 AM, John Hunter wrote: > > On Wed, Aug 12, 2009 at 7:12 AM, John Hunter > wrote: > I appreciate how much time has gone into the patch, but this impacts > so much code I think it is import

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Jason R. Coombs
t: Re: [matplotlib-devel] kwdoc processing with decorators > > On Thu, Aug 13, 2009 at 10:24 AM, Gael > Varoquaux wrote: > > > > I have not followed the conversation, so please forgive me if I am > > talking bull**, but why are you not using functools.wraps? I have > fou

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Darren Dale
On Thu, Aug 13, 2009 at 11:46 AM, John Hunter wrote: > On Thu, Aug 13, 2009 at 9:12 AM, Darren Dale wrote: > > I don't think Jason is on the dev list, so I am CC-ing him.  Please > make sure he is CC-d on all other conversations in this thread. > >> I appreciate how much time has gone into the patc

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread John Hunter
On Thu, Aug 13, 2009 at 9:12 AM, Darren Dale wrote: I don't think Jason is on the dev list, so I am CC-ing him. Please make sure he is CC-d on all other conversations in this thread. > I appreciate how much time has gone into the patch, but this impacts > so much code I think it is important to

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Gael Varoquaux
On Thu, Aug 13, 2009 at 10:52:24AM -0400, Darren Dale wrote: > I am aware of functools.wraps and have used it myself. So far we are > only modifying and returning the original function, not a wrapped > version of the original, so functools.wraps is not necessary. OK, as I suspected, I was not read

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Darren Dale
Hi Gael, On Thu, Aug 13, 2009 at 10:24 AM, Gael Varoquaux wrote: > On Thu, Aug 13, 2009 at 10:12:23AM -0400, Darren Dale wrote: >> I appreciate how much time has gone into the patch, but this impacts >> so much code I think it is important to really nail the >> implementation. I think everything s

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Gael Varoquaux
On Thu, Aug 13, 2009 at 10:12:23AM -0400, Darren Dale wrote: > I appreciate how much time has gone into the patch, but this impacts > so much code I think it is important to really nail the > implementation. I think everything should be rolled up into a single > high level decorator if possible. I

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread Darren Dale
On Thu, Aug 13, 2009 at 7:44 AM, John Hunter wrote: > On Wed, Aug 12, 2009 at 7:12 AM, John Hunter wrote: >> Those of you with an interest in mpl docstring processing may want to >> comment on this tracker item >> >> https://sourceforge.net/tracker/index.php?func=detail&aid=2835685&group_id=80706&a

Re: [matplotlib-devel] kwdoc processing with decorators

2009-08-13 Thread John Hunter
On Wed, Aug 12, 2009 at 7:12 AM, John Hunter wrote: > Those of you with an interest in mpl docstring processing may want to > comment on this tracker item > > https://sourceforge.net/tracker/index.php?func=detail&aid=2835685&group_id=80706&atid=560720 This patch has come a long way since initial s

[matplotlib-devel] kwdoc processing with decorators

2009-08-12 Thread John Hunter
Those of you with an interest in mpl docstring processing may want to comment on this tracker item https://sourceforge.net/tracker/index.php?func=detail&aid=2835685&group_id=80706&atid=560720 JDH -- Let Crystal Reports h