Leonard den Ottolander wrote:
Hi,
[...]
- Blatantly ignoring any suggestion to use NULL, TRUE or FALSE.
[...]
+#include config.h
+#include edit.h
+#include syntax.h
+#include ../src/wtools.h
- Blatantly ignoring any suggestions to follow common #include practice.
+void
Hello,
On Mon, 11 Jul 2005, Leonard den Ottolander wrote:
On Mon, 2005-07-11 at 17:02, Pavel Tsekov wrote:
Instead of a macro you could use the following construct:
static const int MAX_ENTRY_LEN = 40;
Yes, I could to that. Why do you feel this is a cleaner approach?
I know that it is
On Mon, Jul 11, 2005 at 06:02:09PM +0300, Pavel Tsekov wrote:
Instead of a macro you could use the following construct:
static const int MAX_ENTRY_LEN = 40;
this is c++ (well, except that const implies static, i heard). maybe its
in newer c standards, too, but i'm not sure we want to depend
Hello,
On Tue, 12 Jul 2005, Oswald Buddenhagen wrote:
On Tue, Jul 12, 2005 at 10:26:03AM +0300, Pavel Tsekov wrote:
static const int MAX_ENTRY_LEN = 40;
this is c++ (well, except that const implies static, i heard). maybe
its in newer c standards, too, but i'm not sure we want to
Hi Roland,
On Tue, 2005-07-12 at 08:41, Roland Illig wrote:
exec_syntax_dialog should not use the constant MAX_SYNTAX_FILES, but
some parameter names_size. That makes the relation between them tight
closer.
As I've explained the caller cannot make any sensible guess about the
size of the
On Mon, Jul 11, 2005 at 11:02:31PM +0200, Leonard den Ottolander wrote:
F.e. I've translated N_(Quit) to Afsltn in Dutch. This is short for
Afsluiten. Now this string fits nicely in the quick bar, but it's
quite ugly as a header in the quit dialog. By defining the quit string
for the quick
Hello,
On Tue, 12 Jul 2005, Leonard den Ottolander wrote:
On Tue, 2005-07-12 at 09:14, Pavel Tsekov wrote:
I know that it is cleaner and better. The macro is something that is
handled by the preprocessor i.e. before the compiler steps in. So the
compiler doesn't know anything about
Hi Egmont,
On Tue, 2005-07-12 at 13:13, Egmont Koblinger wrote:
Quite ugly approach since it relies on Quit actually being shorter than 6
chars.
The quick bar strings all have a maximum length of 6 chars.
And what do you do at RenMov, Delete, PullDn?
I think the former and the latter are
Hello,
On Tue, 12 Jul 2005, Leonard den Ottolander wrote:
On Tue, 2005-07-12 at 08:41, Roland Illig wrote:
exec_syntax_dialog should not use the constant MAX_SYNTAX_FILES, but
some parameter names_size. That makes the relation between them tight
closer.
As I've explained the caller
Hello,
On Tue, 12 Jul 2005, Egmont Koblinger wrote:
By the way: the bottom right corner of mc has Quit while the File menu
contains eXit associated to F10. Shouldn't they be called the same?
Good catch! Just checked Volkov Commander and it has Quit in both places.
But what should MC do in
Follow-up Comment #1, bug #13727 (project mc):
What do you think should be done in this case ?
1) Silently ignore the fact and continue
2) Pop up a box with several choices
3) Something else
___
Reply to this item at:
Hi Pavel,
On Tue, 2005-07-12 at 13:28, Pavel Tsekov wrote:
How about informing the caller how much memory should be allocated ? The
caller passes a pointer to integer, which is filled with the number of slots
it allocated, to the callee. The callee finds out that the slots are not
enough,
Follow-up Comment #4, bug #13728 (project mc):
Does `bar/name/' contain any entries or is it empty ?
empty, but this should not matter. i don't think we want this susv3-compliant
behavior. at the top level, if the target is an existing directory (empty or
not), we want to move _into_ this
Egmont Koblinger wrote:
A more generic approach is to add the same prefix to all these strings (e.g.
1Quit), make a comment for translators to leave that prefix as it is (e.g.
1Afsltn) and strip that prefix at runtime.
I suggest another naming scheme for it, as the 1 has no intuitive
14 matches
Mail list logo
