Re: msg-patch needs to be checked by experts

2009-03-29 Thread Roland Illig
Vit R schrieb: II. Has it some meaning: maint/template.c:32: #include ... Yes. That file is a template that needs to be modified anyway. If you read the whole file, its intention should be clear to you. Roland ___ Mc-devel mailing list

Re: updated: [54d6ec8] replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file()

2009-02-01 Thread Roland Illig
Andrew Borodin schrieb: On Sat, 31 Jan 2009 18:17:03 +0100 (CET) Enrico Weigelt, metux IT service wrote: +static inline char* mhl_str_dir_plus_file(const char* dirname, const char* filename) +{ +/* make sure we have valid strings */ +if (!dirname) +dirname=; Why is this

Re: updated: [89d3cbd] Removed unneeded var to make build process a bit cleaner

2009-01-26 Thread Roland Illig
Patrick Winnertz schrieb: @@ -61,7 +61,7 @@ static inline char* __mhl_str_concat_hlp(const char* base, ...) size_t totalsize = 0; // first pass: scan through the params and count string sizes -va_list par; +//va_list par; These comments are not valid in C90. And

Re: glib or not glib?

2009-01-07 Thread Roland Illig
Andrew Borodin schrieb: On Wed, 7 Jan 2009 09:35:25 +0100 Enrico Weigelt wrote: * MC Ticket System tick...@midnight-commander.org schrieb: Why the _strcatdup() function is used instead of g_strconcat() one? First tiny step to get rid if glib. It's very strange. Do you think than mc must

Re: bundled intl stuff necessary

2008-12-31 Thread Roland Illig
Enrico Weigelt schrieb: Hi folks, is it necessary to have the intl lib bundled into mc or could it be taken directly from the system ? (I admit, I don't know much about how it really works ;-o) I don't think it is necessary. There are many other projects who have dropped the internal intl/

[bug #15257] mc viewer enters a probably infinite cycle on some files with 8-bit characters

2008-12-19 Thread Roland Illig
Update of bug #15257 (project mc): Status: Need Info = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[bug #23826] Segmentation fault when opening/browsing file

2008-12-19 Thread Roland Illig
Update of bug #23826 (project mc): Status:None = Invalid Open/Closed:Open = Closed ___ Follow-up Comment #1: I cannot reproduce the

[bug #24505] loading X11 library is broken

2008-12-19 Thread Roland Illig
Update of bug #24505 (project mc): Status: Confirmed = Need Info ___ Follow-up Comment #2: Which version of mc are you using? The current version uses GModule for loading shared libraries,

[bug #24505] loading X11 library is broken

2008-12-19 Thread Roland Illig
Update of bug #24505 (project mc): Status: Need Info = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #3: Fixed in the current CVS

Re: Further Midnight Commander development

2008-12-18 Thread Roland Illig
Patrick Winnertz schrieb: So: At first the people who would like to work on mc should send a: I would like to do something. I'd like to. If there is some more action in mc development (like in 2005, when it was great fun), I'm definitely willing to invest some time into it. Maybe we even get

[patch] Invoking mcedit with filename:lineno

2008-12-09 Thread Roland Illig
Hi, many programs output warnings and errors in the format filename:lineno[:]. The attached patch allows users to just copy and paste these locations and invoke mcedit with them. For example: $ mcedit main.c:2000 The patch maintains the usual behavior as much as possible. That is, the new

[bug #24986] crash at startup because of using uninitialized variable

2008-12-02 Thread Roland Illig
Update of bug #24986 (project mc): Severity: 3 - Normal = 4 - Important Open/Closed:Open = Accepted for 4.6.x ___ Reply to this item at:

Re: Small bug in Version 4.6.1 wrapper scripts

2008-11-05 Thread Roland Illig
Lawrence Cahoon schrieb: Hi: I found (and fixed, I think) a small bug in the mc-wrapper.sh file. As delivered, the 6th line of the script is: MC_PWD=`cat $MC_PWD_FILE` but I think it should be: MC_PWD=cat `$MC_PWD_FILE` I don't think you tested exactly this change successfully.

[bug #24594] Wrong sort in case-insensitive sort mode

2008-10-17 Thread Roland Illig
Update of bug #24594 (project mc): Status:None = Invalid Assigned to:None = rillig Open/Closed:Open = Closed

[bug #24505] loading X11 library is broken

2008-10-09 Thread Roland Illig
Update of bug #24505 (project mc): Status:None = Confirmed Assigned to:None = rillig Operating System: GNU/Linux = All

Re: [bug #24038] slow starting of mc

2008-08-12 Thread Roland Illig
Ies Nijman schrieb: Follow-up Comment #3, bug #24038 (project mc): Previous results were from MC 4.6.1 (fast starting). Next slow results from MC 4.6.2 and a strace file. Can you please include the relative timestamps in the strace file? The option is -t. Roland

Re: mc-Bug?

2008-06-17 Thread Roland Illig
7007h pooh schrieb: Hi, Let's make it short - my english isn't best ;) When connected to my ftp-server trough mc everything is all right, thanks for this! Now trying to copy something and the server timed-out (After few minutes) I get a segmentation fault - not what I want... You're right,

[bug #22179] Inconsistent (and confusing) Tab behaviour

2008-02-12 Thread Roland Illig
Update of bug #22179 (project mc): Status:None = Invalid Open/Closed:Open = Closed Operating System: GNU/Linux = All

Re: problems with compiling mc

2008-01-29 Thread Roland Illig
pavol pavelka wrote: hello, i would like to ask you if it is possible to compile mc under winXP and if so, what I have to do? I was trying to compile using Makefile.MIN in pc directory, but witha any success. I get used for mc in Linux and now I have to use Windows in my job and I

[bug #21959] bug in MC beim Start verbindung ins Internet

2008-01-06 Thread Roland Illig
Update of bug #21959 (project mc): Category:None = VFS Status:None = Fixed Assigned to:None = rillig Open/Closed:

[bug #21959] bug in MC beim Start verbindung ins Internet

2008-01-05 Thread Roland Illig
Follow-up Comment #1, bug #21959 (project mc): Es könnte daran liegen, dass in der Samba-Konfigurationsdatei (/etc/smb.conf) in der Zeile interfaces = Netzwerk-Interfaces (z. B. eth0) statt IP-Adressen angegeben sind. Früher waren nur IP-Adressen erlaubt, mittlerweile auch Netzwerk-Interfaces.

Switching the internal editor between byte and UTF-8 mode

2007-10-18 Thread Roland Illig
Hi, in recent discussions, there has often been the question whether the editor should be converted to UTF-8, and indeed, many Linux distributions have chosen to patch mc so that it does. I would at least like to keep the possibility of editing plain binary files, so I suggest to add a new

[bug #3836] As Root, upon Exit, MC chmods /dev/null 600 !

2007-01-03 Thread Roland Illig
Additional Item Attachment, bug #3836 (project mc): File name: widget.c.patch Size:0 KB ___ Reply to this item at: http://savannah.gnu.org/bugs/?3836 ___ Nachricht

[bug #18191] mc crashes with segmentation violation when viewing /proc/registers

2006-11-03 Thread Roland Illig
Follow-up Comment #1, bug #18191 (project mc): Note: this is fixed in the CVS version of mc, in which the viewer has been rewritten in large parts. ___ Reply to this item at: http://savannah.gnu.org/bugs/?18191

[bug #18121] calculation of major and minor device numbers is not portable

2006-10-26 Thread Roland Illig
Update of bug #18121 (project mc): Status:None = Fixed Assigned to:None = rillig Open/Closed:Open = Closed

Re: Slower viewer [was Re: Shall we have a release?]

2006-08-04 Thread Roland Illig
Leonard den Ottolander wrote: Hi Roland, list, On Fri, 2006-08-04 at 06:35 +0200, Roland Illig wrote: You should try mc-4.6.1 then. It gets you to the end immediately. Note that we had a long time where mc-4.6.1 had already been branched, but I had rewritten the viewer in -HEAD

Re: Shall we have a release?

2006-08-04 Thread Roland Illig
Leonard den Ottolander wrote: Hi all, It would be nice if we could have a new release (4.6.2) in a few weeks. Although nothing spectacular has changed there have been some improvements in the last 12 months. If we agree on a release date I'm prepared to write down a list of changes. Please

Re: Shall we have a release?

2006-08-02 Thread Roland Illig
Leonard den Ottolander wrote: Hi all, It would be nice if we could have a new release (4.6.2) in a few weeks. Although nothing spectacular has changed there have been some improvements in the last 12 months. If we agree on a release date I'm prepared to write down a list of changes.

Re: Quoting of variables in fsusage.m4 and ls-mntd-fs.m4

2006-05-30 Thread Roland Illig
Pavel Tsekov wrote: On Mon, 29 May 2006, Roland Illig wrote: Roland Illig wrote: The quoting hid one bug that appeared due to one variable being used, which had never been defined before. I think it has been fixed upstream. It has, and I updated our version of ls-mntd-fs.m4 to the one

Re: Quoting of variables in fsusage.m4 and ls-mntd-fs.m4

2006-05-29 Thread Roland Illig
Roland Illig wrote: The quoting hid one bug that appeared due to one variable being used, which had never been defined before. I think it has been fixed upstream. It has, and I updated our version of ls-mntd-fs.m4 to the one of coreutils. I also documented that in the ChangeLog. Sorry

Re: [patch] Fix progress reporting for file move

2006-05-21 Thread Roland Illig
Hampa Hug wrote: Hello If a file is moved by copy/remove the progress bar is advanced twice. On the other hand, if a file is moved by renaming the progress bar is never updated. The attached patch fixes this. Thanks for identifying and fixing this long-known bug. Before committing the patch,

[bug #16452] mcedit forgets POSIX newline at end of file

2006-04-29 Thread Roland Illig
Follow-up Comment #4, bug #16452 (project mc): mcedit is currently suitable for editing binary files, too. I wouldn't like to give up this feature. So we had to do something like: if (the current file looks like a text file) { if (edit-size 0 get_byte(edit-size) != '\n') { if

[bug #15749] strange behavior with viewing files 2Gb

2006-02-14 Thread Roland Illig
Update of bug #15749 (project mc): Status:None = Need Info Assigned to:None = rillig ___ Follow-up Comment #1: It's true that the

Re: ``ctime''

2006-02-10 Thread Roland Illig
manpage and sourcecode. No hints. Where did you get that source code ? There is no reference to creation time in the current source code. You are right though that in the manpage says creation time. Indeed there is one: 2005-09-05 Roland Illig [EMAIL PROTECTED] * info.c: [...] st_ctime

Re: AMC patches ported to mc-2006-02-03-13.tar.gz

2006-02-06 Thread Roland Illig
Pavel Tsekov wrote: On Mon, 6 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files This doesn't seem very intuitive. Why? /mask things in the current (/) directory

[bug #14155] 4.6.1: mouse wheel strangeness

2006-02-04 Thread Roland Illig
Update of bug #14155 (project mc): Status: Fixed = Need Info Open/Closed: Closed = Open ___ Follow-up Comment #15: The second patch broke

[patch] new pty allocation strategy for BSD

2006-02-04 Thread Roland Illig
Hi, subshell.c currently contains hard-coded values for the available pty names. These names do not match with the ptys that can be found on actual systems. NetBSD 3.0 has ptyp[0-9A-Za-z], as well as pty[qrs][0-9A-Za-z], so mc can only use 64 of the 100 available ptys. There may be similar

Re: [bug #14155] 4.6.1: mouse wheel strangeness

2006-02-04 Thread Roland Illig
anonymous wrote: Follow-up Comment #7, bug #14155 (project mc): hey everyone. ok so this problem had been bugging me too. and i see the patch fixed it and for that I am very grateful. but now it appears something else has broke, the situation is this; i use Eterm for my terminal. I noticed

Re: current CVS mc isn't compilable

2006-02-02 Thread Roland Illig
Pavel Tsekov wrote: Fixed. Oops and thanks. :) Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Crash on hexediting empty file

2006-02-02 Thread Roland Illig
Pavel Tsekov wrote: Index: src/view.c === RCS file: /cvsroot/mc/mc/src/view.c,v retrieving revision 1.353 diff -u -p -r1.353 view.c --- src/view.c 1 Feb 2006 15:59:21 - 1.353 +++ src/view.c 2 Feb 2006 08:49:45 - @@

[bug #11951] [RFE] Show size of all files in directory

2006-01-28 Thread Roland Illig
Update of bug #11951 (project mc): Category: Editor = Core Status:None = Fixed Assigned to:None = rillig Open/Closed:

[bug #10557] [PATCH] makes brief listing mode selectable with ALT+T

2006-01-28 Thread Roland Illig
Update of bug #10557 (project mc): Status:None = Fixed Assigned to:None = rillig Open/Closed:Open = Closed

[bug #15461] vfs/extf for rpm/trpm query obsolete rpm tags

2006-01-28 Thread Roland Illig
Update of bug #15461 (project mc): Category:None = VFS ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=15461

[bug #15057] Feature request, please add support for dar archives

2006-01-28 Thread Roland Illig
Update of bug #15057 (project mc): Category:None = VFS ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=15057

[patch #4741] Syntax Support for config files (conf,ini,cfg,...)

2006-01-28 Thread Roland Illig
Update of patch #4741 (project mc): Status:None = Need Info Assigned to:None = rillig ___ Follow-up Comment #1: This patch doesn't use

Re: [PATCH] Add a command line switch to disable X11 connection

2006-01-28 Thread Roland Illig
Pavel Tsekov wrote: The patch is pretty simple. Comments, etc are much appreciated. You forgot to change the documentation in doc/mc.1.in. Besides that, it looks fine. Roland ___ Mc-devel mailing list

Re: [PATCH] Add a command line switch to disable X11 connection

2006-01-28 Thread Roland Illig
Pavel Tsekov wrote: On Sat, 28 Jan 2006, Roland Illig wrote: Pavel Tsekov wrote: The patch is pretty simple. Comments, etc are much appreciated. You forgot to change the documentation in doc/mc.1.in. Besides that, it looks fine. Are you sure that I didn't change it ? From what I can

Re: [bug #4327] ftpfs confused by certain directory names

2006-01-28 Thread Roland Illig
Leonard den Ottolander wrote: Follow-up Comment #5, bug #4327 (project mc): The third paragraph in comment #4 is a incorrect combination of 2 thoughts. What I meant to say is: 1) We can't determinate whether the date string is 3 or 4 fields long if the file name contains spaces so we need to

[bug #2796] cons.saver in wrong directory

2006-01-27 Thread Roland Illig
Update of bug #2796 (project mc): Status:None = Fixed Assigned to:None = rillig Open/Closed:Open = Closed

[bug #4327] ftpfs confused by certain directory names

2006-01-27 Thread Roland Illig
Follow-up Comment #3, bug #4327 (project mc): The current development version has the valid range of years restricted to 1970 .. 2015. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=4327

[bug #4835] MC misinterprets input

2006-01-27 Thread Roland Illig
Update of bug #4835 (project mc): Status: Need Info = Invalid Open/Closed:Open = Closed ___ Follow-up Comment #2: Feedback timeout.

[bug #15257] mc viewer enters a probably infinite cycle on some files with 8-bit characters

2006-01-27 Thread Roland Illig
Update of bug #15257 (project mc): Status:None = Need Info Assigned to:None = rillig ___ Follow-up Comment #1: This is most likely

Re: accels busted

2006-01-27 Thread Roland Illig
Pavel Tsekov wrote: It would be nice if Roland joined the discussion... Yes, he really should. After all, it's him who broke mc all the time. Who's going to ask him? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: accels busted

2006-01-27 Thread Roland Illig
Oswald Buddenhagen wrote: one of the recent commits broke the alt-letter from main menu accelerators in mcedit. a related thing that always annoyed me: once you are in the menu (after f9), pressing just the unmodified letter should open the respective submenu as well. I had not checked the

Re: [RFE][PATCH] Display free space on device in panels

2005-12-31 Thread Roland Illig
Jindrich Novy wrote: --- mc-4.6.1a/src/screen.c.showfree 2005-12-28 16:49:52.0 +0100 +++ mc-4.6.1a/src/screen.c2005-12-28 17:14:45.0 +0100 @@ -106,6 +107,12 @@ int filetype_mode = 1; /* The hook list for the select file function */ Hook *select_file_hook = 0; +/*

Re: [PATCH] Proper names

2005-12-21 Thread Roland Illig
Pavel Roskin wrote: Hello! On Tue, 2005-12-20 at 20:45 +0100, Marcin Garski wrote: Hello, Here is the patch that changes names to it proper version, like Red Hat, GNOME, GTK+. I think it's wrong to fix ChangeLog files in such way. I understand fixing spacing or obvious typos, but

Re: [PATCH] PHP syntax highlighting broken

2005-12-02 Thread Roland Illig
Jindrich Novy wrote: Hello mc-devel, the php.syntax file is broken due to bad highlighting definition of LOG_LOCAL[0-7] symbols. To reproduce: F4 on any .php file. Results: Error in file /usr/share/mc//syntax/php.syntax on line 4367 and file is edited without any highlighting. Patch is

Re: [PATCH] concat_dir_and_file() needs fixes

2005-12-02 Thread Roland Illig
Jindrich Novy wrote: --- mc-4.6.1a/src/util.c.jn 2005-12-02 11:08:26.0 +0100 +++ mc-4.6.1a/src/util.c2005-12-02 13:11:19.0 +0100 @@ -1515,9 +1515,16 @@ /* If filename is NULL, then we just append PATH_SEP to the dir */ char * -concat_dir_and_file (const char

Re: Depency on ld-linux.so.2(GLIBC_PRIVATE)

2005-11-16 Thread Roland Illig
Leonard den Ottolander wrote: Hi Roland, On Tue, 2005-11-15 at 23:17 +0100, Roland Illig wrote: If you insist on this fix, please put the 0 at the beginning of the line. Otherwise it's likely to be missed. Please do :) -#if !defined(HAVE_ISSETUGID) ... +#if 0 /* was: !defined

Re: Depency on ld-linux.so.2(GLIBC_PRIVATE)

2005-11-15 Thread Roland Illig
Leonard den Ottolander wrote: AFAICT it's not unusual to fix such issues with a minimal diff. If you insist on this fix, please put the 0 at the beginning of the line. Otherwise it's likely to be missed. I could remove the entire block, but I might just wait for this to be fixed upstream.

Re: mcslang2

2005-09-28 Thread Roland Illig
Pavel Tsekov wrote: Suddenly everyone on this list is only interested in sporting the right tone. Whatever the tone it cannot hide the fact that decisions are made from people that hardly have the skills to do so. Just to remind you: Leonard hasn't made a decision, but only a suggestion.

Re: new VFS directory listing parser

2005-09-28 Thread Roland Illig
Leonard den Ottolander wrote: Hi Roland, On Tue, 2005-09-27 at 01:27 +0200, Roland Illig wrote: The current directory listing parser (for ftpfs and extfs) has problems with file names starting with white-space or a four-digit sequence. The latter is caused by the fact that different types

Re: mcslang2

2005-09-27 Thread Roland Illig
Leonard den Ottolander wrote: Hi Pavel, On Tue, 2005-09-27 at 20:39 +0200, Pavel Tsekov wrote: Bootstrap the code and see the generated configure file. Similiar construct is used but in different context. I told you many times - you are too fast, too eager. I didn't say this patch was

Re: Proposal for simplification

2005-09-27 Thread Roland Illig
Pavel Roskin wrote: 3) Support only versions of gettext that have ngettext(), i.e. drop gettext 0.10.x. There had been the suggestion that we don't use internal gettext at all. This would simplify at least the ./autogen.sh and the configure script. It would also reduce the size of the

Re: mcslang2

2005-09-27 Thread Roland Illig
Pavel Tsekov wrote: [...] I told you many times - you are too fast, too eager. This is not the right tone for feedback. Leonard hasn't yet committed his change. If he had, this tone would be appropriate. Please choose your words to sound a little more polite. Roland

Re: locale(1) and iso9660 extfs

2005-09-26 Thread Roland Illig
q# wrote: -save_ctype=`locale | grep LC_CTYPE` +save_ctype=`locale 2/dev/null | grep LC_CTYPE` Committed. Thanks. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

new VFS directory listing parser

2005-09-26 Thread Roland Illig
The current directory listing parser (for ftpfs and extfs) has problems with file names starting with white-space or a four-digit sequence. Today I have completely rewritten the parser code. The file vfsparse.h in the patch contains a lot of parsing functions that can be used not only in the

Re: new VFS directory listing parser

2005-09-26 Thread Roland Illig
Forgot the patch. ;) Roland ftpfs-listing.patch.gz Description: GNU Zip compressed data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

AFK until Sep 21 2005

2005-09-09 Thread Roland Illig
Hello mc developers, I will be mostly away from keyboard until Sep 21. In the first days, I will still have some access to read my mails. Have a nice time. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Little Translation HOWTO (was: Translators wanted)

2005-09-08 Thread Roland Illig
Dear translators, I got some mails that we got some translators who haven't done any translation before. This mail contains some basic instructions that may help you translating. First, you need to download your translation file from

Translators wanted

2005-09-07 Thread Roland Illig
Hi, some years ago, the Midnight Commander had been translated quite well into a whole bunch of languages other than English. Somehow, the translation process has stalled sadly. If you want to help us getting translations of the Midnight Commander, please write to the mc-devel@gnome.org mailing

Re: bug in F2 menu.

2005-09-06 Thread Roland Illig
Roland Illig wrote: ForestCreature wrote: try to gzip/bzip2 directory containig spaces fails. Example ~/my dir/ F2Enter Result my\ dir.tar.gz file contains no files. Thanks for the bug report. I can reproduce it and I'm working on it. It is fixed it the current development version

Re: bug in F2 menu.

2005-09-06 Thread Roland Illig
Pavel Tsekov wrote: Hello, On Tue, 6 Sep 2005, Leonard den Ottolander wrote: Hmmm, the Alt-space was more difficult than it seemed, so I have chosen to use a simple space, which is also much more convenient. The current development version contains the feature. You can download it from I am

Re: tty.c

2005-09-06 Thread Roland Illig
Pavel Tsekov wrote: Hello, On Thu, 1 Sep 2005, Roland Illig wrote: Another benefit of the wrapper is that it reduces the number of warnings for SLsmg_printf(), which is still declared as taking a char *, not a const char *, as first argument. Just build mc with gcc -Wwrite-string and see

Re: bug in F2 menu.

2005-09-06 Thread Roland Illig
Leonard den Ottolander wrote: I am afraid such an option would interfere with a user trying to start a command with a space, which is f.e. useful when HISTCONTROL=ignorespace. I didn't know that this was a commonly used feature, but I've changed the key from a simple space to Ctrl-space,

Re: bug in F2 menu.

2005-09-06 Thread Roland Illig
Leonard den Ottolander wrote: Hello Roland, On Tue, 2005-09-06 at 12:51 +0200, Roland Illig wrote: And you can still start the command line with a space by pressing C-q space. How convenient :-( . Get rid of this. I've already done that. Roland

Re: bug in F2 menu.

2005-09-05 Thread Roland Illig
ForestCreature wrote: try to gzip/bzip2 directory containig spaces fails. Example ~/my dir/ F2Enter Result my\ dir.tar.gz file contains no files. Thanks for the bug report. I can reproduce it and I'm working on it. P.S.: And I would like to see a feature in future release : to

Re: tty.c

2005-09-01 Thread Roland Illig
Pavel Tsekov wrote: Hello Roland, 2005-08-29 Roland Illig [EMAIL PROTECTED] * slint.c: The handling of user interrupts has been moved to ... * tty.c: ... this newly created file, which contains a simple, not yet complete interface to the terminal library. It should

Re: Long filenames

2005-08-17 Thread Roland Illig
andrzej zaborowski wrote: There are only some minor issues about the new viewer: First, the navigation in hex mode is strange: when pressing the down arrow it will scroll only after the cursor gets to the bottom of the screen (like in editor) while up arrow scrolls immediately. I just fixed

Re: Long filenames

2005-08-17 Thread Roland Illig
andrzej zaborowski wrote: Hello MC, I found that long filenames are not displayed correctly (or as I would expect them to be displayed) in the panels and in the line that shows the currently highlighted file below the panel. Normally when a given name is longer than the panel width it would show

Re: [patch] interruptible search in the viewer

2005-08-15 Thread Roland Illig
Jindrich Makovicka wrote: The attached patch makes the search function interruptible by Ctrl-C. Committed. Thanks. I am not sure it it doesn't interfere with get_byte() stuff which can do some I/O, but block_search doesn't disable the interrupts during I/O either. I just fixed the case

Re: [patch] fix another End keypress lockup in the viewer

2005-08-15 Thread Roland Illig
Jindrich Makovicka wrote: Hello, the new viewer has a problem with viewing files with DOS line separators, which manifests again in a lockup after pressing the End key. Then, it is impossible to move the view further, except by pressing the Home key. Can you provide a file where that lockup

Re: [patch] fix another End keypress lockup in the viewer

2005-08-15 Thread Roland Illig
Pavel Tsekov wrote: Are you kidding ? Have you tried with the file I've sent you ? I've debugged the problem and there is no way that it wont happen. Are you using the correct MC binary ? I am using mc-HEAD with the exception of src/view.c, which I took from yesterday. I extracted the file

Re: [patch] fix another End keypress lockup in the viewer

2005-08-15 Thread Roland Illig
Pavel Tsekov wrote: Another approach would be to simplify the following code from view_move_up(): } else if (line = 1) { view_coord_to_offset (view, linestart, line, 0); view_offset_to_coord (view, line, col, linestart - 1); /* if the

Re: [patch] fix another End keypress lockup in the viewer

2005-08-15 Thread Roland Illig
Pavel Tsekov wrote: Hello, On Mon, 15 Aug 2005, Roland Illig wrote: Because we are in text wrap mode. Internally the viewer stores the unwrapped coordinates. When you want to go one line up, you have to distinguish whether you are inside a long line or at the beginning of a line

Re: view growbuf read until() suggestion

2005-08-06 Thread Roland Illig
Roland Illig wrote: Index: view.c === RCS file: /cvsroot/mc/mc/src/view.c,v retrieving revision 1.313 diff -u -p -r1.313 view.c Committed. Roland ___ Mc-devel mailing list http

Re: [PATCH]: Minor cleanup in menubar_draw()

2005-08-05 Thread Roland Illig
Pavel Tsekov wrote: Hello, hline() is used in so many places that if it had some bugs they would be noticed by now. I tested the patch and I haven't observed any visual problems. Committed, Thanks. As the code is from revision 1.1, we cannot expect anyone to tell us where the code

Re: [PATCH]: Minor cleanup in menubar_draw()

2005-08-05 Thread Roland Illig
Pavel Tsekov wrote: Hello, hline() is used in so many places that if it had some bugs they would be noticed by now. I tested the patch and I haven't observed any visual problems. There might be some weird behavior when the end of line is reached, but as the menubar is at the top of the

Re: shell scripting advise: Don't use backslashes inside backtick quotes

2005-08-04 Thread Roland Illig
Oswald Buddenhagen wrote: On Thu, Aug 04, 2005 at 07:31:42AM +0200, Oswald Buddenhagen wrote: On Thu, Aug 04, 2005 at 01:19:50AM +0200, Roland Illig wrote: quote() { _sedexpr=s,',''',g _quotestr=`echo x$1 | sed -e '1s,^x,,' -e ${_sedexpr}` echo '${_quotestr}' } So

Re: Edit selected/hilighted text

2005-08-01 Thread Roland Illig
Michelle Konzack wrote: Hello, if I am in 'mcedit' and edit a text, I like to select a text and sned it via STDIN into a command and past the output (STDOUT) into the selection. Exactly I want to remplace the selection. How is this possibel ? It had been possible for a short while,

Re: Edit selected/hilighted text

2005-08-01 Thread Roland Illig
Michelle Konzack wrote: Am 2005-08-01 18:42:37, schrieb Roland Illig: It had been possible for a short while, somewhere in 2004. I had replaced some parts of the editor with code that did exactly what you want. But because some developers told me not to replace working code with your poorly

Re: Vietnamese UI Translation for Midnight Commander. Documentation?

2005-07-31 Thread Roland Illig
Phan Vinh Thinh wrote: Hi, Few days ago, one guy on debian-russian mailing list gave me a Debian depository address (http://syavad.narod.ru/), which contains MC with UTF-8 support. It works, great! Thanks russian folks. And after that, I decided to translate this my favorite file manager into my

Re: [bug #13734] viewer should save position mode per file

2005-07-30 Thread Roland Illig
/dev/rob0 wrote: Roland Illig wrote: Thus I have dozens of files listed with position 1;0 in filepos. Why are those saved at all? Would it be possible to save file position unless the position happens to be 1;0? Even #utar and other such temporary files have their position saved. I just

Re: [bug #13734] viewer should save position mode per file

2005-07-23 Thread Roland Illig
/dev/rob0 wrote: Thus I have dozens of files listed with position 1;0 in filepos. Why are those saved at all? Would it be possible to save file position unless the position happens to be 1;0? Even #utar and other such temporary files have their position saved. I just fixed that. Is there a

Re: Current translation status

2005-07-23 Thread Roland Illig
Arpad Biro wrote: ta.po translated:0, fuzzy:0, untranslated:0, total:0 (BTW, the table also shows that ta.po is incorrect.) That's because you just examined the first line, which is an error message in the case of ta.po. If you had taken the last line instead, it would have

Re: getgrouplist(3) vs. getgroups(3)

2005-07-23 Thread Roland Illig
Pavel Tsekov wrote: On Fri, 22 Jul 2005, Roland Illig wrote: I updated the patch. Seems nice. How about removing the configure bits related to getgrouplist() too ? Done in PRE. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman

Re: glibc and getgrouplist

2005-07-22 Thread Roland Illig
Koblinger Egmont wrote: (strcmp(gnu_get_libc_version(), 2.3.3) 0) Why not? Note the comparison. Since 2.3.3, this should be definitely fixed. Please use strverscmp() or something similar. According to strcmp, 2.3.10 is smaller than 2.3.3. Hmmm, you're right. As we are sure to

getgrouplist(3) vs. getgroups(3)

2005-07-22 Thread Roland Illig
Why do we use getgrouplist(3) at all? What we're interested in are the permissions of the current process, not what's in the system-wide database. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: getgrouplist segfault?

2005-07-22 Thread Roland Illig
Pavel Tsekov wrote: Hello, On Fri, 22 Jul 2005, Roland Illig wrote: But another question arises: Do we want to keep this variable and the patch forever? Or will we remove it in one or two years? Does it make any difference ? Yes, it bloats the code. Roland

Re: getgrouplist(3) vs. getgroups(3)

2005-07-22 Thread Roland Illig
Roland Illig wrote: Why do we use getgrouplist(3) at all? What we're interested in are the permissions of the current process, not what's in the system-wide database. After applying this patch, everything works as usual. Why have we used a GTree for storing the group IDs of the process? In my

  1   2   3   >