[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Use local ORES service when both ores and ores_services role...

2017-03-25 Thread Code Review
Gergő Tisza has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344814 ) Change subject: Use local ORES service when both ores and ores_services roles are enabled .. Use local ORES service when both ores and

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SurfaceFragment: Avoid double-annotating in insertDocument, ...

2017-03-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344813 ) Change subject: SurfaceFragment: Avoid double-annotating in insertDocument, as well .. SurfaceFragment: Avoid double-annotating in

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Serialize/deserialize for Transaction and IndexValueStore

2017-03-25 Thread Divec (Code Review)
Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344812 ) Change subject: Serialize/deserialize for Transaction and IndexValueStore .. Serialize/deserialize for Transaction and IndexValueStore

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Update linktrails

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344764 ) Change subject: Update linktrails .. Update linktrails Change-Id: I98b6d36db94909e2f5c7f735c595c2a479420717 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Show "change block" in userlinks for blocked users

2017-03-25 Thread EddieGP (Code Review)
EddieGP has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344811 ) Change subject: Show "change block" in userlinks for blocked users .. Show "change block" in userlinks for blocked users User links are

[MediaWiki-commits] [Gerrit] 3d2png/deploy[master]: Add .gitreview

2017-03-25 Thread Mobrovac (Code Review)
Mobrovac has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344810 ) Change subject: Add .gitreview .. Add .gitreview Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999 --- A .gitreview 1 file

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Fix TypeError: undefined is not an object (evaluating '$(hr...

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344795 ) Change subject: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') .. Fix TypeError: undefined is

[MediaWiki-commits] [Gerrit] 3d2png/deploy[master]: Add .gitreview

2017-03-25 Thread Mobrovac (Code Review)
Mobrovac has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344810 ) Change subject: Add .gitreview .. Add .gitreview Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999 --- A .gitreview 1 file changed, 6

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MWHttpRequest: optionally add original request data

2017-03-25 Thread Code Review
Gergő Tisza has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344809 ) Change subject: MWHttpRequest: optionally add original request data .. MWHttpRequest: optionally add original request data Bug:

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Update to use EditPageGetCheckboxesDefinition hook

2017-03-25 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344808 ) Change subject: Update to use EditPageGetCheckboxesDefinition hook .. Update to use EditPageGetCheckboxesDefinition hook

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Fix stuff I broke, also changes

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344807 ) Change subject: Fix stuff I broke, also changes .. Fix stuff I broke, also changes * Some more consistent naming, classes and

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Deploy Timeless skin to labs

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344788 ) Change subject: Deploy Timeless skin to labs .. Deploy Timeless skin to labs Bug: T160643 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Fix stuff I broke, also changes

2017-03-25 Thread Isarra (Code Review)
Isarra has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344807 ) Change subject: Fix stuff I broke, also changes .. Fix stuff I broke, also changes I'm real specific shut up. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Revert "Simplify definition of 'ext.echo.badgeicons' module"

2017-03-25 Thread Paladox (Code Review)
Hello Bartosz Dziewoński, Catrope, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/344806 to review the following change. Change subject: Revert "Simplify definition of 'ext.echo.badgeicons' module"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Refactor getCheckboxes() to allow changing the format

2017-03-25 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344805 ) Change subject: EditPage: Refactor getCheckboxes() to allow changing the format .. EditPage: Refactor getCheckboxes() to allow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add some common functions to BaseTemplate

2017-03-25 Thread Isarra (Code Review)
Isarra has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344804 ) Change subject: Add some common functions to BaseTemplate .. Add some common functions to BaseTemplate Breaks any skins with same-name

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Defer rendering of visual diff until tab is selected

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344782 ) Change subject: Defer rendering of visual diff until tab is selected .. Defer rendering of visual diff until tab is selected

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (15ee3e37d)

2017-03-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344803 ) Change subject: Update VE core submodule to master (15ee3e37d) .. Update VE core submodule to master (15ee3e37d) New changes: e0651b2df

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Move -hasDescriptions class toggle into #renderDiff

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344783 ) Change subject: Move -hasDescriptions class toggle into #renderDiff .. Move -hasDescriptions class toggle into #renderDiff

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffTreeNode: Use getters for type and attributes

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344802 ) Change subject: DiffTreeNode: Use getters for type and attributes .. DiffTreeNode: Use getters for type and attributes Avoids

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Replace instanceof ContentBranchNode with #canContainContent

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344801 ) Change subject: Replace instanceof ContentBranchNode with #canContainContent .. Replace instanceof ContentBranchNode with

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344800 ) Change subject: Remove superfluous setting of canContainContent when inheriting from CBN .. Remove superfluous setting of

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix dm.BlockquoteNode to inherit from ContentBranchNode

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344799 ) Change subject: Fix dm.BlockquoteNode to inherit from ContentBranchNode .. Fix dm.BlockquoteNode to inherit from

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Throw RuntimeException when caching doesn't work in testDisp...

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344751 ) Change subject: Throw RuntimeException when caching doesn't work in testDispatchCoordinator .. Throw RuntimeException when

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Document dispatchingLockManager option in $wgWBRepoSettings

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344750 ) Change subject: Document dispatchingLockManager option in $wgWBRepoSettings .. Document dispatchingLockManager option in

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffTreeNode: Use getters for type and attributes

2017-03-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344802 ) Change subject: DiffTreeNode: Use getters for type and attributes .. DiffTreeNode: Use getters for type and attributes Avoids undefined

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Replace instanceof ContentBranchNode with #canContainContent

2017-03-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344801 ) Change subject: Replace instanceof ContentBranchNode with #canContainContent .. Replace instanceof ContentBranchNode with

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

2017-03-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344800 ) Change subject: Remove superfluous setting of canContainContent when inheriting from CBN .. Remove superfluous setting of

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix dm.BlockquoteNode to inherit from ContentBranchNode

2017-03-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344799 ) Change subject: Fix dm.BlockquoteNode to inherit from ContentBranchNode .. Fix dm.BlockquoteNode to inherit from ContentBranchNode It is

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Test wgLogoHD keys

2017-03-25 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344798 ) Change subject: Test wgLogoHD keys .. Test wgLogoHD keys When a value is defined, keys MUST be 1.5x and 2x. Bug: T161416 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Exclude .git in phpcs.xml instead of command line argument

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344797 ) Change subject: Exclude .git in phpcs.xml instead of command line argument .. Exclude .git in phpcs.xml instead of command line

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Exclude .git in phpcs.xml instead of command line argument

2017-03-25 Thread Seb35 (Code Review)
Seb35 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344797 ) Change subject: Exclude .git in phpcs.xml instead of command line argument .. Exclude .git in phpcs.xml instead of command line argument In

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix wgLogoHD keys

2017-03-25 Thread Dereckson (Code Review)
Dereckson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344796 ) Change subject: Fix wgLogoHD keys .. Fix wgLogoHD keys This is a follow-up to 26cbc1ac3. This solves the following production error:

[MediaWiki-commits] [Gerrit] mediawiki...NewUserActions[master]: Use tabs in json

2017-03-25 Thread Umherirrender (Code Review)
Umherirrender has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344772 ) Change subject: Use tabs in json .. Use tabs in json Change-Id: I18354b03d4620ffc36dbd3f213325b48607c86c2 --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [IMPR] Rewrite setParameters()

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/281603 ) Change subject: [IMPR] Rewrite setParameters() .. [IMPR] Rewrite setParameters() - assign image from generator to

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Fix TypeError: undefined is not an object (evaluating '$(hr...

2017-03-25 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344795 ) Change subject: Fix TypeError: undefined is not an object (evaluating '$(href).offset().top') .. Fix TypeError: undefined is not an

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed a bug in two funnctions which caused zimdump to cause ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/78379 ) Change subject: Fixed a bug in two funnctions which caused zimdump to cause a segmentation fault when the url passed was not found in the zim file. The error occurred when the tool attempts to display

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed wrong libmagic path

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/216530 ) Change subject: Fixed wrong libmagic path .. Fixed wrong libmagic path Change-Id: Ic7674a62530abde447252fd6c0b693a8d741443e --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Minor wording and typo fixes to the zimwriterfs README.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295032 ) Change subject: Minor wording and typo fixes to the zimwriterfs README. .. Minor wording and typo fixes to the zimwriterfs README.

[MediaWiki-commits] [Gerrit] openzim[master]: libzim.pc: Add "Requires" field

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330857 ) Change subject: libzim.pc: Add "Requires" field .. libzim.pc: Add "Requires" field Follows-up b7e5564423b8644c. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types be...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/79021 ) Change subject: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types before storing them to file. .. Bug Fix for bug no 52324

[MediaWiki-commits] [Gerrit] openzim[master]: Add .gitignore and .gitreview

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/84432 ) Change subject: Add .gitignore and .gitreview .. Add .gitignore and .gitreview Bug: 54175 Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed compilation on OSX. made a script to compile both stat...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/216507 ) Change subject: Fixed compilation on OSX. made a script to compile both static and shared .. Fixed compilation on OSX. made a

[MediaWiki-commits] [Gerrit] openzim[master]: Readd call to stripTitleInvalidChars.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295633 ) Change subject: Readd call to stripTitleInvalidChars. .. Readd call to stripTitleInvalidChars. Commit 1c969dd remove the call to

[MediaWiki-commits] [Gerrit] openzim[master]: Move articleSource's related stuffs in articlesource.(h|cpp).

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295517 ) Change subject: Move articleSource's related stuffs in articlesource.(h|cpp). .. Move articleSource's related stuffs in

[MediaWiki-commits] [Gerrit] openzim[master]: Update build instructions for MacOS X.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295382 ) Change subject: Update build instructions for MacOS X. .. Update build instructions for MacOS X. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Update .gitignore files.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295037 ) Change subject: Update .gitignore files. .. Update .gitignore files. Change-Id: Iad8d95fa2deab178396e8804b6e195a5b1520a4a --- C

[MediaWiki-commits] [Gerrit] openzim[master]: Update zimwriterfs makefiles.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295038 ) Change subject: Update zimwriterfs makefiles. .. Update zimwriterfs makefiles. Change-Id: Ic0f93e19eb3e07d86c115bd15f47ef5fbc74f954

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: correctly update cluster offsets in directory entries.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296158 ) Change subject: Bug fix: correctly update cluster offsets in directory entries. .. Bug fix: correctly update cluster offsets in

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory corruption in decodeUrl.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303540 ) Change subject: Fix memory corruption in decodeUrl. .. Fix memory corruption in decodeUrl. Reuse the function from kiwix as it does

[MediaWiki-commits] [Gerrit] openzim[master]: Use the system's libgumbo.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295039 ) Change subject: Use the system's libgumbo. .. Use the system's libgumbo. Change-Id: Id6b06033bba6c1d47d305b50259e7eaf41c073e2 --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Use explicit LZMA_STREAM_INIT initializer, instead of memset.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296548 ) Change subject: Use explicit LZMA_STREAM_INIT initializer, instead of memset. .. Use explicit LZMA_STREAM_INIT initializer, instead

[MediaWiki-commits] [Gerrit] openzim[master]: Revert "Use explicit LZMA_STREAM_INIT initializer, instead o...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296752 ) Change subject: Revert "Use explicit LZMA_STREAM_INIT initializer, instead of memset." .. Revert "Use explicit LZMA_STREAM_INIT

[MediaWiki-commits] [Gerrit] openzim[master]: Revert compatibility with previous API.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296910 ) Change subject: Revert compatibility with previous API. .. Revert compatibility with previous API. The API has changed. The

[MediaWiki-commits] [Gerrit] openzim[master]: Compress blobs and track file size immediately after adding ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295383 ) Change subject: Compress blobs and track file size immediately after adding each article. .. Compress blobs and track file size

[MediaWiki-commits] [Gerrit] openzim[master]: Explain that ZIntStream only represents uint32_t values righ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296657 ) Change subject: Explain that ZIntStream only represents uint32_t values right now. .. Explain that ZIntStream only represents

[MediaWiki-commits] [Gerrit] openzim[master]: Use a Queue object to handle threadsafe access to a queue.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295518 ) Change subject: Use a Queue object to handle threadsafe access to a queue. .. Use a Queue object to handle threadsafe access to a

[MediaWiki-commits] [Gerrit] openzim[master]: Include files from srcdir; built files in builddir.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295111 ) Change subject: Include files from srcdir; built files in builddir. .. Include files from srcdir; built files in builddir.

[MediaWiki-commits] [Gerrit] openzim[master]: Convert READMEs to markdown.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295035 ) Change subject: Convert READMEs to markdown. .. Convert READMEs to markdown. Change-Id: I596bec7ef70bd0a7d45ba67d4fa313d93c861890

[MediaWiki-commits] [Gerrit] openzim[master]: Move zim::writer::ArticleSource::getData() to zim::writer::A...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295460 ) Change subject: Move zim::writer::ArticleSource::getData() to zim::writer::Article::getData(). .. Move

[MediaWiki-commits] [Gerrit] openzim[master]: Move few utility functions to a separate module.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295515 ) Change subject: Move few utility functions to a separate module. .. Move few utility functions to a separate module. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Add xapian indexer.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296913 ) Change subject: Add xapian indexer. .. Add xapian indexer. Xapian is optional. Build your index inside zim by adding "-i" or

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: preserve cluster compression type after clear().

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296547 ) Change subject: Bug fix: preserve cluster compression type after clear(). .. Bug fix: preserve cluster compression type after

[MediaWiki-commits] [Gerrit] openzim[master]: Move `throw` statement out of header file.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295720 ) Change subject: Move `throw` statement out of header file. .. Move `throw` statement out of header file. This ensures that we don't

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: don't store pointers inside a dynamic vector.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296644 ) Change subject: Bug fix: don't store pointers inside a dynamic vector. .. Bug fix: don't store pointers inside a dynamic vector.

[MediaWiki-commits] [Gerrit] openzim[master]: Move article's related stuffs in article.(h|cpp).

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295516 ) Change subject: Move article's related stuffs in article.(h|cpp). .. Move article's related stuffs in article.(h|cpp). Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Port zimwriterfs to the new API.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296911 ) Change subject: Port zimwriterfs to the new API. .. Port zimwriterfs to the new API. No more ArticleSource::getData. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Actually call the (previously-unused) ArticleSource#setFilen...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296632 ) Change subject: Actually call the (previously-unused) ArticleSource#setFilename method. .. Actually call the (previously-unused)

[MediaWiki-commits] [Gerrit] openzim[master]: Add a indexer.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296912 ) Change subject: Add a indexer. .. Add a indexer. This indexer is not used. This is mainly code from kiwix-indexer imported in

[MediaWiki-commits] [Gerrit] openzim[master]: Support running tests with "make check"

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330859 ) Change subject: Support running tests with "make check" .. Support running tests with "make check" Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Add a API to get the offset of a article in the zimfile.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296914 ) Change subject: Add a API to get the offset of a article in the zimfile. .. Add a API to get the offset of a article in the zimfile.

[MediaWiki-commits] [Gerrit] openzim[master]: Fix issue #2 Zimdump crashes on long titles.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296931 ) Change subject: Fix issue #2 Zimdump crashes on long titles. .. Fix issue #2 Zimdump crashes on long titles. Most of filesystems

[MediaWiki-commits] [Gerrit] openzim[master]: Handle the case of last article for filenameQueue is invalid.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296915 ) Change subject: Handle the case of last article for filenameQueue is invalid. .. Handle the case of last article for filenameQueue

[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303776 ) Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one

[MediaWiki-commits] [Gerrit] openzim[master]: Remove temporary ft_index.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/304450 ) Change subject: Remove temporary ft_index. .. Remove temporary ft_index. Xapian indexer create temporary files while indexing

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory leak in zimwriterfs.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303775 ) Change subject: Fix memory leak in zimwriterfs. .. Fix memory leak in zimwriterfs. We are using polymorphism in articlesource.cpp

[MediaWiki-commits] [Gerrit] openzim[master]: Better replaceStringInPlaceOnce.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303778 ) Change subject: Better replaceStringInPlaceOnce. .. Better replaceStringInPlaceOnce. If we do only one replace, we do not need a

[MediaWiki-commits] [Gerrit] openzim[master]: The indexed url must contain the namespace.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/304240 ) Change subject: The indexed url must contain the namespace. .. The indexed url must contain the namespace. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Close the magic database.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303777 ) Change subject: Close the magic database. .. Close the magic database. Change-Id: Ib0c7d1736d804526eea701ef39cb9ae5780b13c1 --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Avoid get the dirent too many time.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314717 ) Change subject: Avoid get the dirent too many time. .. Avoid get the dirent too many time. Article::is* functions are "alias" to

[MediaWiki-commits] [Gerrit] openzim[master]: Read the cluster content only when necessary.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314718 ) Change subject: Read the cluster content only when necessary. .. Read the cluster content only when necessary. Instead of reading

[MediaWiki-commits] [Gerrit] openzim[master]: Invalidate internal streambuf buffer when we change it.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314720 ) Change subject: Invalidate internal streambuf buffer when we change it. .. Invalidate internal streambuf buffer when we change it.

[MediaWiki-commits] [Gerrit] openzim[master]: [zimwriterfs] Try to avoid too big cluster.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/315238 ) Change subject: [zimwriterfs] Try to avoid too big cluster. .. [zimwriterfs] Try to avoid too big cluster. We check that cluster

[MediaWiki-commits] [Gerrit] openzim[master]: Do not store the snippet nor the size of the content in the ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343897 ) Change subject: Do not store the snippet nor the size of the content in the database. .. Do not store the snippet nor the size of

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328341 ) Change subject: Make zimlib compilable with meson. .. Make zimlib compilable with meson. Also install a correct pkg-config file who

[MediaWiki-commits] [Gerrit] openzim[master]: Do not cache uncompressed cluster by default.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/315237 ) Change subject: Do not cache uncompressed cluster by default. .. Do not cache uncompressed cluster by default. Uncompressed cluster

[MediaWiki-commits] [Gerrit] openzim[master]: Adapt tests to new internal cluster API.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/320243 ) Change subject: Adapt tests to new internal cluster API. .. Adapt tests to new internal cluster API. - There is no more

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344794 ) Change subject: Modify access rules .. Modify access rules Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9 --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Few clean and better verbose message.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343898 ) Change subject: Few clean and better verbose message. .. Few clean and better verbose message. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Fix use of ENABLE_* by preprocessor.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330236 ) Change subject: Fix use of ENABLE_* by preprocessor. .. Fix use of ENABLE_* by preprocessor. If a compression lib is not present,

[MediaWiki-commits] [Gerrit] openzim[master]: Provide time gap between uuid generation during tests

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330861 ) Change subject: Provide time gap between uuid generation during tests .. Provide time gap between uuid generation during tests GNU

[MediaWiki-commits] [Gerrit] openzim[master]: pkg_config dependencies are properly declared.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/333593 ) Change subject: pkg_config dependencies are properly declared. .. pkg_config dependencies are properly declared. The 'Requires'

[MediaWiki-commits] [Gerrit] openzim[master]: Always try to cache a cluster, even if it is a uncompressed ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314721 ) Change subject: Always try to cache a cluster, even if it is a uncompressed one. .. Always try to cache a cluster, even if it is a

[MediaWiki-commits] [Gerrit] openzim[master]: Remove unused currentPos from fstream.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314719 ) Change subject: Remove unused currentPos from fstream. .. Remove unused currentPos from fstream. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330417 ) Change subject: Make zimlib compilable with meson. .. Make zimlib compilable with meson. Also install a correct pkg-config file who

[MediaWiki-commits] [Gerrit] openzim[master]: Add libzim.pc for pkg-config

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329759 ) Change subject: Add libzim.pc for pkg-config .. Add libzim.pc for pkg-config This registers the libzim library with pkg-config,

[MediaWiki-commits] [Gerrit] openzim[master]: Add the valuesmap metadata.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343896 ) Change subject: Add the valuesmap metadata. .. Add the valuesmap metadata. This way, the searcher will know where values are

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

2017-03-25 Thread Paladox (Code Review)
Paladox has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344794 ) Change subject: Modify access rules .. Modify access rules Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9 --- M project.config 1

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePageVersion[master]: Use tabs in json

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344752 ) Change subject: Use tabs in json .. Use tabs in json Change-Id: I3435422e6cbdbcb4bbefb64d7f72072519fe3db2 --- M composer.json

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Add a scroll offset when a table of contents anchor link is ...

2017-03-25 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344792 ) Change subject: Add a scroll offset when a table of contents anchor link is clicked .. Add a scroll offset when a table of

  1   2   >