[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove 'vesection' parameter

2016-11-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/319972 Change subject: Remove 'vesection' parameter .. Remove 'vesection' parameter Just use the normal section parameter, haven't been able to fi

[MediaWiki-commits] [Gerrit] operations/puppet[production]: deployment-prep: Fix deployment access.conf rules to allow a...

2016-11-01 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/319249 Change subject: deployment-prep: Fix deployment access.conf rules to allow all deployment servers .. deployment-prep: Fix deployment access

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove extra non-ASCII character in role::cache::text that w...

2016-11-01 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/319243 Change subject: Remove extra non-ASCII character in role::cache::text that was causing issues .. Remove extra non-ASCII character in role::

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Keep edit summary when switching between VE and NWE

2016-10-31 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/318960 Change subject: Keep edit summary when switching between VE and NWE .. Keep edit summary when switching between VE and NWE Bug: T144906 Cha

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up Id0021594: Remove extra code for redlink suggestions

2016-10-27 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/318475 Change subject: Follow-up Id0021594: Remove extra code for redlink suggestions .. Follow-up Id0021594: Remove extra code for redlink suggest

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up I64a8ed73: Fix NWE getWikitextFragment

2016-10-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/318202 Change subject: Follow-up I64a8ed73: Fix NWE getWikitextFragment .. Follow-up I64a8ed73: Fix NWE getWikitextFragment Change-Id: I8f060de197

[MediaWiki-commits] [Gerrit] operations/puppet[production]: phabricator: include project creations with policies other t...

2016-10-25 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/317990 Change subject: phabricator: include project creations with policies other than public+all-users .. phabricator: include project creations

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add missing wiki to RB

2016-10-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/317511 Change subject: Add missing wiki to RB .. Add missing wiki to RB Bug: T148861 Change-Id: I1ed68aa9ceb15e907bf0080e37f2a9ba42407141 --- M mo

[MediaWiki-commits] [Gerrit] operations/puppet[production]: POC: Secure redirect service

2016-10-23 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/317450 Change subject: POC: Secure redirect service .. POC: Secure redirect service This commit includes: * Some config for testing on a specific

[MediaWiki-commits] [Gerrit] operations/puppet[production]: shinkengen: Ensure consistent ordering of hostgroups

2016-10-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/317294 Change subject: shinkengen: Ensure consistent ordering of hostgroups .. shinkengen: Ensure consistent ordering of hostgroups Otherwise --te

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I966f6422: Add missing package dependency, fix for...

2016-10-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/317007 Change subject: Follow-up I966f6422: Add missing package dependency, fix format call .. Follow-up I966f6422: Add missing package dependency

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Get rid of mw-deployment-vars.sh

2016-10-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316928 Change subject: Get rid of mw-deployment-vars.sh .. Get rid of mw-deployment-vars.sh It's flapping back and forth between versions on deplo

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't allow an image to be inserted into a gallery twice sim...

2016-10-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316919 Change subject: Don't allow an image to be inserted into a gallery twice simultaneously .. Don't allow an image to be inserted into a galle

[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[wmf/1.28.0-wmf.22]: Remove all puppet stuff

2016-10-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316909 Change subject: Remove all puppet stuff .. Remove all puppet stuff Also get rid of OpenStackNovaHost::addHostFromInstance which should've b

[MediaWiki-commits] [Gerrit] operations/puppet[production]: deployment-prep: Make LVS config compatible with new require...

2016-10-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316512 Change subject: deployment-prep: Make LVS config compatible with new requirements .. deployment-prep: Make LVS config compatible with new r

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Make the selected gallery image border a bit bigger

2016-10-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316029 Change subject: Make the selected gallery image border a bit bigger .. Make the selected gallery image border a bit bigger Bug: T148041 Cha

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable Quiz extension on beta cawiki

2016-10-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/316004 Change subject: Enable Quiz extension on beta cawiki .. Enable Quiz extension on beta cawiki Bug: T142692 Change-Id: I2e9231f86971edcbba732

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: More NWE-SET integration fixes

2016-10-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315835 Change subject: More NWE-SET integration fixes .. More NWE-SET integration fixes Also stop calling $skin->getUser() so much, store the resu

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix typo in DAT.init.js

2016-10-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315834 Change subject: Fix typo in DAT.init.js .. Fix typo in DAT.init.js Change-Id: I75f7de16ea06d62a1bdfa0e04294fef5560fd5c9 --- M modules/ve-mw

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix another case where we need to pass the section

2016-10-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315739 Change subject: Fix another case where we need to pass the section .. Fix another case where we need to pass the section Bug: T144654 Chang

[MediaWiki-commits] [Gerrit] operations/puppet[production]: apache: Standardise ShortURL config per Giuseppe on If258a076

2016-10-12 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315522 Change subject: apache: Standardise ShortURL config per Giuseppe on If258a076 .. apache: Standardise ShortURL config per Giuseppe on If258a0

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleWidget: Take 'known' status into account when deciding ...

2016-10-11 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315455 Change subject: TitleWidget: Take 'known' status into account when deciding page existence .. TitleWidget: Take 'known' status into account

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Add different change tag to NWE edits

2016-10-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/315194 Change subject: Add different change tag to NWE edits .. Add different change tag to NWE edits Bug: T147587 Change-Id: If9b466ff8449ceeb0e7

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: createExtensionTables: Use x1 for Echo

2016-10-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314846 Change subject: createExtensionTables: Use x1 for Echo .. createExtensionTables: Use x1 for Echo Untested Uses legoktm's code from addWiki

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up I173d82a7: Add dependency for mediawiki.Uri

2016-10-07 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314793 Change subject: Follow-up I173d82a7: Add dependency for mediawiki.Uri .. Follow-up I173d82a7: Add dependency for mediawiki.Uri Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Switch to the wikitext editor if VE fails to load

2016-10-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314460 Change subject: Switch to the wikitext editor if VE fails to load .. Switch to the wikitext editor if VE fails to load Also kill some dead

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Tidy up DAT load failure handling

2016-10-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314456 Change subject: Tidy up DAT load failure handling .. Tidy up DAT load failure handling Get rid of the 504 Gateway Timeout handling while we

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use a proper error message when VE fails to load due to not ...

2016-10-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314216 Change subject: Use a proper error message when VE fails to load due to not being able to connect to RB .. Use a proper error message when

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Allow users who haven't enabled NWE in their preferences to ...

2016-10-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314193 Change subject: Allow users who haven't enabled NWE in their preferences to use veaction=editsource .. Allow users who haven't enabled NWE

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Disable switch-to-VE button in NWE if VE is unavailable, don...

2016-10-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/314040 Change subject: Disable switch-to-VE button in NWE if VE is unavailable, don't hide it .. Disable switch-to-VE button in NWE if VE is unava

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Allow NWE on non-VE namespaces

2016-10-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313908 Change subject: Allow NWE on non-VE namespaces .. Allow NWE on non-VE namespaces Bug: T146182 Change-Id: I9547dfd591ad1e68e045b4928765a9589

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Make check_ssl warning/critical thresholds explicit and lowe...

2016-10-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313805 Change subject: Make check_ssl warning/critical thresholds explicit and lower them on Let's Encrypt domains .. Make check_ssl warning/criti

[MediaWiki-commits] [Gerrit] operations/puppet[production]: varnish: Fix upload backend support for versions other than 4

2016-10-01 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313668 Change subject: varnish: Fix upload backend support for versions other than 4 .. varnish: Fix upload backend support for versions other than

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Batch gallery imageinfo requests via ImageInfoCache subclass

2016-09-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313605 Change subject: Batch gallery imageinfo requests via ImageInfoCache subclass .. Batch gallery imageinfo requests via ImageInfoCache subclass

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't try to add suggested/required parameters already set u...

2016-09-29 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313545 Change subject: Don't try to add suggested/required parameters already set under alias names .. Don't try to add suggested/required paramet

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't call ApiBase::getResultData anymore, it's broken on co...

2016-09-29 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313518 Change subject: Don't call ApiBase::getResultData anymore, it's broken on core master and is deprecated anyway .. Don't call ApiBase::getRe

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs nfsclient: Require /mnt/nfs's existence before trying t...

2016-09-27 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/313034 Change subject: labs nfsclient: Require /mnt/nfs's existence before trying to mount underneath it .. labs nfsclient: Require /mnt/nfs's exi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MWExceptionRenderer::useOutputPage: Don't bother in RL code

2016-09-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312962 Change subject: MWExceptionRenderer::useOutputPage: Don't bother in RL code .. MWExceptionRenderer::useOutputPage: Don't bother in RL code

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Set language on copyright warning to RL default

2016-09-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312961 Change subject: Set language on copyright warning to RL default .. Set language on copyright warning to RL default Bug: T146686 Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Allow language of copyright warning to be specified

2016-09-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312960 Change subject: EditPage: Allow language of copyright warning to be specified .. EditPage: Allow language of copyright warning to be specifi

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: When we have multiple tabs and NWE enabled, set the edit tab...

2016-09-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312710 Change subject: When we have multiple tabs and NWE enabled, set the edit tab's URL to NWE .. When we have multiple tabs and NWE enabled, se

[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[master]: Remove all puppet stuff

2016-09-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312649 Change subject: Remove all puppet stuff .. Remove all puppet stuff Also get rid of OpenStackNovaHost::addHostFromInstance which should've b

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: NWE: Don't show button to switch to VE if it isn't available

2016-09-23 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312618 Change subject: NWE: Don't show button to switch to VE if it isn't available .. NWE: Don't show button to switch to VE if it isn't available

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: Follow-up Ide89c59f: Update ferm rules too

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312455 Change subject: tcpircbot: Follow-up Ide89c59f: Update ferm rules too .. tcpircbot: Follow-up Ide89c59f: Update ferm rules too Change-Id: I

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: remove localhost from ferm rule

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312456 Change subject: tcpircbot: remove localhost from ferm rule .. tcpircbot: remove localhost from ferm rule It's not needed, ferm accepts all

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: Follow-up Ide89c59f: Fix missing CIDR prefix on p...

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312457 Change subject: tcpircbot: Follow-up Ide89c59f: Fix missing CIDR prefix on puppetmaster2001 .. tcpircbot: Follow-up Ide89c59f: Fix missing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: update comment detailing each IP in the ferm rule

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312454 Change subject: tcpircbot: update comment detailing each IP in the ferm rule .. tcpircbot: update comment detailing each IP in the ferm rule

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Cleanup deprecated MobileFrontend variables

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Cleanup deprecated MobileFrontend variables .. Cleanup deprecated MobileFrontend variables * Remove no longer used central notice and upload config variable

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Initiate Hovercards A/B test on ruwiki and itwiki

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Initiate Hovercards A/B test on ruwiki and itwiki .. Initiate Hovercards A/B test on ruwiki and itwiki ON rate of 10% and 20%, respectively. EL sampling rat

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.28.0-wmf.20]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312423 Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423 C

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312418 Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423 C

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I695dab22: Fix style

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312280 Change subject: Follow-up I695dab22: Fix style .. Follow-up I695dab22: Fix style Change-Id: I9832c82aca8dfee9b292781f74c9fde967b6e6e6 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: Import nova_fixed_multi designate plugin

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312278 Change subject: openstack: Import nova_fixed_multi designate plugin .. openstack: Import nova_fixed_multi designate plugin Instead of deplo

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Strip element IDs from HTML generated when wikitext is pasted

2016-09-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312170 Change subject: Strip element IDs from HTML generated when wikitext is pasted .. Strip element IDs from HTML generated when wikitext is past

[MediaWiki-commits] [Gerrit] operations/puppet[production]: designate-sink nova_ldap: set l to the correct site

2016-09-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312115 Change subject: designate-sink nova_ldap: set l to the correct site .. designate-sink nova_ldap: set l to the correct site Change-Id: I0baf

[MediaWiki-commits] [Gerrit] operations/puppet[production]: shinkengen: get role classes from puppet enc too

2016-09-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312109 Change subject: shinkengen: get role classes from puppet enc too .. shinkengen: get role classes from puppet enc too Change-Id: I966f6422d2

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Revert "New wikitext editor: Enable the Beta Feature...

2016-09-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311983 Change subject: Revert "Revert "New wikitext editor: Enable the Beta Feature in Beta Cluster"" .. Revert "Revert "New wikitext editor: Enab

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Pass document to preview through PST

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311863 Change subject: Pass document to preview through PST .. Pass document to preview through PST Change-Id: I2712c26c94cf62f8ec8e68a9912e6a557f

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Split isAvailable from visual-specific checks

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311860 Change subject: Split isAvailable from visual-specific checks .. Split isAvailable from visual-specific checks Not fully tested Bug: T1461

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: VE: Ensure ext.pygments module gets loaded when a user adds ...

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311839 Change subject: VE: Ensure ext.pygments module gets loaded when a user adds a syntax highlight node .. VE: Ensure ext.pygments module gets

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Education popup: Put localStorage check inside try/catch

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311834 Change subject: Education popup: Put localStorage check inside try/catch .. Education popup: Put localStorage check inside try/catch Bug: T

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I80040bee: Fix my order of parameters

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311754 Change subject: Follow-up I80040bee: Fix my order of parameters .. Follow-up I80040bee: Fix my order of parameters Change-Id: I383826059d55

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Unbreak I863367b8: Fix existing check_graphite(_series)?_thr...

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311747 Change subject: Unbreak I863367b8: Fix existing check_graphite(_series)?_threshold callers .. Unbreak I863367b8: Fix existing check_graphit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I55032bf7: urlopen context argument was added in P...

2016-09-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311695 Change subject: Follow-up I55032bf7: urlopen context argument was added in Python 2.7.9 too .. Follow-up I55032bf7: urlopen context argumen

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Replace repeated UseMod rewrites in apache config with exist...

2016-09-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311648 Change subject: Replace repeated UseMod rewrites in apache config with existing include .. Replace repeated UseMod rewrites in apache confi

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up Ifa2cc187: Add ShortUrl support on wikimedia.org d...

2016-09-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311647 Change subject: Follow-up Ifa2cc187: Add ShortUrl support on wikimedia.org docroot sites .. Follow-up Ifa2cc187: Add ShortUrl support on wi

[MediaWiki-commits] [Gerrit] operations/puppet[production]: letsencrypt: acme_tiny: Skip my ignore-HTTPS-validation code...

2016-09-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311639 Change subject: letsencrypt: acme_tiny: Skip my ignore-HTTPS-validation code for old versions of python .. letsencrypt: acme_tiny: Skip my

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: mitaka files/templates: fix puppet header to give...

2016-09-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311309 Change subject: openstack: mitaka files/templates: fix puppet header to give correct path .. openstack: mitaka files/templates: fix puppet

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: Add basic monitoring for HTTP services

2016-09-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311306 Change subject: openstack: Add basic monitoring for HTTP services .. openstack: Add basic monitoring for HTTP services Untested Bug: T4202

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: remove unused volume class, update default version

2016-09-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311304 Change subject: openstack: remove unused volume class, update default version .. openstack: remove unused volume class, update default versi

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs firstboot.sh: Add instance hostname to /etc/hosts

2016-09-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311212 Change subject: labs firstboot.sh: Add instance hostname to /etc/hosts .. labs firstboot.sh: Add instance hostname to /etc/hosts Bug: T1208

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Attempt to fix salt key monitoring sudo rule

2016-09-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311211 Change subject: Attempt to fix salt key monitoring sudo rule .. Attempt to fix salt key monitoring sudo rule The script doesn't attempt to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack nova network: update private_ips of instances

2016-09-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311210 Change subject: openstack nova network: update private_ips of instances .. openstack nova network: update private_ips of instances Get rid

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: (attempt to) make NWE work with SET

2016-09-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311207 Change subject: (attempt to) make NWE work with SET .. (attempt to) make NWE work with SET Ugh. Bug: T143578 Change-Id: I71e08508eb0914be9

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ruby-httpclient callers: Use the operating system's certific...

2016-09-15 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/311048 Change subject: ruby-httpclient callers: Use the operating system's certificate store .. ruby-httpclient callers: Use the operating system'

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Fix missing dependency of ext.proofreadpage.ve.pageTarget up...

2016-09-15 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Fix missing dependency of ext.proofreadpage.ve.pageTarget upon ext.visualEditor.desktopArticleTarget .. Fix missing dependency of ext.proofreadpage.ve.pageT

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310729 Change subject: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo .. puppet::self::gitclone: Get gitdir from puppetmaster::bas

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix missing dependency of ext.visualEditor.mwwikitext upon e...

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310714 Change subject: Fix missing dependency of ext.visualEditor.mwwikitext upon ext.visualEditor.desktopArticleTarget .. Fix missing dependency

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Fix missing dependency of ext.proofreadpage.ve.pageTarget up...

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310713 Change subject: Fix missing dependency of ext.proofreadpage.ve.pageTarget upon ext.visualEditor.desktopArticleTarget .. Fix missing depende

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use correct switch type when opening welcome dialog on NWE

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310709 Change subject: Use correct switch type when opening welcome dialog on NWE .. Use correct switch type when opening welcome dialog on NWE Bu

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Open meta dialog to edit categories when user clicks on the ...

2016-09-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310467 Change subject: Open meta dialog to edit categories when user clicks on the category footer .. Open meta dialog to edit categories when use

[MediaWiki-commits] [Gerrit] operations/puppet[production]: conftool: get conf from class parameters

2016-09-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310459 Change subject: conftool: get conf from class parameters .. conftool: get conf from class parameters So hiera can be used to easily overrid

[MediaWiki-commits] [Gerrit] operations/puppet[production]: admin: use argparse in matrix.py

2016-09-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310344 Change subject: admin: use argparse in matrix.py .. admin: use argparse in matrix.py Change-Id: Ie99cfa615246f993c3bb193bc47e5a5dba8d3147 -

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Simplify and fix category popup widget checks

2016-09-12 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310191 Change subject: Simplify and fix category popup widget checks .. Simplify and fix category popup widget checks Bug: T86357 Change-Id: I9a85

[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd::ssl: fix puppet ssldir path

2016-09-11 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309929 Change subject: etcd::ssl: fix puppet ssldir path .. etcd::ssl: fix puppet ssldir path Use the function that was already made for this purp

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: Update monitor_labs_salt_keys.py for new Nova API...

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309709 Change subject: openstack: Update monitor_labs_salt_keys.py for new Nova API version .. openstack: Update monitor_labs_salt_keys.py for new

[MediaWiki-commits] [Gerrit] operations/puppet[production]: dns-floating-ip-updater: use python's ipaddress class to det...

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309708 Change subject: dns-floating-ip-updater: use python's ipaddress class to determine PTR FQDNs for IPs .. dns-floating-ip-updater: use python

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labtest hiera: use labtestwikitech, not wikitech

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309706 Change subject: labtest hiera: use labtestwikitech, not wikitech .. labtest hiera: use labtestwikitech, not wikitech I noticed this oddity

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove wikitech references from ldapconfig

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309705 Change subject: Remove wikitech references from ldapconfig .. Remove wikitech references from ldapconfig Change-Id: I81afc28bee3b3fd506ea32

[MediaWiki-commits] [Gerrit] operations/puppet[production]: horizon: change wikitech help URLs to use https

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309704 Change subject: horizon: change wikitech help URLs to use https .. horizon: change wikitech help URLs to use https Change-Id: I6118cfa2f407

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: Remove redundant class

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Remove redundant class .. Remove redundant class This was introduced in 6c36175c without explanation. I suspect it was trying to steal some styling from a s

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove references to the old virt* servers

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309695 Change subject: Remove references to the old virt* servers .. Remove references to the old virt* servers Prefix used is labvirt now, these

[MediaWiki-commits] [Gerrit] operations/puppet[production]: more labs regex hiera cluster key fix for wikimedia.org hosts

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309691 Change subject: more labs regex hiera cluster key fix for wikimedia.org hosts .. more labs regex hiera cluster key fix for wikimedia.org hos

[MediaWiki-commits] [Gerrit] operations/puppet[production]: remove extra cluster: labvirt hieradata

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309693 Change subject: remove extra cluster: labvirt hieradata .. remove extra cluster: labvirt hieradata Already set up in hieradata/regex.yaml

[MediaWiki-commits] [Gerrit] operations/puppet[production]: set labtest up in ganglia like labs

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309692 Change subject: set labtest up in ganglia like labs .. set labtest up in ganglia like labs Change-Id: I8cb8fdf10ee65f475a8470ac2c470168b51c

[MediaWiki-commits] [Gerrit] operations/puppet[production]: couple more labs support host hiera cluster key cleanups

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309690 Change subject: couple more labs support host hiera cluster key cleanups .. couple more labs support host hiera cluster key cleanups Change

[MediaWiki-commits] [Gerrit] operations/puppet[production]: fix labstore cluster: labsnfs

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309689 Change subject: fix labstore cluster: labsnfs .. fix labstore cluster: labsnfs regex.yaml was overriding it to labs for eqiad hosts Change

[MediaWiki-commits] [Gerrit] operations/puppet[production]: hiera_lookup util: add support for labtest realm, fix check ...

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309685 Change subject: hiera_lookup util: add support for labtest realm, fix check for labs .. hiera_lookup util: add support for labtest realm, f

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Default wikimedia rcstream to https on port 443

2016-09-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309632 Change subject: Default wikimedia rcstream to https on port 443 .. Default wikimedia rcstream to https on port 443 Instead of http on port

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: test commit do not merge

2016-09-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/309493 Change subject: test commit do not merge .. test commit do not merge Change-Id: I27264a49a9bddaacc8a8147f2331b803243707f4 --- M extension.j

<    1   2   3   4   5   6   7   8   9   10   >