[MediaWiki-commits] [Gerrit] [WIP] Simplify config overrides read YAML - change (wikimedia...SmashPig)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285317 Change subject: [WIP] Simplify config overrides read YAML .. [WIP] Simplify config overrides read YAML TODO: * Kill "@" reference stuff *

[MediaWiki-commits] [Gerrit] Typo - change (wikimedia...php-queue)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285296 Change subject: Typo .. Typo Change-Id: I15ba65d689fc450f7ddc81d05333be5d9a0acf36 --- M src/PHPQueue/Backend/PDO.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] Clean up enough that composer test job will run - change (wikimedia...php-queue)

2016-04-25 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Clean up enough that composer test job will run .. Clean up enough that composer test job will run Skips PDO and Memcache tests if initial probing fails.

[MediaWiki-commits] [Gerrit] [WIP] Enable PHP_CodeSniffer for style consistency - change (wikimedia...SmashPig)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285228 Change subject: [WIP] Enable PHP_CodeSniffer for style consistency .. [WIP] Enable PHP_CodeSniffer for style consistency Change-Id:

[MediaWiki-commits] [Gerrit] Try PHP_CodeSniffer for style consistency - change (wikimedia...SmashPig)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285222 Change subject: Try PHP_CodeSniffer for style consistency .. Try PHP_CodeSniffer for style consistency Change-Id:

[MediaWiki-commits] [Gerrit] Clean up enough that composer test job will run - change (wikimedia...php-queue)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285220 Change subject: Clean up enough that composer test job will run .. Clean up enough that composer test job will run Bug: T133574 Change-Id:

[MediaWiki-commits] [Gerrit] Run PHPUnit for PHP-Queue repo - change (integration/config)

2016-04-25 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/285219 Change subject: Run PHPUnit for PHP-Queue repo .. Run PHPUnit for PHP-Queue repo Also adds HHVM tests Bug: T133574 Change-Id:

[MediaWiki-commits] [Gerrit] Add a timestamp column; specify MySQL syntax - change (wikimedia...php-queue)

2016-04-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284988 Change subject: Add a timestamp column; specify MySQL syntax .. Add a timestamp column; specify MySQL syntax The create syntax was

[MediaWiki-commits] [Gerrit] Support "queue" as an alias for "db_table" - change (wikimedia...php-queue)

2016-04-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284987 Change subject: Support "queue" as an alias for "db_table" .. Support "queue" as an alias for "db_table" Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Playing with the FIFO API - change (wikimedia...php-queue)

2016-04-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284977 Change subject: [WIP] Playing with the FIFO API .. [WIP] Playing with the FIFO API Change-Id: I3a704669a65fcc7d55b8d6a354d4f16aee586dc7 --- M

[MediaWiki-commits] [Gerrit] Experimental lint and phpunit for the SmashPig repo - change (integration/config)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284618 Change subject: Experimental lint and phpunit for the SmashPig repo .. Experimental lint and phpunit for the SmashPig repo Change-Id:

[MediaWiki-commits] [Gerrit] Validate config paths when loading cached values - change (wikimedia...SmashPig)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284614 Change subject: Validate config paths when loading cached values .. Validate config paths when loading cached values Change-Id:

[MediaWiki-commits] [Gerrit] Cheat encapsulation to allow us to reset the configuration c... - change (wikimedia...SmashPig)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284615 Change subject: Cheat encapsulation to allow us to reset the configuration context .. Cheat encapsulation to allow us to reset the

[MediaWiki-commits] [Gerrit] Straighten out test namespaces; reusable config setup - change (wikimedia...SmashPig)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284612 Change subject: Straighten out test namespaces; reusable config setup .. Straighten out test namespaces; reusable config setup Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Integrate with PHP-Queue - change (wikimedia...SmashPig)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284597 Change subject: [WIP] Integrate with PHP-Queue .. [WIP] Integrate with PHP-Queue Get a new FIFO queue by name, like: $queue = new

[MediaWiki-commits] [Gerrit] Use selection weights deterministically - change (mediawiki...DonationInterface)

2016-04-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/284503 Change subject: Use selection weights deterministically .. Use selection weights deterministically The previous behavior was to roll a random

[MediaWiki-commits] [Gerrit] Testing links to exercise secret amounts - change (mediawiki/vagrant)

2016-04-14 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283553 Change subject: Testing links to exercise secret amounts .. Testing links to exercise secret amounts These amounts will trigger various

[MediaWiki-commits] [Gerrit] ISSUERID is alphanumeric due to SEPA - change (mediawiki...DonationInterface)

2016-04-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283276 Change subject: ISSUERID is alphanumeric due to SEPA .. ISSUERID is alphanumeric due to SEPA The format of this field has changed. I found

[MediaWiki-commits] [Gerrit] Script to dump GET_DIRECTORY results - change (mediawiki...DonationInterface)

2016-04-13 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283266 Change subject: Script to dump GET_DIRECTORY results .. Script to dump GET_DIRECTORY results Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Import errors are logged and recoverable - change (wikimedia...crm)

2016-04-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283112 Change subject: [WIP] Import errors are logged and recoverable .. [WIP] Import errors are logged and recoverable This also changes error

[MediaWiki-commits] [Gerrit] [WIP] Ingenico uses generic response handling controller - change (mediawiki...DonationInterface)

2016-04-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283105 Change subject: [WIP] Ingenico uses generic response handling controller .. [WIP] Ingenico uses generic response handling controller Bug:

[MediaWiki-commits] [Gerrit] [WIP] Donors using Ingenico should always return to the resu... - change (mediawiki...DonationInterface)

2016-04-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283093 Change subject: [WIP] Donors using Ingenico should always return to the resultswitcher .. [WIP] Donors using Ingenico should always return to

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...crm)

2016-04-12 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Merge master into deployment .. Merge master into deployment d6f9a8b142d3fa478bb5b47dbe78f1a681e3142f New column headers for JP Morgan

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...crm)

2016-04-12 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/283003 Change subject: Merge master into deployment .. Merge master into deployment d6f9a8b142d3fa478bb5b47dbe78f1a681e3142f New column headers for

[MediaWiki-commits] [Gerrit] [WIP] Split normalizations into helper objects - change (mediawiki...DonationInterface)

2016-04-08 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282436 Change subject: [WIP] Split normalizations into helper objects .. [WIP] Split normalizations into helper objects Change-Id:

[MediaWiki-commits] [Gerrit] Escape paging IDs - change (wikimedia...tools)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282308 Change subject: Escape paging IDs .. Escape paging IDs This allows us to use unsafe or non-numeric column data for paging. Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Simplify export by not explicitly tracking opt-outs - change (wikimedia...tools)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282304 Change subject: [WIP] Simplify export by not explicitly tracking opt-outs .. [WIP] Simplify export by not explicitly tracking opt-outs By

[MediaWiki-commits] [Gerrit] Don't export Contact ID - change (wikimedia...tools)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282303 Change subject: Don't export Contact ID .. Don't export Contact ID It's unused and incorrect. Change-Id:

[MediaWiki-commits] [Gerrit] New column headers for JP Morgan - change (wikimedia...crm)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282298 Change subject: New column headers for JP Morgan .. New column headers for JP Morgan Bug: T131802 Change-Id:

[MediaWiki-commits] [Gerrit] Comment about query performance - change (wikimedia...tools)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282108 Change subject: Comment about query performance .. Comment about query performance Change-Id: I20f4efe1225d48d6248c5381f2032a8d0dd0a4a3 --- M

[MediaWiki-commits] [Gerrit] [WIP] Unsubscribe old emails; fix is_primary bug - change (wikimedia...tools)

2016-04-07 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282106 Change subject: [WIP] Unsubscribe old emails; fix is_primary bug .. [WIP] Unsubscribe old emails; fix is_primary bug Pull addresses from the

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-04-06 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I78927e0aa1930a21fc0954dd3edea93dca7b9a79 --- M

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Merge master into deployment .. Merge master into deployment eaa26a6641842d410468b51ec776d9e81493b30f Extend the fredge payment_submethod column to 32 chars

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282070 Change subject: Merge master into deployment .. Merge master into deployment eaa26a6641842d410468b51ec776d9e81493b30f Extend the fredge

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282068 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I78927e0aa1930a21fc0954dd3edea93dca7b9a79

[MediaWiki-commits] [Gerrit] Update form settings for CL - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282066 Change subject: Update form settings for CL .. Update form settings for CL Comment out individual cards, remove Banco de Chile, fix name of

[MediaWiki-commits] [Gerrit] Merge master into deploy - change (wikimedia...tools)

2016-04-06 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Merge master into deploy .. Merge master into deploy 55e926ed04485c8470f483531939c184f1b24973 Double up on exclusion logic--treat !is_primary the same as

[MediaWiki-commits] [Gerrit] Merge master into deploy - change (wikimedia...tools)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282065 Change subject: Merge master into deploy .. Merge master into deploy 55e926ed04485c8470f483531939c184f1b24973 Double up on exclusion

[MediaWiki-commits] [Gerrit] Reuse common error display code - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282063 Change subject: Reuse common error display code .. Reuse common error display code This surfaces server errors in the iDEAL forms. Plus some

[MediaWiki-commits] [Gerrit] Bring iDEAL forms more in line with our newer RapidHtml forms - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282062 Change subject: Bring iDEAL forms more in line with our newer RapidHtml forms .. Bring iDEAL forms more in line with our newer RapidHtml forms

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282061 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id:

[MediaWiki-commits] [Gerrit] Reuse common error display code - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/282001 Change subject: Reuse common error display code .. Reuse common error display code This surfaces server errors in the iDEAL forms. Bug:

[MediaWiki-commits] [Gerrit] [WIP] Bring iDEAL forms more in line with our newer RapidHtm... - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281974 Change subject: [WIP] Bring iDEAL forms more in line with our newer RapidHtml forms .. [WIP] Bring iDEAL forms more in line with our newer

[MediaWiki-commits] [Gerrit] Extend the fredge payment_submethod column to 32 chars - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281971 Change subject: Extend the fredge payment_submethod column to 32 chars .. Extend the fredge payment_submethod column to 32 chars Needed for

[MediaWiki-commits] [Gerrit] [WIP] Stub contact save hook - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281891 Change subject: [WIP] Stub contact save hook .. [WIP] Stub contact save hook This might be the wrong approach, and we should hook on the edit

[MediaWiki-commits] [Gerrit] Whitespace + readability - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281890 Change subject: Whitespace + readability .. Whitespace + readability Change-Id: Ie6f2110aa0037ecae3bacbe2232c2fb78dc2c6a8 --- M

[MediaWiki-commits] [Gerrit] Split out contribution save hook - change (wikimedia...crm)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281889 Change subject: Split out contribution save hook .. Split out contribution save hook Bug: T122411 Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] double up on exclusion logic--treat !is_primary the sa... - change (wikimedia...tools)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281884 Change subject: [WIP] double up on exclusion logic--treat !is_primary the same as is_deleted .. [WIP] double up on exclusion logic--treat

[MediaWiki-commits] [Gerrit] WIP Playing with payment method, trying to understand how to... - change (mediawiki...DonationInterface)

2016-04-06 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281883 Change subject: WIP Playing with payment method, trying to understand how to fix the two-level method hierarchy. .. WIP Playing with payment

[MediaWiki-commits] [Gerrit] WIP remove quotes - change (mediawiki...DonationInterface)

2016-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281872 Change subject: WIP remove quotes .. WIP remove quotes Change-Id: I1a8cf0515fa488fd9ccab81afbf6c82ec6be26a7 --- M

[MediaWiki-commits] [Gerrit] WIP Move issuers into its own file - change (mediawiki...DonationInterface)

2016-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281873 Change subject: WIP Move issuers into its own file .. WIP Move issuers into its own file Change-Id: Iae165a78cf343d0adff04dabe17e40b21f655811

[MediaWiki-commits] [Gerrit] WIP issuer patch - change (mediawiki...DonationInterface)

2016-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281871 Change subject: WIP issuer patch .. WIP issuer patch Change-Id: I6cd28866379df29a727fa2680edf9b79b4614bfe --- M

[MediaWiki-commits] [Gerrit] Remove Knab from iDEAL options - change (mediawiki...DonationInterface)

2016-04-05 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281866 Change subject: Remove Knab from iDEAL options .. Remove Knab from iDEAL options The bank has broken. This is just a workaround, we need to

[MediaWiki-commits] [Gerrit] Trim email during normalization - change (mediawiki...DonationInterface)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281581 Change subject: Trim email during normalization .. Trim email during normalization Trailing spaces would cause validation failure, which is

[MediaWiki-commits] [Gerrit] Tiny cleanups - change (mediawiki...DonationInterface)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281566 Change subject: Tiny cleanups .. Tiny cleanups Change-Id: I3ddf124544f3c76296fea46d019ace33642e8298 --- M

[MediaWiki-commits] [Gerrit] Merge master into deploy - change (wikimedia...tools)

2016-04-04 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Merge master into deploy .. Merge master into deploy 4ec420e1450399ea794a6b11f6b5f562304f2c2d Remove obsolete Amazon FPS audit

[MediaWiki-commits] [Gerrit] Merge master into deploy - change (wikimedia...tools)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281557 Change subject: Merge master into deploy .. Merge master into deploy 4ec420e1450399ea794a6b11f6b5f562304f2c2d Remove obsolete Amazon FPS

[MediaWiki-commits] [Gerrit] Provision fundraising-tools repo - change (mediawiki/vagrant)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281493 Change subject: Provision fundraising-tools repo .. Provision fundraising-tools repo Clone and provision the Silverpop export script, for

[MediaWiki-commits] [Gerrit] Python requirements file for installing dependencies - change (wikimedia...tools)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281491 Change subject: Python requirements file for installing dependencies .. Python requirements file for installing dependencies Change-Id:

[MediaWiki-commits] [Gerrit] Rename $unstaged variable - change (mediawiki...DonationInterface)

2016-04-04 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281461 Change subject: Rename $unstaged variable .. Rename $unstaged variable It's clearer to call this input data $normalized. Note that I'm not

[MediaWiki-commits] [Gerrit] [WIP] Hack to highlight invalid fields in Mustache forms - change (mediawiki...DonationInterface)

2016-04-02 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281181 Change subject: [WIP] Hack to highlight invalid fields in Mustache forms .. [WIP] Hack to highlight invalid fields in Mustache forms

[MediaWiki-commits] [Gerrit] [WIP] Explore encapsulating validation along with transforma... - change (mediawiki...DonationInterface)

2016-04-02 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281084 Change subject: [WIP] Explore encapsulating validation along with transformations .. [WIP] Explore encapsulating validation along with

[MediaWiki-commits] [Gerrit] Move most error mapping into config - change (mediawiki...DonationInterface)

2016-04-02 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281081 Change subject: Move most error mapping into config .. Move most error mapping into config Change-Id:

[MediaWiki-commits] [Gerrit] Default function defines data transformers from config - change (mediawiki...DonationInterface)

2016-04-01 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281062 Change subject: Default function defines data transformers from config .. Default function defines data transformers from config Change-Id:

[MediaWiki-commits] [Gerrit] Move data transformers to config - change (mediawiki...DonationInterface)

2016-04-01 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281063 Change subject: Move data transformers to config .. Move data transformers to config TODO: * Haven't converted Worldpay. * Do something more

[MediaWiki-commits] [Gerrit] Rename config loading function to reflect its increased resp... - change (mediawiki...DonationInterface)

2016-04-01 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/281061 Change subject: Rename config loading function to reflect its increased responsibilities .. Rename config loading function to reflect its

[MediaWiki-commits] [Gerrit] is_deleted is another way to opt out ; ) - change (wikimedia...tools)

2016-03-31 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280784 Change subject: is_deleted is another way to opt out ;) .. is_deleted is another way to opt out ;) Bug: T130660 Change-Id:

[MediaWiki-commits] [Gerrit] Revert "Deprecation notice" - change (mediawiki...FundraisingChart)

2016-03-31 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280770 Change subject: Revert "Deprecation notice" .. Revert "Deprecation notice" I mistook this for another extension... This reverts commit

[MediaWiki-commits] [Gerrit] Deprecation notice - change (mediawiki...FundraisingChart)

2016-03-31 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280767 Change subject: Deprecation notice .. Deprecation notice Change-Id: Iadab694930a69a4f71bde982dafb53218eb501b5 --- A README 1 file changed, 1

[MediaWiki-commits] [Gerrit] Compress PNGs using zopflipng - change (mediawiki...DonationInterface)

2016-03-31 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280766 Change subject: Compress PNGs using zopflipng .. Compress PNGs using zopflipng Squeezes a few bytes out... Prepared using, git ls-files

[MediaWiki-commits] [Gerrit] [WIP] Try to fix missing exchange rate fixtures - change (wikimedia...crm)

2016-03-31 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280763 Change subject: [WIP] Try to fix missing exchange rate fixtures .. [WIP] Try to fix missing exchange rate fixtures There's still a problem,

[MediaWiki-commits] [Gerrit] CRM-18193 create all new log tables with log_conn_id = varch... - change (wikimedia...civicrm)

2016-03-30 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: CRM-18193 create all new log tables with log_conn_id = varchar(17) .. CRM-18193 create all new log tables with log_conn_id = varchar(17) This provides

[MediaWiki-commits] [Gerrit] Fix to enable logging in multisite - change (wikimedia...civicrm)

2016-03-30 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: Fix to enable logging in multisite .. Fix to enable logging in multisite This is being backported in order to keep our files cleaner against the upstream

[MediaWiki-commits] [Gerrit] CRM-18193 adapt reports to expect a 17 char string rather th... - change (wikimedia...civicrm)

2016-03-30 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id .. CRM-18193 adapt reports to expect a 17 char string rather

[MediaWiki-commits] [Gerrit] CRM-18310 add tests for debug logging and option to specify ... - change (wikimedia...civicrm)

2016-03-30 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. .. CRM-18310 add tests for debug logging and option to specify log

[MediaWiki-commits] [Gerrit] Add a missing module - change (mediawiki/vagrant)

2016-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280477 Change subject: Add a missing module .. Add a missing module Change-Id: I332adb97b46f21a8b83f859e7816e8dde1eed199 --- M

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280280 Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I7fd52dfc3cb991071639b868c0f68317da93b83c

[MediaWiki-commits] [Gerrit] update DonationInterface submodule - change (mediawiki/core)

2016-03-30 Thread Awight (Code Review)
Awight has submitted this change and it was merged. Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id: I7fd52dfc3cb991071639b868c0f68317da93b83c --- M

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (mediawiki...DonationInterface)

2016-03-30 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280269 Change subject: Merge master into deployment .. Merge master into deployment 054d4e85bd65c61fc1f96f6361a783a4bc8496a5 Currency selector

[MediaWiki-commits] [Gerrit] [WIP] Kafka backend - change (wikimedia...php-queue)

2016-03-29 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280158 Change subject: [WIP] Kafka backend .. [WIP] Kafka backend Change-Id: I869a9669ec1ce0550300bc0a4350423e09ce154b --- M README.md A

[MediaWiki-commits] [Gerrit] [WIP] Change meaning of validation variables - change (mediawiki...DonationInterface)

2016-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280141 Change subject: [WIP] Change meaning of validation variables .. [WIP] Change meaning of validation variables There were two buckets of

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (mediawiki...DonationInterface)

2016-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280127 Change subject: Merge master into deployment .. Merge master into deployment 29899a9c7e57e5aabdafaed98e4225abf4a7f6a1 Update package pointers

[MediaWiki-commits] [Gerrit] Update package pointers - change (mediawiki...DonationInterface)

2016-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280125 Change subject: Update package pointers .. Update package pointers Change-Id: If9a3db8f96210f753a2b0283c4486e044af5b1e4 --- M composer.lock 1

[MediaWiki-commits] [Gerrit] Update packages - change (mediawiki...vendor)

2016-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280124 Change subject: Update packages .. Update packages Change-Id: I62bf4932ae0f5f640f392e668cc74e7ba1afdab7 --- A

[MediaWiki-commits] [Gerrit] Merge master into deployment - change (mediawiki...DonationInterface)

2016-03-28 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/280121 Change subject: Merge master into deployment .. Merge master into deployment 016478026a7f578f7366bf9715212fa166004d86 Fix undefined variable

[MediaWiki-commits] [Gerrit] [WIP] looking at direct kafka integration. - change (wikimedia...crm)

2016-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279745 Change subject: [WIP] looking at direct kafka integration. .. [WIP] looking at direct kafka integration. Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Mirror to Kafka - change (mediawiki...DonationInterface)

2016-03-27 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279744 Change subject: [WIP] Mirror to Kafka .. [WIP] Mirror to Kafka Bug: T130304 Change-Id: I293e2d3f6a8e34fcbc37ff7e97d83023818044b9 --- M

[MediaWiki-commits] [Gerrit] Maintenance notice takes precedence over disabled gateway - change (mediawiki...DonationInterface)

2016-03-23 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279302 Change subject: Maintenance notice takes precedence over disabled gateway .. Maintenance notice takes precedence over disabled gateway

[MediaWiki-commits] [Gerrit] Tests for new ResultPages functions - change (mediawiki...DonationInterface)

2016-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279078 Change subject: Tests for new ResultPages functions .. Tests for new ResultPages functions Bug: T129376 Change-Id:

[MediaWiki-commits] [Gerrit] Stop spinning onunload - change (mediawiki...DonationInterface)

2016-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279077 Change subject: Stop spinning onunload .. Stop spinning onunload Change-Id: I8b57414845011c368d46dd02fc3d8d8bdec4759e FIXME: This might be

[MediaWiki-commits] [Gerrit] Tiny cleanups - change (mediawiki...DonationInterface)

2016-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/279072 Change subject: Tiny cleanups .. Tiny cleanups Change-Id: I3ddf124544f3c76296fea46d019ace33642e8298 --- M

[MediaWiki-commits] [Gerrit] Make parameter optional to thwart type hinting - change (mediawiki...DonationInterface)

2016-03-22 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/278953 Change subject: Make parameter optional to thwart type hinting .. Make parameter optional to thwart type hinting We can't pass null

[MediaWiki-commits] [Gerrit] Split ContributionTrackingPlusUnique into a reusable thing - change (mediawiki...DonationInterface)

2016-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277981 Change subject: Split ContributionTrackingPlusUnique into a reusable thing .. Split ContributionTrackingPlusUnique into a reusable thing

[MediaWiki-commits] [Gerrit] Encapsulate PayPal staging logic - change (mediawiki...DonationInterface)

2016-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277985 Change subject: Encapsulate PayPal staging logic .. Encapsulate PayPal staging logic Bug: T130075 Change-Id:

[MediaWiki-commits] [Gerrit] Finish encapsulating Ingenico staging logic - change (mediawiki...DonationInterface)

2016-03-20 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277983 Change subject: Finish encapsulating Ingenico staging logic .. Finish encapsulating Ingenico staging logic Change-Id:

[MediaWiki-commits] [Gerrit] Fix some known issues with running PHPUnit in a multiwiki co... - change (mediawiki/vagrant)

2016-03-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/278050 Change subject: Fix some known issues with running PHPUnit in a multiwiki context .. Fix some known issues with running PHPUnit in a

[MediaWiki-commits] [Gerrit] Generalize data transformations - change (mediawiki...DonationInterface)

2016-03-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277845 Change subject: Generalize data transformations .. Generalize data transformations Transformers are often specialized to only stage or

[MediaWiki-commits] [Gerrit] [WIP] Encapsulate Ingenico staging logic - change (mediawiki...DonationInterface)

2016-03-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277861 Change subject: [WIP] Encapsulate Ingenico staging logic .. [WIP] Encapsulate Ingenico staging logic Change-Id:

[MediaWiki-commits] [Gerrit] Split out language staging - change (mediawiki...DonationInterface)

2016-03-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277982 Change subject: Split out language staging .. Split out language staging Change-Id: Iba744e3bdfc9481fcc4db077e679730f3f29cf83 --- M

[MediaWiki-commits] [Gerrit] Put all extra transaction keys in submethod meta - change (mediawiki...DonationInterface)

2016-03-19 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/277978 Change subject: Put all extra transaction keys in submethod meta .. Put all extra transaction keys in submethod meta These were being added

<    4   5   6   7   8   9   10   11   12   13   >