Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250979
Change subject: point to new location of localized resources
..
point to new location of localized resources
Now under the
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250897
Change subject: adds an apple-app-site-association file used to support iOS
deep-linking
..
adds an apple-app-site-association file used to
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/239399
Change subject: move wikipedia-ios config to GitHub & remove Main_iPhone
localizations
..
move wikipedia-ios config to GitHub & remove
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/236050
Change subject: add notifs for #wikimedia-ios room
..
add notifs for #wikimedia-ios room
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226979
Change subject: update support url
..
update support url
Change-Id: I5e6457e4c1baa3205cd3fda27028eb89d5df15b5
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226726
Change subject: fix gallery image owner label overflow
..
fix gallery image owner label overflow
Needed to add tail truncation to
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226923
Change subject: fix nil handling in langlink responses
..
fix nil handling in langlink responses
When we get a response from langlinks
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226925
Change subject: add API error handling to articlefetcher
..
add API error handling to articlefetcher
Bug: T102643
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226926
Change subject: use correct site when loading search results
..
use correct site when loading search results
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226644
Change subject: fix crash when saving empty/nil title
..
fix crash when saving empty/nil title
Bug: T106028
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226649
Change subject: un-static face detector
..
un-static face detector
We were reusing the face face detector (and its state) across all image
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226284
Change subject: fix crash due to weak promise ref
..
fix crash due to weak promise ref
Change-Id: I64a5986c4d68fc2cd38cbec98114d0f453fa73ef
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226429
Change subject: fix crash when fetching title with empty text
..
fix crash when fetching title with empty text
pass an error instead of
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226233
Change subject: fix list crashes, history saves from search, KVO cycles
..
fix list crashes, history saves from search, KVO cycles
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226019
Change subject: fix MWKList KVO and article observation
..
fix MWKList KVO and article observation
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224430
Change subject: overlay app icon from dev lane 5.0 version bump
..
overlay app icon from dev lane 5.0 version bump
- cherry-picked bump
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224115
Change subject: Migrate article images from un-migrated save page entries
..
Migrate article images from un-migrated save page entries
At
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224193
Change subject: fastlane dev
..
fastlane dev
Change-Id: I3946c5c1a07f4cb1a800e54e713309825443d4b6
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223787
Change subject: brute-force fix for schemeless image URLs
..
brute-force fix for schemeless image URLs
also added unit tests for all the
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223965
Change subject: dismiss search keyboard on scroll
..
dismiss search keyboard on scroll
and cause search bar to resign first responder when
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/223219
Change subject: wording
..
wording
more user friendly; bugging sounds like you don't want them.
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222373
Change subject: use HTTPS submodule for SDWebImage
..
use HTTPS submodule for SDWebImage
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221850
Change subject: history list performance tests
..
history list performance tests
Change-Id: I20ec399ec283240bd8d5dd56f8fac0755d4719a2
---
A
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220527
Change subject: centralized image caching retrieval
..
centralized image caching retrieval
Project changes:
- Added SDWebImage fork as a
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220951
Change subject: add sdwebimage fork as local pod
..
add sdwebimage fork as local pod
Change-Id: Id39a423af461dfbd48ea31a6098c551ce554e635
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221668
Change subject: restore legacy empty string behavior for titles
..
restore legacy empty string behavior for titles
also added some more
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221669
Change subject: saved history list error handling testing
..
saved history list error handling testing
- attempt to recover from bad
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221673
Change subject: Version Bump
..
Version Bump
Change-Id: I5b4de021ce3523491a31eee7cab80fd3e603030f
---
M Wikipedia.xcodeproj/project.pbxproj
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221672
Change subject: automate bumping via fastlane
..
automate bumping via fastlane
Change-Id: I3d486611eddfd51159ad7cf45ae1cb3b2b252318
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220943
Change subject: sync with master
..
sync with master
Change-Id: I49ec50f938f4eb6e78c60a97620e665876da25f0
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220813
Change subject: uncrustify stuff
..
uncrustify stuff
Change-Id: I908a3f0efdaedd4fd5d75fdc27b23cab201d6433
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220609
Change subject: scale language row height w/ device
..
scale language row height w/ device
Fixes text being cropped on iPad. [0]
0:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219844
Change subject: update reorganize pods
..
update reorganize pods
Change-Id: Ia9b6c9e101ef2db6137770dbee308f9c9fd6b4b5
---
M Gemfile
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219474
Change subject: save user lang selection
..
save user lang selection
Change-Id: I8f3eef90811ca600941efcc6db256d471fd87a49
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219434
Change subject: update reorganize pods
..
update reorganize pods
Change-Id: Ia9b6c9e101ef2db6137770dbee308f9c9fd6b4b5
---
M Gemfile
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219435
Change subject: add CocoaLumberjack
..
add CocoaLumberjack
Change-Id: I85bf6739df20541587ae0e485a05ad4a2295f02f
---
M Podfile
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219428
Change subject: remove UI-V5 folder
..
remove UI-V5 folder
Change-Id: Id383dafa49b1f70855a2f9e70c2a675da6b26311
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219205
Change subject: Update Podfile to iOS 7
..
Update Podfile to iOS 7
Follow on patch for T102362
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216861
Change subject: Bump to 4.1.5.141
..
Bump to 4.1.5.141
Change-Id: Iebce6e6e081e316a4919e5ddd07368449cdf1190
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216875
Change subject: fix compiler error
..
fix compiler error
Change-Id: Iae758d8ce28119d95487775b3511d2ba56423c12
---
M Wikipedia/View
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216903
Change subject: fix visual fnl lang picker regressions
..
fix visual fnl lang picker regressions
- Language filtering (filter both
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216692
Change subject: build url using formats until iOS 6 is dropped
..
build url using formats until iOS 6 is dropped
Can't use NSURLComponents
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216276
Change subject: add FAQ wiki link to More menu
..
add FAQ wiki link to More menu
FAQ lives under the new About section (formerly Privacy
Bgerstle has submitted this change and it was merged.
Change subject: Fix to makefile so it pulls same upstream css as before.
..
Fix to makefile so it pulls same upstream css as before.
The mobile app extension css handling
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215817
Change subject: move hockeyapp debug menu config to info.plist
..
move hockeyapp debug menu config to info.plist
- tested on:
- [x]
Bgerstle has submitted this change and it was merged.
Change subject: make sure to run block when commenting out version bump work
..
make sure to run block when commenting out version bump work
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215659
Change subject: fix unit tests (again) crash reporting
..
fix unit tests (again) crash reporting
Crash reporting is now expected to
Bgerstle has submitted this change and it was merged.
Change subject: Fix for Bug: T99122 - exception on non-wmf image urls
..
Fix for Bug: T99122 - exception on non-wmf image urls
Once again throwing an exception where none
Bgerstle has submitted this change and it was merged.
Change subject: Fix alpha builds - use jenkins number for build number until we
have the ability to push changes to gerrit.
..
Fix alpha builds - use jenkins number for
Bgerstle has submitted this change and it was merged.
Change subject: Fix for article not reloading from cache on app start.
..
Fix for article not reloading from cache on app start.
Also fixed issue with both article
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215326
Change subject: Fetch site info to get main page
..
Fetch site info to get main page
Prevents a crash in the app when we don't know the
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215354
Change subject: add tests for article fetcher
..
add tests for article fetcher
Bug: T101078
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215114
Change subject: hygiene: hash equality utils plus title site cleanup
..
hygiene: hash equality utils plus title site cleanup
This is a
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214426
Change subject: fix unit tests consolidate fixtures
..
fix unit tests consolidate fixtures
- Changes to MWK ownership semantics were
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214425
Change subject: Image assets file updates
..
Image assets file updates
These changes result from simply clicking the .xcassets file in
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214089
Change subject: set UIFileSharingEnabled based on build config
..
set UIFileSharingEnabled based on build config
Writes to the app's
Bgerstle has submitted this change and it was merged.
Change subject: Fix build and analyzer warnings
..
Fix build and analyzer warnings
Bug T99260
Change-Id: Ibc9fd00c9916371f01ce086eaafbd639782a0708
---
M
Bgerstle has submitted this change and it was merged.
Change subject: Core data performance improvements. Bug T99260
..
Core data performance improvements. Bug T99260
Separate core data fetches into batches.
Reset context
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210760
Change subject: deploy adhoc to HA for store lane
..
deploy adhoc to HA for store lane
modify store lane so that it:
- deploys the app to
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210823
Change subject: ugly WIP: group preferred languages
..
ugly WIP: group preferred languages
- [x] group languages by preferred and other
- [
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210393
Change subject: bump to 4.1.4.0, implement versioning in fastlane
..
bump to 4.1.4.0, implement versioning in fastlane
Versioning scheme:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210561
Change subject: merge pull request #14
..
merge pull request #14
Cleaned up the Deliverfile
Change-Id:
Bgerstle has submitted this change and it was merged.
Change subject: Update icon.
..
Update icon.
Used ruby script which is most easily run in ubuntu for creating
various icon resolutions from icon svg.
Renamed items in icon
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210613
Change subject: convert svgs-to-pngs using convert
..
convert svgs-to-pngs using convert
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210532
Change subject: merge pull request #13
..
merge pull request #13
- Removed {} from action calls
- Some clean ups of the Fastfile
- Also
Bgerstle has submitted this change and it was merged.
Change subject: Bug T98626 Typo - wrong case
..
Bug T98626 Typo - wrong case
Change-Id: Ia756239d704f3e4e875cf1b4e7320acc2bb1ba49
---
M Wikipedia/View
Bgerstle has submitted this change and it was merged.
Change subject: Fix for Bug T96450 - history is rewritten when refreshing
..
Fix for Bug T96450 - history is rewritten when refreshing
- Added new discovery method:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210206
Change subject: bump fastlane to 1.0, simplify fastfile
..
bump fastlane to 1.0, simplify fastfile
- Remove calls to produce (app records
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/210095
Change subject: fix for missing file
..
fix for missing file
Change-Id: Ie0f15812e141c9095b27bb3de36e37530efafdca
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209812
Change subject: use a different share snippet xpath for main pages
..
use a different share snippet xpath for main pages
main pages wrap
Bgerstle has submitted this change and it was merged.
Change subject: Remove superfluous appInstallID from URLs
..
Remove superfluous appInstallID from URLs
Change-Id: Ic20a8f2ad65af2cfeafc7fcc7be41087afc45edd
---
M
Bgerstle has submitted this change and it was merged.
Change subject: Migration fixes - Bug: T96607 Sending migration failures to
OTRS Adding build number to user agent string Adding logic to remove old
backups after 30 days Refactor many methods to be instance methods to make the
classes
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209554
Change subject: lint OldDataSchema and WikipediaUnitTests
..
lint OldDataSchema and WikipediaUnitTests
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209529
Change subject: fix parsing test
..
fix parsing test
Change-Id: Ib2e35990c8f0c55e938c0c5a93c99883521d1dd5
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209298
Change subject: fix section share snippet XPath to only grab top-level p's
..
fix section share snippet XPath to only grab top-level p's
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209297
Change subject: refactor add more sanitation to article snippet heuristic
..
refactor add more sanitation to article snippet heuristic
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/209163
Change subject: do text sanitation on selected text before sharing
..
do text sanitation on selected text before sharing
We weren't doing
Bgerstle has submitted this change and it was merged.
Change subject: Fix typo.
..
Fix typo.
Change-Id: Id2f9cad27024f41923e28b6cf9a6410e6aa110aa
---
M MediaWikiKit/MediaWikiKit/MWKImage.h
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208830
Change subject: wmf-ify and rename string categories
..
wmf-ify and rename string categories
Use Apple stringBy... convention and/or
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208139
Change subject: bump to 4.1.3.96
..
bump to 4.1.3.96
Change-Id: I75549b6117eda57ea2dda0d69f4dd253aab4c3ea
---
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/208165
Change subject: add bundle info utils and fix About page
..
add bundle info utils and fix About page
The About page was only showing the
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207848
Change subject: CI fixes
..
CI fixes
Change-Id: I5afbacdfb916c88b21162928762d965735d748d9
---
M .gitignore
M Gemfile
M Gemfile.lock
M
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207298
Change subject: add README which links to wiki docs
..
add README which links to wiki docs
Change-Id:
Bgerstle has submitted this change and it was merged.
Change subject: Fix T96603 - wrapping section html creation in an exception
handler.
..
Fix T96603 - wrapping section html creation in an exception handler.
Also added a
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206970
Change subject: prevent storing article titles that fail to load in history
..
prevent storing article titles that fail to load in history
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/206858
Change subject: add assertion macros
..
add assertion macros
Add a suite of assertion macros which we can use to easily implement the
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205874
Change subject: refactor MWKTestCase and fix linting errors
..
refactor MWKTestCase and fix linting errors
Change-Id:
Bgerstle has submitted this change and it was merged.
Change subject: Fix for article centric strings not using article lang
localizations.
..
Fix for article centric strings not using article lang localizations.
Native
Bgerstle has submitted this change and it was merged.
Change subject: Remove run-time css sync so we have more control over css
deployment.
..
Remove run-time css sync so we have more control over css deployment.
Change-Id:
Bgerstle has submitted this change and it was merged.
Change subject: Fix for too much whitespace beneath article title on landscape.
..
Fix for too much whitespace beneath article title on landscape.
To reproduce bug:
-load
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/205287
Change subject: merge release/4.1.1
..
merge release/4.1.1
Here's a breakdown of the conflicts:
- Wikipedia.xcodeproj/project.pbxproj
Bgerstle has submitted this change and it was merged.
Change subject: Fix for side to side scrolling of wide images with div overlays.
..
Fix for side to side scrolling of wide images with div overlays.
See the following
Bgerstle has submitted this change and it was merged.
Change subject: Fix for weird staged file from last incoming translation set.
..
Fix for weird staged file from last incoming translation set.
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202805
Change subject: fix for some compiler warnings
..
fix for some compiler warnings
- wasn't properly implementing ImageInfoController
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202905
Change subject: remove accidentally-committed xcuserdata
..
remove accidentally-committed xcuserdata
Change-Id:
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202928
Change subject: import imgs into xcassets and fix wikipedia group path
..
import imgs into xcassets and fix wikipedia group path
We had
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202463
Change subject: readme: WIP
..
readme: WIP
Change-Id: I33df4b6b2917063e6e78b228c2f29e901eb153fa
---
M Makefile
M README.md
A
Bgerstle has submitted this change and it was merged.
Change subject: Fixing unit tests and running tests in alpha lane T94421
..
Fixing unit tests and running tests in alpha lane T94421
Adding missing file to test bundle
Save
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202649
Change subject: makefile fastlane follow-on
..
makefile fastlane follow-on
- fix some syntax rebase errors in the Makefile
- add make fn
Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202040
Change subject: commit Pods folder
..
commit Pods folder
Commits the Pods folder, which removes bundler cocoapods as build
dependencies.
1 - 100 of 143 matches
Mail list logo
