[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: VE MobileFrontend: fix call to _fixIosHeader

2018-01-23 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405991 ) Change subject: VE MobileFrontend: fix call to _fixIosHeader .. VE MobileFrontend: fix call to _fixIosHeader Needs to be a jQuery object,

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWWikitextStringTransferHandler: Perform Parsoid cleanup on ...

2018-01-22 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405759 ) Change subject: MWWikitextStringTransferHandler: Perform Parsoid cleanup on result .. MWWikitextStringTransferHandler: Perform Parsoid

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update TitleInput's getTitle to getMWTitle

2018-01-18 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405023 ) Change subject: Update TitleInput's getTitle to getMWTitle .. Update TitleInput's getTitle to getMWTitle

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use mw.storage instead of localStorage

2018-01-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403434 ) Change subject: Use mw.storage instead of localStorage .. Use mw.storage instead of localStorage mw.storage catches errors, so we won't

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Catch errors when accessing localStorage

2018-01-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403433 ) Change subject: Catch errors when accessing localStorage .. Catch errors when accessing localStorage Bug: T181822 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Change save dialog accesskey to be entirely off the trigger

2018-01-08 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402874 ) Change subject: Change save dialog accesskey to be entirely off the trigger .. Change save dialog accesskey to be entirely off the trigger

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use section fragment after-save even if the query is empty

2018-01-05 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402399 ) Change subject: Use section fragment after-save even if the query is empty .. Use section fragment after-save even if the query is empty

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTargetEvents: Track editor mode on save events

2017-12-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398333 ) Change subject: ArticleTargetEvents: Track editor mode on save events .. ArticleTargetEvents: Track editor mode on save events Bug: T182610

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Add section id to URI fragment on save

2017-12-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398285 ) Change subject: Add section id to URI fragment on save .. Add section id to URI fragment on save Bug: T181075 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: trackSubscriber: data isn't required

2017-12-13 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398084 ) Change subject: trackSubscriber: data isn't required .. trackSubscriber: data isn't required Editor-fixing caused errors on some events

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Track time-to-ready/loaded via window.performance

2017-12-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397580 ) Change subject: Track time-to-ready/loaded via window.performance .. Track time-to-ready/loaded via window.performance Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Bump Edit schema version

2017-12-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397573 ) Change subject: Bump Edit schema version .. Bump Edit schema version Change-Id: I873bd197806c6f7e8d7a72436610044ec8e8b011 --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Track action=loaded for consistency with WikiEditor

2017-12-06 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395783 ) Change subject: Track action=loaded for consistency with WikiEditor .. Track action=loaded for consistency with WikiEditor Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use rel="noopener" on links targeted at new windows

2017-11-30 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394374 ) Change subject: Use rel="noopener" on links targeted at new windows .. Use rel="noopener" on links targeted at new windows Bug: T180932

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use rel="noopener" on links targeted at new windows

2017-11-30 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394373 ) Change subject: Use rel="noopener" on links targeted at new windows .. Use rel="noopener" on links targeted at new windows Bug: T180932

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ui.MWSaveDialog: consistent handling of preview category links

2017-11-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394088 ) Change subject: ui.MWSaveDialog: consistent handling of preview category links .. ui.MWSaveDialog: consistent handling of preview category

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: more tests for Google Docs pasting

2017-11-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393932 ) Change subject: ce.Surface: more tests for Google Docs pasting .. ce.Surface: more tests for Google Docs pasting Bug: T145252 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: support formatted google docs paste content again

2017-11-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393813 ) Change subject: ce.Surface: support formatted google docs paste content again .. ce.Surface: support formatted google docs paste content

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget: enable spellcheck on sectionTitle

2017-11-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391587 ) Change subject: DesktopArticleTarget: enable spellcheck on sectionTitle .. DesktopArticleTarget: enable spellcheck on sectionTitle Tell

[MediaWiki-commits] [Gerrit] oojs/ui[master]: TextInputWidget: support spellcheck attribute

2017-11-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391256 ) Change subject: TextInputWidget: support spellcheck attribute .. TextInputWidget: support spellcheck attribute `spellcheck` allows browser

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: on paste, make sure clipboardKey spans don't sho...

2017-11-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389750 ) Change subject: ce.Surface: on paste, make sure clipboardKey spans don't show up .. ce.Surface: on paste, make sure clipboardKey spans don't

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTarget: remember whether we preloaded, so it can affe...

2017-10-26 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386644 ) Change subject: ArticleTarget: remember whether we preloaded, so it can affect the save button .. ArticleTarget: remember whether we

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.ContentBranchNode: onTeardown, check if we have a root

2017-10-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386419 ) Change subject: ce.ContentBranchNode: onTeardown, check if we have a root .. ce.ContentBranchNode: onTeardown, check if we have a root Some

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinearEnterKeyDownHandler: Enter behavior in nested lists

2017-10-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386418 ) Change subject: LinearEnterKeyDownHandler: Enter behavior in nested lists .. LinearEnterKeyDownHandler: Enter behavior in nested lists Bug:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWInternalLinkContextItem: increase specificity to override ...

2017-10-24 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386286 ) Change subject: MWInternalLinkContextItem: increase specificity to override OOUI changes .. MWInternalLinkContextItem: increase specificity

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: MWReferencesList: drop autoGenerated attribute if changed

2017-10-17 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384757 ) Change subject: MWReferencesList: drop autoGenerated attribute if changed .. MWReferencesList: drop autoGenerated attribute if changed If

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: init.mw.DesktopArticleTarget: properly set up section links

2017-10-16 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384560 ) Change subject: init.mw.DesktopArticleTarget: properly set up section links .. init.mw.DesktopArticleTarget: properly set up section links

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: init.mw.Target: make getSurfaceConfig aware of modes

2017-10-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383410 ) Change subject: init.mw.Target: make getSurfaceConfig aware of modes .. init.mw.Target: make getSurfaceConfig aware of modes ve.init.Target

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Make sure content is set

2017-10-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382359 ) Change subject: Make sure content is set .. Make sure content is set Change-Id: I59a5146a1186937a643818d02441563c5cc63319 --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ApiVisualEditor: avoid some unset variable notices

2017-10-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382166 ) Change subject: ApiVisualEditor: avoid some unset variable notices .. ApiVisualEditor: avoid some unset variable notices Bug: T176440

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: handle table-adjacent observed selection changes...

2017-10-02 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381805 ) Change subject: ce.Surface: handle table-adjacent observed selection changes better .. ce.Surface: handle table-adjacent observed selection

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.Surface: in observed selection changes, only make cursora...

2017-09-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381235 ) Change subject: ce.Surface: in observed selection changes, only make cursorable selections .. ce.Surface: in observed selection changes,

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinearEnterKeyDownHandler: make sure the range is in a curso...

2017-09-27 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381033 ) Change subject: LinearEnterKeyDownHandler: make sure the range is in a cursorable location .. LinearEnterKeyDownHandler: make sure the

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Api: Missing preloadparams

2017-09-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380536 ) Change subject: Api: Missing preloadparams .. Api: Missing preloadparams Tiny fix to 33dc60838cbb8fc1c78678230c4516c1a36c23b3. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Api: include preload content when section=new

2017-09-25 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380530 ) Change subject: Api: include preload content when section=new .. Api: include preload content when section=new Consistency with former

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ApiVisualEditor: Stop an undefined variable error for preloa...

2017-09-21 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379666 ) Change subject: ApiVisualEditor: Stop an undefined variable error for preload on existing pages .. ApiVisualEditor: Stop an undefined

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (bd5da1725)

2017-09-21 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379557 ) Change subject: Update VE core submodule to master (bd5da1725) .. Update VE core submodule to master (bd5da1725) New changes: 3a64969b9

[MediaWiki-commits] [Gerrit] mediawiki...Graph[master]: ui.MWGraphDialog: update dialog fragment after popping staging

2017-09-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379437 ) Change subject: ui.MWGraphDialog: update dialog fragment after popping staging .. ui.MWGraphDialog: update dialog fragment after popping

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Surface: reset selection when popping staging

2017-09-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379435 ) Change subject: Surface: reset selection when popping staging .. Surface: reset selection when popping staging Bug: T166134 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Hooks: remove preloadtitle from unsupported list

2017-09-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379246 ) Change subject: Hooks: remove preloadtitle from unsupported list .. Hooks: remove preloadtitle from unsupported list Bug: T51622 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget: Support preloadtitle in source mode

2017-09-18 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378726 ) Change subject: DesktopArticleTarget: Support preloadtitle in source mode .. DesktopArticleTarget: Support preloadtitle in source mode

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Enable preload in VisualEditor

2017-09-15 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378343 ) Change subject: Enable preload in VisualEditor .. Enable preload in VisualEditor This allows the use of the preload and preloadparams query

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ui.TableLineContext: fix z-index for menu

2017-09-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378099 ) Change subject: ui.TableLineContext: fix z-index for menu .. ui.TableLineContext: fix z-index for menu Bug: T169389 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ui.TableLineContext: adjust positioning

2017-09-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377482 ) Change subject: ui.TableLineContext: adjust positioning .. ui.TableLineContext: adjust positioning a4a0be2da1 restored this rule to stop

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget.init: handle new-section tab when in vi...

2017-09-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377301 ) Change subject: DesktopArticleTarget.init: handle new-section tab when in visual mode .. DesktopArticleTarget.init: handle new-section tab

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWExtensionWindow: clean up originalMwData on teardown

2017-09-07 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376536 ) Change subject: MWExtensionWindow: clean up originalMwData on teardown .. MWExtensionWindow: clean up originalMwData on teardown Not doing

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: mw.ArticleTarget: strip HTML tags entirely from source-mode ...

2017-08-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374573 ) Change subject: mw.ArticleTarget: strip HTML tags entirely from source-mode summary .. mw.ArticleTarget: strip HTML tags entirely from

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWLinkAnnotationInspector: check input validity when switchi...

2017-08-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374563 ) Change subject: MWLinkAnnotationInspector: check input validity when switching modes .. MWLinkAnnotationInspector: check input validity

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: ce.MWReferencesListNode: wait for content before destroying ...

2017-08-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369949 ) Change subject: ce.MWReferencesListNode: wait for content before destroying temporary view node .. ce.MWReferencesListNode: wait for

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ce.GeneratedContentNode: helper for waiting for generation

2017-08-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369948 ) Change subject: ce.GeneratedContentNode: helper for waiting for generation .. ce.GeneratedContentNode: helper for waiting for generation

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinearTabKeyDownHandler: Abort if modifiers are used

2017-08-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369407 ) Change subject: LinearTabKeyDownHandler: Abort if modifiers are used .. LinearTabKeyDownHandler: Abort if modifiers are used Firefox still

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ce.MWTransclusionNode: make sure model exists before getting...

2017-07-24 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367429 ) Change subject: ce.MWTransclusionNode: make sure model exists before getting its document .. ce.MWTransclusionNode: make sure model exists

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTarget: set local config to hide welcome dialog

2017-07-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366279 ) Change subject: ArticleTarget: set local config to hide welcome dialog .. ArticleTarget: set local config to hide welcome dialog This stops

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: LinkCache: parsoid element styling, detect selflink fragments

2017-07-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366286 ) Change subject: LinkCache: parsoid element styling, detect selflink fragments .. LinkCache: parsoid element styling, detect selflink

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget.init: more explicit no-welcome-on-prote...

2017-07-17 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365867 ) Change subject: DesktopArticleTarget.init: more explicit no-welcome-on-protected-pages .. DesktopArticleTarget.init: more explicit

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: ce.MWSyntaxHighlightNode: Always generate node contents

2017-07-17 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365643 ) Change subject: ce.MWSyntaxHighlightNode: Always generate node contents .. ce.MWSyntaxHighlightNode: Always generate node contents Don't

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ce.MWTransclusionNode: make sure model exists before getting...

2017-07-13 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365057 ) Change subject: ce.MWTransclusionNode: make sure model exists before getting its document .. ce.MWTransclusionNode: make sure model exists

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget.init: only show welcome dialog if page ...

2017-07-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364760 ) Change subject: DesktopArticleTarget.init: only show welcome dialog if page editable .. DesktopArticleTarget.init: only show welcome dialog

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WindowManager: fix closing promise state check

2017-07-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364227 ) Change subject: WindowManager: fix closing promise state check .. WindowManager: fix closing promise state check Async promise resolution

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: hide strikethrough on hover

2017-07-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364202 ) Change subject: DiffElement: hide strikethrough on hover .. DiffElement: hide strikethrough on hover Bug: T170133 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ui.TableLineContext: restore the z-index hack

2017-07-06 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363619 ) Change subject: ve.ui.TableLineContext: restore the z-index hack .. ve.ui.TableLineContext: restore the z-index hack 73ce638f11 removed

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Minimal demo: update deprecated TextInputWidget

2017-07-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363096 ) Change subject: Minimal demo: update deprecated TextInputWidget .. Minimal demo: update deprecated TextInputWidget Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Custom TextInputWidgets: clean up unneeded multiline config

2017-07-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363095 ) Change subject: Custom TextInputWidgets: clean up unneeded multiline config .. Custom TextInputWidgets: clean up unneeded multiline config

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (65ea4cf36)

2017-07-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363036 ) Change subject: Update VE core submodule to master (65ea4cf36) .. Update VE core submodule to master (65ea4cf36) New changes: 7b9f264b6

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ui.WhitespacePreservingTextInputWidget: inherit from Multili...

2017-07-03 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363034 ) Change subject: ui.WhitespacePreservingTextInputWidget: inherit from MultilineTextInputWidget .. ui.WhitespacePreservingTextInputWidget:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ui.FormatAction: fixup selection for empty conversions

2017-06-29 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362229 ) Change subject: ui.FormatAction: fixup selection for empty conversions .. ui.FormatAction: fixup selection for empty conversions Converting

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: dm.SurfaceFragment tests: exercise fixupInsertion for mwHead...

2017-06-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361890 ) Change subject: dm.SurfaceFragment tests: exercise fixupInsertion for mwHeadings .. dm.SurfaceFragment tests: exercise fixupInsertion for

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: dm.Document fixupInsertion: check suggestedParents as well

2017-06-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361888 ) Change subject: dm.Document fixupInsertion: check suggestedParents as well .. dm.Document fixupInsertion: check suggestedParents as well

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTransclusionDialog: fix conditions for "show options" butt...

2017-06-14 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358984 ) Change subject: MWTransclusionDialog: fix conditions for "show options" button disabling .. MWTransclusionDialog: fix conditions for "show

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTransclusionDialog: size footer correctly

2017-06-13 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358632 ) Change subject: MWTransclusionDialog: size footer correctly .. MWTransclusionDialog: size footer correctly Changing label means a refresh

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.fixupBase: handle Safari behavior

2017-06-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358174 ) Change subject: ve.fixupBase: handle Safari behavior .. ve.fixupBase: handle Safari behavior Protocol relative URLs in a confuse Safari,

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Correct numbers in visualeditor-dialog-meta-settings-toc-help

2017-06-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356618 ) Change subject: Correct numbers in visualeditor-dialog-meta-settings-toc-help .. Correct numbers in

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: summarizeTransaction: hide null author

2017-05-21 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354936 ) Change subject: summarizeTransaction: hide null author .. summarizeTransaction: hide null author Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ui.DebugBar: Transaction log

2017-05-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354687 ) Change subject: ui.DebugBar: Transaction log .. ui.DebugBar: Transaction log Change-Id: I0a0ddb68ded333809b3b3ebceb1497b013c7b32e --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: demo.minimal should use getInitializedPromise

2017-05-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354655 ) Change subject: demo.minimal should use getInitializedPromise .. demo.minimal should use getInitializedPromise Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: dm.MWTransclusionNode: remove TableCellableNode mixin

2017-05-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354558 ) Change subject: dm.MWTransclusionNode: remove TableCellableNode mixin .. dm.MWTransclusionNode: remove TableCellableNode mixin Change-Id:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: PopupWidget head: position close button absolutely

2017-05-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354458 ) Change subject: PopupWidget head: position close button absolutely .. PopupWidget head: position close button absolutely Floating it meant

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWCategoryInputWidget: missing 'new' for cached redirected o...

2017-05-19 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354440 ) Change subject: MWCategoryInputWidget: missing 'new' for cached redirected optionwidgets .. MWCategoryInputWidget: missing 'new' for cached

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: MobileContext: Fix alignment of label and description

2017-05-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353324 ) Change subject: MobileContext: Fix alignment of label and description .. MobileContext: Fix alignment of label and description They were

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWWikitextDataTransferHandlerFactory: Don't reimplement getText

2017-05-10 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353096 ) Change subject: MWWikitextDataTransferHandlerFactory: Don't reimplement getText .. MWWikitextDataTransferHandlerFactory: Don't reimplement

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: dm.VisualDiff: fix indentation eslint complained about

2017-05-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351887 ) Change subject: dm.VisualDiff: fix indentation eslint complained about .. dm.VisualDiff: fix indentation eslint complained about Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: TableAction: Handle non-TableCell cells better

2017-05-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351885 ) Change subject: TableAction: Handle non-TableCell cells better .. TableAction: Handle non-TableCell cells better This (downstream) lets

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTransclusionNode: Implement MWTransclusionTableCell

2017-05-04 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351883 ) Change subject: MWTransclusionNode: Implement MWTransclusionTableCell .. MWTransclusionNode: Implement MWTransclusionTableCell Back in

[MediaWiki-commits] [Gerrit] oojs/ui[master]: ProcessDialog: safe action buttons were misaligned

2017-05-02 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351341 ) Change subject: ProcessDialog: safe action buttons were misaligned .. ProcessDialog: safe action buttons were misaligned Bug: T163473

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: MergeCellsContextItem: Make sure we're on a TableSelection

2017-05-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351157 ) Change subject: MergeCellsContextItem: Make sure we're on a TableSelection .. MergeCellsContextItem: Make sure we're on a TableSelection

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: UrlStringTransferHandler: in source mode, skip annotating if...

2017-05-01 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351152 ) Change subject: UrlStringTransferHandler: in source mode, skip annotating if possible .. UrlStringTransferHandler: in source mode, skip

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: MobileContext: fix button spacing

2017-04-28 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350962 ) Change subject: MobileContext: fix button spacing .. MobileContext: fix button spacing Bug: T163473 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: tests: MWInternalLinkAnnotation getFragment

2017-04-27 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350595 ) Change subject: tests: MWInternalLinkAnnotation getFragment .. tests: MWInternalLinkAnnotation getFragment Also, fix docs for it. It could

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinkAnnotation: fix getFragment behavior

2017-04-27 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350586 ) Change subject: LinkAnnotation: fix getFragment behavior .. LinkAnnotation: fix getFragment behavior Make it more consistent with mw.Title.

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: DesktopArticleTarget: only destroy notices tool if it exists

2017-04-26 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350432 ) Change subject: DesktopArticleTarget: only destroy notices tool if it exists .. DesktopArticleTarget: only destroy notices tool if it exists

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MenuSelectWidget: scroll to the top if filtering and no exac...

2017-04-26 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350423 ) Change subject: MenuSelectWidget: scroll to the top if filtering and no exact match .. MenuSelectWidget: scroll to the top if filtering and

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWCategoryWidget: batch requests for category data

2017-04-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349338 ) Change subject: MWCategoryWidget: batch requests for category data .. MWCategoryWidget: batch requests for category data API query cuts off

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: MWReferenceNode: Don't try to remove from the internal list ...

2017-04-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349161 ) Change subject: MWReferenceNode: Don't try to remove from the internal list if it's not added .. MWReferenceNode: Don't try to remove from

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWCategoryItemWidget: remove DraggableElement's padding

2017-04-20 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349157 ) Change subject: MWCategoryItemWidget: remove DraggableElement's padding .. MWCategoryItemWidget: remove DraggableElement's padding OOjs UI

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: LinkAnnotation: add a getFragment method for consistency wit...

2017-04-17 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348498 ) Change subject: LinkAnnotation: add a getFragment method for consistency with MWInternalLinkAnnotation .. LinkAnnotation: add a getFragment

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Fix typo in frameless button mixin

2017-04-16 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348404 ) Change subject: Fix typo in frameless button mixin .. Fix typo in frameless button mixin Bug: T163085 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: TemplatePlaceholderPage: abort pending template search after...

2017-04-12 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347871 ) Change subject: TemplatePlaceholderPage: abort pending template search after adding template .. TemplatePlaceholderPage: abort pending

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: LinkCache: don't treat a link with a fragment as a selflink

2017-04-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347644 ) Change subject: LinkCache: don't treat a link with a fragment as a selflink .. LinkCache: don't treat a link with a fragment as a selflink

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Internal link context popup: selflinks still get link styling

2017-04-11 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347631 ) Change subject: Internal link context popup: selflinks still get link styling .. Internal link context popup: selflinks still get link

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ArticleTarget: building summary in source mode, strip links ...

2017-04-05 Thread DLynch (Code Review)
DLynch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346566 ) Change subject: ArticleTarget: building summary in source mode, strip links from section titles .. ArticleTarget: building summary in

  1   2   3   >