[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix position of ace tooltip

2017-03-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342871 ) Change subject: Fix position of ace tooltip .. Fix position of ace tooltip The floating tooltip breaks inside OOUI dialogs. In the

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Add custom messages for change descriptions

2017-03-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342834 ) Change subject: Add custom messages for change descriptions .. Add custom messages for change descriptions Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove MSIE from blacklist, already blacklisted upstream

2017-03-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342824 ) Change subject: Remove MSIE from blacklist, already blacklisted upstream .. Remove MSIE from blacklist, already blacklisted upstream We

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Refactor rect-from-element computation in FocusableNode into...

2017-03-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342814 ) Change subject: Refactor rect-from-element computation in FocusableNode into static method .. Refactor rect-from-element computation in

[MediaWiki-commits] [Gerrit] mediawiki...Blueprint[master]: Update VE fixes

2017-03-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342329 ) Change subject: Update VE fixes .. Update VE fixes Change-Id: Ibf47805e407fee0f4efe88abc3d8db417cfcc4d4 --- M resources/master.less 1

[MediaWiki-commits] [Gerrit] mediawiki...Blueprint[master]: build: Replace jshint with eslint and introduce stylelint

2017-03-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342328 ) Change subject: build: Replace jshint with eslint and introduce stylelint .. build: Replace jshint with eslint and introduce stylelint

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use words for describing notification counts in HTML text node

2017-03-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342327 ) Change subject: Use words for describing notification counts in HTML text node .. Use words for describing notification counts in HTML

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Allow edit sections outside of mw-body-content

2017-03-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342326 ) Change subject: Allow edit sections outside of mw-body-content .. Allow edit sections outside of mw-body-content Bug: T160269 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Move demo's qqx language option into the language dialog

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342237 ) Change subject: Move demo's qqx language option into the language dialog .. Move demo's qqx language option into the language dialog

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix cursor style on language search widget

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342236 ) Change subject: Fix cursor style on language search widget .. Fix cursor style on language search widget Since OO.ui.LabelWidgets

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove $returnFocusTo hack now null is supported upstream

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342227 ) Change subject: Remove $returnFocusTo hack now null is supported upstream .. Remove $returnFocusTo hack now null is supported upstream

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: PositionedTargetToolbar: Move code that assumes surface exis...

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342213 ) Change subject: PositionedTargetToolbar: Move code that assumes surface exists to after check .. PositionedTargetToolbar: Move code that

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Connect inputs to onChangeHandler

2017-03-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342195 ) Change subject: Connect inputs to onChangeHandler .. Connect inputs to onChangeHandler Bug: T160162 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: findText: Fix documentation and tests

2017-03-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342062 ) Change subject: findText: Fix documentation and tests .. findText: Fix documentation and tests * Update documentation * Actually re-run

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: FindAndReplace: Use Intl.Collator instead of localeCompare

2017-03-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342015 ) Change subject: FindAndReplace: Use Intl.Collator instead of localeCompare .. FindAndReplace: Use Intl.Collator instead of localeCompare

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use Intl.Collator for all searches if available

2017-03-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342016 ) Change subject: Use Intl.Collator for all searches if available .. Use Intl.Collator for all searches if available Fall back to simple

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Render self-links as , not

2017-03-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341775 ) Change subject: Render self-links as , not .. Render self-links as , not Logically depends on I558682c in core, but won't break without

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Allow links to be constructed with custom elements

2017-03-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341774 ) Change subject: Allow links to be constructed with custom elements .. Allow links to be constructed with custom elements Q: "When is a

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix load order of LangaugeContextItem

2017-03-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341771 ) Change subject: Fix load order of LangaugeContextItem .. Fix load order of LangaugeContextItem Ensure dm.LanguageAnnotation exists when

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Apex: Fix target margins

2017-03-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341205 ) Change subject: Apex: Fix target margins .. Apex: Fix target margins Apex is basically abandonware, so we should consider deleting this

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Add external classes to mw:ExtLinks in NWE preview

2017-03-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341204 ) Change subject: Add external classes to mw:ExtLinks in NWE preview .. Add external classes to mw:ExtLinks in NWE preview Bug: T153413

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Move heading, paragraph and editsection styles into mw-body-...

2017-03-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341203 ) Change subject: Move heading, paragraph and editsection styles into mw-body-content .. Move heading, paragraph and editsection styles

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add mw-body-content to indicators

2017-03-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341196 ) Change subject: Add mw-body-content to indicators .. Add mw-body-content to indicators Bug: T155863 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Comment Parsoid hacks as such

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341097 ) Change subject: Comment Parsoid hacks as such .. Comment Parsoid hacks as such Change-Id: I23fcc49031e3b34e5b83d7acea56845b325f3026 --- M

[MediaWiki-commits] [Gerrit] mediawiki...MonoBook[master]: Add mw-body-content to siteNotice

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341095 ) Change subject: Add mw-body-content to siteNotice .. Add mw-body-content to siteNotice Bug: T159578 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change mw-body ancestor selector to mw-body-content

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341073 ) Change subject: Change mw-body ancestor selector to mw-body-content .. Change mw-body ancestor selector to mw-body-content

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Change mw-body ancestor selector to mw-body-content

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341060 ) Change subject: Change mw-body ancestor selector to mw-body-content .. Change mw-body ancestor selector to mw-body-content Bug: T159578

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use mw-body-content instead of mw-body

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341045 ) Change subject: Use mw-body-content instead of mw-body .. Use mw-body-content instead of mw-body This ensures the styles are applied to

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Ensure del/ins tags encapsulate annotation changes

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341001 ) Change subject: DiffElement: Ensure del/ins tags encapsulate annotation changes .. DiffElement: Ensure del/ins tags encapsulate annotation

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Use a real ve.Range instead of a plain object

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340988 ) Change subject: DiffElement: Use a real ve.Range instead of a plain object .. DiffElement: Use a real ve.Range instead of a plain object

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Improve NWE new section styles

2017-03-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340962 ) Change subject: Improve NWE new section styles .. Improve NWE new section styles * Use for TextInputWidget to avoid duplicating skin

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: New editor switching widget

2017-03-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340741 ) Change subject: New editor switching widget .. New editor switching widget Change-Id: I5ed8ad37b6eac37a87310858d1ae34b6e2852145 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix switching widget when VE is not available

2017-03-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340740 ) Change subject: Fix switching widget when VE is not available .. Fix switching widget when VE is not available Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Measure box-shadow boders in pixels to avoid bl...

2017-03-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340716 ) Change subject: DiffElement: Measure box-shadow boders in pixels to avoid blurring .. DiffElement: Measure box-shadow boders in pixels to

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Allow a node change to be an attribute change *...

2017-03-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340715 ) Change subject: DiffElement: Allow a node change to be an attribute change *and* a linear diff .. DiffElement: Allow a node change to be

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: De-clutter left margin

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340647 ) Change subject: DiffElement: De-clutter left margin .. DiffElement: De-clutter left margin Remove blue border for modified sections, the

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Fix remaining class->data-attribute conversions

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340577 ) Change subject: DiffElement: Fix remaining class->data-attribute conversions .. DiffElement: Fix remaining class->data-attribute

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Use different technique for sidebar full height background

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340558 ) Change subject: Use different technique for sidebar full height background .. Use different technique for sidebar full height background

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Make dropdown button links full width

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340546 ) Change subject: Make dropdown button links full width .. Make dropdown button links full width They should be clickable across the width

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Load VE plugin modules

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340541 ) Change subject: Load VE plugin modules .. Load VE plugin modules While we don't (yet) support these in the UI, users would expect to be

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: stylelint: drop value-keyword-case and make a pass

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340535 ) Change subject: stylelint: drop value-keyword-case and make a pass .. stylelint: drop value-keyword-case and make a pass Add some

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: stylelint: drop selector-pseudo-element-colon-notation excep...

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340531 ) Change subject: stylelint: drop selector-pseudo-element-colon-notation exception and make pass .. stylelint: drop

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: VE: Don't load PRP target on all pages, just PRP pages.

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340501 ) Change subject: VE: Don't load PRP target on all pages, just PRP pages. .. VE: Don't load PRP target on all pages, just PRP pages.

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Cleanup DesktopTarget styles

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340497 ) Change subject: Cleanup DesktopTarget styles .. Cleanup DesktopTarget styles * Ensure DAT styles are fully scoped to DAT instances *

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Load mw core extensions through new module

2017-03-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340493 ) Change subject: Load mw core extensions through new module .. Load mw core extensions through new module Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move article edit switching tools to articleTarget module

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340440 ) Change subject: Move article edit switching tools to articleTarget module .. Move article edit switching tools to articleTarget module

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use more specific event name for switching editor from the t...

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340430 ) Change subject: Use more specific event name for switching editor from the toolbar .. Use more specific event name for switching editor

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use pencil icon for editor switcher dropdown

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340428 ) Change subject: Use pencil icon for editor switcher dropdown .. Use pencil icon for editor switcher dropdown Pencil is the icon we use

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move switching methods to ArticleTarget and fix in mobile

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340322 ) Change subject: Move switching methods to ArticleTarget and fix in mobile .. Move switching methods to ArticleTarget and fix in mobile

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use ems for mobile surface font sizes, and add top/bottom sp...

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340321 ) Change subject: Use ems for mobile surface font sizes, and add top/bottom spacing .. Use ems for mobile surface font sizes, and add

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use new editor switcher widget from VE

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340320 ) Change subject: Use new editor switcher widget from VE .. Use new editor switcher widget from VE Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove explicit setting of menu indicator in mobile

2017-02-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340315 ) Change subject: Remove explicit setting of menu indicator in mobile .. Remove explicit setting of menu indicator in mobile It is now

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: WIP diff attribute changes

2017-02-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340160 ) Change subject: WIP diff attribute changes .. WIP diff attribute changes Change-Id: I846bfaa42c855c4d206aaa1ec64edf279581eafd --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move modules loaded from DAT.init/TargetLoader to ResourceLo...

2017-02-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340137 ) Change subject: Move modules loaded from DAT.init/TargetLoader to ResourceLoader .. Move modules loaded from DAT.init/TargetLoader to

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use list tool group for editor switching

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339959 ) Change subject: Use list tool group for editor switching .. Use list tool group for editor switching Bug: T116417 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Tweak mw-ui padding to match oo-ui for buttons and text inputs

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339953 ) Change subject: Tweak mw-ui padding to match oo-ui for buttons and text inputs .. Tweak mw-ui padding to match oo-ui for buttons and text

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Follow-up I3dc3db6db: De-italicise surface placeholder

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339949 ) Change subject: Follow-up I3dc3db6db: De-italicise surface placeholder .. Follow-up I3dc3db6db: De-italicise surface placeholder

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Remove toolbar border (shadow) in monobook as well

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339948 ) Change subject: Remove toolbar border (shadow) in monobook as well .. Remove toolbar border (shadow) in monobook as well Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix padding of large inputs

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339947 ) Change subject: Fix padding of large inputs .. Fix padding of large inputs Change-Id: Ic8a7106db39f75d01e723e99bd4e87d63200208b --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: [PULL THROUGH] Diacritic insensitive search

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339933 ) Change subject: [PULL THROUGH] Diacritic insensitive search .. [PULL THROUGH] Diacritic insensitive search Bug: T154195 Depends-On:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Diacritic insensitive search in find & replace dialog

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339932 ) Change subject: Diacritic insensitive search in find & replace dialog .. Diacritic insensitive search in find & replace dialog Bug:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Icon for diacritic insensitive search

2017-02-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339931 ) Change subject: Icon for diacritic insensitive search .. Icon for diacritic insensitive search Bug: T154195 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Change pubkey for Ed Sanders

2017-02-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339468 ) Change subject: Change pubkey for Ed Sanders .. Change pubkey for Ed Sanders Change-Id: I86c6a4d9cce2db32457f081e2314e70354a8cc99 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Follow-up I96d2225: Adding white background color to framed ...

2017-02-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339402 ) Change subject: Follow-up I96d2225: Adding white background color to framed images in Parsoid .. Follow-up I96d2225: Adding white

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Allow uploading of dropped Blobs

2017-02-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339400 ) Change subject: Allow uploading of dropped Blobs .. Allow uploading of dropped Blobs Previous the media upload panel didn't support this.

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Fix documentation and parent constructor call

2017-02-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339210 ) Change subject: DiffElement: Fix documentation and parent constructor call .. DiffElement: Fix documentation and parent constructor call

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Avoid modifying class attributes on DM HTML

2017-02-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339211 ) Change subject: DiffElement: Avoid modifying class attributes on DM HTML .. DiffElement: Avoid modifying class attributes on DM HTML

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use node.get*Outer*Range() when splicing in removes

2017-02-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339184 ) Change subject: Use node.get*Outer*Range() when splicing in removes .. Use node.get*Outer*Range() when splicing in removes

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Build diff using raw DOM operations

2017-02-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339178 ) Change subject: DiffElement: Build diff using raw DOM operations .. DiffElement: Build diff using raw DOM operations The converter gives

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix adjacent input widget border radii

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338794 ) Change subject: Fix adjacent input widget border radii .. Fix adjacent input widget border radii This does not address the issue with

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Separate message boxes from round-corner input widget group

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338795 ) Change subject: Separate message boxes from round-corner input widget group .. Separate message boxes from round-corner input widget group

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Use new placeholder mixin

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338779 ) Change subject: Use new placeholder mixin .. Use new placeholder mixin Depends-On: I96686bb53cee1a833db8f4d0b691d5e4a1b82885 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Use new placeholder mixin

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338773 ) Change subject: Use new placeholder mixin .. Use new placeholder mixin Change-Id: Ib6437b13760e8c13d06927cb45ef674a5f301e35 Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Fix stylelint glob pattern

2017-02-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338771 ) Change subject: build: Fix stylelint glob pattern .. build: Fix stylelint glob pattern Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove used 'header' params from toolbar config

2017-02-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338637 ) Change subject: Remove used 'header' params from toolbar config .. Remove used 'header' params from toolbar config Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Strike through removed text

2017-02-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338619 ) Change subject: VisualDiff: Strike through removed text .. VisualDiff: Strike through removed text Bug: T152001 Change-Id:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Improve vertical alignment of button icons in MW

2017-02-18 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338542 ) Change subject: Improve vertical alignment of button icons in MW .. Improve vertical alignment of button icons in MW Bug: T158486

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use OO.ui.confrim for edit abandon message

2017-02-18 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338535 ) Change subject: Use OO.ui.confrim for edit abandon message .. Use OO.ui.confrim for edit abandon message Could potentially be upstreamed

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Don't allow slug buttons to take focus

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338275 ) Change subject: Don't allow slug buttons to take focus .. Don't allow slug buttons to take focus Bug: T158295 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Use important background colours to force override

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338103 ) Change subject: DiffElement: Use important background colours to force override .. DiffElement: Use important background colours to force

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Move standalone diff dialog into separate module

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338100 ) Change subject: Move standalone diff dialog into separate module .. Move standalone diff dialog into separate module Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Introduce visual differ

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338101 ) Change subject: Introduce visual differ .. Introduce visual differ Change-Id: I1297d0f4bb87e69be3b50220c1830a22dac1bbae --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use windowAction to open diff dialog in demo

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338099 ) Change subject: Use windowAction to open diff dialog in demo .. Use windowAction to open diff dialog in demo Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Increase margin on DiffElement

2017-02-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338093 ) Change subject: Increase margin on DiffElement .. Increase margin on DiffElement Change-Id: Ic0bbbdd86e35a0c232c1e9c444db9f12069354ea ---

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Upstream change to message 'summary-preview' from en.wiki

2017-02-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337606 ) Change subject: Upstream change to message 'summary-preview' from en.wiki .. Upstream change to message 'summary-preview' from en.wiki

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Fix vertical alignment of eye icon

2017-02-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337601 ) Change subject: Fix vertical alignment of eye icon .. Fix vertical alignment of eye icon Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Preview collapsible handles in tables

2017-02-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337561 ) Change subject: Preview collapsible handles in tables .. Preview collapsible handles in tables Use CSS :after content to avoids problems

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: build: Introduce stylelint

2017-02-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337418 ) Change subject: build: Introduce stylelint .. build: Introduce stylelint Change-Id: I7687435a9b027d7a9abba8ee9384e579a4b83e82 --- A

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: build: Replace jshint/jscs with eslint

2017-02-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337416 ) Change subject: build: Replace jshint/jscs with eslint .. build: Replace jshint/jscs with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTableDialog: Extend initial values to 'done' button behave...

2017-02-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337274 ) Change subject: MWTableDialog: Extend initial values to 'done' button behaves correctly .. MWTableDialog: Extend initial values to 'done'

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: TableDialog: Disable 'done' button when no changes made

2017-02-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337273 ) Change subject: TableDialog: Disable 'done' button when no changes made .. TableDialog: Disable 'done' button when no changes made

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWTableDialog: Inherit actions from core

2017-02-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337268 ) Change subject: MWTableDialog: Inherit actions from core .. MWTableDialog: Inherit actions from core Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ui.TableDialog: Add "Cancel" button

2017-02-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337267 ) Change subject: ve.ui.TableDialog: Add "Cancel" button .. ve.ui.TableDialog: Add "Cancel" button The dialog already supports cancelling

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Replace non-breaking spaces when pasting into source

2017-02-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336939 ) Change subject: Replace non-breaking spaces when pasting into source .. Replace non-breaking spaces when pasting into source Bug: T154382

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: Math symbols: Remove 'tex' when identical to 'insert'

2017-02-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336895 ) Change subject: Math symbols: Remove 'tex' when identical to 'insert' .. Math symbols: Remove 'tex' when identical to 'insert' Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Listen to mouseup events on documentNode for focus changes

2017-02-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336812 ) Change subject: Listen to mouseup events on documentNode for focus changes .. Listen to mouseup events on documentNode for focus changes

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SourceMode: Fix sanitization loop in plain text paste

2017-02-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336694 ) Change subject: SourceMode: Fix sanitization loop in plain text paste .. SourceMode: Fix sanitization loop in plain text paste Loop

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Stay in cell editing mode when pressing table inside a cell

2017-02-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336648 ) Change subject: Stay in cell editing mode when pressing table inside a cell .. Stay in cell editing mode when pressing table inside a cell

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Check for 'veaction' when clicking section edit links

2017-02-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336645 ) Change subject: Check for 'veaction' when clicking section edit links .. Check for 'veaction' when clicking section edit links Such as in

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Cache generated content request when inserting templates

2017-02-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336494 ) Change subject: Cache generated content request when inserting templates .. Cache generated content request when inserting templates We

<    4   5   6   7   8   9   10   11   12   13   >