[MediaWiki-commits] [Gerrit] Move remaining PHP DOM-based methods into SVGFile - change (mediawiki...TranslateSvg)

2015-08-02 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Move remaining PHP DOM-based methods into SVGFile .. Move remaining PHP DOM-based methods into SVGFile Add related tests (requires amending test SVG for

[MediaWiki-commits] [Gerrit] Implement tests for TranslateSvgUtils - change (mediawiki...TranslateSvg)

2015-08-01 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Implement tests for TranslateSvgUtils .. Implement tests for TranslateSvgUtils Slightly tidy to make sure param strings (faux templates) actually look

[MediaWiki-commits] [Gerrit] Add testImportTranslations() and testGetOnWikiLanguages() - change (mediawiki...TranslateSvg)

2015-08-01 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Add testImportTranslations() and testGetOnWikiLanguages() .. Add testImportTranslations() and testGetOnWikiLanguages() ...to SVGMessageGroup testing cycle.

[MediaWiki-commits] [Gerrit] Fiddle with makeTranslationReady() - change (mediawiki...TranslateSvg)

2015-08-01 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Fiddle with makeTranslationReady() .. Fiddle with makeTranslationReady() I'm not sure why this suddenly wasn't working as intended, but in any case

[MediaWiki-commits] [Gerrit] Add afterEditorShown hook - change (mediawiki...Translate)

2015-05-31 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/214921 Change subject: Add afterEditorShown hook .. Add afterEditorShown hook This allows extensions to hook in very late in the display process,

[MediaWiki-commits] [Gerrit] Add simple test for SVGFile::newFromMessageGroup() - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213791 Change subject: Add simple test for SVGFile::newFromMessageGroup() .. Add simple test for SVGFile::newFromMessageGroup() Change-Id:

[MediaWiki-commits] [Gerrit] Implement tests for TranslateSvgUtils - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213789 Change subject: Implement tests for TranslateSvgUtils .. Implement tests for TranslateSvgUtils Slightly tidy to make sure param strings

[MediaWiki-commits] [Gerrit] Create extension.json using maintenance/ConvertExtensionToRe... - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213790 Change subject: Create extension.json using maintenance/ConvertExtensionToRegistration.php .. Create extension.json using

[MediaWiki-commits] [Gerrit] Add tests for each code path in makeTranslationReady - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213798 Change subject: Add tests for each code path in makeTranslationReady .. Add tests for each code path in makeTranslationReady Implement

[MediaWiki-commits] [Gerrit] Overhaul replaceIndicesRecursive, adding tests - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213799 Change subject: Overhaul replaceIndicesRecursive, adding tests .. Overhaul replaceIndicesRecursive, adding tests Despite the fact that I

[MediaWiki-commits] [Gerrit] Fiddle with makeTranslationReady() - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213797 Change subject: Fiddle with makeTranslationReady() .. Fiddle with makeTranslationReady() I'm not sure why this suddenly wasn't working as

[MediaWiki-commits] [Gerrit] Extract reorderTexts() and add an extra invocation - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Extract reorderTexts() and add an extra invocation .. Extract reorderTexts() and add an extra invocation Extra invocation means roundtripping shouldn't

[MediaWiki-commits] [Gerrit] Add test for hasTextContent - change (mediawiki...TranslateSvg)

2015-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/213801 Change subject: Add test for hasTextContent .. Add test for hasTextContent Change-Id: I0a61984f95934aa4a2d78300ee33a50fc60d8a4d --- M

[MediaWiki-commits] [Gerrit] Move remaining PHP DOM-based methods into SVGFile - change (mediawiki...TranslateSvg)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181566 Change subject: Move remaining PHP DOM-based methods into SVGFile .. Move remaining PHP DOM-based methods into SVGFile Change-Id:

[MediaWiki-commits] [Gerrit] Fix redirect in SpecialTranslateNewSvg - change (mediawiki...TranslateSvg)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181567 Change subject: Fix redirect in SpecialTranslateNewSvg .. Fix redirect in SpecialTranslateNewSvg Change-Id:

[MediaWiki-commits] [Gerrit] Split off TranslateSvgUtils::isSupportedAttribute for readab... - change (mediawiki...TranslateSvg)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181568 Change subject: Split off TranslateSvgUtils::isSupportedAttribute for readability .. Split off TranslateSvgUtils::isSupportedAttribute for

[MediaWiki-commits] [Gerrit] Fix unit tests - change (mediawiki...TranslateSvg)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181569 Change subject: Fix unit tests .. Fix unit tests * Make one test platform independent (re: line-endings) * Flush database writes later to

[MediaWiki-commits] [Gerrit] Fix redirect in SpecialTranslateNewSvg - change (mediawiki...TranslateSvg)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Fix redirect in SpecialTranslateNewSvg .. Fix redirect in SpecialTranslateNewSvg Change-Id: Ic4366f5bf8a3c993fe0eebdbaaef9747fb241b27 --- M

[MediaWiki-commits] [Gerrit] Translate depends on ULS which depends on EventLogging... - change (integration/config)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181574 Change subject: Translate depends on ULS which depends on EventLogging... .. Translate depends on ULS which depends on EventLogging...

[MediaWiki-commits] [Gerrit] Modify TranslateTranslationAids so it does something useful - change (mediawiki...Translate)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181625 Change subject: Modify TranslateTranslationAids so it does something useful .. Modify TranslateTranslationAids so it does something useful

[MediaWiki-commits] [Gerrit] Change default to UnsupportedTranslationAid - change (mediawiki...Translate)

2014-12-23 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/181676 Change subject: Change default to UnsupportedTranslationAid .. Change default to UnsupportedTranslationAid This ensures that new

[MediaWiki-commits] [Gerrit] Move language splitting logic from analyse() to makeTranslat... - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Move language splitting logic from analyse() to makeTranslationReady() .. Move language splitting logic from analyse() to makeTranslationReady() Although

[MediaWiki-commits] [Gerrit] Stop implicitly testing group name normalisation - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/178082 Change subject: Stop implicitly testing group name normalisation .. Stop implicitly testing group name normalisation Mental overhead was

[MediaWiki-commits] [Gerrit] Reorder tearDownAfterClass() to work around $title destruction - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/178083 Change subject: Reorder tearDownAfterClass() to work around $title destruction .. Reorder tearDownAfterClass() to work around $title

[MediaWiki-commits] [Gerrit] Stop implicitly testing group name normalisation - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Stop implicitly testing group name normalisation .. Stop implicitly testing group name normalisation Mental overhead was getting unbearable, should be

[MediaWiki-commits] [Gerrit] Reorder tearDownAfterClass() to work around $title destruction - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Reorder tearDownAfterClass() to work around $title destruction .. Reorder tearDownAfterClass() to work around $title destruction Functions like

[MediaWiki-commits] [Gerrit] Add extra parser tests for SVGMessageGroup and SVGFile classes - change (mediawiki...TranslateSvg)

2014-12-07 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Add extra parser tests for SVGMessageGroup and SVGFile classes .. Add extra parser tests for SVGMessageGroup and SVGFile classes Change-Id:

[MediaWiki-commits] [Gerrit] Phase out use of MessageGroupStats in favour of more brutal ... - change (mediawiki...TranslateSvg)

2014-08-28 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156885 Change subject: Phase out use of MessageGroupStats in favour of more brutal methods .. Phase out use of MessageGroupStats in favour of

[MediaWiki-commits] [Gerrit] Create TranslateSvgUtils::langCodeToOs() and osTolangCode() - change (mediawiki...TranslateSvg)

2014-08-28 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Create TranslateSvgUtils::langCodeToOs() and osTolangCode() .. Create TranslateSvgUtils::langCodeToOs() and osTolangCode() Although not particularly

[MediaWiki-commits] [Gerrit] Remove SVGFormatReader class and distribute its methods - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156129 Change subject: Remove SVGFormatReader class and distribute its methods .. Remove SVGFormatReader class and distribute its methods *

[MediaWiki-commits] [Gerrit] Create TranslateSvgUtils::langCodeToOs() and osTolangCode() - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156130 Change subject: Create TranslateSvgUtils::langCodeToOs() and osTolangCode() .. Create TranslateSvgUtils::langCodeToOs() and osTolangCode()

[MediaWiki-commits] [Gerrit] Create TranslateSvgUtils::fetchLanguageName() - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156131 Change subject: Create TranslateSvgUtils::fetchLanguageName() .. Create TranslateSvgUtils::fetchLanguageName() Wrapper function providing

[MediaWiki-commits] [Gerrit] Move language splitting logic from analyse() to makeTranslat... - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156133 Change subject: Move language splitting logic from analyse() to makeTranslationReady() .. Move language splitting logic from analyse() to

[MediaWiki-commits] [Gerrit] Add extra parser tests for SVGMessageGroup and SVGFile classes - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156134 Change subject: Add extra parser tests for SVGMessageGroup and SVGFile classes .. Add extra parser tests for SVGMessageGroup and SVGFile

[MediaWiki-commits] [Gerrit] Whitespace fixes and rm debug code - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156132 Change subject: Whitespace fixes and rm debug code .. Whitespace fixes and rm debug code Change-Id:

[MediaWiki-commits] [Gerrit] Remove SVGFormatReader class and distribute its methods - change (mediawiki...TranslateSvg)

2014-08-25 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Remove SVGFormatReader class and distribute its methods .. Remove SVGFormatReader class and distribute its methods * Anything to do with the DOM goes into

[MediaWiki-commits] [Gerrit] Documentation updates (move to newer format) - change (mediawiki...TranslateSvg)

2014-08-24 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156059 Change subject: Documentation updates (move to newer format) .. Documentation updates (move to newer format) Change-Id:

[MediaWiki-commits] [Gerrit] Documentation updates (move to newer format) - change (mediawiki...TranslateSvg)

2014-08-24 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Documentation updates (move to newer format) .. Documentation updates (move to newer format) Change-Id: Ic21317e903526015d98f8884d9e59936535c1b73 --- M

[MediaWiki-commits] [Gerrit] Migrate more instances of confusing term overrides - change (mediawiki...TranslateSvg)

2014-08-24 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/156061 Change subject: Migrate more instances of confusing term overrides .. Migrate more instances of confusing term overrides ...to more

[MediaWiki-commits] [Gerrit] Migrate more instances of confusing term overrides - change (mediawiki...TranslateSvg)

2014-08-24 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Migrate more instances of confusing term overrides .. Migrate more instances of confusing term overrides ...to more sensible term in-progress translations.

[MediaWiki-commits] [Gerrit] Start PHPUnit testing framework - change (mediawiki...TranslateSvg)

2014-08-22 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Start PHPUnit testing framework .. Start PHPUnit testing framework * Create TranslateSvgTestCase to handle shared content * Use TranslateSvgTestCase to

[MediaWiki-commits] [Gerrit] Use and test SVGMessageGroup::register - change (mediawiki...TranslateSvg)

2014-08-22 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Use and test SVGMessageGroup::register .. Use and test SVGMessageGroup::register Code added in previous commit I7842792 but was previously unused pending

[MediaWiki-commits] [Gerrit] Make SVGMessageGroup::register cheap - change (mediawiki...TranslateSvg)

2014-08-22 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Make SVGMessageGroup::register cheap .. Make SVGMessageGroup::register cheap More specifically, use $dbw-affectedRows() to check whether the MessageIndex

[MediaWiki-commits] [Gerrit] Add testImportTranslations() and testGetOnWikiLanguages() - change (mediawiki...TranslateSvg)

2014-08-22 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/155733 Change subject: Add testImportTranslations() and testGetOnWikiLanguages() .. Add testImportTranslations() and testGetOnWikiLanguages()

[MediaWiki-commits] [Gerrit] Abstract and hollow out most of addSVGGroup() - change (mediawiki...TranslateSvg)

2014-08-10 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Abstract and hollow out most of addSVGGroup() .. Abstract and hollow out most of addSVGGroup() Change-Id: I7842792c092770463d63c323469e6c376a7f2502 --- M

[MediaWiki-commits] [Gerrit] Implement caching for getOnWikiTranslations and tidy up nome... - change (mediawiki...TranslateSvg)

2014-08-10 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Implement caching for getOnWikiTranslations and tidy up nomenclature .. Implement caching for getOnWikiTranslations and tidy up nomenclature Change-Id:

[MediaWiki-commits] [Gerrit] Fix logic error in SVGFormatReader - change (mediawiki...TranslateSvg)

2014-08-10 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Fix logic error in SVGFormatReader .. Fix logic error in SVGFormatReader Change-Id: Ic676ae436af44d0ff86de9346d8221fdfc18ba76 --- M SVGFormatReader.php 1

[MediaWiki-commits] [Gerrit] Use and test SVGMessageGroup::register - change (mediawiki...TranslateSvg)

2014-08-10 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153332 Change subject: Use and test SVGMessageGroup::register .. Use and test SVGMessageGroup::register Change-Id:

[MediaWiki-commits] [Gerrit] Make SVGMessageGroup::register cheap - change (mediawiki...TranslateSvg)

2014-08-10 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153331 Change subject: Make SVGMessageGroup::register cheap .. Make SVGMessageGroup::register cheap More specifically, use $dbw-affectedRows() to

[MediaWiki-commits] [Gerrit] Migrate doEdit() to doEditContent() - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153043 Change subject: Migrate doEdit() to doEditContent() .. Migrate doEdit() to doEditContent() Change-Id:

[MediaWiki-commits] [Gerrit] Fix logic error in SVGFormatReader - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153045 Change subject: Fix logic error in SVGFormatReader .. Fix logic error in SVGFormatReader Change-Id:

[MediaWiki-commits] [Gerrit] Implement caching for getOnWikiTranslations and tidy up nome... - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153044 Change subject: Implement caching for getOnWikiTranslations and tidy up nomenclature .. Implement caching for getOnWikiTranslations and

[MediaWiki-commits] [Gerrit] Add some extra error checks - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153048 Change subject: Add some extra error checks .. Add some extra error checks Change-Id: I78184dd9a99d9a399357420c247721cb5b4019f1 --- M

[MediaWiki-commits] [Gerrit] Abstract and hollow out most of addSVGGroup() - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153047 Change subject: Abstract and hollow out most of addSVGGroup() .. Abstract and hollow out most of addSVGGroup() Change-Id:

[MediaWiki-commits] [Gerrit] Accept comma as switch delimiter - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153046 Change subject: Accept comma as switch delimiter .. Accept comma as switch delimiter Change-Id: I7b4ac17003cf65d30e348af9476a026372ecf370

[MediaWiki-commits] [Gerrit] Start PHPUnit testing framework - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153049 Change subject: Start PHPUnit testing framework .. Start PHPUnit testing framework Change-Id: I3495d8f719616d60f8193bac8a54dbe98722ea17

[MediaWiki-commits] [Gerrit] Rename some badly named properties - change (mediawiki...TranslateSvg)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153061 Change subject: Rename some badly named properties .. Rename some badly named properties Change-Id:

[MediaWiki-commits] [Gerrit] Add separate entry for TranslateSVG to note dependency - change (integration/jenkins-job-builder-config)

2014-08-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/153130 Change subject: Add separate entry for TranslateSVG to note dependency .. Add separate entry for TranslateSVG to note dependency

[MediaWiki-commits] [Gerrit] Cast Language to language code (fix associated fatal) - change (mediawiki...TranslateSvg)

2014-07-06 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/144408 Change subject: Cast Language to language code (fix associated fatal) .. Cast Language to language code (fix associated fatal) Change-Id:

[MediaWiki-commits] [Gerrit] Cast Language to language code (fix associated fatal) - change (mediawiki...TranslateSvg)

2014-07-06 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Cast Language to language code (fix associated fatal) .. Cast Language to language code (fix associated fatal) Change-Id:

[MediaWiki-commits] [Gerrit] Use PHPStorm to reformat the PHP files - change (mediawiki...TranslateSvg)

2014-07-06 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Use PHPStorm to reformat the PHP files .. Use PHPStorm to reformat the PHP files In line with MediaWiki code style. Mostly a question of getting rid of

[MediaWiki-commits] [Gerrit] Fix encoding - change (mediawiki...TranslateSvg)

2014-03-11 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Fix encoding .. Fix encoding Change-Id: If9b2f6397457f27d5336127e08e615a09b2cc7d8 --- M SVGFormatWriter.php 1 file changed, 1 insertion(+), 1 deletion(-)

[MediaWiki-commits] [Gerrit] Generalise filename-matching in mediawiki.Title.newFromImg() - change (mediawiki/core)

2013-10-21 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/90897 Change subject: Generalise filename-matching in mediawiki.Title.newFromImg() .. Generalise filename-matching in

[MediaWiki-commits] [Gerrit] Update thumb.php to handle langXX-type thumbnail names - change (mediawiki/core)

2013-06-16 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/69019 Change subject: Update thumb.php to handle langXX-type thumbnail names .. Update thumb.php to handle langXX-type thumbnail names See

[MediaWiki-commits] [Gerrit] Tweak file handling code, particularly to improve performance - change (mediawiki...TranslateSvg)

2013-05-27 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Tweak file handling code, particularly to improve performance .. Tweak file handling code, particularly to improve performance Tidy up variables and use

[MediaWiki-commits] [Gerrit] Support non-duplicative sublocales (pt_BR, en_GB, etc.) - change (mediawiki...TranslateSvg)

2013-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Support non-duplicative sublocales (pt_BR, en_GB, etc.) .. Support non-duplicative sublocales (pt_BR, en_GB, etc.) Two parts: (1) Read support (2) Write

[MediaWiki-commits] [Gerrit] Add and use wgFileTranslationStarted to improve user experience - change (mediawiki...TranslateSvg)

2013-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65628 Change subject: Add and use wgFileTranslationStarted to improve user experience .. Add and use wgFileTranslationStarted to improve user

[MediaWiki-commits] [Gerrit] Add and use wgFileTranslationStarted to improve user experience - change (mediawiki...TranslateSvg)

2013-05-26 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Add and use wgFileTranslationStarted to improve user experience .. Add and use wgFileTranslationStarted to improve user experience Change-Id:

[MediaWiki-commits] [Gerrit] Tweak file handling code, particularly to improve performance - change (mediawiki...TranslateSvg)

2013-05-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65458 Change subject: Tweak file handling code, particularly to improve performance .. Tweak file handling code, particularly to improve

[MediaWiki-commits] [Gerrit] Support non-duplicative sublocales (pt_BR, en_GB, etc.) - change (mediawiki...TranslateSvg)

2013-05-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65460 Change subject: Support non-duplicative sublocales (pt_BR, en_GB, etc.) .. Support non-duplicative sublocales (pt_BR, en_GB, etc.) Two

[MediaWiki-commits] [Gerrit] Upgrade TranslateSvg for use with TUX - change (mediawiki...TranslateSvg)

2013-05-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65462 Change subject: Upgrade TranslateSvg for use with TUX .. Upgrade TranslateSvg for use with TUX Add two translation aids (properties and

[MediaWiki-commits] [Gerrit] Add loading spinner and tweak display time. - change (mediawiki...TranslateSvg)

2013-05-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65464 Change subject: Add loading spinner and tweak display time. .. Add loading spinner and tweak display time. Uses jquery.spinner methods.

[MediaWiki-commits] [Gerrit] Tidy and miscellaneous bugfix - change (mediawiki...TranslateSvg)

2013-05-25 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65466 Change subject: Tidy and miscellaneous bugfix .. Tidy and miscellaneous bugfix Change-Id: I262c6e1d05383657fec34de61cfa85288ed21449 --- M

[MediaWiki-commits] [Gerrit] Move dependency on ext.translateHooks to base module - change (mediawiki...Translate)

2013-05-24 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65338 Change subject: Move dependency on ext.translateHooks to base module .. Move dependency on ext.translateHooks to base module The

[MediaWiki-commits] [Gerrit] Reimplement beforeSubmit, afterSubmit and afterRegisterFeatu... - change (mediawiki...Translate)

2013-05-24 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65339 Change subject: Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures hooks .. Reimplement beforeSubmit, afterSubmit and

[MediaWiki-commits] [Gerrit] Readd formatMessageBeforeTable hook - change (mediawiki...Translate)

2013-03-31 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/56882 Change subject: Readd formatMessageBeforeTable hook .. Readd formatMessageBeforeTable hook The hook has a PHP variant in MessageTable.php,

[MediaWiki-commits] [Gerrit] Make it possible to use a custom selection of translation aids. - change (mediawiki...Translate)

2013-03-29 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/56622 Change subject: Make it possible to use a custom selection of translation aids. .. Make it possible to use a custom selection of

[MediaWiki-commits] [Gerrit] Stop PHPStorm hating me - change (mediawiki...TranslateSvg)

2013-03-21 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/55081 Change subject: Stop PHPStorm hating me .. Stop PHPStorm hating me Mostly docs changes and type hinting. Also some more substantive

[MediaWiki-commits] [Gerrit] Provide helper links on file description pages. - change (mediawiki...TranslateSvg)

2013-03-21 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Provide helper links on file description pages. .. Provide helper links on file description pages. These come in a few different flavours: no translations,

[MediaWiki-commits] [Gerrit] Stop PHPStorm hating me - change (mediawiki...TranslateSvg)

2013-03-21 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Stop PHPStorm hating me .. Stop PHPStorm hating me Mostly docs changes and type hinting. Also some more substantive changes, but only really of the tweak

[MediaWiki-commits] [Gerrit] Miscellaneous bugfixes and amendments. - change (mediawiki...TranslateSvg)

2013-03-21 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. https://gerrit.wikimedia.org/r/55094 Change subject: Miscellaneous bugfixes and amendments. .. Miscellaneous bugfixes and amendments. Change-Id:

[MediaWiki-commits] [Gerrit] Miscellaneous bugfixes and amendments. - change (mediawiki...TranslateSvg)

2013-03-21 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Miscellaneous bugfixes and amendments. .. Miscellaneous bugfixes and amendments. Change-Id: I8a43465340e30ec256498372c36bc59180c16563 --- M

[MediaWiki-commits] [Gerrit] Followup I90849cd3: small logic fixes and improvements - change (mediawiki...TranslateSvg[master])

2013-01-02 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Followup I90849cd3: small logic fixes and improvements .. Followup I90849cd3: small logic fixes and improvements Specifically, fix invocation of $dbr-select, avoid

[MediaWiki-commits] [Gerrit] Followup I90849cd3: small logic fixes and improvements - change (mediawiki...TranslateSvg[master])

2013-01-02 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Followup I90849cd3: small logic fixes and improvements .. Followup I90849cd3: small logic fixes and improvements Specifically, fix invocation of

[MediaWiki-commits] [Gerrit] Add Special:TranslateNewSvg - change (mediawiki...TranslateSvg[master])

2013-01-01 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Add Special:TranslateNewSvg .. Add Special:TranslateNewSvg The special page allows user to select the source language, then import it (register it for

[MediaWiki-commits] [Gerrit] (bug #43509) Special:Whatlinkshere pagination broken - change (mediawiki/core[master])

2012-12-30 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: (bug #43509) Special:Whatlinkshere pagination broken .. (bug #43509) Special:Whatlinkshere pagination broken Resolve by switching from a from/back system to an

[MediaWiki-commits] [Gerrit] Use ul,li in search suggestions instead of endless div... - change (mediawiki/core[master])

2012-12-29 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Use ul,li in search suggestions instead of endless divs. .. Use ul,li in search suggestions instead of endless divs. It's more semantic, and, well, sensible.

[MediaWiki-commits] [Gerrit] [DO NOT MERGE] Rough and ready proof of concept for search s... - change (mediawiki/core[master])

2012-12-29 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: [DO NOT MERGE] Rough and ready proof of concept for search suggestions .. [DO NOT MERGE] Rough and ready proof of concept for search suggestions For MatmaRex's

[MediaWiki-commits] [Gerrit] Make the PNG thumbnail update live - change (mediawiki...TranslateSvg[master])

2012-12-28 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Make the PNG thumbnail update live .. Make the PNG thumbnail update live A live-updated thumbnail allows users to perfect the formatting of translated

[MediaWiki-commits] [Gerrit] Bugfix missing backslash, private-public function, misc - change (mediawiki...TranslateSvg[master])

2012-12-19 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Bugfix missing backslash, private-public function, misc .. Bugfix missing backslash, private-public function, misc Change-Id:

[MediaWiki-commits] [Gerrit] Bugfix missing backslash, private-public function, misc - change (mediawiki...TranslateSvg[master])

2012-12-19 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Bugfix missing backslash, private-public function, misc .. Bugfix missing backslash, private-public function, misc Change-Id:

[MediaWiki-commits] [Gerrit] Commit ExportSVGMessagesTask and SVGFormatWriter classes - change (mediawiki...TranslateSvg[master])

2012-12-18 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Commit ExportSVGMessagesTask and SVGFormatWriter classes .. Commit ExportSVGMessagesTask and SVGFormatWriter classes Together, these provide export

[MediaWiki-commits] [Gerrit] ApiGroupReview: Protect against spaces in example group name - change (mediawiki...Translate[master])

2012-12-18 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: ApiGroupReview: Protect against spaces in example group name .. ApiGroupReview: Protect against spaces in example group name Replace spaces with underscores to

[MediaWiki-commits] [Gerrit] (bug #20789) What links here pager falsely says No pages li... - change (mediawiki/core[master])

2012-12-09 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: (bug #20789) What links here pager falsely says No pages link to .. (bug #20789) What links here pager falsely says No pages link to Create some (4) new messages

[MediaWiki-commits] [Gerrit] Rectify missing dependency on mediawiki.Uri - change (mediawiki...Translate[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Rectify missing dependency on mediawiki.Uri .. Rectify missing dependency on mediawiki.Uri Change-Id: Ib39f8ed59e0626bb4c2a549338a018b080e89d4c --- M Translate.php

[MediaWiki-commits] [Gerrit] Fix simple but deadly logic error - change (mediawiki...TranslateSvg[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Fix simple but deadly logic error .. Fix simple but deadly logic error Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313 --- M TranslateSvgHooks.php 1 file

[MediaWiki-commits] [Gerrit] Fix simple but deadly logic error - change (mediawiki...TranslateSvg[master])

2012-12-08 Thread Jarry1250 (Code Review)
Jarry1250 has submitted this change and it was merged. Change subject: Fix simple but deadly logic error .. Fix simple but deadly logic error Change-Id: I586bc8995f4016765991aa53ccd40f330aabd313 --- M TranslateSvgHooks.php 1

[MediaWiki-commits] [Gerrit] (bug #19185) Don't display p-personal if it contains no link... - change (mediawiki/core[master])

2012-12-06 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: (bug #19185) Don't display p-personal if it contains no links. .. (bug #19185) Don't display p-personal if it contains no links. Also tidy up with the weird

[MediaWiki-commits] [Gerrit] Add librsvg to contint puppet manifest - change (operations/puppet[production])

2012-12-03 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Add librsvg to contint puppet manifest .. Add librsvg to contint puppet manifest Having librsvg on gallium and/or any other continuious integration servers allows

[MediaWiki-commits] [Gerrit] Followup I15843fab: don't show page=1 in file link - change (mediawiki/core[master])

2012-10-17 Thread Jarry1250 (Code Review)
Jarry1250 has uploaded a new change for review. Change subject: Followup I15843fab: don't show page=1 in file link .. Followup I15843fab: don't show page=1 in file link By standardising the file parameters were handed around,

  1   2   >