[MediaWiki-commits] [Gerrit] Code style imporvements in TypeCheckerHelper - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229640 Change subject: Code style imporvements in TypeCheckerHelper .. Code style imporvements in TypeCheckerHelper Change-Id:

[MediaWiki-commits] [Gerrit] Add missing type hint in UpdateConstraintsTable - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229647 Change subject: Add missing type hint in UpdateConstraintsTable .. Add missing type hint in UpdateConstraintsTable Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead parameter - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229646 Change subject: Remove dead parameter .. Remove dead parameter Change-Id: I9f3d749d6c92bdcc2b4047223fdfe5e100b4b9ca --- M

[MediaWiki-commits] [Gerrit] Improve type resolving in SpecialViolationsPage - change (mediawiki...WikibaseQuality)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229636 Change subject: Improve type resolving in SpecialViolationsPage .. Improve type resolving in SpecialViolationsPage Change-Id:

[MediaWiki-commits] [Gerrit] Split code added to method off into its own method - change (mediawiki...Wikibase)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/230041 Change subject: Split code added to method off into its own method .. Split code added to method off into its own method Change-Id:

[MediaWiki-commits] [Gerrit] Add composer cs command - change (mediawiki...Wikibase)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229632 Change subject: Add composer cs command .. Add composer cs command We have this in several other repos, and this is something we can

[MediaWiki-commits] [Gerrit] Improve type hints in ConnectionCheckerHelper - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229637 Change subject: Improve type hints in ConnectionCheckerHelper .. Improve type hints in ConnectionCheckerHelper Change-Id:

[MediaWiki-commits] [Gerrit] Improve formatting in entry point - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229643 Change subject: Improve formatting in entry point .. Improve formatting in entry point Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup in HtmlTableBuilder - change (mediawiki...WikibaseQuality)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229634 Change subject: Cleanup in HtmlTableBuilder .. Cleanup in HtmlTableBuilder Change-Id: I96710993b5b24ecd5e184fb5cc1469af545a8d4b --- M

[MediaWiki-commits] [Gerrit] Fix wrong type hint - change (mediawiki...WikibaseQuality)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229635 Change subject: Fix wrong type hint .. Fix wrong type hint Change-Id: I51617fdea017510c95f8c3e6398bd459214f67b5 --- M

[MediaWiki-commits] [Gerrit] Remove broken git repo ref - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229645 Change subject: Remove broken git repo ref .. Remove broken git repo ref Change-Id: I558fb4c476c2c821c6b35445b655817eaba32c59 --- M

[MediaWiki-commits] [Gerrit] Remove dead field - change (mediawiki...WikibaseQuality)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229633 Change subject: Remove dead field .. Remove dead field Change-Id: I6360842dafa39dca20d7bd1d272d1b6fd124874a --- M

[MediaWiki-commits] [Gerrit] Improve type hints in EvaluateConstraintReportJobService - change (mediawiki...WikibaseQualityConstraints)

2015-08-06 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229642 Change subject: Improve type hints in EvaluateConstraintReportJobService .. Improve type hints in EvaluateConstraintReportJobService

[MediaWiki-commits] [Gerrit] Simplify DataValueFactory and remove dead code - change (mediawiki...Wikibase)

2015-08-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229327 Change subject: Simplify DataValueFactory and remove dead code .. Simplify DataValueFactory and remove dead code Change-Id:

[MediaWiki-commits] [Gerrit] Optimized Wikibase Client imports - change (mediawiki...Wikibase)

2015-08-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229625 Change subject: Optimized Wikibase Client imports .. Optimized Wikibase Client imports Change-Id:

[MediaWiki-commits] [Gerrit] Make protected fields private - change (mediawiki...Wikibase)

2015-08-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229626 Change subject: Make protected fields private .. Make protected fields private Change-Id: I1f865a3c3e13a30b133df539ebdef08145fc6f44

[MediaWiki-commits] [Gerrit] Optimized imports of repo tests - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229315 Change subject: Optimized imports of repo tests .. Optimized imports of repo tests Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead import in GetClaimsTest - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229316 Change subject: Remove dead import in GetClaimsTest .. Remove dead import in GetClaimsTest Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code in GetClaimsTest - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229317 Change subject: Remove dead code in GetClaimsTest .. Remove dead code in GetClaimsTest Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code in getTermIndexEntry - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229318 Change subject: Remove dead code in getTermIndexEntry .. Remove dead code in getTermIndexEntry Change-Id:

[MediaWiki-commits] [Gerrit] Optimize lib tests imports - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229320 Change subject: Optimize lib tests imports .. Optimize lib tests imports Change-Id: Ic4ee321a1e6dfd2e72bc794a0cefe2b066014ff3 --- M

[MediaWiki-commits] [Gerrit] Delete deleteAllData :( - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229321 Change subject: Delete deleteAllData :( .. Delete deleteAllData :( Not 100% sure it is no longer used, though it certainly is no

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229310 Change subject: Remove dead code .. Remove dead code Change-Id: I6da1359b5a86fcbb732112016cae7e8847a5f04c --- M

[MediaWiki-commits] [Gerrit] Remove serialization compat code - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229312 Change subject: Remove serialization compat code .. Remove serialization compat code If I'm not mistaken, this was added to be able

[MediaWiki-commits] [Gerrit] Remove usage of deprecated method in ItemSearchTextGenerator - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229311 Change subject: Remove usage of deprecated method in ItemSearchTextGenerator .. Remove usage of deprecated method in

[MediaWiki-commits] [Gerrit] Resolve type conflict in ItemMergeInteractor - change (mediawiki...Wikibase)

2015-08-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229314 Change subject: Resolve type conflict in ItemMergeInteractor .. Resolve type conflict in ItemMergeInteractor Change-Id:

[MediaWiki-commits] [Gerrit] Fix type mismatch in newTermSearchInteractor - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229053 Change subject: Fix type mismatch in newTermSearchInteractor .. Fix type mismatch in newTermSearchInteractor Change-Id:

[MediaWiki-commits] [Gerrit] Stop using Entity in SpecialModifyTerm::getValue - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229049 Change subject: Stop using Entity in SpecialModifyTerm::getValue .. Stop using Entity in SpecialModifyTerm::getValue Change-Id:

[MediaWiki-commits] [Gerrit] Claim - Statement in RemoveQualifiers - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229051 Change subject: Claim - Statement in RemoveQualifiers .. Claim - Statement in RemoveQualifiers Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused arguments. - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229041 Change subject: Remove unused arguments. .. Remove unused arguments. Change-Id: I7aa10f71fb03915d1cf6732b3a38d7e33db55774 --- M

[MediaWiki-commits] [Gerrit] Add missing imports to OutputPageEntityIdReader - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229045 Change subject: Add missing imports to OutputPageEntityIdReader .. Add missing imports to OutputPageEntityIdReader Change-Id:

[MediaWiki-commits] [Gerrit] Remove broken imports - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229044 Change subject: Remove broken imports .. Remove broken imports Change-Id: I1b44a424596f6645e0b3db4d5e7ad043c617a180 --- M

[MediaWiki-commits] [Gerrit] Explicitly define field in SpecialNewEntity - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229046 Change subject: Explicitly define field in SpecialNewEntity .. Explicitly define field in SpecialNewEntity Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead arguments - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229057 Change subject: Remove dead arguments .. Remove dead arguments Change-Id: I88f01517a1cb2389f60310097a160df8d4442b59 --- M

[MediaWiki-commits] [Gerrit] Claim - Statement in ResultBuilder - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/229052 Change subject: Claim - Statement in ResultBuilder .. Claim - Statement in ResultBuilder Change-Id:

[MediaWiki-commits] [Gerrit] Use EntityDocument rather than Entity - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228870 Change subject: Use EntityDocument rather than Entity .. Use EntityDocument rather than Entity Change-Id:

[MediaWiki-commits] [Gerrit] Simple simplifications in ClientEntitySerializer - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228885 Change subject: Simple simplifications in ClientEntitySerializer .. Simple simplifications in ClientEntitySerializer Change-Id:

[MediaWiki-commits] [Gerrit] Extract method in EntityAccessor - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228887 Change subject: Extract method in EntityAccessor .. Extract method in EntityAccessor Change-Id:

[MediaWiki-commits] [Gerrit] Use correct version ranges for the dependencies - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228868 Change subject: Use correct version ranges for the dependencies .. Use correct version ranges for the dependencies Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228894 Change subject: Remove dead code .. Remove dead code Change-Id: I567da42fd1a83f8a085db8c98d13d256acbbf05b --- M

[MediaWiki-commits] [Gerrit] Remove file alias for dispatchChanges maintenance script - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228901 Change subject: Remove file alias for dispatchChanges maintenance script .. Remove file alias for dispatchChanges maintenance script

[MediaWiki-commits] [Gerrit] Remove unused param in JulianDateTimeValueCleaner - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228966 Change subject: Remove unused param in JulianDateTimeValueCleaner .. Remove unused param in JulianDateTimeValueCleaner Change-Id:

[MediaWiki-commits] [Gerrit] Use Wikibase DataModel 4.x - change (mediawiki...WikibaseQuality)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228970 Change subject: Use Wikibase DataModel 4.x .. Use Wikibase DataModel 4.x Change-Id: I3bd74b1805f390cb70cd9eca461b75e8da863401 --- M

[MediaWiki-commits] [Gerrit] Use Wikibase DataModel 4.x - change (mediawiki...WikibaseQualityConstraints)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228974 Change subject: Use Wikibase DataModel 4.x .. Use Wikibase DataModel 4.x Change-Id: Ib0d6d5fb6d9317eca36594205698391c48884be6 --- M

[MediaWiki-commits] [Gerrit] Fix type hint in LanguageFallbackChainFactory - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228893 Change subject: Fix type hint in LanguageFallbackChainFactory .. Fix type hint in LanguageFallbackChainFactory Change-Id:

[MediaWiki-commits] [Gerrit] Optimized imports in repo/includes - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228948 Change subject: Optimized imports in repo/includes .. Optimized imports in repo/includes Change-Id:

[MediaWiki-commits] [Gerrit] Organize methods in DateTimeValueCleaner - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228965 Change subject: Organize methods in DateTimeValueCleaner .. Organize methods in DateTimeValueCleaner Top to bottom, not bottom to top

[MediaWiki-commits] [Gerrit] Have extension listed together with other WB extensions - change (mediawiki...WikibaseQualityConstraints)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228969 Change subject: Have extension listed together with other WB extensions .. Have extension listed together with other WB extensions

[MediaWiki-commits] [Gerrit] Have extension listed together with other WB extensions - change (mediawiki...WikibaseQuality)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228968 Change subject: Have extension listed together with other WB extensions .. Have extension listed together with other WB extensions

[MediaWiki-commits] [Gerrit] Improve type hint in SitesModuleWorker - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228892 Change subject: Improve type hint in SitesModuleWorker .. Improve type hint in SitesModuleWorker Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused var in SpecialMergeItems - change (mediawiki...Wikibase)

2015-08-03 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228957 Change subject: Remove unused var in SpecialMergeItems .. Remove unused var in SpecialMergeItems Change-Id:

[MediaWiki-commits] [Gerrit] Simplify entity construction - change (mediawiki...Wikibase)

2015-07-31 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228340 Change subject: Simplify entity construction .. Simplify entity construction Change-Id: Idfacf35c067fc6c999a889506d66ad973b8ca800 ---

[MediaWiki-commits] [Gerrit] Use PHPUnits assertSameSize - change (mediawiki...Wikibase)

2015-07-31 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/228335 Change subject: Use PHPUnits assertSameSize .. Use PHPUnits assertSameSize Change-Id: I5c4d03778c1fb3421c3eb947c1fb9aa27b095026 --- M

[MediaWiki-commits] [Gerrit] Fix spacing and punctuation in English i18n messages - change (mediawiki...SemanticMediaWiki)

2015-07-31 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix spacing and punctuation in English i18n messages .. Fix spacing and punctuation in English i18n messages Change-Id:

[MediaWiki-commits] [Gerrit] Revert Replace deprecated $wgSpecialPageGroups - change (mediawiki...SemanticMediaWiki)

2015-06-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/221644 Change subject: Revert Replace deprecated $wgSpecialPageGroups .. Revert Replace deprecated $wgSpecialPageGroups This reverts commit

[MediaWiki-commits] [Gerrit] Revert Replace deprecated $wgSpecialPageGroups - change (mediawiki...SemanticMediaWiki)

2015-06-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Revert Replace deprecated $wgSpecialPageGroups .. Revert Replace deprecated $wgSpecialPageGroups This reverts commit

[MediaWiki-commits] [Gerrit] Replace Claims with StatementList in ChangeOpReference[Remove] - change (mediawiki...Wikibase)

2015-06-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace Claims with StatementList in ChangeOpReference[Remove] .. Replace Claims with StatementList in ChangeOpReference[Remove] Change-Id:

[MediaWiki-commits] [Gerrit] Stop using Claims in CreateClaim - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220387 Change subject: Stop using Claims in CreateClaim .. Stop using Claims in CreateClaim Change-Id:

[MediaWiki-commits] [Gerrit] Use StatementGuidParser instead of ClaimGuidParser - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220389 Change subject: Use StatementGuidParser instead of ClaimGuidParser .. Use StatementGuidParser instead of ClaimGuidParser Change-Id:

[MediaWiki-commits] [Gerrit] Simplification and OCP violation fix in ChangeOpClaim - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220390 Change subject: Simplification and OCP violation fix in ChangeOpClaim .. Simplification and OCP violation fix in ChangeOpClaim

[MediaWiki-commits] [Gerrit] Use EntityDocument in StatementModificationHelper - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220391 Change subject: Use EntityDocument in StatementModificationHelper .. Use EntityDocument in StatementModificationHelper This was

[MediaWiki-commits] [Gerrit] Claim - Statement in ClaimDiffer - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220392 Change subject: Claim - Statement in ClaimDiffer .. Claim - Statement in ClaimDiffer Change-Id:

[MediaWiki-commits] [Gerrit] Use newSnakListDeserializer insread of newSnaksDeserializer - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220393 Change subject: Use newSnakListDeserializer insread of newSnaksDeserializer .. Use newSnakListDeserializer insread of

[MediaWiki-commits] [Gerrit] Do not type hint against degenerate interface while using me... - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220394 Change subject: Do not type hint against degenerate interface while using methods on the object .. Do not type hint against

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220395 Change subject: Remove unused import .. Remove unused import Change-Id: I4cc993a581882bf4122dc0e8c44cfa6786b6b02e --- M

[MediaWiki-commits] [Gerrit] Add missing type hints - change (mediawiki...Wikibase)

2015-06-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220396 Change subject: Add missing type hints .. Add missing type hints Change-Id: Ie2f84ea70ad709553bdac889bc3694d657613b5b --- M

[MediaWiki-commits] [Gerrit] Remove not needed if statement - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220049 Change subject: Remove not needed if statement .. Remove not needed if statement Change-Id: I27067f712e196d519d711a4aef6cc5d48b5ea479

[MediaWiki-commits] [Gerrit] Rename usage of ClaimGuidParsingException - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220056 Change subject: Rename usage of ClaimGuidParsingException .. Rename usage of ClaimGuidParsingException Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead private method - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220045 Change subject: Remove dead private method .. Remove dead private method Change-Id: I4d6d5430a350a129565c5bd9882c185eff0ef89a --- M

[MediaWiki-commits] [Gerrit] Decrease information passed into ModifyEntity-createEntity - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220048 Change subject: Decrease information passed into ModifyEntity-createEntity .. Decrease information passed into

[MediaWiki-commits] [Gerrit] Match rename of factory functions in serialization component - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220066 Change subject: Match rename of factory functions in serialization component .. Match rename of factory functions in serialization

[MediaWiki-commits] [Gerrit] Remove unused imports - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220041 Change subject: Remove unused imports .. Remove unused imports Change-Id: I17cad5daa645d30c417aeac598b84032432a9072 --- M

[MediaWiki-commits] [Gerrit] Use more narrow EntityDocument interface in EditFilterHookRu... - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220047 Change subject: Use more narrow EntityDocument interface in EditFilterHookRunner .. Use more narrow EntityDocument interface in

[MediaWiki-commits] [Gerrit] Use more narrow entity interface in EntityStore - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220051 Change subject: Use more narrow entity interface in EntityStore .. Use more narrow entity interface in EntityStore Change-Id:

[MediaWiki-commits] [Gerrit] Match rename of factory methods in serialization component - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220058 Change subject: Match rename of factory methods in serialization component .. Match rename of factory methods in serialization

[MediaWiki-commits] [Gerrit] Remove not needed assignment - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220057 Change subject: Remove not needed assignment .. Remove not needed assignment Change-Id: Ic26d5064d47f1e1bef6b6c83845f7ee958c85ed5 ---

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220062 Change subject: Remove dead code .. Remove dead code Change-Id: I0ea2e8a6880022cf1b33c2ad20ec5478dace7ced --- M

[MediaWiki-commits] [Gerrit] Type hint against TermIndex insted of TermSqlIndex - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220060 Change subject: Type hint against TermIndex insted of TermSqlIndex .. Type hint against TermIndex insted of TermSqlIndex Also changed

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220044 Change subject: Remove dead code .. Remove dead code Change-Id: Ie01f822d5320009c0aa9bed11c8dd28426c1f7cb --- M

[MediaWiki-commits] [Gerrit] Move entityExists into only class that uses it - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220059 Change subject: Move entityExists into only class that uses it .. Move entityExists into only class that uses it And make it take

[MediaWiki-commits] [Gerrit] Removed unused imports in client/includes - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220064 Change subject: Removed unused imports in client/includes .. Removed unused imports in client/includes Change-Id:

[MediaWiki-commits] [Gerrit] Use Statement instead of Claim in EntityChange - change (mediawiki...Wikibase)

2015-06-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220067 Change subject: Use Statement instead of Claim in EntityChange .. Use Statement instead of Claim in EntityChange Change-Id:

[MediaWiki-commits] [Gerrit] Remove the withoutTermWeight setting - change (mediawiki...Wikibase)

2015-06-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove the withoutTermWeight setting .. Remove the withoutTermWeight setting This was only needed to safely deploy the wb_terms table schema change,

[MediaWiki-commits] [Gerrit] Reduce amount of duplicate code in WikibaseDataTypeBuilders - change (mediawiki...Wikibase)

2015-06-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Reduce amount of duplicate code in WikibaseDataTypeBuilders .. Reduce amount of duplicate code in WikibaseDataTypeBuilders Change-Id:

[MediaWiki-commits] [Gerrit] Replace Claim alias in StatementGroupListView - change (mediawiki...Wikibase)

2015-06-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace Claim alias in StatementGroupListView .. Replace Claim alias in StatementGroupListView This is an other patch that reduces the usage of Claim,

[MediaWiki-commits] [Gerrit] Rename Wikibase\Term to Wikibase\TermIndexEntry - change (mediawiki...Wikibase)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Rename Wikibase\Term to Wikibase\TermIndexEntry .. Rename Wikibase\Term to Wikibase\TermIndexEntry This avoids confusion with Term in DataModel. The

[MediaWiki-commits] [Gerrit] Remove dead link from readme - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219031 Change subject: Remove dead link from readme .. Remove dead link from readme Change-Id: I3dd4aae11cf3b0d36e9ba45259a9699ba725d29c ---

[MediaWiki-commits] [Gerrit] Remove dead refs to Claim - change (mediawiki...Wikibase)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219038 Change subject: Remove dead refs to Claim .. Remove dead refs to Claim Change-Id: I83d84c54d2d5222f8f1504699eb59e6e17a04d33 --- M

[MediaWiki-commits] [Gerrit] Remove dead resource module - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove dead resource module .. Remove dead resource module Change-Id: Id9f2812234134e55a2b90cc2d134ea5666cec9e0 --- M Survey.php 1 file changed, 0

[MediaWiki-commits] [Gerrit] Add compat with MW 1.24+ - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add compat with MW 1.24+ .. Add compat with MW 1.24+ Patch provided by Mike Cariaso Change-Id: I6cb03887977cdbe3aaf33530cd26509fff818e66 --- M

[MediaWiki-commits] [Gerrit] Add compat with MW 1.24+ - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219033 Change subject: Add compat with MW 1.24+ .. Add compat with MW 1.24+ Change-Id: I6cb03887977cdbe3aaf33530cd26509fff818e66 --- M

[MediaWiki-commits] [Gerrit] Remove dead resource module - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219036 Change subject: Remove dead resource module .. Remove dead resource module Change-Id: Id9f2812234134e55a2b90cc2d134ea5666cec9e0 --- M

[MediaWiki-commits] [Gerrit] Remove dead link from readme - change (mediawiki...Survey)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove dead link from readme .. Remove dead link from readme Change-Id: I3dd4aae11cf3b0d36e9ba45259a9699ba725d29c --- M README 1 file changed, 0

[MediaWiki-commits] [Gerrit] Stop using Claims and decrease method complexity - change (mediawiki...Wikibase)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219041 Change subject: Stop using Claims and decrease method complexity .. Stop using Claims and decrease method complexity I've been

[MediaWiki-commits] [Gerrit] Update references to StatementListProvider - change (mediawiki...Wikibase)

2015-06-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/219029 Change subject: Update references to StatementListProvider .. Update references to StatementListProvider Change-Id:

[MediaWiki-commits] [Gerrit] Switch from DataModel 2.x to 3.x - change (mediawiki...Wikibase)

2015-06-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/217885 Change subject: Switch from DataModel 2.x to 3.x .. Switch from DataModel 2.x to 3.x These are the minimal changes needed to make the

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Generic.ControlStructures - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Enable PHPCS sniff Generic.ControlStructures .. Enable PHPCS sniff Generic.ControlStructures There is only 1 error for this sniff in our Wikibase.git

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Squiz.ControlStructures.ControlSignature - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Enable PHPCS sniff Squiz.ControlStructures.ControlSignature .. Enable PHPCS sniff Squiz.ControlStructures.ControlSignature Change-Id:

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKer... - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKernighanRitchie .. Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKernighanRitchie

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Squiz.WhiteSpace.FunctionSpacing - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Enable PHPCS sniff Squiz.WhiteSpace.FunctionSpacing .. Enable PHPCS sniff Squiz.WhiteSpace.FunctionSpacing Change-Id:

<    1   2   3   4   5   6   7   8   9   10   >