[MediaWiki-commits] [Gerrit] Some more whitespace formatting in addition to PHPCS - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Some more whitespace formatting in addition to PHPCS .. Some more whitespace formatting in addition to PHPCS I focussed on a few cases that are not

[MediaWiki-commits] [Gerrit] Have TravisCI run PHPCS - change (mediawiki...Wikibase)

2015-06-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/217576 Change subject: Have TravisCI run PHPCS .. Have TravisCI run PHPCS Change-Id: Iac7022f95e3c020754ce850a4c278e026c6b0457 --- M

[MediaWiki-commits] [Gerrit] Fix EntityFactory calling a non-existing newEmpty method - change (mediawiki...Wikibase)

2015-06-09 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix EntityFactory calling a non-existing newEmpty method .. Fix EntityFactory calling a non-existing newEmpty method This is required to make the

[MediaWiki-commits] [Gerrit] Simplify if-not-else into a positive guard - change (mediawiki...Wikibase)

2015-06-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/215075 Change subject: Simplify if-not-else into a positive guard .. Simplify if-not-else into a positive guard Change-Id:

[MediaWiki-commits] [Gerrit] Ignore modifier when looking up usages. - change (mediawiki...Wikibase)

2015-06-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Ignore modifier when looking up usages. .. Ignore modifier when looking up usages. This provides forward-compatibility for a situation where the

[MediaWiki-commits] [Gerrit] Remove the usePropertyInfoTable setting - change (mediawiki...Wikibase)

2015-05-31 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove the usePropertyInfoTable setting .. Remove the usePropertyInfoTable setting As it's no longer of much use. Has been introduced in

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213831 Change subject: Remove unused import .. Remove unused import Change-Id: I9c183054f428de8337746dd4257c3d0043ff13f6 --- M

[MediaWiki-commits] [Gerrit] Use SettingsArray instead of Settings - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213833 Change subject: Use SettingsArray instead of Settings .. Use SettingsArray instead of Settings Change-Id:

[MediaWiki-commits] [Gerrit] Simplifications in AffectedPagesFinderTest - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213836 Change subject: Simplifications in AffectedPagesFinderTest .. Simplifications in AffectedPagesFinderTest Change-Id:

[MediaWiki-commits] [Gerrit] protected - private - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213828 Change subject: protected - private .. protected - private Change-Id: I015c819e78057ac64e48d4753d8740c331df1cbd --- M

[MediaWiki-commits] [Gerrit] Do not use deprecated sitelink method - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213832 Change subject: Do not use deprecated sitelink method .. Do not use deprecated sitelink method Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code from SpecialListProperties - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213830 Change subject: Remove dead code from SpecialListProperties .. Remove dead code from SpecialListProperties Note that while this code

[MediaWiki-commits] [Gerrit] Stop using deprecated method in SidebarHookHandlersTest - change (mediawiki...Wikibase)

2015-05-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213834 Change subject: Stop using deprecated method in SidebarHookHandlersTest .. Stop using deprecated method in SidebarHookHandlersTest

[MediaWiki-commits] [Gerrit] Improve package description - change (mediawiki...WikibaseJavaScriptApi)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213583 Change subject: Improve package description .. Improve package description Change-Id: Icdfe1a7654783c956447d6c84715ff18aecfd6a3 --- M

[MediaWiki-commits] [Gerrit] Remove supposedly obsolete maintenance script - change (mediawiki...Wikibase)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213585 Change subject: Remove supposedly obsolete maintenance script .. Remove supposedly obsolete maintenance script Change-Id:

[MediaWiki-commits] [Gerrit] Add description and Packagist badge to README file - change (mediawiki...WikibaseJavaScriptApi)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213584 Change subject: Add description and Packagist badge to README file .. Add description and Packagist badge to README file Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213595 Change subject: Remove dead code .. Remove dead code Change-Id: Ie7ef09b4b6846e6ca69180d124eef9a5ff8dad1c --- M

[MediaWiki-commits] [Gerrit] Fix type hint in WikibaseValueFormatterBuilders - change (mediawiki...Wikibase)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213596 Change subject: Fix type hint in WikibaseValueFormatterBuilders .. Fix type hint in WikibaseValueFormatterBuilders Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...Wikibase)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213597 Change subject: Remove unused import .. Remove unused import Change-Id: Ic7ac98c016ca663c167b0259a45efe104c306bcc --- M

[MediaWiki-commits] [Gerrit] Use EntityDocument instead of Entity - change (mediawiki...Wikibase)

2015-05-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/213598 Change subject: Use EntityDocument instead of Entity .. Use EntityDocument instead of Entity Change-Id:

[MediaWiki-commits] [Gerrit] Fix all mismatching PHPDoc comments in Wikibase.git - change (mediawiki...Wikibase)

2015-05-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix all mismatching PHPDoc comments in Wikibase.git .. Fix all mismatching PHPDoc comments in Wikibase.git This fixes a single issue (reported by the

[MediaWiki-commits] [Gerrit] Remove presumably dead code - change (mediawiki...Wikibase)

2015-05-04 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208620 Change subject: Remove presumably dead code .. Remove presumably dead code The comment reffers to

[MediaWiki-commits] [Gerrit] Fix OCP violation in EntityChangeFactory and stop using depr... - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208122 Change subject: Fix OCP violation in EntityChangeFactory and stop using deprecated method and class .. Fix OCP violation in

[MediaWiki-commits] [Gerrit] Have EntityHolder use EntityDocument - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208126 Change subject: Have EntityHolder use EntityDocument .. Have EntityHolder use EntityDocument Change-Id:

[MediaWiki-commits] [Gerrit] Remove commented out code - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208129 Change subject: Remove commented out code .. Remove commented out code FYI: we are actually using a VCS here Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused imports in Client tests - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208143 Change subject: Remove unused imports in Client tests .. Remove unused imports in Client tests Change-Id:

[MediaWiki-commits] [Gerrit] Add fixes indicating bad assumptions on entity id format - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208121 Change subject: Add fixes indicating bad assumptions on entity id format .. Add fixes indicating bad assumptions on entity id format

[MediaWiki-commits] [Gerrit] Use UtfNormal\Validator rather than deprecated UtfNormal - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208124 Change subject: Use UtfNormal\Validator rather than deprecated UtfNormal .. Use UtfNormal\Validator rather than deprecated UtfNormal

[MediaWiki-commits] [Gerrit] Remove @ignore tags - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208130 Change subject: Remove @ignore tags .. Remove @ignore tags Change-Id: Id4586923b18ee56e8295642b964d6d86a711adea --- M

[MediaWiki-commits] [Gerrit] Stop using getClaims method and add type doc for local var - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208136 Change subject: Stop using getClaims method and add type doc for local var .. Stop using getClaims method and add type doc for local

[MediaWiki-commits] [Gerrit] One does not simply merge into master - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208141 Change subject: One does not simply merge into master .. One does not simply merge into master Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused import - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208131 Change subject: Remove unused import .. Remove unused import Change-Id: If31a2df0c6cf2b0ef7963d9f83f1f7b2a1792a08 --- M

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208144 Change subject: Remove dead code .. Remove dead code Change-Id: I796097b2132fd3ed1743e9845557ff7c5e24665a --- M

[MediaWiki-commits] [Gerrit] Have EntityRevision use EntityDocument - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208120 Change subject: Have EntityRevision use EntityDocument .. Have EntityRevision use EntityDocument Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused parameters - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208133 Change subject: Remove unused parameters .. Remove unused parameters Change-Id: I7b91c02f18e70d6e47a8f5cbb550279269fff7e0 --- M

[MediaWiki-commits] [Gerrit] Remove dead variable - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208132 Change subject: Remove dead variable .. Remove dead variable Change-Id: I767ec005f7e7ce8a33a67e10681820d09f78202d --- M

[MediaWiki-commits] [Gerrit] after of this commit remember do a git reset hard - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208140 Change subject: after of this commit remember do a git reset hard .. after of this commit remember do a git reset hard Change-Id:

[MediaWiki-commits] [Gerrit] To be honest, I do not quite remember everything I changed h... - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208142 Change subject: To be honest, I do not quite remember everything I changed here today. But it is all good, I tell ya. .. To be

[MediaWiki-commits] [Gerrit] Remove assumption that all entities have claims from SetClai... - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208138 Change subject: Remove assumption that all entities have claims from SetClaimValueTest .. Remove assumption that all entities have

[MediaWiki-commits] [Gerrit] apparently i did something… - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208151 Change subject: apparently i did something… .. apparently i did something… Change-Id: I43cb579be3e8e33f3ef378269ff04e7c3e77281f --- M

[MediaWiki-commits] [Gerrit] The last time I tried this the monkey didnt survive. Lets ho... - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208156 Change subject: The last time I tried this the monkey didnt survive. Lets hope it works better this time. .. The last time I tried

[MediaWiki-commits] [Gerrit] Suspect we are no longer using this - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208157 Change subject: Suspect we are no longer using this .. Suspect we are no longer using this Do verify before merging though :)

[MediaWiki-commits] [Gerrit] Move service construction code to factory - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208160 Change subject: Move service construction code to factory .. Move service construction code to factory Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated MediaWikiSite::newFromGlobalId - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208149 Change subject: Stop using deprecated MediaWikiSite::newFromGlobalId .. Stop using deprecated MediaWikiSite::newFromGlobalId

[MediaWiki-commits] [Gerrit] Iterator does not have a count method - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208147 Change subject: Iterator does not have a count method .. Iterator does not have a count method Change-Id:

[MediaWiki-commits] [Gerrit] Make return docs of getAffectedUsagesByPage not lie - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208145 Change subject: Make return docs of getAffectedUsagesByPage not lie .. Make return docs of getAffectedUsagesByPage not lie Change-Id:

[MediaWiki-commits] [Gerrit] Obligatory placeholder commit message - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208152 Change subject: Obligatory placeholder commit message .. Obligatory placeholder commit message Change-Id:

[MediaWiki-commits] [Gerrit] Do not give Client access to Repository settings - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208097 Change subject: Do not give Client access to Repository settings .. Do not give Client access to Repository settings Change-Id:

[MediaWiki-commits] [Gerrit] Do not give RepoAccessModule access to Client settings - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208098 Change subject: Do not give RepoAccessModule access to Client settings .. Do not give RepoAccessModule access to Client settings

[MediaWiki-commits] [Gerrit] Do not use deprecated Settings::singleton in SqlEntityInfoBu... - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208099 Change subject: Do not use deprecated Settings::singleton in SqlEntityInfoBuilderTest .. Do not use deprecated Settings::singleton in

[MediaWiki-commits] [Gerrit] Do not give Repository access to Client settings - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208100 Change subject: Do not give Repository access to Client settings .. Do not give Repository access to Client settings Change-Id:

[MediaWiki-commits] [Gerrit] Use EntityDocument instead of Entity - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208087 Change subject: Use EntityDocument instead of Entity .. Use EntityDocument instead of Entity The call in getRequiredPermissions was

[MediaWiki-commits] [Gerrit] Update type hint to what the callers expect - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208090 Change subject: Update type hint to what the callers expect .. Update type hint to what the callers expect Change-Id:

[MediaWiki-commits] [Gerrit] Add missing return tag in SpecialPageLinker - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208093 Change subject: Add missing return tag in SpecialPageLinker .. Add missing return tag in SpecialPageLinker Change-Id:

[MediaWiki-commits] [Gerrit] Stop using Claims and Entity in RemoveClaims - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208094 Change subject: Stop using Claims and Entity in RemoveClaims .. Stop using Claims and Entity in RemoveClaims If we have more places

[MediaWiki-commits] [Gerrit] Switch travis to use hhvm instead of hhvm-nightly - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Switch travis to use hhvm instead of hhvm-nightly .. Switch travis to use hhvm instead of hhvm-nightly hhvm-nightly is no longer supported:

[MediaWiki-commits] [Gerrit] Fix type hint in getExceptionLocalizers - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208091 Change subject: Fix type hint in getExceptionLocalizers .. Fix type hint in getExceptionLocalizers Change-Id:

[MediaWiki-commits] [Gerrit] Add missing imports in OutputPageEntityIdReader - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208092 Change subject: Add missing imports in OutputPageEntityIdReader .. Add missing imports in OutputPageEntityIdReader The execption

[MediaWiki-commits] [Gerrit] Do not pass a whole list of claims to ClaimSummaryBuilder - change (mediawiki...Wikibase)

2015-05-01 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/208095 Change subject: Do not pass a whole list of claims to ClaimSummaryBuilder .. Do not pass a whole list of claims to ClaimSummaryBuilder

[MediaWiki-commits] [Gerrit] Use SnakList instead of Snaks - change (mediawiki...Wikibase)

2015-04-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206725 Change subject: Use SnakList instead of Snaks .. Use SnakList instead of Snaks As per

[MediaWiki-commits] [Gerrit] Do not use deprecated strict setting - change (mediawiki...WikidataQualityConstraints)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206621 Change subject: Do not use deprecated strict setting .. Do not use deprecated strict setting Change-Id:

[MediaWiki-commits] [Gerrit] Do not use deprecated strict setting - change (mediawiki...WikidataQualityExternalValidation)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206620 Change subject: Do not use deprecated strict setting .. Do not use deprecated strict setting Change-Id:

[MediaWiki-commits] [Gerrit] Make OutputPageBeforeHTMLHookHandler an own class, add tests - change (mediawiki...Wikibase)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make OutputPageBeforeHTMLHookHandler an own class, add tests .. Make OutputPageBeforeHTMLHookHandler an own class, add tests Change-Id:

[MediaWiki-commits] [Gerrit] Raise min DataModel version - change (mediawiki...Wikibase)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206624 Change subject: Raise min DataModel version .. Raise min DataModel version Change-Id: I3949367fb486d3cf56db1a16a2c06b669c8d6191 --- M

[MediaWiki-commits] [Gerrit] Move RepoHooks::getEntityIdFromOutputPage into OutputPageEnt... - change (mediawiki...Wikibase)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move RepoHooks::getEntityIdFromOutputPage into OutputPageEntityIdReader .. Move RepoHooks::getEntityIdFromOutputPage into OutputPageEntityIdReader

[MediaWiki-commits] [Gerrit] Remove b/c for label as ChangeOpsMerge ignore conflicts - change (mediawiki...Wikibase)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove b/c for label as ChangeOpsMerge ignore conflicts .. Remove b/c for label as ChangeOpsMerge ignore conflicts No longer used by any caller, API

[MediaWiki-commits] [Gerrit] Use common Wikibase style for JSON indent - change (mediawiki...WikidataQualityConstraints)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206618 Change subject: Use common Wikibase style for JSON indent .. Use common Wikibase style for JSON indent Change-Id:

[MediaWiki-commits] [Gerrit] Make DB setup work for installs using a table prefix - change (mediawiki...WikidataQualityExternalValidation)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206616 Change subject: Make DB setup work for installs using a table prefix .. Make DB setup work for installs using a table prefix

[MediaWiki-commits] [Gerrit] Make DB setup work for installs using a table prefix - change (mediawiki...WikidataQualityConstraints)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206617 Change subject: Make DB setup work for installs using a table prefix .. Make DB setup work for installs using a table prefix

[MediaWiki-commits] [Gerrit] Use common Wikibase style for JSON indent - change (mediawiki...WikidataQualityExternalValidation)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206619 Change subject: Use common Wikibase style for JSON indent .. Use common Wikibase style for JSON indent Change-Id:

[MediaWiki-commits] [Gerrit] Adjust maintenance entrypoint inclusion path - change (mediawiki...WikidataQualityExternalValidation)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206622 Change subject: Adjust maintenance entrypoint inclusion path .. Adjust maintenance entrypoint inclusion path Change-Id:

[MediaWiki-commits] [Gerrit] Allow usage of Diff 2.x - change (mediawiki...Wikibase)

2015-04-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206623 Change subject: Allow usage of Diff 2.x .. Allow usage of Diff 2.x Change-Id: I80c9e8e70145aece6fbd8216134976075fb7d86f --- M

[MediaWiki-commits] [Gerrit] Make DB setup work for installs using a table prefix - change (mediawiki...WikidataQuality)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206497 Change subject: Make DB setup work for installs using a table prefix .. Make DB setup work for installs using a table prefix

[MediaWiki-commits] [Gerrit] Do not use deprecated PHPUnit strict flag - change (mediawiki...WikidataQuality)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206498 Change subject: Do not use deprecated PHPUnit strict flag .. Do not use deprecated PHPUnit strict flag PHPUnit 4 has specific

[MediaWiki-commits] [Gerrit] Split long lines in README - change (mediawiki...WikidataQuality)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206494 Change subject: Split long lines in README .. Split long lines in README Change-Id: I73d7d29822a5e64f79f8231b11d0ac5925d0129f --- M

[MediaWiki-commits] [Gerrit] Use common Wikibase style for JSON indent - change (mediawiki...WikidataQuality)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206499 Change subject: Use common Wikibase style for JSON indent .. Use common Wikibase style for JSON indent Change-Id:

[MediaWiki-commits] [Gerrit] Some refactoring in JsonFileEntityLookup - change (mediawiki...WikidataQuality)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206501 Change subject: Some refactoring in JsonFileEntityLookup .. Some refactoring in JsonFileEntityLookup Change-Id:

[MediaWiki-commits] [Gerrit] Add getDataValueDeserializer, since WD Quality needs this in... - change (mediawiki...Wikibase)

2015-04-24 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206500 Change subject: Add getDataValueDeserializer, since WD Quality needs this info as well .. Add getDataValueDeserializer, since WD

[MediaWiki-commits] [Gerrit] Remove global scope assumptions in entry point - change (mediawiki...WikidataQualityConstraints)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206220 Change subject: Remove global scope assumptions in entry point .. Remove global scope assumptions in entry point See

[MediaWiki-commits] [Gerrit] Remove global scope assumptions in entry point - change (mediawiki...WikidataQuality)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206205 Change subject: Remove global scope assumptions in entry point .. Remove global scope assumptions in entry point See

[MediaWiki-commits] [Gerrit] Reduce complexity in HtmlTable::__construct - change (mediawiki...WikidataQuality)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206295 Change subject: Reduce complexity in HtmlTable::__construct .. Reduce complexity in HtmlTable::__construct Change-Id:

[MediaWiki-commits] [Gerrit] Style changes in the Html classes - change (mediawiki...WikidataQuality)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206296 Change subject: Style changes in the Html classes .. Style changes in the Html classes Change-Id:

[MediaWiki-commits] [Gerrit] Remove global scope assumptions in entry point - change (mediawiki...WikidataQualityExternalValidation)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206237 Change subject: Remove global scope assumptions in entry point .. Remove global scope assumptions in entry point See

[MediaWiki-commits] [Gerrit] Fix type hint in ViolationLookup - change (mediawiki...WikidataQuality)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206323 Change subject: Fix type hint in ViolationLookup .. Fix type hint in ViolationLookup Change-Id:

[MediaWiki-commits] [Gerrit] Reduce nesting - change (mediawiki...WikidataQualityConstraints)

2015-04-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206331 Change subject: Reduce nesting .. Reduce nesting Change-Id: Ia7022c78ee0f244949f8739eb6e60bf57461da41 --- M

[MediaWiki-commits] [Gerrit] Improve dependency version ranges - change (mediawiki...WikidataQualityExternalValidation)

2015-04-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206067 Change subject: Improve dependency version ranges .. Improve dependency version ranges See http://semver.org/ for appropriate usage

[MediaWiki-commits] [Gerrit] Improve dependency version ranges - change (mediawiki...WikidataQuality)

2015-04-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/206064 Change subject: Improve dependency version ranges .. Improve dependency version ranges See http://semver.org/ for appropriate usage

[MediaWiki-commits] [Gerrit] Replace deprecated Claims code from RemoveClaimsTest - change (mediawiki...Wikibase)

2015-03-23 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace deprecated Claims code from RemoveClaimsTest .. Replace deprecated Claims code from RemoveClaimsTest See

[MediaWiki-commits] [Gerrit] Improve isolation in ChangeOpsMergeTest and MergeChangeOpsFa... - change (mediawiki...Wikibase)

2015-03-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Improve isolation in ChangeOpsMergeTest and MergeChangeOpsFactoryTest .. Improve isolation in ChangeOpsMergeTest and MergeChangeOpsFactoryTest

[MediaWiki-commits] [Gerrit] Cleanup in ChangeOpsMergeTest - change (mediawiki...Wikibase)

2015-03-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/197888 Change subject: Cleanup in ChangeOpsMergeTest .. Cleanup in ChangeOpsMergeTest Change-Id: Ie113bd077c8218b5877278b8ab8f798ad50ce19a

[MediaWiki-commits] [Gerrit] Introduce SpecialPageLinker - change (mediawiki...Wikibase)

2015-03-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Introduce SpecialPageLinker .. Introduce SpecialPageLinker Change-Id: I937a17873221a614bddeb4a81ca12eea610f1e43 --- M composer.json M

[MediaWiki-commits] [Gerrit] Use Diff 2.x - change (mediawiki...Wikibase)

2015-03-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/197645 Change subject: Use Diff 2.x .. Use Diff 2.x Change-Id: I0014fe0a19819e36299b2b3303a39b1ae9001572 --- M composer.json 1 file changed,

[MediaWiki-commits] [Gerrit] Add autocompletion, options to modify existing pages use V... - change (mediawiki...CreatePage)

2015-03-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add autocompletion, options to modify existing pages use VisualEditor .. Add autocompletion, options to modify existing pages use VisualEditor *

[MediaWiki-commits] [Gerrit] Drop @since tags from private stuff - change (mediawiki...Wikibase)

2015-03-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop @since tags from private stuff .. Drop @since tags from private stuff Change-Id: I152cf0b5e4ea432522c77c5b21622b2e8d428dd3 --- M

[MediaWiki-commits] [Gerrit] Make FormatterOptions nullable in lib classes - change (mediawiki...Wikibase)

2015-03-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make FormatterOptions nullable in lib classes .. Make FormatterOptions nullable in lib classes It's a simple value object. In many cases it defaults

[MediaWiki-commits] [Gerrit] Drop unused Summary::toString method - change (mediawiki...Wikibase)

2015-03-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop unused Summary::toString method .. Drop unused Summary::toString method Note that this is not the magic __toString method but an own. Nobody

[MediaWiki-commits] [Gerrit] Fix type hint - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/196152 Change subject: Fix type hint .. Fix type hint Change-Id: Ibf9eb2bfab468c40cb8166150ab8850ee678d0bb --- M

[MediaWiki-commits] [Gerrit] Simplify overcomplicated getInstance methods - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Simplify overcomplicated getInstance methods .. Simplify overcomplicated getInstance methods Change-Id: I823bb7031d1f2e0ccdfb9762011722e3ae523da5 ---

[MediaWiki-commits] [Gerrit] Add fixme for LSP violation - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/196153 Change subject: Add fixme for LSP violation .. Add fixme for LSP violation Change-Id: I71fe833437b4214ea72a04fa5ebe107bd191dfc1 --- M

[MediaWiki-commits] [Gerrit] Fix ClaimDifferTest - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/196151 Change subject: Fix ClaimDifferTest .. Fix ClaimDifferTest This test was broken in 8d3df54e0e43c3e0b4e35685a64e5c30ee4c9bc0 For some

<    1   2   3   4   5   6   7   8   9   10   >