[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Add `previewType` to logging data for `dismissed` action

2017-01-05 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330718 ) Change subject: Add `previewType` to logging data for `dismissed` action .. Add `previewType` to logging data for `dismissed` action Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Settings dialog

2016-12-12 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326402 ) Change subject: Settings dialog .. Settings dialog Also removes some unused (redundant) actions and the renderer reducer. Bug: T152223

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Make implicit dependency on mw.Uri explicit

2016-12-11 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326387 ) Change subject: Make implicit dependency on mw.Uri explicit .. Make implicit dependency on mw.Uri explicit Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Contain Redux to one file

2016-11-16 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/321899 Change subject: Contain Redux to one file .. Contain Redux to one file Move rootReducer into boot.js Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Add reducer cases for all actions

2016-11-16 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/321892 Change subject: Add reducer cases for all actions .. Add reducer cases for all actions These may change as actions are implemented. Also fixes

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: WIP: Reducers

2016-11-10 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/320811 Change subject: WIP: Reducers .. WIP: Reducers I may actually just write a test for the renderer reducer and then submit this as a baseline.

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: WIP: Add LINK_DWELL and LINK_ABANDON actions

2016-11-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/320623 Change subject: WIP: Add LINK_DWELL and LINK_ABANDON actions .. WIP: Add LINK_DWELL and LINK_ABANDON actions Fork of

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Make mpga the default branch for git-review

2016-11-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/320447 Change subject: Make mpga the default branch for git-review .. Make mpga the default branch for git-review Git should probably push changes ON

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: Update linting and enable command line qunit

2016-11-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/320430 Change subject: Update linting and enable command line qunit .. Update linting and enable command line qunit You can use `grunt watch` now!

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Update linting and enable command line qunit

2016-11-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/320417 Change subject: Update linting and enable command line qunit .. Update linting and enable command line qunit You can use `grunt watch` now!

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Revert "Revert "Fix tooltip interactions""

2016-11-03 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/319624 Change subject: Revert "Revert "Fix tooltip interactions"" .. Revert "Revert "Fix tooltip interactions"" This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Move redirect message to toast

2016-11-02 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/319323 Change subject: Move redirect message to toast .. Move redirect message to toast Non-JS behavior unchanged Bug: T146596 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Fix tooltip interactions

2016-10-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/316978 Change subject: Fix tooltip interactions .. Fix tooltip interactions Tooltips are intended to be stripped upon `mouseenter` and `focus` events

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix content being added to v1 footer via `.hlist-separated`

2016-10-03 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/313891 Change subject: Fix content being added to v1 footer via `.hlist-separated` .. Fix content being added to v1 footer via `.hlist-separated`

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Push footerV2 to stable

2016-09-29 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/313426 Change subject: Push footerV2 to stable .. Push footerV2 to stable Still behind a feature flag Bug: T145442 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: EventLogging sampling rate should default to 0

2016-09-16 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/311148 Change subject: EventLogging sampling rate should default to 0 .. EventLogging sampling rate should default to 0 The EventLogging sampling

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[wmf/1.28.0-wmf.18]: Display edit icon and page actions

2016-09-14 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/310601 Change subject: Display edit icon and page actions .. Display edit icon and page actions According to Adam (on ticket) the hiding of these is

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Initiate Hovercards A/B test on ruwiki and itwiki

2016-09-13 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/310483 Change subject: Initiate Hovercards A/B test on ruwiki and itwiki .. Initiate Hovercards A/B test on ruwiki and itwiki ON rate of 10% and 20%,

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove Browser#supportsPositionFixed and Skin#setupPositionF...

2016-09-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/309586 Change subject: Remove Browser#supportsPositionFixed and Skin#setupPositionFixedEmulation .. Remove Browser#supportsPositionFixed and

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Alternate approach to I82dfa78e93f4bb7a8a28d038470265e7fd30c423

2016-09-01 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/307961 Change subject: Alternate approach to I82dfa78e93f4bb7a8a28d038470265e7fd30c423 .. Alternate approach to

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Use mw.viewport to check when to load related pages

2016-08-30 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/307547 Change subject: Use mw.viewport to check when to load related pages .. Use mw.viewport to check when to load related pages Also avoid layout

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove irrelevant browser test for Watchlist

2016-08-25 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/306715 Change subject: Remove irrelevant browser test for Watchlist .. Remove irrelevant browser test for Watchlist Changes: * Remove `Watchlist URL

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Deploy lazy loaded images to all mobile web wikipedias

2016-08-17 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/305387 Change subject: Deploy lazy loaded images to all mobile web wikipedias .. Deploy lazy loaded images to all mobile web wikipedias Bug: T142399

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Fix settings dialog layout on IE

2016-08-11 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/304242 Change subject: Fix settings dialog layout on IE .. Fix settings dialog layout on IE Change-Id: I6f530c12dd498705b1797faf820cb5e620c81853 ---

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Sort languages displayed on Special:MobileLanguages

2016-07-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/301649 Change subject: Sort languages displayed on Special:MobileLanguages .. Sort languages displayed on Special:MobileLanguages Include a PHPUnit

[MediaWiki-commits] [Gerrit] Introduce config variable to control tagline - change (mediawiki...MobileFrontend)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296352 Change subject: Introduce config variable to control tagline .. Introduce config variable to control tagline This patch aims to help fix that

[MediaWiki-commits] [Gerrit] Introduce variable for wikidata taglines - change (operations/mediawiki-config)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296346 Change subject: Introduce variable for wikidata taglines .. Introduce variable for wikidata taglines Bug: T138738 Change-Id:

[MediaWiki-commits] [Gerrit] Introduce variable for wikidata taglines - change (operations/mediawiki-config)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296345 Change subject: Introduce variable for wikidata taglines .. Introduce variable for wikidata taglines Bug: T138738 Change-Id:

[MediaWiki-commits] [Gerrit] Refactor wikibase config variables to be less confusing - change (mediawiki...MobileFrontend)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296342 Change subject: Refactor wikibase config variables to be less confusing .. Refactor wikibase config variables to be less confusing The

[MediaWiki-commits] [Gerrit] Refactor wikibase config variables to be less confusing - change (mediawiki...MobileFrontend)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296281 Change subject: Refactor wikibase config variables to be less confusing .. Refactor wikibase config variables to be less confusing The

[MediaWiki-commits] [Gerrit] Enable Wikibase descriptions on Catalan and Polish wikis - change (operations/mediawiki-config)

2016-06-27 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/296242 Change subject: Enable Wikibase descriptions on Catalan and Polish wikis .. Enable Wikibase descriptions on Catalan and Polish wikis

[MediaWiki-commits] [Gerrit] Remove old mobile workaround for wikidata descriptions - change (operations/mediawiki-config)

2016-06-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/295311 Change subject: Remove old mobile workaround for wikidata descriptions .. Remove old mobile workaround for wikidata descriptions Bug: T127250

[MediaWiki-commits] [Gerrit] Enable wikibase descriptions for beta, even if disabled for ... - change (mediawiki...MobileFrontend)

2016-06-17 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/295012 Change subject: Enable wikibase descriptions for beta, even if disabled for production .. Enable wikibase descriptions for beta, even if

[MediaWiki-commits] [Gerrit] Prepare Wikidata descriptions on mobile for production rollout - change (operations/mediawiki-config)

2016-06-10 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/293883 Change subject: Prepare Wikidata descriptions on mobile for production rollout .. Prepare Wikidata descriptions on mobile for production

[MediaWiki-commits] [Gerrit] Prepare Wikidata descriptions for rollout to stable - change (mediawiki...MobileFrontend)

2016-06-10 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/293882 Change subject: Prepare Wikidata descriptions for rollout to stable .. Prepare Wikidata descriptions for rollout to stable * Move header html

[MediaWiki-commits] [Gerrit] Enable Hovercards for huwiki - change (operations/mediawiki-config)

2016-06-01 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/292206 Change subject: Enable Hovercards for huwiki .. Enable Hovercards for huwiki * Enable Popups extension for huwiki * Enable Hovercards

[MediaWiki-commits] [Gerrit] Make Wikidata descriptions only show up on main namespace - change (mediawiki...MobileFrontend)

2016-05-31 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/291976 Change subject: Make Wikidata descriptions only show up on main namespace .. Make Wikidata descriptions only show up on main namespace Include

[MediaWiki-commits] [Gerrit] Temporary fix for blurry images - change (mediawiki...RelatedArticles)

2016-04-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/282423 Change subject: Temporary fix for blurry images .. Temporary fix for blurry images Request double the size until pithumbmode is implemented.

[MediaWiki-commits] [Gerrit] WIP: Fix phantom overlay title on scroll for iOS9 - change (mediawiki...MobileFrontend)

2016-03-15 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/277607 Change subject: WIP: Fix phantom overlay title on scroll for iOS9 .. WIP: Fix phantom overlay title on scroll for iOS9 This does not work yet.

[MediaWiki-commits] [Gerrit] Fix blurry images - change (mediawiki...RelatedArticles)

2016-03-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/276396 Change subject: Fix blurry images .. Fix blurry images Use new PageImages property "cover" to specify minimum dimensions instead of maximum.

[MediaWiki-commits] [Gerrit] Allow specification of cover attribute for thumbnails - change (mediawiki...PageImages)

2016-03-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/276394 Change subject: Allow specification of cover attribute for thumbnails .. Allow specification of cover attribute for thumbnails Currently,

[MediaWiki-commits] [Gerrit] Fix broken external links - change (mediawiki...ZeroBanner)

2016-03-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/276375 Change subject: Fix broken external links .. Fix broken external links Update ZeroOverlay to use OO.mfExtend Bug: T129394 Change-Id:

[MediaWiki-commits] [Gerrit] Enable survey at reduced sample rate - change (operations/mediawiki-config)

2016-02-12 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/270344 Change subject: Enable survey at reduced sample rate .. Enable survey at reduced sample rate Expect to increase sample rate from 0.5 to

[MediaWiki-commits] [Gerrit] Upstream `isElementInViewport` from MobileFrontend - change (mediawiki/core)

2016-01-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/267058 Change subject: Upstream `isElementInViewport` from MobileFrontend .. Upstream `isElementInViewport` from MobileFrontend As a useful utility

[MediaWiki-commits] [Gerrit] [Hygiene] Update qunit tests for clarity - change (mediawiki...QuickSurveys)

2015-12-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/261288 Change subject: [Hygiene] Update qunit tests for clarity .. [Hygiene] Update qunit tests for clarity The previous selectors were very

[MediaWiki-commits] [Gerrit] Implement platform-dependent surveys - change (mediawiki...QuickSurveys)

2015-12-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/261212 Change subject: Implement platform-dependent surveys .. Implement platform-dependent surveys Our current configuration defines the allowed

[MediaWiki-commits] [Gerrit] Release 1.0.0 - change (mediawiki...QuickSurveys)

2015-12-22 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/260680 Change subject: Release 1.0.0 .. Release 1.0.0 We're doing a bit of a catch-up release here with just the version number changing.

[MediaWiki-commits] [Gerrit] Release 0.7.0 - change (mediawiki...Gather)

2015-12-17 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/259798 Change subject: Release 0.7.0 .. Release 0.7.0 +225f593 Fix notifications +fe02ab1 Replace DB begin()/commit() with startAtomic()/endAtomic()

[MediaWiki-commits] [Gerrit] Use background-size:cover for thumbnails - change (mediawiki...Cards)

2015-12-14 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/259193 Change subject: Use background-size:cover for thumbnails .. Use background-size:cover for thumbnails Fallback to status quo. Includes the same

[MediaWiki-commits] [Gerrit] Disable QuickSurveys reader segmentation survey - change (operations/mediawiki-config)

2015-11-25 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/255448 Change subject: Disable QuickSurveys reader segmentation survey .. Disable QuickSurveys reader segmentation survey Completely remove the

[MediaWiki-commits] [Gerrit] Increase survey coverage - change (operations/mediawiki-config)

2015-11-24 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/255276 Change subject: Increase survey coverage .. Increase survey coverage We're not getting anywhere near the number of responses we expected.

[MediaWiki-commits] [Gerrit] [WIP] Third QuickSurveys external survey - change (operations/mediawiki-config)

2015-11-23 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/254908 Change subject: [WIP] Third QuickSurveys external survey .. [WIP] Third QuickSurveys external survey Bug: T116433 Change-Id:

[MediaWiki-commits] [Gerrit] End first mobile QuickSurveys campaign - change (operations/mediawiki-config)

2015-11-23 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/254831 Change subject: End first mobile QuickSurveys campaign .. End first mobile QuickSurveys campaign Remove the config for the current

[MediaWiki-commits] [Gerrit] Reduce sampling rate for QuickSurveys survey - change (operations/mediawiki-config)

2015-11-19 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/254352 Change subject: Reduce sampling rate for QuickSurveys survey .. Reduce sampling rate for QuickSurveys survey The sampling rate is too high.

[MediaWiki-commits] [Gerrit] Enable new QuickSurveys survey on mobile enwiki - change (operations/mediawiki-config)

2015-11-19 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/254322 Change subject: Enable new QuickSurveys survey on mobile enwiki .. Enable new QuickSurveys survey on mobile enwiki Run the same survey from

[MediaWiki-commits] [Gerrit] Disable first QuickSurveys survey - change (operations/mediawiki-config)

2015-11-13 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/253038 Change subject: Disable first QuickSurveys survey .. Disable first QuickSurveys survey Disable survey but leave QuickSurveys deployed on

[MediaWiki-commits] [Gerrit] [Hygiene] Rename internal uses of "article" to "page" - change (mediawiki...RelatedArticles)

2015-11-13 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/253051 Change subject: [Hygiene] Rename internal uses of "article" to "page" .. [Hygiene] Rename internal uses of "article" to "page" Leave all

[MediaWiki-commits] [Gerrit] [Hygiene] Rename internal uses of "article" to "page" - change (mediawiki...RelatedArticles)

2015-11-13 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/253054 Change subject: [Hygiene] Rename internal uses of "article" to "page" .. [Hygiene] Rename internal uses of "article" to "page" Leave all

[MediaWiki-commits] [Gerrit] Fix clear:both breaking pages - change (mediawiki...QuickSurveys)

2015-11-12 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/252736 Change subject: Fix clear:both breaking pages .. Fix clear:both breaking pages Headers and infoboxes are clearing past all floated elements

[MediaWiki-commits] [Gerrit] Copy wmgQuickSurveysConfig to wgQuickSurveysConfig - change (operations/mediawiki-config)

2015-11-11 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/252456 Change subject: Copy wmgQuickSurveysConfig to wgQuickSurveysConfig .. Copy wmgQuickSurveysConfig to wgQuickSurveysConfig QuickSurveys should

[MediaWiki-commits] [Gerrit] Deploy QuickSurveys to English Wikipedia - change (operations/mediawiki-config)

2015-11-11 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/252606 Change subject: Deploy QuickSurveys to English Wikipedia .. Deploy QuickSurveys to English Wikipedia * Enable QuickSurveys on English

[MediaWiki-commits] [Gerrit] Fix collapsible header arrows - change (mediawiki...MobileFrontend)

2015-11-03 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/250838 Change subject: Fix collapsible header arrows .. Fix collapsible header arrows Collapsible header arrows should point up by default when

[MediaWiki-commits] [Gerrit] Make page issues link take up an entire line - change (mediawiki...MobileFrontend)

2015-11-03 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/250751 Change subject: Make page issues link take up an entire line .. Make page issues link take up an entire line Change page issues cleanup link

[MediaWiki-commits] [Gerrit] Add pageId and pageTitle to EventLogging schema - change (mediawiki...QuickSurveys)

2015-10-30 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/250029 Change subject: Add pageId and pageTitle to EventLogging schema .. Add pageId and pageTitle to EventLogging schema Update EventLogging schema

[MediaWiki-commits] [Gerrit] Remove jQuery dependency during banner injection - change (mediawiki...ZeroBanner)

2015-10-29 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/249874 Change subject: Remove jQuery dependency during banner injection .. Remove jQuery dependency during banner injection jQuery isn't always

[MediaWiki-commits] [Gerrit] [WIP] Disable EventLogging on DoNotTrack - change (mediawiki...MobileFrontend)

2015-10-21 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/247787 Change subject: [WIP] Disable EventLogging on DoNotTrack .. [WIP] Disable EventLogging on DoNotTrack Disable any logging when the user has

[MediaWiki-commits] [Gerrit] Switch default branch from 'master' to 'dev' - change (mediawiki...Gather)

2015-10-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/247527 Change subject: Switch default branch from 'master' to 'dev' .. Switch default branch from 'master' to 'dev' Per

[MediaWiki-commits] [Gerrit] Message text enhancements - change (mediawiki...Gather)

2015-10-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/247530 Change subject: Message text enhancements .. Message text enhancements Avoid SITENAME as per

[MediaWiki-commits] [Gerrit] Switch default branch from 'master' to 'dev' - change (mediawiki...Gather)

2015-10-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/247525 Change subject: Switch default branch from 'master' to 'dev' .. Switch default branch from 'master' to 'dev' Per

[MediaWiki-commits] [Gerrit] Release 0.5.0 of Gather - change (mediawiki...Gather)

2015-10-20 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/247529 Change subject: Release 0.5.0 of Gather .. Release 0.5.0 of Gather Bug: T113972 Change-Id: I46ebbf0b49c0be4a93c21d21b190344ae0ed5ca0 --- M

[MediaWiki-commits] [Gerrit] Make interstitial title customizable - change (mediawiki...ZeroBanner)

2015-10-15 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/246676 Change subject: Make interstitial title customizable .. Make interstitial title customizable The title of the exit warning interstitial should

[MediaWiki-commits] [Gerrit] Remove 'header-loaded' event - change (mediawiki...MobileFrontend)

2015-10-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/244609 Change subject: Remove 'header-loaded' event .. Remove 'header-loaded' event Previously we were registering the click events of the main menu

[MediaWiki-commits] [Gerrit] Die gracefully when survey throws exception - change (mediawiki...QuickSurveys)

2015-10-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/244623 Change subject: Die gracefully when survey throws exception .. Die gracefully when survey throws exception Currently, if a message is not

[MediaWiki-commits] [Gerrit] Fix banner injection - change (mediawiki...ZeroBanner)

2015-10-05 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/243827 Change subject: Fix banner injection .. Fix banner injection Variable $banner is not HTML and should not be wrapped in

[MediaWiki-commits] [Gerrit] Fix deprecation warnings - change (mediawiki...ZeroBanner)

2015-09-30 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/242661 Change subject: Fix deprecation warnings .. Fix deprecation warnings Will hopefully fix unknown error with banner rendering in middle of page.

[MediaWiki-commits] [Gerrit] Fix font of h1s in content area for minerva - change (mediawiki...MobileFrontend)

2015-09-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/241902 Change subject: Fix font of h1s in content area for minerva .. Fix font of h1s in content area for minerva Font of s should be Linux

[MediaWiki-commits] [Gerrit] Interstitial should be fixed position - change (mediawiki...ZeroBanner)

2015-09-25 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/241104 Change subject: Interstitial should be fixed position .. Interstitial should be fixed position Fix interstitial styling to be fixed position

[MediaWiki-commits] [Gerrit] DTAC Interstitial design change - change (mediawiki...ZeroBanner)

2015-09-23 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/240448 Change subject: DTAC Interstitial design change .. DTAC Interstitial design change Use 3 button layout instead of 4 button layout Change-Id:

[MediaWiki-commits] [Gerrit] Custom interstitial button for non-js browsers - change (mediawiki...ZeroBanner)

2015-09-15 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/238659 Change subject: Custom interstitial button for non-js browsers .. Custom interstitial button for non-js browsers Support for allowing

[MediaWiki-commits] [Gerrit] [WIP] Interstitial design overhaul for DTAC - change (mediawiki...ZeroBanner)

2015-09-01 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/235267 Change subject: [WIP] Interstitial design overhaul for DTAC .. [WIP] Interstitial design overhaul for DTAC Revamp charge warning interstitial

[MediaWiki-commits] [Gerrit] T95623 - Load first search result on submit - change (apps...wikipedia)

2015-06-12 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/217863 Change subject: T95623 - Load first search result on submit .. T95623 - Load first search result on submit Fix for T95623 in order to match

[MediaWiki-commits] [Gerrit] T95966 - Display a message for no search results - change (mediawiki...Gather)

2015-05-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/209721 Change subject: T95966 - Display a message for no search results .. T95966 - Display a message for no search results Fix for T95966. Display

[MediaWiki-commits] [Gerrit] Remove mobile.templates dependency - change (mediawiki...ZeroBanner)

2015-04-21 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/205635 Change subject: Remove mobile.templates dependency .. Remove mobile.templates dependency The code syntax was already changed previously, but a

[MediaWiki-commits] [Gerrit] [WIP] Create browser tests - change (mediawiki...ZeroBanner)

2015-02-03 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/188418 Change subject: [WIP] Create browser tests .. [WIP] Create browser tests Add some browser tests for banner, info screen, and interstitial

[MediaWiki-commits] [Gerrit] Update to mediawiki-selenium pre-release version - change (mediawiki...ZeroPortal)

2015-01-29 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/187602 Change subject: Update to mediawiki-selenium pre-release version .. Update to mediawiki-selenium pre-release version Update to stable

[MediaWiki-commits] [Gerrit] Fix routing capabilities - change (mediawiki...ZeroBanner)

2015-01-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/187241 Change subject: Fix routing capabilities .. Fix routing capabilities Mobile FrontEnd changed the scope of the Router, this patch updates to

[MediaWiki-commits] [Gerrit] Enable $wgAllowSiteCSSOnRestrictedPages for zero - change (operations/mediawiki-config)

2014-12-30 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/182227 Change subject: Enable $wgAllowSiteCSSOnRestrictedPages for zero .. Enable $wgAllowSiteCSSOnRestrictedPages for zero Zerowiki needs Common.css

[MediaWiki-commits] [Gerrit] Enable $wgAllowSiteCSSOnRestrictedPages - change (mediawiki...ZeroPortal)

2014-12-29 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/182112 Change subject: Enable $wgAllowSiteCSSOnRestrictedPages .. Enable $wgAllowSiteCSSOnRestrictedPages Allow Mediawiki:Common.css to apply to

[MediaWiki-commits] [Gerrit] Fix for bug T76982 - change (mediawiki...ZeroBanner)

2014-12-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/178420 Change subject: Fix for bug T76982 .. Fix for bug T76982 Switch uses of 'ev.target' to 'this' to fix cases where click events come from

[MediaWiki-commits] [Gerrit] Use settings module instead of variable - change (mediawiki...ZeroBanner)

2014-11-26 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/176061 Change subject: Use settings module instead of variable .. Use settings module instead of variable Update ZeroBanner to latest MFE convention

[MediaWiki-commits] [Gerrit] Fix banner dismiss button - change (mediawiki...ZeroBanner)

2014-11-25 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/175881 Change subject: Fix banner dismiss button .. Fix banner dismiss button Enable the ability to dismiss banners as well as keeping them dismissed

[MediaWiki-commits] [Gerrit] [WIP] News page tests with Cucumber error - change (mediawiki...ZeroPortal)

2014-11-04 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/170942 Change subject: [WIP] News page tests with Cucumber error .. [WIP] News page tests with Cucumber error Uploading to gerrit in reference to bug

[MediaWiki-commits] [Gerrit] Update interstitial to use OOjs-UI - change (mediawiki...ZeroBanner)

2014-10-28 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/169633 Change subject: Update interstitial to use OOjs-UI .. Update interstitial to use OOjs-UI Move leaving zero-rated access warning screen to an

[MediaWiki-commits] [Gerrit] Add tests for home page - change (mediawiki...ZeroPortal)

2014-10-14 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/166616 Change subject: Add tests for home page .. Add tests for home page Also add authorization check for login page Change-Id:

[MediaWiki-commits] [Gerrit] Add reset less file - change (mediawiki...ZeroPortal)

2014-10-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/165944 Change subject: Add reset less file .. Add reset less file Add a reset less file for overriding default mediawiki ui Change-Id:

[MediaWiki-commits] [Gerrit] Add 437-05 to unified baselining - change (operations/puppet)

2014-10-09 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/165863 Change subject: Add 437-05 to unified baselining .. Add 437-05 to unified baselining Also move 255-03 from disabled to enabled in comments

[MediaWiki-commits] [Gerrit] Refactor browser tests - change (mediawiki...ZeroPortal)

2014-10-08 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/165524 Change subject: Refactor browser tests .. Refactor browser tests Follow best practices according to mobile-frontend Create base set of tests

[MediaWiki-commits] [Gerrit] Redesign Zero info screen - change (mediawiki...ZeroBanner)

2014-10-06 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/165162 Change subject: Redesign Zero info screen .. Redesign Zero info screen Add oojs-ui ProcessDialog to ZeroInfo Enable routing with oojs-ui

[MediaWiki-commits] [Gerrit] Update zero info page to match mobile-frontend - change (mediawiki...ZeroBanner)

2014-09-30 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/163891 Change subject: Update zero info page to match mobile-frontend .. Update zero info page to match mobile-frontend Make info page overlay more

[MediaWiki-commits] [Gerrit] Reduce file size of wikipedia favicon - change (operations/mediawiki-config)

2014-09-23 Thread Jhobs (Code Review)
Jhobs has uploaded a new change for review. https://gerrit.wikimedia.org/r/162538 Change subject: Reduce file size of wikipedia favicon .. Reduce file size of wikipedia favicon Change-Id:

  1   2   >