Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/406063 )
Change subject: rdbms: Simplify Database::factory()
..
rdbms: Simplify Database::factory()
Follows-up 0ff2b7a776 (T120333) which removed
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/406055 )
Change subject: tests: Update phpunit and enable coverage for all classes
..
tests: Update phpunit and enable coverage for all classes
The
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405929 )
Change subject: Archive repository
..
Archive repository
Bug: T174416
Change-Id: I0a4a291607da3acf6ba4de7da140c3d8fd4117af
---
D
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405995 )
Change subject: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs
..
cover: Convert coverage sub-nav from breadcrumbs to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405996 )
Change subject: cover: Add sort=cover parameter to coverage report
..
cover: Add sort=cover parameter to coverage report
When enabled, the
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405930 )
Change subject: Remove jobs for 'generator-wikimedia-php-library'
..
Remove jobs for 'generator-wikimedia-php-library'
Repo is being
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405929 )
Change subject: Archive repository
..
Archive repository
Bug: T174416
Change-Id: I0a4a291607da3acf6ba4de7da140c3d8fd4117af
---
D
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404046 )
Change subject: webperf: Introduce 'templates' in test fixture and use for
mwload
..
webperf: Introduce 'templates' in test fixture and
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404045 )
Change subject: webperf: Re-use expected result by reference to simplify fixture
..
webperf: Re-use expected result by reference to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403980 )
Change subject: config: Increase coverage of EtcdConfig::parseDirectory()
..
config: Increase coverage of EtcdConfig::parseDirectory()
One
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403974 )
Change subject: Initial profiler for Beta Cluster
..
Initial profiler for Beta Cluster
* profiler-labs.php: Like profiler.php, but for
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403973 )
Change subject: Remove unused PhpAutoPrepend.php file for now.
..
Remove unused PhpAutoPrepend.php file for now.
Follows-up 96de34769,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403835 )
Change subject: JavaScriptMinifier: Remove support for unused $maxLineLength
param
..
JavaScriptMinifier: Remove support for unused
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403769 )
Change subject: JavaScriptMinifier: Enable phpcs and fix violations
..
JavaScriptMinifier: Enable phpcs and fix violations
Found 90
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403569 )
Change subject: keys: Simplify and update keys.html styling to match other
simple pages
..
keys: Simplify and update keys.html styling to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403560 )
Change subject: [WIP] coal: Consume EventLogging from Kafka instead of ZMQ
..
[WIP] coal: Consume EventLogging from Kafka instead of ZMQ
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403331 )
Change subject: JavaScriptMinifier: Improve docs for parsing of string literals
..
JavaScriptMinifier: Improve docs for parsing of string
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403332 )
Change subject: JavaScriptMinifier: Fix "Uninitialized offset" in string and
regexp parsing
..
JavaScriptMinifier: Fix "Uninitialized
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402145 )
Change subject: tests: Add @covers tags
..
tests: Add @covers tags
Change-Id: Ia3e18e7149292cd23765636111acc846564bf6cc
---
M
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400434 )
Change subject: phpunit: Remove outdated comment about calling of
LinkCache::clear()
..
phpunit: Remove outdated comment about calling of
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400432 )
Change subject: maintenance: Add unit test for Benchmarker class
..
maintenance: Add unit test for Benchmarker class
Change-Id:
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399861 )
Change subject: JavaScriptMinifier: Improve docs around parsing of regexp
literals
..
JavaScriptMinifier: Improve docs around parsing of
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399855 )
Change subject: JavaScriptMinifier: Remove support for unused
$statementsOnOwnLine flag
..
JavaScriptMinifier: Remove support for unused
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399853 )
Change subject: resourceloader: Improve JavaScriptMinifier code coverage
..
resourceloader: Improve JavaScriptMinifier code coverage
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398408 )
Change subject: build: Remove phplint --ignore-fails hack for symlink support
..
build: Remove phplint --ignore-fails hack for symlink
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398319 )
Change subject: mediawiki.loader: Fix logError() not to print exceptions twice
..
mediawiki.loader: Fix logError() not to print exceptions
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398109 )
Change subject: mediawiki.loader: Avoid jQuery for simple creation and selection
..
mediawiki.loader: Avoid jQuery for simple creation and
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398108 )
Change subject: resourceloader: Use document.head instead of
getElementsByTagName
..
resourceloader: Use document.head instead of
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395159 )
Change subject: [WIP] ImagePage: Create metadata table collapse button in PHP
..
[WIP] ImagePage: Create metadata table collapse button in
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395157 )
Change subject: ImagePage: Clean up metadata.js collapsing
..
ImagePage: Clean up metadata.js collapsing
In preparation for trying out a
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395158 )
Change subject: ImagePage: Make metadata table's initial collapse CSS-only
..
ImagePage: Make metadata table's initial collapse CSS-only
Hello Urbanecm, Legoktm, jenkins-bot, Anomie, Zoranzoki21,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/395150
to review the following change.
Change subject: Re-apply "Revert "Set wgCommentTableSchemaMigrationStage =
MIGRATION_WRITE_BOTH on test wikis""
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395149 )
Change subject: Revert "Revert "Set wgCommentTableSchemaMigrationStage =
MIGRATION_WRITE_BOTH on test wikis""
..
Revert "Revert
Hello Urbanecm, Legoktm, jenkins-bot, Anomie, Zoranzoki21,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/395149
to review the following change.
Change subject: Revert "Revert "Set wgCommentTableSchemaMigrationStage =
MIGRATION_WRITE_BOTH on test wikis""
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395120 )
Change subject: multiversion: Update docs for 'wfShellWikiCmd' hook
..
multiversion: Update docs for 'wfShellWikiCmd' hook
This hook was
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395074 )
Change subject: Remove various redundant '@license' tags in file headers
..
Remove various redundant '@license' tags in file headers
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394732 )
Change subject: [DNM] Fun with PHP - https://3v4l.org/Gv3QB
..
[DNM] Fun with PHP - https://3v4l.org/Gv3QB
Change-Id:
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394705 )
Change subject: Add tests for App::getDB()
..
Add tests for App::getDB()
Change-Id: I49bd2762b070d8641d8a7c7faf139a823d2d0421
---
M
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394666 )
Change subject: build: Add PHP 7.1 to Travis CI test matrix
..
build: Add PHP 7.1 to Travis CI test matrix
Looks like we've got at least
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394665 )
Change subject: objectcache: Fix HashBagOStuffTest test in PHP 7.1
..
objectcache: Fix HashBagOStuffTest test in PHP 7.1
> There was 1
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394661 )
Change subject: build: Update to PHPUnit 5
..
build: Update to PHPUnit 5
Bug: T181852
Change-Id: I5134c4fe4c3398e5e0463472601e813ed975cded
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394655 )
Change subject: Switch tools/guc jobs from php55 to php56
..
Switch tools/guc jobs from php55 to php56
Looks like a base image variant
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394651 )
Change subject: Switch to `*.web.db.svc.eqiad.wmflabs`
..
Switch to `*.web.db.svc.eqiad.wmflabs`
Bug: T176686
Change-Id:
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394645 )
Change subject: Fix-up typo from 9f2c515
..
Fix-up typo from 9f2c515
Change-Id: I6a14d52bee225a80b4f6afc3b1947baba09771de
---
M
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394644 )
Change subject: Improve re-use of connections between getDB()/openDB()
..
Improve re-use of connections between getDB()/openDB()
Current
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394511 )
Change subject: Update "Other patches" to hide if already reviewed by MW or WMF
groups
..
Update "Other patches" to hide if already
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394511 )
Change subject: Update "Other patches" to hide if already reviewed by MW or WMF
groups
..
Update "Other patches" to hide if
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394505 )
Change subject: objectcache: Add @ingroup to RedisBagOStuff
..
objectcache: Add @ingroup to RedisBagOStuff
Was missing from "Cache" group,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394502 )
Change subject: Remove @defgroup from DefaultSettings.php
..
Remove @defgroup from DefaultSettings.php
This renders in Doxygen as a blank
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394497 )
Change subject: resourceloader: Remove deprecated minifier config vars
..
resourceloader: Remove deprecated minifier config vars
Unused,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394441 )
Change subject: Factor out getRandom() and inSample()
..
Factor out getRandom() and inSample()
* Centralise the Math.floor() logic and add
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394400 )
Change subject: jobs: Remove ClearUserWatchlistJob 'batchSize' option
..
jobs: Remove ClearUserWatchlistJob 'batchSize' option
Use
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394184 )
Change subject: Shell: skip null parameters
..
Shell: skip null parameters
Right now they're treated as empty strings, however
this
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393713 )
Change subject: [WIP] WebStart: Remove use of realpath() for $IP
..
[WIP] WebStart: Remove use of realpath() for $IP
When installing
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393702 )
Change subject: Exclude CR<0 if from performance group
..
Exclude CR<0 if from performance group
We already exclude CR -2 which is limited
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393702 )
Change subject: Exclude CR<0 if from performance group
..
Exclude CR<0 if from performance group
We already exclude CR -2 which is
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393701 )
Change subject: Also exclude WIP/DNM from "Other" section
..
Also exclude WIP/DNM from "Other" section
Matches the logic of the
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393701 )
Change subject: Also exclude WIP/DNM from "Other" section
..
Also exclude WIP/DNM from "Other" section
Matches the logic of the other
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393691 )
Change subject: Gerrit: Fix negative cut-off logo on page load
..
Gerrit: Fix negative cut-off logo on page load
Follows-up db9ea750ef.
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393641 )
Change subject: Update "Other patches" to use reviewerin: instead of file:
..
Update "Other patches" to use reviewerin: instead of
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393641 )
Change subject: Update "Other patches" to use reviewerin: instead of file:
..
Update "Other patches" to use reviewerin: instead of file:
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393638 )
Change subject: Add section for patches by others to subscribed areas
..
Add section for patches by others to subscribed areas
We
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393638 )
Change subject: Add section for patches by others to subscribed areas
..
Add section for patches by others to subscribed areas
We should
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392986 )
Change subject: RemoteSchema: Use SchemaApiUrl instead of DBname in cache key
..
RemoteSchema: Use SchemaApiUrl instead of DBname in cache
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392982 )
Change subject: Simplify onSetup check for configuration
..
Simplify onSetup check for configuration
* No need for isset(), because these
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392891 )
Change subject: InstallDocFormatter: Add missing @covers scope
..
InstallDocFormatter: Add missing @covers scope
The format() method is a
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392888 )
Change subject: build: Add 'npm run qunit' command
..
build: Add 'npm run qunit' command
The running of 'grunt qunit' is unconvenient due
Hello Bartosz Dziewoński, Fomafix, Reedy, Florianschmidtwelzow, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/392773
to review the following change.
Change subject: Revert "Move styles for Special:UserRights to separate style
module"
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392561 )
Change subject: multiversion: Assume --wiki=aawiki for purgeUrls.php
..
multiversion: Assume --wiki=aawiki for purgeUrls.php
Similar to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392557 )
Change subject: noc: Remove more unused styles/images and update Vector
..
noc: Remove more unused styles/images and update Vector
No
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392317 )
Change subject: noc: Link to Grafana instead of Ganglia
..
noc: Link to Grafana instead of Ganglia
Closes
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392112 )
Change subject: Try again with using 'ownerin:' instead of hardcoded list
..
Try again with using 'ownerin:' instead of hardcoded
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392112 )
Change subject: Try again with using 'ownerin:' instead of hardcoded list
..
Try again with using 'ownerin:' instead of hardcoded list
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391991 )
Change subject: mw.MediaWikiPlayerSupport: Fix more .bind() deprecation warnings
..
mw.MediaWikiPlayerSupport: Fix more .bind() deprecation
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391987 )
Change subject: labs: Enable profiler based on same signals as production does
..
labs: Enable profiler based on same signals as production
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391982 )
Change subject: labs: Clean up outdated wgProfiler config
..
labs: Clean up outdated wgProfiler config
* Define $wgProfiler cleanly (not
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391755 )
Change subject: wikidatawiki back to wmf.7
..
wikidatawiki back to wmf.7
Follows-up 75a290113.
Pushing local unstaged change from
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391644 )
Change subject: Archive the ActivityMonitor extension
..
Archive the ActivityMonitor extension
Bug: T180631
Change-Id:
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391162 )
Change subject: [WIP] Split profile.php from StartProfiler and add
PhpAutoPrepend
..
[WIP] Split profile.php from StartProfiler and add
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391158 )
Change subject: VectorTemplate: Restore 'id' for siteNotice wrapper
..
VectorTemplate: Restore 'id' for siteNotice wrapper
Follows-up
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390548 )
Change subject: Improve StartProfiler.php file documentation
..
Improve StartProfiler.php file documentation
In preparation for
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390543 )
Change subject: frontend: Restore replag warning
..
frontend: Restore replag warning
It was still trying to insert before `.maincontent
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390526 )
Change subject: Add warning and documentation comment to HHVMRequestInit.php
..
Add warning and documentation comment to
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390351 )
Change subject: Setup: Include StartProfiler before others
..
Setup: Include StartProfiler before others
Bug: T180183
Change-Id:
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390350 )
Change subject: Merge ProfilerFunctions into GlobalFunctions
..
Merge ProfilerFunctions into GlobalFunctions
Even if people use these
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390186 )
Change subject: VectorTemplate: Some consistency in mixed PHP/HTML formatting
..
VectorTemplate: Some consistency in mixed PHP/HTML
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390187 )
Change subject: VectorTemplate: Refactor literal HTML by using Html methods
instead
..
VectorTemplate: Refactor literal HTML by using Html
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390083 )
Change subject: webperf: Refactor tests to directly associate expected data
with cases
..
webperf: Refactor tests to directly associate
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390061 )
Change subject: webperf: Record navtiming discards to Graphite, and add is_sane
test
..
webperf: Record navtiming discards to Graphite,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389917 )
Change subject: Use the proper cache key method in loadFromCache()
..
Use the proper cache key method in loadFromCache()
Bug: T17
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389887 )
Change subject: hooks: Remove redundant wgMemc check in onSetup
..
hooks: Remove redundant wgMemc check in onSetup
This is run on all
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389886 )
Change subject: Reduce initFlowExtension cost from Utils::isParsoidConfigured()
..
Reduce initFlowExtension cost from
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389798 )
Change subject: grafana: Fix network graphs to not end in a weird drop to 0
..
grafana: Fix network graphs to not end in a weird drop to 0
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389795 )
Change subject: build: Remove outdated references to server/
..
build: Remove outdated references to server/
The development version of
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389664 )
Change subject: upload: Simplify UploadStashTest by using getNewTempFile()
..
upload: Simplify UploadStashTest by using getNewTempFile()
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388573 )
Change subject: Add modules/ sub directories to match module registration
..
Add modules/ sub directories to match module registration
*
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/388571 )
Change subject: geoFeatures: Use local var instead of document data for state
..
geoFeatures: Use local var instead of document data for
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387980 )
Change subject: grafana: Update server-board JSON to schemaVersion 14 (no-op)
..
grafana: Update server-board JSON to schemaVersion 14
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387981 )
Change subject: grafana: Reduce "network" dropdown to valid options for current
server
..
grafana: Reduce "network" dropdown to valid
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387973 )
Change subject: Fix case of SpecialRecentChanges class
..
Fix case of SpecialRecentChanges class
Test fails with
1 - 100 of 4725 matches
Mail list logo
