[MediaWiki-commits] [Gerrit] (bug 45968) Set $wgCategoryCollation to 'uca-pl' on Polish W... - change (operations/mediawiki-config)

2013-03-18 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54352 Change subject: (bug 45968) Set $wgCategoryCollation to 'uca-pl' on Polish Wikivoyage .. (bug 45968) Set $wgCategoryCollation to 'uca-pl' on

[MediaWiki-commits] [Gerrit] (bug 46239) jquery.makeCollapsible: don't fail if no options... - change (mediawiki/core)

2013-03-17 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54210 Change subject: (bug 46239) jquery.makeCollapsible: don't fail if no options given .. (bug 46239) jquery.makeCollapsible: don't fail if no o

[MediaWiki-commits] [Gerrit] (bug 39225) Configure $wgBabelCategoryNames and $wgBabelMain... - change (operations/mediawiki-config)

2013-03-16 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54144 Change subject: (bug 39225) Configure $wgBabelCategoryNames and $wgBabelMainCategory for pl.wikisource .. (bug 39225) Configure $wgBabelCate

[MediaWiki-commits] [Gerrit] swap the common arrow images for prettier ones - change (mediawiki/core)

2013-03-16 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54136 Change subject: swap the common arrow images for prettier ones .. swap the common arrow images for prettier ones As far as I know these are

[MediaWiki-commits] [Gerrit] (bug 43689) make the templates/category lists on edit page c... - change (mediawiki/core)

2013-03-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54089 Change subject: (bug 43689) make the templates/category lists on edit page collapsible .. (bug 43689) make the templates/category lists on e

[MediaWiki-commits] [Gerrit] jquery.makeCollapsible: add plainMode support - change (mediawiki/core)

2013-03-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/54065 Change subject: jquery.makeCollapsible: add plainMode support .. jquery.makeCollapsible: add plainMode support When .makeCollapsible() is us

[MediaWiki-commits] [Gerrit] jquery.makeCollapsible: add a few options to the jQuery plugin - change (mediawiki/core)

2013-03-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53963 Change subject: jquery.makeCollapsible: add a few options to the jQuery plugin .. jquery.makeCollapsible: add a few options to the jQuery plu

[MediaWiki-commits] [Gerrit] jquery.makeCollapsible: move helper functions to the outer s... - change (mediawiki/core)

2013-03-14 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53798 Change subject: jquery.makeCollapsible: move helper functions to the outer scope .. jquery.makeCollapsible: move helper functions to the oute

[MediaWiki-commits] [Gerrit] jQuery.makeCollapsible: clean up the handler toggling logic - change (mediawiki/core)

2013-03-13 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53685 Change subject: jQuery.makeCollapsible: clean up the handler toggling logic .. jQuery.makeCollapsible: clean up the handler toggling logic M

[MediaWiki-commits] [Gerrit] IcuCollation::$tailoringFirstLetters: implement letter removal - change (mediawiki/core)

2013-03-12 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53384 Change subject: IcuCollation::$tailoringFirstLetters: implement letter removal .. IcuCollation::$tailoringFirstLetters: implement letter remo

[MediaWiki-commits] [Gerrit] IcuCollation::$tailoringFirstLetters: implement letter removal - change (mediawiki/core)

2013-03-12 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53383 Change subject: IcuCollation::$tailoringFirstLetters: implement letter removal .. IcuCollation::$tailoringFirstLetters: implement letter remo

[MediaWiki-commits] [Gerrit] IcuCollation::$tailoringFirstLetters: implement letter removal - change (mediawiki/core)

2013-03-11 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53275 Change subject: IcuCollation::$tailoringFirstLetters: implement letter removal .. IcuCollation::$tailoringFirstLetters: implement letter remo

[MediaWiki-commits] [Gerrit] (bug 25325) fix wlexcludeuser for ApiFeedWatchlist - change (mediawiki/core)

2013-03-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53049 Change subject: (bug 25325) fix wlexcludeuser for ApiFeedWatchlist .. (bug 25325) fix wlexcludeuser for ApiFeedWatchlist The effect of setti

[MediaWiki-commits] [Gerrit] $.makecollapsible: interleave ifs, fixing issues caused by w... - change (mediawiki/core)

2013-03-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53048 Change subject: $.makecollapsible: interleave ifs, fixing issues caused by wrong nesting .. $.makecollapsible: interleave ifs, fixing issues

[MediaWiki-commits] [Gerrit] $.makeCollapsible: don't declare functions together with var... - change (mediawiki/core)

2013-03-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53047 Change subject: $.makeCollapsible: don't declare functions together with variables .. $.makeCollapsible: don't declare functions together wi

[MediaWiki-commits] [Gerrit] mediawiki.action.edit.js: remove a weird hack from 2010 - change (mediawiki/core)

2013-03-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/53029 Change subject: mediawiki.action.edit.js: remove a weird hack from 2010 .. mediawiki.action.edit.js: remove a weird hack from 2010 Introduce

[MediaWiki-commits] [Gerrit] lowercase second character in digraph letters in IcuCollatio... - change (mediawiki/core)

2013-03-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52986 Change subject: lowercase second character in digraph letters in IcuCollation tailorings .. lowercase second character in digraph letters in

[MediaWiki-commits] [Gerrit] (bug 45911) Set $wgCategoryCollation to 'uca-pt' for the Por... - change (operations/mediawiki-config)

2013-03-08 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52903 Change subject: (bug 45911) Set $wgCategoryCollation to 'uca-pt' for the Portuguese Wikipedia and Wikibooks .. (bug 45911) Set $wgCategoryCo

[MediaWiki-commits] [Gerrit] (bug 45446) Set $wgCategoryCollation to 'uca-sv' for the Swe... - change (operations/mediawiki-config)

2013-03-08 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52902 Change subject: (bug 45446) Set $wgCategoryCollation to 'uca-sv' for the Swedish Wikipedia .. (bug 45446) Set $wgCategoryCollation to 'uca-s

[MediaWiki-commits] [Gerrit] (bug 45444) Set $wgCategoryCollation to 'uca-uk' for the Ukr... - change (operations/mediawiki-config)

2013-03-08 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52901 Change subject: (bug 45444) Set $wgCategoryCollation to 'uca-uk' for the Ukrainian Wikipedia .. (bug 45444) Set $wgCategoryCollation to 'uca

[MediaWiki-commits] [Gerrit] (bug 23393) (bug 45803) Parser: fix whitespace handling with... - change (mediawiki/core)

2013-03-06 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52451 Change subject: (bug 23393) (bug 45803) Parser: fix whitespace handling within headings .. (bug 23393) (bug 45803) Parser: fix whitespace ha

[MediaWiki-commits] [Gerrit] IcuCollation::$tailoringFirstLetters: 'en', 'it', 'hu', 'pt'... - change (mediawiki/core)

2013-03-05 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52232 Change subject: IcuCollation::$tailoringFirstLetters: 'en', 'it', 'hu', 'pt', 'uk' verified .. IcuCollation::$tailoringFirstLetters: 'en', '

[MediaWiki-commits] [Gerrit] (bug 45677) CSSJanus: support text-shadow and box-shadow fli... - change (mediawiki/core)

2013-03-04 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/52031 Change subject: (bug 45677) CSSJanus: support text-shadow and box-shadow flipping .. (bug 45677) CSSJanus: support text-shadow and box-shado

[MediaWiki-commits] [Gerrit] Vector: clean up background-images on the tabs - change (mediawiki/core)

2013-03-03 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51901 Change subject: Vector: clean up background-images on the tabs .. Vector: clean up background-images on the tabs They had unnecessary blue "

[MediaWiki-commits] [Gerrit] Vector: fix jump-to-navigation link href - change (mediawiki/core)

2013-03-03 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51895 Change subject: Vector: fix jump-to-navigation link href .. Vector: fix jump-to-navigation link href We can use the recently introduced #mw-

[MediaWiki-commits] [Gerrit] $.collapsibleTabs: rewrite code for expandCondition and coll... - change (mediawiki...Vector)

2013-03-03 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51892 Change subject: $.collapsibleTabs: rewrite code for expandCondition and collapseCondition .. $.collapsibleTabs: rewrite code for expandCondi

[MediaWiki-commits] [Gerrit] adjusted comments for IcuCollation::$tailoringFirstLetters - change (mediawiki/core)

2013-02-28 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51359 Change subject: adjusted comments for IcuCollation::$tailoringFirstLetters .. adjusted comments for IcuCollation::$tailoringFirstLetters Mor

[MediaWiki-commits] [Gerrit] (bug 42413) Set $wgCategoryCollation to 'uca-pl' for the Pol... - change (operations/mediawiki-config)

2013-02-27 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51183 Change subject: (bug 42413) Set $wgCategoryCollation to 'uca-pl' for the Polish Wikipedia .. (bug 42413) Set $wgCategoryCollation to 'uca-pl

[MediaWiki-commits] [Gerrit] Revert "(bug 29788) Swedish Collation (uppercase-sv). Swaps ... - change (mediawiki/core)

2013-02-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/51025 Change subject: Revert "(bug 29788) Swedish Collation (uppercase-sv). Swaps Ä and Æ" .. Revert "(bug 29788) Swedish Collation (uppercase-sv)

[MediaWiki-commits] [Gerrit] (bug 45142) dirty RTL CSS hack for Opera - change (mediawiki...UniversalLanguageSelector)

2013-02-21 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/50183 Change subject: (bug 45142) dirty RTL CSS hack for Opera .. (bug 45142) dirty RTL CSS hack for Opera For some absolutely inexplicable reason

[MediaWiki-commits] [Gerrit] (bug 45163) make gerrit's link parser not match incomplete w... - change (operations/puppet)

2013-02-20 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/50029 Change subject: (bug 45163) make gerrit's link parser not match incomplete words .. (bug 45163) make gerrit's link parser not match incomplet

[MediaWiki-commits] [Gerrit] (bug 44988) unbreak $.suggestions up/down arrow navigation [... - change (mediawiki/core)

2013-02-19 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/49850 Change subject: (bug 44988) unbreak $.suggestions up/down arrow navigation [regression] .. (bug 44988) unbreak $.suggestions up/down arrow n

[MediaWiki-commits] [Gerrit] (bug 43799) create language-specific collations for category... - change (mediawiki/core)

2013-02-18 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/49776 Change subject: (bug 43799) create language-specific collations for category sorting .. (bug 43799) create language-specific collations for

[MediaWiki-commits] [Gerrit] (bug 45056) Remove head icon from Vector and Monobook skins - change (mediawiki/core)

2013-02-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/49367 Change subject: (bug 45056) Remove head icon from Vector and Monobook skins .. (bug 45056) Remove head icon from Vector and Monobook skins C

[MediaWiki-commits] [Gerrit] (bug 41729) [DRAFT] display editsection links next to headin... - change (mediawiki/core)

2013-02-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/49364 Change subject: (bug 41729) [DRAFT] display editsection links next to headings .. (bug 41729) [DRAFT] display editsection links next to headi

[MediaWiki-commits] [Gerrit] fix a typo in generateCollationData.php - change (mediawiki/core)

2013-02-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: fix a typo in generateCollationData.php .. fix a typo in generateCollationData.php Follow-up to I85353559. Change-Id: If65589d9f2b855849ca34a13eef2bce3377252ef ---

[MediaWiki-commits] [Gerrit] (bug 43802) Do not bundle first-letters-root.ser with MediaW... - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 43802) Do not bundle first-letters-root.ser with MediaWiki .. (bug 43802) Do not bundle first-letters-root.ser with MediaWiki According to eaeea84 it was genera

[MediaWiki-commits] [Gerrit] stop pretending we support locales in ICU collation - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: stop pretending we support locales in ICU collation .. stop pretending we support locales in ICU collation Let's throw an exception right in the constructor instead

[MediaWiki-commits] [Gerrit] (bug 35974) $.suggestions, mw.searchSuggest: fix form submis... - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 35974) $.suggestions, mw.searchSuggest: fix form submission .. (bug 35974) $.suggestions, mw.searchSuggest: fix form submission Don't override form submission b

[MediaWiki-commits] [Gerrit] $.suggestions: make it possible to re-show suggestions - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: $.suggestions: make it possible to re-show suggestions .. $.suggestions: make it possible to re-show suggestions This patch makes it possible to re-show suggestions

[MediaWiki-commits] [Gerrit] (bug 40354) Add support for formatnum in jqueryMsg parser - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 40354) Add support for formatnum in jqueryMsg parser .. (bug 40354) Add support for formatnum in jqueryMsg parser Support for {{formatnum:$1}} and {{formatnum:$

[MediaWiki-commits] [Gerrit] mediawiki.jqueryMsg: Fix regression and add tests. - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: mediawiki.jqueryMsg: Fix regression and add tests. .. mediawiki.jqueryMsg: Fix regression and add tests. From If060b75f. Thanks to jshint and us using Checkstyle re

[MediaWiki-commits] [Gerrit] (bug 44459) Ensure jqueryMsg treats plain messages as plain, ... - change (mediawiki/core)

2013-02-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44459) Ensure jqueryMsg treats plain messages as plain, with tests. .. (bug 44459) Ensure jqueryMsg treats plain messages as plain, with tests. * Minor comment

[MediaWiki-commits] [Gerrit] adjustments to footer cleanup's CSS - change (mediawiki...Vector)

2013-02-07 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: adjustments to footer cleanup's CSS .. adjustments to footer cleanup's CSS Almost no functional changes, just cleanup. * Added comments * Removed some direct-ancest

[MediaWiki-commits] [Gerrit] made the footer cleanup script suck less - change (mediawiki...Vector)

2013-02-07 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: made the footer cleanup script suck less .. made the footer cleanup script suck less Rewrote it to make it a little more readable and discovered a couple of bugs in

[MediaWiki-commits] [Gerrit] (bug 29472) kill $wgUseDynamicDates - change (mediawiki/core[master])

2013-02-06 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 29472) kill $wgUseDynamicDates .. (bug 29472) kill $wgUseDynamicDates Remove $wgUseDynamicDates and everything related to it. I left DateFormatter::reformat()

[MediaWiki-commits] [Gerrit] (bug 44385) make ext.vector.collapsibleTabs actually work - change (mediawiki...Vector[master])

2013-02-06 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44385) make ext.vector.collapsibleTabs actually work .. (bug 44385) make ext.vector.collapsibleTabs actually work It didn't hide empty dropdown since the headin

[MediaWiki-commits] [Gerrit] (bug 44385) clean up jquery.collapsibleTabs vs ext.vector.co... - change (mediawiki...Vector[master])

2013-02-05 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44385) clean up jquery.collapsibleTabs vs ext.vector.collapsibleTabs .. (bug 44385) clean up jquery.collapsibleTabs vs ext.vector.collapsibleTabs Moving some s

[MediaWiki-commits] [Gerrit] (bug 44385) move jquery.collapsibleTabs module to Vector ext... - change (mediawiki/core[master])

2013-02-05 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44385) move jquery.collapsibleTabs module to Vector extension .. (bug 44385) move jquery.collapsibleTabs module to Vector extension It was entirely Vector-exte

[MediaWiki-commits] [Gerrit] (bug 44385) move jquery.collapsibleTabs module from MediaWik... - change (mediawiki...Vector[master])

2013-02-05 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44385) move jquery.collapsibleTabs module from MediaWiki core .. (bug 44385) move jquery.collapsibleTabs module from MediaWiki core It was entirely Vector-exte

[MediaWiki-commits] [Gerrit] specify width and height of a SVG image to ensure it scales ... - change (mediawiki...timeline[master])

2013-02-03 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: specify width and height of a SVG image to ensure it scales properly .. specify width and height of a SVG image to ensure it scales properly Change-Id: Iaa9da5de592

[MediaWiki-commits] [Gerrit] omit the .ttf extension in default font name - change (mediawiki...timeline[master])

2013-02-01 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: omit the .ttf extension in default font name .. omit the .ttf extension in default font name Per the Ploticus docs[1], font name shouldn't include the .ttf extension

[MediaWiki-commits] [Gerrit] fixes for install-ploticus.sh - change (mediawiki...timeline[master])

2013-01-31 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: fixes for install-ploticus.sh .. fixes for install-ploticus.sh * fixed typos in comments * cd into the script's directory before doing anything, to ensure that the

[MediaWiki-commits] [Gerrit] whitelist Brian Wolff (bawolff) - change (integration/zuul-config[master])

2013-01-30 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: whitelist Brian Wolff (bawolff) .. whitelist Brian Wolff (bawolff) I noticed that his commits aren't being tested and thought that they certainly could be. Change-

[MediaWiki-commits] [Gerrit] (bug 20234) change how Vector's tabs behave on small resolut... - change (mediawiki/core[master])

2013-01-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 20234) change how Vector's tabs behave on small resolutions .. (bug 20234) change how Vector's tabs behave on small resolutions Instead of overlapping, the "rig

[MediaWiki-commits] [Gerrit] make collapsibleTabs more resilient to CSS changes in Vector... - change (mediawiki...Vector[master])

2013-01-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: make collapsibleTabs more resilient to CSS changes in Vector skin .. make collapsibleTabs more resilient to CSS changes in Vector skin Using .offset() instead of .p

[MediaWiki-commits] [Gerrit] remove unused lqt-quote and lqt-quote-intro messages - change (mediawiki...LiquidThreads[master])

2013-01-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: remove unused lqt-quote and lqt-quote-intro messages .. remove unused lqt-quote and lqt-quote-intro messages As far as I could see, these are unused since 2009, comm

[MediaWiki-commits] [Gerrit] (bug 42198) fix ext.wikiEditor.publish so that it actually w... - change (mediawiki...WikiEditor[master])

2013-01-21 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42198) fix ext.wikiEditor.publish so that it actually works .. (bug 42198) fix ext.wikiEditor.publish so that it actually works Two fixes: * The Cancel button

[MediaWiki-commits] [Gerrit] add styles for low definition displays to the Vector skin - change (mediawiki/core[master])

2013-01-20 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: add styles for low definition displays to the Vector skin .. add styles for low definition displays to the Vector skin Change-Id: I13e4ea5647d7b23c1af714251e450c3551

[MediaWiki-commits] [Gerrit] (bug 44141) Clean up usage of one-pixel images in Vector's C... - change (mediawiki/core[master])

2013-01-19 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44141) Clean up usage of one-pixel images in Vector's CSS .. (bug 44141) Clean up usage of one-pixel images in Vector's CSS Removed appropriate background-image

[MediaWiki-commits] [Gerrit] (bug 43804) fix docs in generateCollationData.php - change (mediawiki/core[master])

2013-01-18 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 43804) fix docs in generateCollationData.php .. (bug 43804) fix docs in generateCollationData.php They previously advertised using versions which were apparentl

[MediaWiki-commits] [Gerrit] (bug 43801) add getters for intl and ICU version to ICUColla... - change (mediawiki/core[master])

2013-01-18 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 43801) add getters for intl and ICU version to ICUCollation .. (bug 43801) add getters for intl and ICU version to ICUCollation They will be necessary to be abl

[MediaWiki-commits] [Gerrit] (bug 44063) use .hasOwnProperty when checking for presence o... - change (mediawiki...ApiSandbox[master])

2013-01-18 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 44063) use .hasOwnProperty when checking for presence of object keys .. (bug 44063) use .hasOwnProperty when checking for presence of object keys Otherwise Fir

[MediaWiki-commits] [Gerrit] consistently use for user-visible errors - change (mediawiki...timeline[master])

2013-01-16 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: consistently use for user-visible errors .. consistently use for user-visible errors Some parts of the code used , some used plain without the "error" class, and

[MediaWiki-commits] [Gerrit] (bug 43981) disable live preview on user .js/.css pages - change (mediawiki/core[master])

2013-01-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 43981) disable live preview on user .js/.css pages .. (bug 43981) disable live preview on user .js/.css pages Disable live preview on user .js/.css pages, as th

[MediaWiki-commits] [Gerrit] (bug 40124) allow arbitrary user preferences prefixed with '... - change (mediawiki/core[wmf/1.21wmf7])

2013-01-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 40124) allow arbitrary user preferences prefixed with 'userjs-' .. (bug 40124) allow arbitrary user preferences prefixed with 'userjs-' Before change I98df55f2

[MediaWiki-commits] [Gerrit] Update FlaggedRevs to master - change (mediawiki/core[wmf/1.21wmf7])

2013-01-11 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: Update FlaggedRevs to master .. Update FlaggedRevs to master I1a49ad7b fixes a major bug, it'd be nice to get it on the wikis using FR sooner than later. Change-Id

[MediaWiki-commits] [Gerrit] adjust release note about I45b077cf - change (mediawiki/core[master])

2013-01-10 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: adjust release note about I45b077cf .. adjust release note about I45b077cf It's not a config change; it simply introduces a new global config variable. Change-Id: I

[MediaWiki-commits] [Gerrit] whitelist Bartosz Dziewoński (Matma Rex) - change (integration/zuul-config[master])

2013-01-07 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: whitelist Bartosz Dziewoński (Matma Rex) .. whitelist Bartosz Dziewoński (Matma Rex) I'm not sure if I am that "long term" (submitting patches since September 2012,

[MediaWiki-commits] [Gerrit] $.tablesorter: remove and inline getTextFromRowAndCellIndex(... - change (mediawiki/core[master])

2013-01-04 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: $.tablesorter: remove and inline getTextFromRowAndCellIndex() .. $.tablesorter: remove and inline getTextFromRowAndCellIndex() It introduced unnecessary indirection

[MediaWiki-commits] [Gerrit] Pull settings' summaries from MediaWiki wiki - change (mediawiki...Configure[master])

2012-12-23 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: Pull settings' summaries from MediaWiki wiki .. Pull settings' summaries from MediaWiki wiki Change-Id: I14f5815a807fc5ac7ed3b147b546ba2c475ef1f3 --- M settings/Sett

[MediaWiki-commits] [Gerrit] Add missing messages for $wgUpdateCompatibleMetadata - change (mediawiki...Configure[master])

2012-12-23 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: Add missing messages for $wgUpdateCompatibleMetadata .. Add missing messages for $wgUpdateCompatibleMetadata It was present in Settings-core.php, but not in the i18n

[MediaWiki-commits] [Gerrit] Remove everything related to nonexistent $wgExcludeFromThumb... - change (mediawiki...Configure[master])

2012-12-23 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: Remove everything related to nonexistent $wgExcludeFromThumbnailPurge .. Remove everything related to nonexistent $wgExcludeFromThumbnailPurge It has no documentati

[MediaWiki-commits] [Gerrit] (bug 42354) final and ultimate fix, for JS this time - change (mediawiki...Vector[master])

2012-12-23 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42354) final and ultimate fix, for JS this time .. (bug 42354) final and ultimate fix, for JS this time Change-Id: I0a05ed3983cf35235b5813d64283ad2d0313a5c9 ---

[MediaWiki-commits] [Gerrit] (bug 658) don't use a for the TOC - change (mediawiki/core[master])

2012-12-21 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 658) don't use a for the TOC .. (bug 658) don't use a for the TOC It makes no sense semantically; it was only used to make the TOC not span full width of the

[MediaWiki-commits] [Gerrit] applying code conventions and cleanup in mediawiki.special.* - change (mediawiki/core[master])

2012-12-16 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: applying code conventions and cleanup in mediawiki.special.* .. applying code conventions and cleanup in mediawiki.special.* Using standard closures per [[CC/JS]], t

[MediaWiki-commits] [Gerrit] drop "@fixed" annotations in CologneBlue skin - change (mediawiki/core[master])

2012-12-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: drop "@fixed" annotations in CologneBlue skin .. drop "@fixed" annotations in CologneBlue skin These were only useful for me when I was refactoring the code, and are

[MediaWiki-commits] [Gerrit] (bug 42497) do not use fake values for {{PLURAL: in newmessa... - change (mediawiki/core[master])

2012-12-13 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42497) do not use fake values for {{PLURAL: in newmessages* messages .. (bug 42497) do not use fake values for {{PLURAL: in newmessages* messages There were tw

[MediaWiki-commits] [Gerrit] (bug 40124) [DRAFT] allow non-default preferences prefixed w... - change (mediawiki/core[master])

2012-12-07 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 40124) [DRAFT] allow non-default preferences prefixed with 'userjs-' .. (bug 40124) [DRAFT] allow non-default preferences prefixed with 'userjs-' Before change

[MediaWiki-commits] [Gerrit] (bug 42604) fix faulty browser detection code for Opera - change (mediawiki/core[master])

2012-12-01 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42604) fix faulty browser detection code for Opera .. (bug 42604) fix faulty browser detection code for Opera Opera's `navigator.userAgent` might not include th

[MediaWiki-commits] [Gerrit] (bug 42491) Merge wikimedia-copyrightwarning and wikimedia-e... - change (mediawiki...WikimediaMessages[master])

2012-11-28 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42491) Merge wikimedia-copyrightwarning and wikimedia-editpage-tos-summary .. (bug 42491) Merge wikimedia-copyrightwarning and wikimedia-editpage-tos-summary S

[MediaWiki-commits] [Gerrit] release notes for I9a2ebd50 - change (mediawiki/core[master])

2012-11-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: release notes for I9a2ebd50 .. release notes for I9a2ebd50 I forgot them earlier, sorry. Change-Id: I08236ae05edb0d96febb4bb01fc8d15324d327bd --- M RELEASE-NOTES-1.

[MediaWiki-commits] [Gerrit] (bug 41342) fix a race condition in mw.searchSuggest - change (mediawiki/core[master])

2012-11-24 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 41342) fix a race condition in mw.searchSuggest .. (bug 41342) fix a race condition in mw.searchSuggest mw.searchSuggest wouldn't cancel a suggestions request w

[MediaWiki-commits] [Gerrit] (bug 34876) improve $.makeCollapsible performance on the ini... - change (mediawiki/core[master])

2012-11-24 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 34876) improve $.makeCollapsible performance on the initial collapsing .. (bug 34876) improve $.makeCollapsible performance on the initial collapsing The logic

[MediaWiki-commits] [Gerrit] (bug 26617) clean up usages of list-style in Vector&Monobook... - change (mediawiki/core[master])

2012-11-17 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 26617) clean up usages of list-style in Vector&Monobook CSS .. (bug 26617) clean up usages of list-style in Vector&Monobook CSS * remove list-style-*: none from

[MediaWiki-commits] [Gerrit] (bug 40850) always adjust prevSafeVal in $.byteLimit - change (mediawiki/core[master])

2012-11-15 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 40850) always adjust prevSafeVal in $.byteLimit .. (bug 40850) always adjust prevSafeVal in $.byteLimit Not doing this sometimes caused trimValForByteLength to

[MediaWiki-commits] [Gerrit] (bug 42097) a stopgap solution for $.tablesorter hanging on ... - change (mediawiki/core[master])

2012-11-14 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 42097) a stopgap solution for $.tablesorter hanging on pare load .. (bug 42097) a stopgap solution for $.tablesorter hanging on pare load See the bug for detai

[MediaWiki-commits] [Gerrit] (bug 41886) make $.tablesorter support headers with colspan - change (mediawiki/core[master])

2012-11-09 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 41886) make $.tablesorter support headers with colspan .. (bug 41886) make $.tablesorter support headers with colspan Previously, if a header had colspan set, a

[MediaWiki-commits] [Gerrit] (bug 37158) display personal menu on top of page tabs on Vec... - change (mediawiki/core[master])

2012-11-01 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 37158) display personal menu on top of page tabs on Vector .. (bug 37158) display personal menu on top of page tabs on Vector If personal menu is long enough to

[MediaWiki-commits] [Gerrit] (bug 36276) add redlink styles to legacy shared.css - change (mediawiki/core[master])

2012-11-01 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 36276) add redlink styles to legacy shared.css .. (bug 36276) add redlink styles to legacy shared.css This is mostly intended to fix the display in Myskin. Cha

[MediaWiki-commits] [Gerrit] rephrase underline-default message - change (mediawiki/core[master])

2012-11-01 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: rephrase underline-default message .. rephrase underline-default message Most skins override this, so this isn't really the browser's default. Change-Id: Iafc5837f4

[MediaWiki-commits] [Gerrit] make addPortletLink work with CologneBlue - change (mediawiki/core[master])

2012-10-31 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: make addPortletLink work with CologneBlue .. make addPortletLink work with CologneBlue To achieve this: * remove the special-casing in mw.util * use standard portlet

[MediaWiki-commits] [Gerrit] add sidebar-heading message - change (mediawiki/core[master])

2012-10-27 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: add sidebar-heading message .. add sidebar-heading message Change-Id: I9a2ebd503ec9dd901802a9b3b1f5137a85990373 --- M languages/messages/MessagesEn.php M languages/m

[MediaWiki-commits] [Gerrit] CologneBlue rewrite: output the sidebar items as lists - change (mediawiki/core[master])

2012-10-27 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: CologneBlue rewrite: output the sidebar items as lists .. CologneBlue rewrite: output the sidebar items as lists This fixes the second part of bug 41456. Also * w

[MediaWiki-commits] [Gerrit] CologneBlue rewrite: rework quickbar() once again - change (mediawiki/core[master])

2012-10-27 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: CologneBlue rewrite: rework quickbar() once again .. CologneBlue rewrite: rework quickbar() once again * three separate phases: * semantic modifications (adding ne

[MediaWiki-commits] [Gerrit] fix sidebar HTML escaping in CologneBlue (again) - change (mediawiki/core[master])

2012-10-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: fix sidebar HTML escaping in CologneBlue (again) .. fix sidebar HTML escaping in CologneBlue (again) Followup to I6df92c62. Change-Id: If9394a6223da987dc363057e276c

[MediaWiki-commits] [Gerrit] (bug 41349) improve selectors for search suggestions - change (mediawiki/core[master])

2012-10-24 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: (bug 41349) improve selectors for search suggestions .. (bug 41349) improve selectors for search suggestions They were hardcoded with no explanation. Added comments,

[MediaWiki-commits] [Gerrit] fix indenting in footerCleanup.js - change (mediawiki...Vector[master])

2012-10-23 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: fix indenting in footerCleanup.js .. fix indenting in footerCleanup.js Something was borked here. Also other whitespace/comment changes while we're at it. Change-I

[MediaWiki-commits] [Gerrit] fix sidebar HTML escaping in CologneBlue - change (mediawiki/core[master])

2012-10-22 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: fix sidebar HTML escaping in CologneBlue .. fix sidebar HTML escaping in CologneBlue In my defense, it wasn't documented anywhere that it isn't safe to output. I add

[MediaWiki-commits] [Gerrit] document Skin::buildSidebar per own experience with CologneB... - change (mediawiki/core[master])

2012-10-22 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review. Change subject: document Skin::buildSidebar per own experience with CologneBlue .. document Skin::buildSidebar per own experience with CologneBlue Change-Id: If56df0a7ce20bc8f7a7325

<    1   2   3   4   >