[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing jQueryMsg dependency

2018-01-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402459 ) Change subject: Add missing jQueryMsg dependency .. Add missing jQueryMsg dependency Some of these messages use jQueryMsg-only

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Fix 1 change

2018-01-04 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402177 ) Change subject: RCFilters: Fix 1 change .. RCFilters: Fix 1 change Fix typo so it's '1 change' instead of 'change'. Bug: T182241

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Remove Ruby browser tests

2017-12-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399131 ) Change subject: Remove Ruby browser tests .. Remove Ruby browser tests The continuous integration infrastructure for these is being

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Remove Ruby browser tests

2017-12-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399130 ) Change subject: Remove Ruby browser tests .. Remove Ruby browser tests The continuous integration infrastructure for these is being

[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Remove Ruby browser tests

2017-12-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399129 ) Change subject: Remove Ruby browser tests .. Remove Ruby browser tests The continuous integration infrastructure for these is being

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DO NOT MERGE: Throw SQL timeout

2017-10-22 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385940 ) Change subject: DO NOT MERGE: Throw SQL timeout .. DO NOT MERGE: Throw SQL timeout Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix SVG href error messaage to be more accurate and useful

2017-10-11 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383502 ) Change subject: Fix SVG href error messaage to be more accurate and useful .. Fix SVG href error messaage to be more accurate and

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Improve board_text AbuseFilter variable description to match...

2017-10-09 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383060 ) Change subject: Improve board_text AbuseFilter variable description to match std AF .. Improve board_text AbuseFilter variable

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Fire-and-forget EventLogging for link clicks

2017-09-20 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379468 ) Change subject: Fire-and-forget EventLogging for link clicks .. Fire-and-forget EventLogging for link clicks Analytics recommends

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Simplify link logging for target=_blank

2017-09-20 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379466 ) Change subject: Simplify link logging for target=_blank .. Simplify link logging for target=_blank We still use the promises (it

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.18]: WLFilters: Handle (un)seen (un)filled bullets on grouped RC

2017-09-19 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378929 ) Change subject: WLFilters: Handle (un)seen (un)filled bullets on grouped RC .. WLFilters: Handle (un)seen (un)filled bullets on

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[wmf/1.30.0-wmf.18]: RCFilters tours: Only load on specific page

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378836 ) Change subject: RCFilters tours: Only load on specific page .. RCFilters tours: Only load on specific page Bug: T167262 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[wmf/1.30.0-wmf.18]: Allow directly launching tour from server without ?tour= or ...

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378835 ) Change subject: Allow directly launching tour from server without ?tour= or cookies .. Allow directly launching tour from server

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WLFilters: Handle (un)seen (un)filled bullets on grouped RC

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378832 ) Change subject: WLFilters: Handle (un)seen (un)filled bullets on grouped RC .. WLFilters: Handle (un)seen (un)filled bullets on

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Allow directly launching tour from server without ?tour= or ...

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378827 ) Change subject: Allow directly launching tour from server without ?tour= or cookies .. Allow directly launching tour from server

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP: RCFilters: Display specific error if query times out.

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378687 ) Change subject: WIP: RCFilters: Display specific error if query times out. .. WIP: RCFilters: Display specific error if query times

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Detect query timeouts and throw a specific exception

2017-09-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378683 ) Change subject: Detect query timeouts and throw a specific exception .. Detect query timeouts and throw a specific exception Throw

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Preference length is in bytes, so use $.byteLimit

2017-09-12 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377691 ) Change subject: RCFilters: Preference length is in bytes, so use $.byteLimit .. RCFilters: Preference length is in bytes, so use

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Followup Newsletter talk: Must be numeric

2017-09-12 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377668 ) Change subject: Followup Newsletter talk: Must be numeric .. Followup Newsletter talk: Must be numeric Must use numeric ID here to

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable Flow on Newsletter_talk on mediawiki.org

2017-09-12 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377657 ) Change subject: Enable Flow on Newsletter_talk on mediawiki.org .. Enable Flow on Newsletter_talk on mediawiki.org All talk

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add class marking whether RCFilters is enabled

2017-09-11 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377201 ) Change subject: Add class marking whether RCFilters is enabled .. Add class marking whether RCFilters is enabled Also added

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Add documentation for 'autoFocus' and 'width'

2017-09-08 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376854 ) Change subject: Add documentation for 'autoFocus' and 'width' .. Add documentation for 'autoFocus' and 'width' Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP: RCFilters: Keep the default for replaced filters, but a...

2017-09-08 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376794 ) Change subject: WIP: RCFilters: Keep the default for replaced filters, but allow override .. WIP: RCFilters: Keep the default for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Remove getValue and use FormOptions

2017-09-08 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376793 ) Change subject: RCFilters: Remove getValue and use FormOptions .. RCFilters: Remove getValue and use FormOptions Bug: T174725

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Prioritize the secondary link, so it shows (without needing ...

2017-09-07 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376646 ) Change subject: Prioritize the secondary link, so it shows (without needing ... menu) .. Prioritize the secondary link, so it shows

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix interpretation of 'prioritized'

2017-09-07 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376644 ) Change subject: Fix interpretation of 'prioritized' .. Fix interpretation of 'prioritized' Docs (especially in

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Move handling for missing post content to lower level

2017-09-07 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376478 ) Change subject: Move handling for missing post content to lower level .. Move handling for missing post content to lower level *

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: More thorough documentation for ChangesListSpecialPageStruct...

2017-09-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376155 ) Change subject: More thorough documentation for ChangesListSpecialPageStructuredFilters .. More thorough documentation for

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: Revert "WLFilters: fix msg keys to comply with standard"

2017-09-05 Thread Mattflaschen (Code Review)
Hello Jack Phoenix, Sbisson, jenkins-bot, Siebrand, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/376038 to review the following change. Change subject: Revert "WLFilters: fix msg keys to comply with standard"

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[wmf/1.30.0-wmf.16]: Revert "RCFilters: Note that these are now available on the ...

2017-09-05 Thread Mattflaschen (Code Review)
Hello jenkins-bot, Siebrand, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/376040 to review the following change. Change subject: Revert "RCFilters: Note that these are now available on the Watchlist too"

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: Revert "WLFilters: reword watchlist-details slightly"

2017-09-05 Thread Mattflaschen (Code Review)
Hello Sbisson, jenkins-bot, Siebrand, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/376039 to review the following change. Change subject: Revert "WLFilters: reword watchlist-details slightly"

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: WLFilters: adapt to customized watchlist-details

2017-09-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376030 ) Change subject: WLFilters: adapt to customized watchlist-details .. WLFilters: adapt to customized watchlist-details The

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: WLFilters: fix msg keys to comply with standard

2017-09-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376032 ) Change subject: WLFilters: fix msg keys to comply with standard .. WLFilters: fix msg keys to comply with standard Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: WLFilters: wrap Watchlist-details in a div instead of a p

2017-09-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376031 ) Change subject: WLFilters: wrap Watchlist-details in a div instead of a p .. WLFilters: wrap Watchlist-details in a div instead of a p

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Note that namemsg also works for custom action button text.

2017-08-31 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375098 ) Change subject: Note that namemsg also works for custom action button text. .. Note that namemsg also works for custom action button

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix interwiki

2017-08-31 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375051 ) Change subject: Fix interwiki .. Fix interwiki Missed the wgInterwikiCache Change-Id: Ica05c1365e29732ed042d984e31b76422c95ccbc ---

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: WLFilters: fix server-side tag filtering

2017-08-31 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375047 ) Change subject: WLFilters: fix server-side tag filtering .. WLFilters: fix server-side tag filtering Tag filtering was enabled in the

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.16]: WLFilters: convert 'edit watchlist' button to new UX

2017-08-31 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375039 ) Change subject: WLFilters: convert 'edit watchlist' button to new UX .. WLFilters: convert 'edit watchlist' button to new UX Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.15]: WLFilters: convert 'edit watchlist' button to new UX

2017-08-31 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375038 ) Change subject: WLFilters: convert 'edit watchlist' button to new UX .. WLFilters: convert 'edit watchlist' button to new UX Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix interwiki links on Labs

2017-08-30 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374922 ) Change subject: Fix interwiki links on Labs .. Fix interwiki links on Labs Bug: T69931 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[wmf/1.30.0-wmf.16]: RCFilters: Note that these are now available on the Watchlis...

2017-08-29 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374670 ) Change subject: RCFilters: Note that these are now available on the Watchlist too .. RCFilters: Note that these are now available on

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.30.0-wmf.15]: Fix infinite scroll

2017-08-24 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373713 ) Change subject: Fix infinite scroll .. Fix infinite scroll Bug: T173807 Change-Id: I1c4be9438710cd0c7295ca8ea418c6f2352d468f (cherry

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Recompile handlebars

2017-08-22 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373140 ) Change subject: Recompile handlebars .. Recompile handlebars Change-Id: I5d9fed67fbb3c593d5959430c22caf42b413bf64 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WANCacheReapUpdate: Handle special pages without exception

2017-08-04 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370290 ) Change subject: WANCacheReapUpdate: Handle special pages without exception .. WANCacheReapUpdate: Handle special pages without

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: WIP: Allow loading revisions without content

2017-08-04 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370154 ) Change subject: WIP: Allow loading revisions without content .. WIP: Allow loading revisions without content The Data\Storage and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:Contribs: Ensure 'start' and 'end' are never undefined

2017-08-03 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370097 ) Change subject: Special:Contribs: Ensure 'start' and 'end' are never undefined .. Special:Contribs: Ensure 'start' and 'end' are never

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Remove externalstore role; instead use only for wikimediaflow

2017-08-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369586 ) Change subject: Remove externalstore role; instead use only for wikimediaflow .. Remove externalstore role; instead use only for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split minoredit into minoredit and enotif_minoredit

2017-07-27 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368331 ) Change subject: Split minoredit into minoredit and enotif_minoredit .. Split minoredit into minoredit and enotif_minoredit This

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Make emails for minor edits always available; keep defaults

2017-07-26 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368113 ) Change subject: Make emails for minor edits always available; keep defaults .. Make emails for minor edits always available; keep

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[wmf/1.30.0-wmf.10]: Add missing jQueryMsg dependency for mobile diff view

2017-07-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366899 ) Change subject: Add missing jQueryMsg dependency for mobile diff view .. Add missing jQueryMsg dependency for mobile diff view Bug:

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Fix http://php5.local.wmftest.net:8080 to actually be PHP 5 ...

2017-07-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366046 ) Change subject: Fix http://php5.local.wmftest.net:8080 to actually be PHP 5 (Zend) .. Fix http://php5.local.wmftest.net:8080 to

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: Add missing jQueryMsg dependency for mobile diff view

2017-07-18 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366028 ) Change subject: Add missing jQueryMsg dependency for mobile diff view .. Add missing jQueryMsg dependency for mobile diff view Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.30.0-wmf.7]: Do not override other flags on enhanced recent changes

2017-07-10 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364337 ) Change subject: Do not override other flags on enhanced recent changes .. Do not override other flags on enhanced recent changes Any

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clarify what $params is for ApiBase methods to get Title/Wik...

2017-07-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363754 ) Change subject: Clarify what $params is for ApiBase methods to get Title/WikiPage .. Clarify what $params is for ApiBase methods to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use shell_exec instead of backtick

2017-07-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363751 ) Change subject: Use shell_exec instead of backtick .. Use shell_exec instead of backtick They are exactly equivalent, but shell_exec

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Forbid backtick operator

2017-07-05 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363512 ) Change subject: Forbid backtick operator .. Forbid backtick operator It is identical to shell_exec, which is much more clear. There

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Remove dead code and messages

2017-06-28 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362089 ) Change subject: Remove dead code and messages .. Remove dead code and messages Change-Id: Ifbbf6844648940357df41d6998453edfe113c9a8

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: GenerateFlowAutoload: Call parent constructor

2017-06-26 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361515 ) Change subject: GenerateFlowAutoload: Call parent constructor .. GenerateFlowAutoload: Call parent constructor Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: Fix Thanks messages not say "received your thanks"

2017-06-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360785 ) Change subject: Fix Thanks messages not say "received your thanks" .. Fix Thanks messages not say "received your thanks" We don't

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RC Filters: Fix tags for integrated filters

2017-06-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360612 ) Change subject: RC Filters: Fix tags for integrated filters .. RC Filters: Fix tags for integrated filters Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Correct license to MIT

2017-06-20 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360585 ) Change subject: Correct license to MIT .. Correct license to MIT This extension overall is under MIT, per Echo.php, extension.json,

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Convert gen-autoload.php to maintenance script to fix error

2017-06-15 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359375 ) Change subject: Convert gen-autoload.php to maintenance script to fix error .. Convert gen-autoload.php to maintenance script to fix

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add | to error message about invalid change tag characters

2017-06-14 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359085 ) Change subject: Add | to error message about invalid change tag characters .. Add | to error message about invalid change tag

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix NoLangLinkHandler

2017-06-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357523 ) Change subject: Fix NoLangLinkHandler .. Fix NoLangLinkHandler Missing reference in 3b7445e0aff893524755497c8e57daf793b57ae1 ,

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.30.0-wmf.4]: Revert "Throw when unserializing invalid Flow workflow metad...

2017-06-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357501 ) Change subject: Revert "Throw when unserializing invalid Flow workflow metadata JSON" .. Revert "Throw when unserializing invalid

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.30.0-wmf.2]: Revert "Throw when unserializing invalid Flow workflow metad...

2017-06-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357500 ) Change subject: Revert "Throw when unserializing invalid Flow workflow metadata JSON" .. Revert "Throw when unserializing invalid

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Revert "Throw when unserializing invalid Flow workflow metad...

2017-06-06 Thread Mattflaschen (Code Review)
Hello Catrope, Sbisson, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/357445 to review the following change. Change subject: Revert "Throw when unserializing invalid Flow workflow metadata JSON"

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[REL1_28]: Handle Help:Guided tour/guider not existing, not being able ...

2017-06-06 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357443 ) Change subject: Handle Help:Guided tour/guider not existing, not being able to launch .. Handle Help:Guided tour/guider not existing,

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix user talk exception for blacklist

2017-05-30 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356320 ) Change subject: Fix user talk exception for blacklist .. Fix user talk exception for blacklist There was a null-dereference for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update \n handling for HTMLUsersMultiselectField

2017-05-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354982 ) Change subject: Update \n handling for HTMLUsersMultiselectField .. Update \n handling for HTMLUsersMultiselectField Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Trivial docfix in DiscussionParser

2017-05-20 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354665 ) Change subject: Trivial docfix in DiscussionParser .. Trivial docfix in DiscussionParser Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.1]: Gate option to save RC filters to default false

2017-05-11 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353479 ) Change subject: Gate option to save RC filters to default false .. Gate option to save RC filters to default false Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable saving RC Filters on Beta Cluster

2017-05-11 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353349 ) Change subject: Enable saving RC Filters on Beta Cluster .. Enable saving RC Filters on Beta Cluster Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Gate RC filters to default false

2017-05-11 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353336 ) Change subject: Gate RC filters to default false .. Gate RC filters to default false Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Make testing-access-wrapper require instead of require-dev

2017-05-10 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353213 ) Change subject: Make testing-access-wrapper require instead of require-dev .. Make testing-access-wrapper require instead of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make testing-access-wrap require instead of require-dev

2017-05-10 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353212 ) Change subject: Make testing-access-wrap require instead of require-dev .. Make testing-access-wrap require instead of require-dev

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: Support providing custom text instead of using the default a...

2017-05-08 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352707 ) Change subject: Support providing custom text instead of using the default action icon .. Support providing custom text instead of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change delimiter for multiple namespaces and tags to semi-colon

2017-05-07 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352542 ) Change subject: Change delimiter for multiple namespaces and tags to semi-colon .. Change delimiter for multiple namespaces and tags

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Convert mwdoc-filter.php to Maintenance", rm wfShell...

2017-05-03 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351743 ) Change subject: Revert "Convert mwdoc-filter.php to Maintenance", rm wfShellWikiCmd .. Revert "Convert mwdoc-filter.php to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix all the Doxygen for the RCFilters backend

2017-05-02 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351570 ) Change subject: Fix all the Doxygen for the RCFilters backend .. Fix all the Doxygen for the RCFilters backend Bug: T163069

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Convert mwdoc-filter.php to Maintenance class so --wiki works

2017-05-02 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351568 ) Change subject: Convert mwdoc-filter.php to Maintenance class so --wiki works .. Convert mwdoc-filter.php to Maintenance class so

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Fix multi-wiki support for onWfShellMaintenanceCmd

2017-05-02 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351567 ) Change subject: Fix multi-wiki support for onWfShellMaintenanceCmd .. Fix multi-wiki support for onWfShellMaintenanceCmd Add

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Document "What's This" group UI feature

2017-05-02 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351378 ) Change subject: Document "What's This" group UI feature .. Document "What's This" group UI feature Bug: T163069 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.29.0-wmf.21]: Fix incorrect find/replace for getUser causing fatal

2017-05-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351236 ) Change subject: Fix incorrect find/replace for getUser causing fatal .. Fix incorrect find/replace for getUser causing fatal

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix incorrect find/replace for getUser causing fatal

2017-05-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351233 ) Change subject: Fix incorrect find/replace for getUser causing fatal .. Fix incorrect find/replace for getUser causing fatal

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Add test case names for SpamFilter, to make which fails obvious

2017-05-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351218 ) Change subject: Add test case names for SpamFilter, to make which fails obvious .. Add test case names for SpamFilter, to make which

[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Import PHPUnit tests from Flow, plus one more

2017-05-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351216 ) Change subject: Import PHPUnit tests from Flow, plus one more .. Import PHPUnit tests from Flow, plus one more Based on Flow repo as

[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Clarify license and authorship statement

2017-05-01 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351202 ) Change subject: Clarify license and authorship statement .. Clarify license and authorship statement Follow-up to

[MediaWiki-commits] [Gerrit] mediawiki...GettingStarted[master]: Add number of pages to dump_redis.php

2017-04-29 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351098 ) Change subject: Add number of pages to dump_redis.php .. Add number of pages to dump_redis.php This is a proxy for the size used.

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.29.0-wmf.21]: Fix FlaggedRevs RC (RecentChanges and Watchlist) line indica...

2017-04-29 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351093 ) Change subject: Fix FlaggedRevs RC (RecentChanges and Watchlist) line indications .. Fix FlaggedRevs RC (RecentChanges and Watchlist)

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix FlaggedRevs RC (RecentChanges and Watchlist) line indica...

2017-04-28 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350968 ) Change subject: Fix FlaggedRevs RC (RecentChanges and Watchlist) line indications .. Fix FlaggedRevs RC (RecentChanges and Watchlist)

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix filter on Special:NewPages

2017-04-27 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350662 ) Change subject: Fix filter on Special:NewPages .. Fix filter on Special:NewPages Bug: T163994 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[wmf/1.29.0-wmf.20]: Hack around the fact that setting $wgHiddenPrefs from GetPre...

2017-04-24 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350010 ) Change subject: Hack around the fact that setting $wgHiddenPrefs from GetPreferences doesn't fully work .. Hack around the fact that

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: WIP: Transform user ID from repo to client in change prop

2017-04-24 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349977 ) Change subject: WIP: Transform user ID from repo to client in change prop .. WIP: Transform user ID from repo to client in change prop

[MediaWiki-commits] [Gerrit] mediawiki...ORES[wmf/1.29.0-wmf.20]: Add defaults for ores-damaging-flag-rc and oresHighlight

2017-04-24 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349960 ) Change subject: Add defaults for ores-damaging-flag-rc and oresHighlight .. Add defaults for ores-damaging-flag-rc and oresHighlight

[MediaWiki-commits] [Gerrit] mediawiki...ORES[wmf/1.29.0-wmf.20]: Make the preference for the "r" flag on the RC page also con...

2017-04-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349537 ) Change subject: Make the preference for the "r" flag on the RC page also control highlighting .. Make the preference for the "r" flag

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Add defaults for ores-damaging-flag-rc and oresHighlight

2017-04-21 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349534 ) Change subject: Add defaults for ores-damaging-flag-rc and oresHighlight .. Add defaults for ores-damaging-flag-rc and oresHighlight

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Force Labs to eqiad, since all the services are there.

2017-04-20 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349349 ) Change subject: Force Labs to eqiad, since all the services are there. .. Force Labs to eqiad, since all the services are there. The

[MediaWiki-commits] [Gerrit] mediawiki...Nuke[master]: Revert "Use $dbr->buildLike() instead of manual LIKE"

2017-04-20 Thread Mattflaschen (Code Review)
Hello Reedy, Jack Phoenix, Legoktm, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/349278 to review the following change. Change subject: Revert "Use $dbr->buildLike() instead of manual LIKE"

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Beta: Enable GuidedTour everywhere (except loginwiki and vot...

2017-04-17 Thread Mattflaschen (Code Review)
Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348647 ) Change subject: Beta: Enable GuidedTour everywhere (except loginwiki and votewiki) .. Beta: Enable GuidedTour everywhere (except

  1   2   3   4   5   6   7   8   9   10   >