[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use cpPosTime cookie for same-domain redirects on DB change

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use cpPosTime cookie for same-domain redirects on DB change .. Use cpPosTime cookie for same-domain redirects on DB change This follows-up a3dacac90f to

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Add link to action=edit in message editor's tools menu

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add link to action=edit in message editor's tools menu .. Add link to action=edit in message editor's tools menu Translators sometimes need access to the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::puppetmaster::frontend: remove 'puppet' vhost

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310490 Change subject: role::puppetmaster::frontend: remove 'puppet' vhost .. role::puppetmaster::frontend: remove 'puppet' vhost It

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::puppetmaster::frontend: remove 'puppet' vhost

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: role::puppetmaster::frontend: remove 'puppet' vhost .. role::puppetmaster::frontend: remove 'puppet' vhost It should just be on palladium during

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.19]: Use cpPosTime cookie for same-domain redirects on DB change

2016-09-14 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/310494 Change subject: Use cpPosTime cookie for same-domain redirects on DB change .. Use cpPosTime cookie for same-domain redirects on DB change

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet: switch ulsfo to use srv records, puppetmaster1001

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: puppet: switch ulsfo to use srv records, puppetmaster1001 .. puppet: switch ulsfo to use srv records, puppetmaster1001 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Set cpPosTime cookie for the non-redirect case as well

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310493 Change subject: Set cpPosTime cookie for the non-redirect case as well .. Set cpPosTime cookie for the non-redirect case as well This

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::web_frontend: use secret() for non-fqdn sites

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: puppetmaster::web_frontend: use secret() for non-fqdn sites .. puppetmaster::web_frontend: use secret() for non-fqdn sites Instead of limiting

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2016-09-14T10:00:01+0000

2016-09-14 Thread WikidataBuilder (Code Review)
WikidataBuilder has uploaded a new change for review. https://gerrit.wikimedia.org/r/310502 Change subject: New Wikidata Build - 2016-09-14T10:00:01+ .. New Wikidata Build - 2016-09-14T10:00:01+ Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Have private repo git config user.name

2016-09-14 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has uploaded a new change for review. https://gerrit.wikimedia.org/r/310503 Change subject: puppetmaster: Have private repo git config user.name .. puppetmaster: Have private repo git config user.name

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::web_frontend: fix ownership of files

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310504 Change subject: puppetmaster::web_frontend: fix ownership of files .. puppetmaster::web_frontend: fix ownership of files

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::web_frontend: fix ownership of files

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: puppetmaster::web_frontend: fix ownership of files .. puppetmaster::web_frontend: fix ownership of files Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Have private repo git config user.name

2016-09-14 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppetmaster: Have private repo git config user.name .. puppetmaster: Have private repo git config user.name Just to ensure we got a value so

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Send mentions when editing multiple sections in between sect...

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Send mentions when editing multiple sections in between sections. .. Send mentions when editing multiple sections in between sections. This patch fixes

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: T143127 - adding focus state to language button

2016-09-14 Thread Jdrewniak (Code Review)
Jdrewniak has uploaded a new change for review. https://gerrit.wikimedia.org/r/310505 Change subject: T143127 - adding focus state to language button .. T143127 - adding focus state to language button Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] Encapsulate country validation in a helper class

2016-09-14 Thread Awight (Code Review)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/310495 Change subject: [WIP] Encapsulate country validation in a helper class .. [WIP] Encapsulate country validation in a helper class Cleanup

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base::puppet: stop using SRV record

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: base::puppet: stop using SRV record .. base::puppet: stop using SRV record Apparently, puppetlabs wasn't able to cache DNS results when using SRV

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Only set position_increment_gap on fields where positions ar...

2016-09-14 Thread DCausse (Code Review)
DCausse has uploaded a new change for review. https://gerrit.wikimedia.org/r/310310 Change subject: Only set position_increment_gap on fields where positions are stored .. Only set position_increment_gap on fields where

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet-merge: Allow forcing, passing SHA1 args

2016-09-14 Thread Alexandros Kosiaris (Code Review)
Alexandros Kosiaris has submitted this change and it was merged. Change subject: puppet-merge: Allow forcing, passing SHA1 args .. puppet-merge: Allow forcing, passing SHA1 args Alter puppet merge to allow: * passing a sha1

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Make /opt/wmf-mariadb10/bin/mysqld_safe managed by puppet

2016-09-14 Thread Muehlenhoff (Code Review)
Muehlenhoff has uploaded a new change for review. https://gerrit.wikimedia.org/r/310498 Change subject: Make /opt/wmf-mariadb10/bin/mysqld_safe managed by puppet .. Make /opt/wmf-mariadb10/bin/mysqld_safe managed by puppet

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Rework siteselector.tests to conform to JSCS/JSHint rules

2016-09-14 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/310499 Change subject: Rework siteselector.tests to conform to JSCS/JSHint rules .. Rework siteselector.tests to conform to JSCS/JSHint

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Expand Revision Slider when user activates pin button

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Expand Revision Slider when user activates pin button .. Expand Revision Slider when user activates pin button Bug: T145068 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: thumbor: set MemoryLimit to 1G

2016-09-14 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has uploaded a new change for review. https://gerrit.wikimedia.org/r/310500 Change subject: thumbor: set MemoryLimit to 1G .. thumbor: set MemoryLimit to 1G Bug: T145623 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: thumbor: set MemoryLimit to 1G

2016-09-14 Thread Filippo Giunchedi (Code Review)
Filippo Giunchedi has submitted this change and it was merged. Change subject: thumbor: set MemoryLimit to 1G .. thumbor: set MemoryLimit to 1G Bug: T145623 Change-Id: I0ec8aa286708d17eefafa641242aaf124fa4d1ea --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::web_frontend: use secret() for non-fqdn sites

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310501 Change subject: puppetmaster::web_frontend: use secret() for non-fqdn sites .. puppetmaster::web_frontend: use secret() for

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Revert "Add MobileFrontend.Context service"

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Revert "Add MobileFrontend.Context service" .. Revert "Add MobileFrontend.Context service" This is problematic because it tries to access the service

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Rename getThreshold() to getDamagingThreshold()

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Rename getThreshold() to getDamagingThreshold() .. Rename getThreshold() to getDamagingThreshold() Also make it take a User object. Remove concerns

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: ext.translate.special.translate: fix tab header display mobile

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: ext.translate.special.translate: fix tab header display mobile .. ext.translate.special.translate: fix tab header display mobile Increase selector

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base::puppet: stop using SRV record

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310496 Change subject: base::puppet: stop using SRV record .. base::puppet: stop using SRV record Apparently, puppetlabs wasn't able to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base::puppet: add ca_server setting when needed

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310497 Change subject: base::puppet: add ca_server setting when needed .. base::puppet: add ca_server setting when needed Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: refreshLinks: Add --namespace option

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: refreshLinks: Add --namespace option .. refreshLinks: Add --namespace option This allows limiting refreshing data to pages in a single namespace.

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove most itemremoved events

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove most itemremoved events .. Remove most itemremoved events Change-Id: Id1e93bcdc176af663e70aafb3aed91809a951806 --- M

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: tools.py: add file_mode_checker()

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: tools.py: add file_mode_checker() .. tools.py: add file_mode_checker() Implement a single function for file permission checks. File permission check is

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid MWException and wf* log methods in DatabaseBase

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310720 Change subject: Avoid MWException and wf* log methods in DatabaseBase .. Avoid MWException and wf* log methods in DatabaseBase

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga/phab: adjust checkcommand for phabricator http check

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310721 Change subject: icinga/phab: adjust checkcommand for phabricator http check .. icinga/phab: adjust checkcommand for phabricator http check For

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga/phab: adjust checkcommand for phabricator http check

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: icinga/phab: adjust checkcommand for phabricator http check .. icinga/phab: adjust checkcommand for phabricator http check For unknown reasons this existing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: Remove unneeded puppet-lint ignore rules

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: toollabs: Remove unneeded puppet-lint ignore rules .. toollabs: Remove unneeded puppet-lint ignore rules They are not needed since puppet lint does not fail

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change DatabaseBase => IDatabase in /db where possible

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310722 Change subject: Change DatabaseBase => IDatabase in /db where possible .. Change DatabaseBase => IDatabase in /db where possible

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Fix WikiModule preload to support localised ...

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: resourceloader: Fix WikiModule preload to support localised titles .. resourceloader: Fix WikiModule preload to support localised titles Follows-up

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Silence DBPerformance warnings during password migration

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Silence DBPerformance warnings during password migration .. Silence DBPerformance warnings during password migration Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Fix: The topic name is revision-visibility-change

2016-09-14 Thread Mobrovac (Code Review)
Mobrovac has uploaded a new change for review. https://gerrit.wikimedia.org/r/310555 Change subject: Fix: The topic name is revision-visibility-change .. Fix: The topic name is revision-visibility-change Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: Switch most references away from palladium

2016-09-14 Thread Giuseppe Lavagetto (Code Review)
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/310556 Change subject: Switch most references away from palladium .. Switch most references away from palladium Migrate eqiad,

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add per-prefix config tabs

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310683 Change subject: Puppet panel: Add per-prefix config tabs .. Puppet panel: Add per-prefix config tabs This is a roughed-in design

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.19]: resourceloader: Fix WikiModule preload to support localised ...

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: resourceloader: Fix WikiModule preload to support localised titles .. resourceloader: Fix WikiModule preload to support localised titles Follows-up

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceFoundation[master]: TaskApi permissions: Fixed fatal

2016-09-14 Thread Pwirth (Code Review)
Pwirth has submitted this change and it was merged. Change subject: TaskApi permissions: Fixed fatal .. TaskApi permissions: Fixed fatal A fatal error occured when a user has no 'read' permission. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: remove an extra /div

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Puppet panel: remove an extra /div .. Puppet panel: remove an extra /div Change-Id: I3ed6d5014995192e217fadb70de71e108a622575 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: More fixups to httpyaml hiera backend

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/310687 Change subject: labs: More fixups to httpyaml hiera backend .. labs: More fixups to httpyaml hiera backend Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Simplify mock object syntax in includes/db/ tests

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310686 Change subject: phpunit: Simplify mock object syntax in includes/db/ tests .. phpunit: Simplify mock object syntax in includes/db/ tests *

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Force straight join for prop=linkshere|transcludedin|fi...

2016-09-14 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. https://gerrit.wikimedia.org/r/310552 Change subject: API: Force straight join for prop=linkshere|transcludedin|fileusage .. API: Force straight join for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache_upload: do not set do_stream=true on Varnish 4

2016-09-14 Thread Ema (Code Review)
Ema has uploaded a new change for review. https://gerrit.wikimedia.org/r/310551 Change subject: cache_upload: do not set do_stream=true on Varnish 4 .. cache_upload: do not set do_stream=true on Varnish 4 Varnish 4 already

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Reorder functions to reduce forward declarations

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Reorder functions to reduce forward declarations .. Reorder functions to reduce forward declarations Change-Id: I13cdf676cf7cb468966dd1a6ceca248c3e46d6ad

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ircyall: move role to module/role

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: ircyall: move role to module/role .. ircyall: move role to module/role Change-Id: I59eeb42bf6a486990aa2b4e939a6541f7cddd3af --- R

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add logging channel for NewUserMessage

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add logging channel for NewUserMessage .. Add logging channel for NewUserMessage I'll be adding logging for failures to leave a message, e.g. due to an

[MediaWiki-commits] [Gerrit] operations/puppet[production]: auto-reimage: improved output

2016-09-14 Thread Volans (Code Review)
Volans has uploaded a new change for review. https://gerrit.wikimedia.org/r/310680 Change subject: auto-reimage: improved output .. auto-reimage: improved output Bug: T143536 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: burrow: fix optional parameter listed before required parameter

2016-09-14 Thread Ottomata (Code Review)
Ottomata has submitted this change and it was merged. Change subject: burrow: fix optional parameter listed before required parameter .. burrow: fix optional parameter listed before required parameter Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: auto-reimage: improved output

2016-09-14 Thread Volans (Code Review)
Volans has submitted this change and it was merged. Change subject: auto-reimage: improved output .. auto-reimage: improved output Bug: T143536 Change-Id: I6b75e55e7da73e92da78411279f169f00d17bb9f --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.28.0-wmf.19]: Always serve all the data on preview

2016-09-14 Thread Yurik (Code Review)
Yurik has uploaded a new change for review. https://gerrit.wikimedia.org/r/310681 Change subject: Always serve all the data on preview .. Always serve all the data on preview Bug: T145615 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add a missing /div

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review. https://gerrit.wikimedia.org/r/310682 Change subject: Puppet panel: Add a missing /div .. Puppet panel: Add a missing /div Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Make sure tests fail on missing response file

2016-09-14 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/310684 Change subject: Make sure tests fail on missing response file .. Make sure tests fail on missing response file We were relying on something

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Puppet panel: Add per-prefix config tabs

2016-09-14 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged. Change subject: Puppet panel: Add per-prefix config tabs .. Puppet panel: Add per-prefix config tabs This is a roughed-in design with a few placeholder tabs. Bug:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tendril: fix 'optional before required parameter'

2016-09-14 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/310685 Change subject: tendril: fix 'optional before required parameter' .. tendril: fix 'optional before required parameter' Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: More fixups to httpyaml hiera backend

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has submitted this change and it was merged. Change subject: labs: More fixups to httpyaml hiera backend .. labs: More fixups to httpyaml hiera backend Change-Id: If7155d50b15bcb4af2ea367c894abbdae44837b5 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tendril: fix 'optional before required parameter'

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: tendril: fix 'optional before required parameter' .. tendril: fix 'optional before required parameter' Change-Id: I09cf80df0f1421fad13f491a3d87e2f18aea3fdb ---

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster: Fix whitespace error

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: puppetmaster: Fix whitespace error .. puppetmaster: Fix whitespace error Fixes ERROR: trailing whitespace found on line 11 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Upload.BookletLayout: Fix typo in comment

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310688 Change subject: mediawiki.Upload.BookletLayout: Fix typo in comment .. mediawiki.Upload.BookletLayout: Fix typo in comment Follows-up

[MediaWiki-commits] [Gerrit] operations/puppet[production]: snapshot: Fix variable contains an uppercase letter

2016-09-14 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: snapshot: Fix variable contains an uppercase letter .. snapshot: Fix variable contains an uppercase letter Bug: T93645 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: Use YAML.load instead of .parse for loading YAML

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/310689 Change subject: labs: Use YAML.load instead of .parse for loading YAML .. labs: Use YAML.load instead of .parse for loading YAML

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labs: Use YAML.load instead of .parse for loading YAML

2016-09-14 Thread Yuvipanda (Code Review)
Yuvipanda has submitted this change and it was merged. Change subject: labs: Use YAML.load instead of .parse for loading YAML .. labs: Use YAML.load instead of .parse for loading YAML Change-Id:

[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: repository: fix error verbosity

2016-09-14 Thread Dachary (Code Review)
Dachary has uploaded a new change for review. https://gerrit.wikimedia.org/r/310690 Change subject: repository: fix error verbosity .. repository: fix error verbosity Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.28.0-wmf.19]: Always serve all the data on preview

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Always serve all the data on preview .. Always serve all the data on preview Bug: T145615 Change-Id: I1a58a9e613a59a4259081fbb8dfb9a39aa813964 (cherry

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Simplify mock object syntax in includes/db/ tests

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: phpunit: Simplify mock object syntax in includes/db/ tests .. phpunit: Simplify mock object syntax in includes/db/ tests * Omit redundant `expects(

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Move 'site' and 'user' logic to makeModuleRe...

2016-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/310727 Change subject: resourceloader: Move 'site' and 'user' logic to makeModuleResponse .. resourceloader: Move 'site' and 'user' logic to

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310728 Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move LoadMonitorMySQL to LoadMonitor

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310733 Change subject: Move LoadMonitorMySQL to LoadMonitor .. Move LoadMonitorMySQL to LoadMonitor * The LoadMonitor interface is now

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Exception cleanups for LoadBalancer

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Exception cleanups for LoadBalancer .. Exception cleanups for LoadBalancer * Make the error message itself be dumb/raw. * Make the exception exposer show

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310726 Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Use a secure variable so that forks don't spam us

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Use a secure variable so that forks don't spam us .. Use a secure variable so that forks don't spam us * This was generated with, travis encrypt

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change $wiki => $domain in LoadBalancer

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Change $wiki => $domain in LoadBalancer .. Change $wiki => $domain in LoadBalancer Change-Id: I97f96383c501e9b3262c11d143795b82ae36aca5 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move various DB helper classes to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move various DB helper classes to /libs/rdbms .. Move various DB helper classes to /libs/rdbms Change-Id: I0724f1acce4f6c43b1f0983fa119e628e7c53ba5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: Avoid deprecated LBFactory::singleton() in tests

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id: Id9c39e9332270f34979db74b251c8f834cce7057

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Only store the full country code if it is on our valid list.

2016-09-14 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. https://gerrit.wikimedia.org/r/310732 Change subject: Only store the full country code if it is on our valid list. .. Only store the full country code if it is on our valid list.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused LBFactoryFake class

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310731 Change subject: Remove unused LBFactoryFake class .. Remove unused LBFactoryFake class Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo

2016-09-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/310729 Change subject: puppet::self::gitclone: Get gitdir from puppetmaster::base_repo .. puppet::self::gitclone: Get gitdir from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused LBFactoryFake class

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove unused LBFactoryFake class .. Remove unused LBFactoryFake class Change-Id: I88acf72fc32c7e3c9bead81d11c5adfd8dff6151 --- M autoload.php M

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Use a secure variable so that forks don't spam us

2016-09-14 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. https://gerrit.wikimedia.org/r/310730 Change subject: Use a secure variable so that forks don't spam us .. Use a secure variable so that forks don't spam us * This was generated

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change $wiki => $domain in LoadBalancer

2016-09-14 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310723 Change subject: Change $wiki => $domain in LoadBalancer .. Change $wiki => $domain in LoadBalancer Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Change DatabaseBase => IDatabase in /db where possible

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Change DatabaseBase => IDatabase in /db where possible .. Change DatabaseBase => IDatabase in /db where possible Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...examples[master]: Change Commit

2016-09-14 Thread Himavarshini (Code Review)
Himavarshini has uploaded a new change for review. https://gerrit.wikimedia.org/r/310725 Change subject: Change Commit .. Change Commit Change-Id: I523ba3403adef25bf7ddeea2c8b9623faaa3d7e5 --- M Example/Example.php 1 file

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove handling for bad data (language = '_' as we are clean...

2016-09-14 Thread Eileen (Code Review)
Eileen has uploaded a new change for review. https://gerrit.wikimedia.org/r/310724 Change subject: Remove handling for bad data (language = '_' as we are cleaning that up .. Remove handling for bad data (language = '_' as we

[MediaWiki-commits] [Gerrit] integration/config[master]: mediawiki: Merge parsertests job back into main phpunit job

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: mediawiki: Merge parsertests job back into main phpunit job .. mediawiki: Merge parsertests job back into main phpunit job This was originally separated

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid MWException and wf* log methods in DatabaseBase

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Avoid MWException and wf* log methods in DatabaseBase .. Avoid MWException and wf* log methods in DatabaseBase Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Fix: The topic name is revision-visibility-change

2016-09-14 Thread Mobrovac (Code Review)
Mobrovac has submitted this change and it was merged. Change subject: Fix: The topic name is revision-visibility-change .. Fix: The topic name is revision-visibility-change Change-Id: Iaec4f943add5eb6608edea2e684a0fb7f13bacac

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move LoadBalancer to /libs/rdbms

2016-09-14 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move LoadBalancer to /libs/rdbms .. Move LoadBalancer to /libs/rdbms Change-Id: Ic87f1cc84ba44be20f345944406e1d8a34be1c96 --- M autoload.php R

<    1   2   3   4