[MediaWiki-commits] [Gerrit] Bump version of extension to 2.3 (Since XSS issue got fixed) - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294231 Change subject: Bump version of extension to 2.3 (Since XSS issue got fixed) .. Bump version of extension to 2.3 (Since XSS issue got fixe

[MediaWiki-commits] [Gerrit] Bump version of extension to 2.3 (Since XSS issue got fixed) - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Bump version of extension to 2.3 (Since XSS issue got fixed) .. Bump version of extension to 2.3 (Since XSS issue got fixed) Also remove having both old s

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294232 Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 (cherry pi

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 (cherry picked from commit 51ba1112f546e4be

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug: T133511 Change-Id: I606714c8602

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294233 Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug

[MediaWiki-commits] [Gerrit] Bump version of extension to 2.3 (Since XSS issue got fixed) - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294234 Change subject: Bump version of extension to 2.3 (Since XSS issue got fixed) .. Bump version of extension to 2.3 (Since XSS issue got fixe

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294236 Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294235 Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 --- M MsCa

[MediaWiki-commits] [Gerrit] Bump version to 2.0-1 to denote that XSS is fixed - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294237 Change subject: Bump version to 2.0-1 to denote that XSS is fixed .. Bump version to 2.0-1 to denote that XSS is fixed Change-Id: Id02435

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 --- M MsCalendar.body.php 1 file changed, 3

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug: T133511 Change-Id: I606714c8602

[MediaWiki-commits] [Gerrit] Bump version to 2.0-1 to denote that XSS is fixed - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Bump version to 2.0-1 to denote that XSS is fixed .. Bump version to 2.0-1 to denote that XSS is fixed Change-Id: Id0243589bca54f9f6d2491f0a80ee432b62233b

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294238 Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 --- M MsCa

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294239 Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug

[MediaWiki-commits] [Gerrit] Bump version to 2.0-1 to denote that XSS is fixed - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294240 Change subject: Bump version to 2.0-1 to denote that XSS is fixed .. Bump version to 2.0-1 to denote that XSS is fixed Change-Id: Id02435

[MediaWiki-commits] [Gerrit] Bump version to 2.0-1 to denote that XSS is fixed - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Bump version to 2.0-1 to denote that XSS is fixed .. Bump version to 2.0-1 to denote that XSS is fixed Change-Id: Id0243589bca54f9f6d2491f0a80ee432b62233b

[MediaWiki-commits] [Gerrit] Sanitize before output instead of before input - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Sanitize before output instead of before input .. Sanitize before output instead of before input Follow up 7c8b811c1 Bug: T133511 Change-Id: I606714c8602

[MediaWiki-commits] [Gerrit] Fix XSS in extension - change (mediawiki...MsCalendar)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Fix XSS in extension .. Fix XSS in extension Bug: T133511 Change-Id: I98ead6364dd148838842ac92d025b61a448b3f20 --- M MsCalendar.body.php 1 file changed, 3

[MediaWiki-commits] [Gerrit] Allow specifying the allowed IPs in a message - change (mediawiki...NetworkAuth)

2016-06-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294251 Change subject: Allow specifying the allowed IPs in a message .. Allow specifying the allowed IPs in a message This lets you do config li

[MediaWiki-commits] [Gerrit] Stop using inline styles for list modules - change (mediawiki...CollaborationKit)

2016-06-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294442 Change subject: Stop using inline styles for list modules .. Stop using inline styles for list modules Making this work for plain transcl

[MediaWiki-commits] [Gerrit] Make hook be marked public - change (mediawiki...CollaborationKit)

2016-06-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/29 Change subject: Make hook be marked public .. Make hook be marked public Change-Id: I566f6926daf346a60573f674e4f953c3edee27bb --- M inclu

[MediaWiki-commits] [Gerrit] Initial work on an editing interface for collabkit Lists - change (mediawiki...CollaborationKit)

2016-06-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294443 Change subject: Initial work on an editing interface for collabkit Lists .. Initial work on an editing interface for collabkit Lists UI i

[MediaWiki-commits] [Gerrit] SECURITY: Don't list deleted edits without rights - change (mediawiki...MobileFrontend)

2016-06-30 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: SECURITY: Don't list deleted edits without rights .. SECURITY: Don't list deleted edits without rights If the current user doesn't have the appropriate ri

[MediaWiki-commits] [Gerrit] SECURITY: Don't list deleted edits without rights - change (mediawiki...MobileFrontend)

2016-06-30 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: SECURITY: Don't list deleted edits without rights .. SECURITY: Don't list deleted edits without rights If the current user doesn't have the appropriate ri

[MediaWiki-commits] [Gerrit] Fix no image case, and add confirmable - change (mediawiki...CollaborationKit)

2016-07-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297177 Change subject: Fix no image case, and add confirmable .. Fix no image case, and add confirmable Bug: T136462 Bug: T139098 Change-Id: I66

[MediaWiki-commits] [Gerrit] Add a human readable edit format. - change (mediawiki...CollaborationKit)

2016-07-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297179 Change subject: Add a human readable edit format. .. Add a human readable edit format. Not 100% sure this is the best approach. Possibly

[MediaWiki-commits] [Gerrit] Add vim swap files to .gitignore - change (mediawiki...CollaborationKit)

2016-07-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297178 Change subject: Add vim swap files to .gitignore .. Add vim swap files to .gitignore Change-Id: I3529ad0932541b18cd6fd2360091779462237e60

[MediaWiki-commits] [Gerrit] Make normal link when item is a category or file. - change (mediawiki...CollaborationKit)

2016-07-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297180 Change subject: Make normal link when item is a category or file. .. Make normal link when item is a category or file. Change-Id: I0a7cd1

[MediaWiki-commits] [Gerrit] Add a message to Special:GlobalUsage containing the file name - change (mediawiki...GlobalUsage)

2016-07-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297191 Change subject: Add a message to Special:GlobalUsage containing the file name .. Add a message to Special:GlobalUsage containing the file

[MediaWiki-commits] [Gerrit] Add a test for entity expansion OOM in XmlTypeCheck - change (mediawiki/core)

2016-07-07 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297842 Change subject: Add a test for entity expansion OOM in XmlTypeCheck .. Add a test for entity expansion OOM in XmlTypeCheck Change-Id: Ia2

[MediaWiki-commits] [Gerrit] Update LoginNotify for AuthManager. - change (mediawiki...LoginNotify)

2016-07-07 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/297844 Change subject: Update LoginNotify for AuthManager. .. Update LoginNotify for AuthManager. I left the old hook in place for back-compatib

[MediaWiki-commits] [Gerrit] Tell users that js/css subpages are public - change (mediawiki/core)

2016-07-10 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/298188 Change subject: Tell users that js/css subpages are public .. Tell users that js/css subpages are public There is concern that users migh

[MediaWiki-commits] [Gerrit] Consistency tweaks in prepararion for translatewiki.net - change (mediawiki...NetworkAuth)

2016-07-10 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Consistency tweaks in prepararion for translatewiki.net .. Consistency tweaks in prepararion for translatewiki.net Change-Id: I65d9a7fcc04e7a8f2449ddc2b1c

[MediaWiki-commits] [Gerrit] Split edit page for lists into description + list - change (mediawiki...CollaborationKit)

2016-07-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/299439 Change subject: Split edit page for lists into description + list .. Split edit page for lists into description + list Bug: T140181 Chang

[MediaWiki-commits] [Gerrit] Do not override content format in EditPage when loading rev. - change (mediawiki/core)

2016-07-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/299440 Change subject: Do not override content format in EditPage when loading rev. .. Do not override content format in EditPage when loading re

[MediaWiki-commits] [Gerrit] Supply model/format directly to hook - change (mediawiki...CodeEditor)

2016-07-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/299441 Change subject: Supply model/format directly to hook .. Supply model/format directly to hook Most of the time people want to trigger on c

[MediaWiki-commits] [Gerrit] Only json highlight if actually json. - change (mediawiki...CollaborationKit)

2016-07-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/299442 Change subject: Only json highlight if actually json. .. Only json highlight if actually json. Bug: T139097 Change-Id: I73e67cc15ad7c4bda

[MediaWiki-commits] [Gerrit] Make custom editor work in json mode properly - change (mediawiki...CollaborationKit)

2016-07-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/299443 Change subject: Make custom editor work in json mode properly .. Make custom editor work in json mode properly Change-Id: I8d3a18f523d92f

[MediaWiki-commits] [Gerrit] make backcompat 1.26 - change (mediawiki...CollaborationKit)

2016-06-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294775 Change subject: make backcompat 1.26 .. make backcompat 1.26 Change-Id: Ie55ec238afc94b62659702b94a8952f53d3df6c5 --- M extension.json 1

[MediaWiki-commits] [Gerrit] Follow-up 28b553f0fa0, last commit was wrong - change (mediawiki...CollaborationKit)

2016-06-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/294836 Change subject: Follow-up 28b553f0fa0, last commit was wrong .. Follow-up 28b553f0fa0, last commit was wrong Change-Id: I126064f41e5e6071

[MediaWiki-commits] [Gerrit] Fixup qrcode-generating js, to stop race condition. - change (mediawiki...OATHAuth)

2016-06-20 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/295191 Change subject: Fixup qrcode-generating js, to stop race condition. .. Fixup qrcode-generating js, to stop race condition. Previously the

[MediaWiki-commits] [Gerrit] Add ą, č, ę, ė, į, š, ų, ū, ž to linkTrail for lt language - change (mediawiki/core)

2016-06-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/295342 Change subject: Add ą, č, ę, ė, į, š, ų, ū, ž to linkTrail for lt language .. Add ą, č, ę, ė, į, š, ų, ū, ž to linkTrail for lt language

[MediaWiki-commits] [Gerrit] Set proper cactions on Special:EditCollaborationHub. - change (mediawiki...CollaborationKit)

2016-06-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/295746 Change subject: Set proper cactions on Special:EditCollaborationHub. .. Set proper cactions on Special:EditCollaborationHub. Bug: T131717

[MediaWiki-commits] [Gerrit] Fix fatal if members list page does not exist - change (mediawiki...CollaborationKit)

2016-06-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/295748 Change subject: Fix fatal if members list page does not exist .. Fix fatal if members list page does not exist Change-Id: I707881578b4b8a

[MediaWiki-commits] [Gerrit] Improve list editor. It is prettier. - change (mediawiki...CollaborationKit)

2016-06-24 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/295878 Change subject: Improve list editor. It is prettier. .. Improve list editor. It is prettier. Some strings still have to be i18n-ized. Bu

[MediaWiki-commits] [Gerrit] Add drag and drop to list editor - change (mediawiki...CollaborationKit)

2016-06-25 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/296069 Change subject: Add drag and drop to list editor .. Add drag and drop to list editor Javascript is still rather rough Bug: T136462 Chang

[MediaWiki-commits] [Gerrit] Fix misleading comment about svg filtering. - change (mediawiki/core)

2016-06-27 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/296195 Change subject: Fix misleading comment about svg filtering. .. Fix misleading comment about svg filtering. Follow-up 551d79a3e6754. See a

[MediaWiki-commits] [Gerrit] [DO NOT MERGE until feedback wikitech-l] Remove support for ... - change (mediawiki/core)

2016-05-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/286495 Change subject: [DO NOT MERGE until feedback wikitech-l] Remove support for $wgWellFormedXml=false .. [DO NOT MERGE until feedback wikite

[MediaWiki-commits] [Gerrit] Suppress session_destroy() warnings for unit tests - change (mediawiki/core)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290150 Change subject: Suppress session_destroy() warnings for unit tests .. Suppress session_destroy() warnings for unit tests Warning: session

[MediaWiki-commits] [Gerrit] Suppress session_destroy() warnings for unit tests - change (mediawiki/core)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290151 Change subject: Suppress session_destroy() warnings for unit tests .. Suppress session_destroy() warnings for unit tests Warning: session

[MediaWiki-commits] [Gerrit] Remove support for $wgWellFormedXml=false - change (mediawiki/core)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290152 Change subject: Remove support for $wgWellFormedXml=false .. Remove support for $wgWellFormedXml=false tl;dr: Having unnessary complexity

[MediaWiki-commits] [Gerrit] Follow-up ceffd37e68 Fix parser test that broke - change (mediawiki/core)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290153 Change subject: Follow-up ceffd37e68 Fix parser test that broke .. Follow-up ceffd37e68 Fix parser test that broke Bug: T135906 Change-Id

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290157 Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when esc

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290158 Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when esc

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290159 Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when esc

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290160 Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when esc

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-23 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when escaping attributes in mw.html Core

[MediaWiki-commits] [Gerrit] SECURITY: Don't escape strip markers when escaping attribute... - change (mediawiki...Scribunto)

2016-05-23 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: SECURITY: Don't escape strip markers when escaping attributes in mw.html .. SECURITY: Don't escape strip markers when escaping attributes in mw.html Core

[MediaWiki-commits] [Gerrit] Remove Vary header check from MobileFrontendHooksTest::testO... - change (mediawiki...MobileFrontend)

2016-05-24 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Remove Vary header check from MobileFrontendHooksTest::testOnBeforePageDisplay .. Remove Vary header check from MobileFrontendHooksTest::testOnBeforePageD

[MediaWiki-commits] [Gerrit] Allow mw.util.addPortletLink to take a function for the link... - change (mediawiki/core)

2016-05-24 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/290605 Change subject: Allow mw.util.addPortletLink to take a function for the link href .. Allow mw.util.addPortletLink to take a function for

[MediaWiki-commits] [Gerrit] Use STRAIGHT_JOIN on updateCollation.php per jcrespo - change (mediawiki/core)

2016-05-10 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288032 Change subject: Use STRAIGHT_JOIN on updateCollation.php per jcrespo .. Use STRAIGHT_JOIN on updateCollation.php per jcrespo Was not usin

[MediaWiki-commits] [Gerrit] use slave for row estimate in updateCollation.php - change (mediawiki/core)

2016-05-10 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288036 Change subject: use slave for row estimate in updateCollation.php .. use slave for row estimate in updateCollation.php jcrespo reported a

[MediaWiki-commits] [Gerrit] Make updateCollation wait for slaves every 500 (instead of 2... - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288364 Change subject: Make updateCollation wait for slaves every 500 (instead of 2000) .. Make updateCollation wait for slaves every 500 (instea

[MediaWiki-commits] [Gerrit] Make updateCollation wait for slaves every 500 (instead of 2... - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288384 Change subject: Make updateCollation wait for slaves every 500 (instead of 2000) .. Make updateCollation wait for slaves every 500 (instea

[MediaWiki-commits] [Gerrit] Use STRAIGHT_JOIN on updateCollation.php per jcrespo - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288385 Change subject: Use STRAIGHT_JOIN on updateCollation.php per jcrespo .. Use STRAIGHT_JOIN on updateCollation.php per jcrespo Was not usin

[MediaWiki-commits] [Gerrit] use slave for row estimate in updateCollation.php - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288386 Change subject: use slave for row estimate in updateCollation.php .. use slave for row estimate in updateCollation.php jcrespo reported a

[MediaWiki-commits] [Gerrit] Add initial PHPUnit tests - change (mediawiki...CollaborationKit)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288400 Change subject: Add initial PHPUnit tests .. Add initial PHPUnit tests Bug: T131672 Change-Id: Ia94f9fa581339d7ed120465ae2bba7b0f840b9f6

[MediaWiki-commits] [Gerrit] Use STRAIGHT_JOIN on updateCollation.php per jcrespo - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288411 Change subject: Use STRAIGHT_JOIN on updateCollation.php per jcrespo .. Use STRAIGHT_JOIN on updateCollation.php per jcrespo Was not usin

[MediaWiki-commits] [Gerrit] Make updateCollation wait for slaves every 500 (instead of 2... - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288412 Change subject: Make updateCollation wait for slaves every 500 (instead of 2000) .. Make updateCollation wait for slaves every 500 (instea

[MediaWiki-commits] [Gerrit] use slave for row estimate in updateCollation.php - change (mediawiki/core)

2016-05-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288413 Change subject: use slave for row estimate in updateCollation.php .. use slave for row estimate in updateCollation.php jcrespo reported a

[MediaWiki-commits] [Gerrit] Make GWToolset properly record events in CU log - change (mediawiki...GWToolset)

2016-05-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288878 Change subject: Make GWToolset properly record events in CU log .. Make GWToolset properly record events in CU log Bug: T126450 Change-Id

[MediaWiki-commits] [Gerrit] Call $job->teardown() even if Job throws an exception. - change (mediawiki/core)

2016-05-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288879 Change subject: Call $job->teardown() even if Job throws an exception. .. Call $job->teardown() even if Job throws an exception. teardown

[MediaWiki-commits] [Gerrit] Fix parser tests for core commit ee4d5c6eed (removal $wgWell... - change (mediawiki...SyntaxHighlight_GeSHi)

2016-05-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288899 Change subject: Fix parser tests for core commit ee4d5c6eed (removal $wgWellFormedXML) .. Fix parser tests for core commit ee4d5c6eed (re

[MediaWiki-commits] [Gerrit] PHPUnit tests for CollaborationHubContent - change (mediawiki...CollaborationKit)

2016-05-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288904 Change subject: PHPUnit tests for CollaborationHubContent .. PHPUnit tests for CollaborationHubContent Bug: T131672 Change-Id: I90741bdb5

[MediaWiki-commits] [Gerrit] [DO NOT MERGE] Remove inline event handler js from charinsert - change (mediawiki...CharInsert)

2016-05-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/288922 Change subject: [DO NOT MERGE] Remove inline event handler js from charinsert .. [DO NOT MERGE] Remove inline event handler js from charin

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Unit tests for CollationFa (0bfcbd724)

2017-05-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356067 ) Change subject: Unit tests for CollationFa (0bfcbd724) .. Unit tests for CollationFa (0bfcbd724) Change-Id: I8286244cc1a61f34a3599c4f2e

[MediaWiki-commits] [Gerrit] mediawiki...SemanticForms[3.7]: Added use of Database::buildLike()

2017-03-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342545 ) Change subject: Added use of Database::buildLike() .. Added use of Database::buildLike() Backport from PageForms bb42c6f401b9 Change-I

[MediaWiki-commits] [Gerrit] mediawiki...SemanticForms[3.7]: Added use of Database::buildLike()

2017-03-13 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/342545 ) Change subject: Added use of Database::buildLike() .. Added use of Database::buildLike() Backport from PageForms bb42c6f401b9

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Better path traversal prevention in TemplateParser.

2017-03-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342561 ) Change subject: Better path traversal prevention in TemplateParser. .. Better path traversal prevention in TemplateParser. In practise

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rv accidental inclusion of debug code in TemplateParser

2017-03-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342791 ) Change subject: rv accidental inclusion of debug code in TemplateParser .. rv accidental inclusion of debug code in TemplateParser Foll

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Default to CACHE_ACCEL if user skips advanced settings

2017-03-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342793 ) Change subject: Default to CACHE_ACCEL if user skips advanced settings .. Default to CACHE_ACCEL if user skips advanced settings In the

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Never use CACHE_NONE for CACHE_ANYTHING

2017-03-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342959 ) Change subject: Never use CACHE_NONE for CACHE_ANYTHING .. Never use CACHE_NONE for CACHE_ANYTHING If $wgMainCacheType = CACHE_ACCEL, b

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Properly detect if CACHE_ACCEL is available in the installer

2017-03-15 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342966 ) Change subject: Properly detect if CACHE_ACCEL is available in the installer .. Properly detect if CACHE_ACCEL is available in the insta

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Be more defensive about checking revision is present

2017-03-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343977 ) Change subject: Be more defensive about checking revision is present .. Be more defensive about checking revision is present This will

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Avoid logs about unexpected writes from special page.

2017-03-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344039 ) Change subject: Avoid logs about unexpected writes from special page. .. Avoid logs about unexpected writes from special page. Change-I

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Make selectRowCount() (hopefully) work in MSSQL.

2017-03-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345328 ) Change subject: Make selectRowCount() (hopefully) work in MSSQL. .. Make selectRowCount() (hopefully) work in MSSQL. Make table and col

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Make selectRowCount() (hopefully) work in MSSQL.

2017-03-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345330 ) Change subject: Make selectRowCount() (hopefully) work in MSSQL. .. Make selectRowCount() (hopefully) work in MSSQL. Make table and col

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Drop index oi_name_archive_name on table oldimage in MSSQL

2017-03-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345333 ) Change subject: Drop index oi_name_archive_name on table oldimage in MSSQL .. Drop index oi_name_archive_name on table oldimage in MSSQL

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Make selectRowCount() (hopefully) work in MSSQL.

2017-03-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/345330 ) Change subject: Make selectRowCount() (hopefully) work in MSSQL. .. Make selectRowCount() (hopefully) work in MSSQL. Make table

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Drop index oi_name_archive_name on table oldimage in MSSQL

2017-03-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345339 ) Change subject: Drop index oi_name_archive_name on table oldimage in MSSQL .. Drop index oi_name_archive_name on table oldimage in MSSQL

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Set path globals in phpunit tests

2017-04-19 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348994 ) Change subject: Set path globals in phpunit tests .. Set path globals in phpunit tests Avoid differences in output due to different scr

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Some style fixes to better match MW coding conventions

2017-04-20 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349281 ) Change subject: Some style fixes to better match MW coding conventions .. Some style fixes to better match MW coding conventions Automa

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Enforce MW coding convention with phpcs

2017-04-20 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349282 ) Change subject: Enforce MW coding convention with phpcs .. Enforce MW coding convention with phpcs (This commit will probably fail unit

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Test authmanager restricter in labs

2017-04-25 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350231 ) Change subject: Test authmanager restricter in labs .. Test authmanager restricter in labs This was causing problems with logstash in p

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Release notes for no in system messages (1c7889446)

2017-04-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345999 ) Change subject: Release notes for no in system messages (1c7889446) .. Release notes for no in system messages (1c7889446) Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_23]: SECURITY: Disable tag on system messages despite $wgR...

2017-04-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346025 ) Change subject: SECURITY: Disable tag on system messages despite $wgRawHtml = true; .. SECURITY: Disable tag on system messages despi

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_23]: SECURITY: Disable tag on system messages despite $wgR...

2017-04-01 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/346025 ) Change subject: SECURITY: Disable tag on system messages despite $wgRawHtml = true; .. SECURITY: Disable tag on system messag

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Release notes for CACHE_ANYTHING being CACHE_NONE (c5a0fa5be...

2017-04-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346031 ) Change subject: Release notes for CACHE_ANYTHING being CACHE_NONE (c5a0fa5bed4c) .. Release notes for CACHE_ANYTHING being CACHE_NONE (c

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_23]: Fix phpunit test added in 57efcafa8a3a64f

2017-04-05 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346593 ) Change subject: Fix phpunit test added in 57efcafa8a3a64f .. Fix phpunit test added in 57efcafa8a3a64f ObjectFactory wasn't added until

<    1   2   3   4   5   6   7   8   9   >