[MediaWiki-commits] [Gerrit] Phabricator: Setup git config for all repositories - change (operations/puppet)

2015-07-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/227488 Change subject: Phabricator: Setup git config for all repositories .. Phabricator: Setup git config for all repositories Start with HTTP proxy s

[MediaWiki-commits] [Gerrit] Phabricator: Fetch all references in Git - change (operations/puppet)

2015-07-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/227489 Change subject: Phabricator: Fetch all references in Git .. Phabricator: Fetch all references in Git I'm not 100% sure on the syntax, yet. Chan

[MediaWiki-commits] [Gerrit] Revert "Add special wikipedias to wikipedia.dblist" - change (operations/mediawiki-config)

2015-07-28 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/227645 Change subject: Revert "Add special wikipedias to wikipedia.dblist" .. Revert "Add special wikipedias to wikipedia.dblist" Not a bad idea, but h

[MediaWiki-commits] [Gerrit] Revert "Add special wikipedias to wikipedia.dblist" - change (operations/mediawiki-config)

2015-07-28 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Revert "Add special wikipedias to wikipedia.dblist" .. Revert "Add special wikipedias to wikipedia.dblist" Not a bad idea, but having wikis in 2 dblists could ge

[MediaWiki-commits] [Gerrit] beta: Swap text caches to -text04, which is jessie - change (operations/mediawiki-config)

2015-07-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/227743 Change subject: beta: Swap text caches to -text04, which is jessie .. beta: Swap text caches to -text04, which is jessie Bug: T98758 Change-Id:

[MediaWiki-commits] [Gerrit] beta: swap text caches to text04, which is jessie - change (operations/puppet)

2015-07-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/227744 Change subject: beta: swap text caches to text04, which is jessie .. beta: swap text caches to text04, which is jessie Bug: T98758 Change-Id: I2

[MediaWiki-commits] [Gerrit] MW releases: create shared build directory in /srv - change (operations/puppet)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230601 Change subject: MW releases: create shared build directory in /srv .. MW releases: create shared build directory in /srv Because sharing builds

[MediaWiki-commits] [Gerrit] SECURITY: Don't disclose if an IP is autoblocked on Special:... - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230667 Change subject: SECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions .. SECURITY: Don't disclose if an IP is autoblo

[MediaWiki-commits] [Gerrit] thumb.php: Escape $rel404 in error message - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230666 Change subject: thumb.php: Escape $rel404 in error message .. thumb.php: Escape $rel404 in error message Bug: T97391 Change-Id: I363686732fe9e56

[MediaWiki-commits] [Gerrit] SECURITY: API: Use constant-time comparison for watchlist token - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230665 Change subject: SECURITY: API: Use constant-time comparison for watchlist token .. SECURITY: API: Use constant-time comparison for watchlist toke

[MediaWiki-commits] [Gerrit] Update Releasenotes and version number for 1.25.2 - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230668 Change subject: Update Releasenotes and version number for 1.25.2 .. Update Releasenotes and version number for 1.25.2 Change-Id: Idb92283cf1fbd

[MediaWiki-commits] [Gerrit] thumb.php: Escape $rel404 in error message - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230670 Change subject: thumb.php: Escape $rel404 in error message .. thumb.php: Escape $rel404 in error message Bug: T97391 Change-Id: I363686732fe9e56

[MediaWiki-commits] [Gerrit] Update Releasenotes and version number for 1.24.3 - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230672 Change subject: Update Releasenotes and version number for 1.24.3 .. Update Releasenotes and version number for 1.24.3 Change-Id: I4dd24b10d7a48

[MediaWiki-commits] [Gerrit] SECURITY: API: Use constant-time comparison for watchlist token - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230669 Change subject: SECURITY: API: Use constant-time comparison for watchlist token .. SECURITY: API: Use constant-time comparison for watchlist toke

[MediaWiki-commits] [Gerrit] SECURITY: Don't disclose if an IP is autoblocked on Special:... - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230671 Change subject: SECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions .. SECURITY: Don't disclose if an IP is autoblo

[MediaWiki-commits] [Gerrit] thumb.php: Escape $rel404 in error message - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230674 Change subject: thumb.php: Escape $rel404 in error message .. thumb.php: Escape $rel404 in error message Bug: T97391 Change-Id: I363686732fe9e56

[MediaWiki-commits] [Gerrit] Update Releasenotes and version number for 1.23.10 - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230676 Change subject: Update Releasenotes and version number for 1.23.10 .. Update Releasenotes and version number for 1.23.10 Change-Id: Ibcb5605e99c

[MediaWiki-commits] [Gerrit] SECURITY: API: Use constant-time comparison for watchlist token - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230673 Change subject: SECURITY: API: Use constant-time comparison for watchlist token .. SECURITY: API: Use constant-time comparison for watchlist toke

[MediaWiki-commits] [Gerrit] SECURITY: Don't disclose if an IP is autoblocked on Special:... - change (mediawiki/core)

2015-08-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230675 Change subject: SECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions .. SECURITY: Don't disclose if an IP is autoblo

[MediaWiki-commits] [Gerrit] thumb.php: Escape $rel404 in error message - change (mediawiki/core)

2015-08-11 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230775 Change subject: thumb.php: Escape $rel404 in error message .. thumb.php: Escape $rel404 in error message Bug: T97391 Change-Id: I363686732fe9e56

[MediaWiki-commits] [Gerrit] SECURITY: API: Use constant-time comparison for watchlist token - change (mediawiki/core)

2015-08-11 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230774 Change subject: SECURITY: API: Use constant-time comparison for watchlist token .. SECURITY: API: Use constant-time comparison for watchlist toke

[MediaWiki-commits] [Gerrit] SECURITY: Don't disclose if an IP is autoblocked on Special:... - change (mediawiki/core)

2015-08-11 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/230776 Change subject: SECURITY: Don't disclose if an IP is autoblocked on Special:DeletedContributions .. SECURITY: Don't disclose if an IP is autoblo

[MediaWiki-commits] [Gerrit] Followup Ibd58670e: Also set auto_create_index for beta logs... - change (operations/puppet)

2015-08-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/231049 Change subject: Followup Ibd58670e: Also set auto_create_index for beta logstash .. Followup Ibd58670e: Also set auto_create_index for beta logst

[MediaWiki-commits] [Gerrit] Protect against undefined array access - change (mediawiki...CirrusSearch)

2015-08-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/231332 Change subject: Protect against undefined array access .. Protect against undefined array access explode() can return less than two array items

[MediaWiki-commits] [Gerrit] Handle missing parser in onParserAfterParse - change (mediawiki...Graph)

2015-08-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/231339 Change subject: Handle missing parser in onParserAfterParse .. Handle missing parser in onParserAfterParse Sometimes onParserAfterParse() is giv

[MediaWiki-commits] [Gerrit] Bumping submodule for Graph extension (pulls in Ic305a1ec) - change (mediawiki/core)

2015-08-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/231391 Change subject: Bumping submodule for Graph extension (pulls in Ic305a1ec) .. Bumping submodule for Graph extension (pulls in Ic305a1ec) Change-

[MediaWiki-commits] [Gerrit] Fix I9e63789e: Release notes should refer to old versions in... - change (mediawiki/core)

2015-04-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/202782 Change subject: Fix I9e63789e: Release notes should refer to old versions in HISTORY .. Fix I9e63789e: Release notes should refer to old version

[MediaWiki-commits] [Gerrit] Removing Hanp, to be deleted. - change (mediawiki/extensions)

2015-04-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/203957 Change subject: Removing Hanp, to be deleted. .. Removing Hanp, to be deleted. Change-Id: Id43ab7245425bb84ec982e7123cd75f13574be2b --- M .gitmo

[MediaWiki-commits] [Gerrit] Removing Hanp, to be deleted. - change (mediawiki/extensions)

2015-04-13 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Removing Hanp, to be deleted. .. Removing Hanp, to be deleted. Change-Id: Id43ab7245425bb84ec982e7123cd75f13574be2b --- M .gitmodules D Hanp 2 files changed, 0 i

[MediaWiki-commits] [Gerrit] More useful debugging information on unsafe tag attributes - change (oojs/ui)

2015-04-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/203968 Change subject: More useful debugging information on unsafe tag attributes .. More useful debugging information on unsafe tag attributes Bug: T9

[MediaWiki-commits] [Gerrit] Use Diffusion to support r1234 links in Gerrit - change (operations/puppet)

2015-04-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204211 Change subject: Use Diffusion to support r1234 links in Gerrit .. Use Diffusion to support r1234 links in Gerrit Change-Id: Iaab070a1a6897ca7f7a

[MediaWiki-commits] [Gerrit] Fix fatals in LoginUserMigrated hook - change (mediawiki...CentralAuth)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204281 Change subject: Fix fatals in LoginUserMigrated hook .. Fix fatals in LoginUserMigrated hook This is a quick fix, long term we should look at th

[MediaWiki-commits] [Gerrit] Fix for I49ee1270: Tabs aren't actually a problem - change (mediawiki...CirrusSearch)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204284 Change subject: Fix for I49ee1270: Tabs aren't actually a problem .. Fix for I49ee1270: Tabs aren't actually a problem Ideographic spaces are wh

[MediaWiki-commits] [Gerrit] Updating CentralAuth to pull in I088a84b1 - change (mediawiki/core)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204288 Change subject: Updating CentralAuth to pull in I088a84b1 .. Updating CentralAuth to pull in I088a84b1 Change-Id: Iac0d13bee8b7c994b02414efc82dc

[MediaWiki-commits] [Gerrit] Remove MW_SPECIALPAGE_VERSION. Unused anywhere. - change (mediawiki/core)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204290 Change subject: Remove MW_SPECIALPAGE_VERSION. Unused anywhere. .. Remove MW_SPECIALPAGE_VERSION. Unused anywhere. If we needed such a constant

[MediaWiki-commits] [Gerrit] Remove backup support from Cirrus - change (mediawiki...CirrusSearch)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204310 Change subject: Remove backup support from Cirrus .. Remove backup support from Cirrus Backups should be managed by Elasticsearch, not Cirrus C

[MediaWiki-commits] [Gerrit] Hiera-ize the mediawiki-installation dsh group - change (operations/puppet)

2015-04-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/204331 Change subject: Hiera-ize the mediawiki-installation dsh group .. Hiera-ize the mediawiki-installation dsh group Change-Id: I27f65b3b3f05d0f6b13

[MediaWiki-commits] [Gerrit] Remove MW_SPECIALPAGE_VERSION. Unused anywhere. - change (mediawiki/core)

2015-04-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove MW_SPECIALPAGE_VERSION. Unused anywhere. .. Remove MW_SPECIALPAGE_VERSION. Unused anywhere. If we needed such a constant nowadays we'd probably stick it o

[MediaWiki-commits] [Gerrit] UI for adding and removing change tags on revisions and log ... - change (mediawiki/core)

2015-04-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: UI for adding and removing change tags on revisions and log entries .. UI for adding and removing change tags on revisions and log entries There is a new specia

[MediaWiki-commits] [Gerrit] RELEASE-NOTES for change tagging changes - change (mediawiki/core)

2015-04-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: RELEASE-NOTES for change tagging changes .. RELEASE-NOTES for change tagging changes See I37275e0f and I7d3ef92. Change-Id: I4ed12a2551241f3224d9994b66e3f1675c5

[MediaWiki-commits] [Gerrit] Phabricator: Enable the webserver to serve git repos - change (operations/puppet)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/215942 Change subject: Phabricator: Enable the webserver to serve git repos .. Phabricator: Enable the webserver to serve git repos Sudo bits are untes

[MediaWiki-commits] [Gerrit] Phabricator role: Don't need to set upload-size-limit anymore - change (mediawiki/vagrant)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/215989 Change subject: Phabricator role: Don't need to set upload-size-limit anymore .. Phabricator role: Don't need to set upload-size-limit anymore "

[MediaWiki-commits] [Gerrit] APCU: Be more explicit with package, tune for developers - change (mediawiki/vagrant)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/215996 Change subject: APCU: Be more explicit with package, tune for developers .. APCU: Be more explicit with package, tune for developers Settings sh

[MediaWiki-commits] [Gerrit] Phab config: don't pass $deploy_dir, just full qualify it - change (mediawiki/vagrant)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/215998 Change subject: Phab config: don't pass $deploy_dir, just full qualify it .. Phab config: don't pass $deploy_dir, just full qualify it Change-Id

[MediaWiki-commits] [Gerrit] Phabricator: Turn on developer mode - change (mediawiki/vagrant)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/215999 Change subject: Phabricator: Turn on developer mode .. Phabricator: Turn on developer mode Change-Id: I001fdc427ec16a1f0f6fd8700892b04e33a8dc16

[MediaWiki-commits] [Gerrit] Phabricator config: Whitespace cleanup - change (mediawiki/vagrant)

2015-06-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/216000 Change subject: Phabricator config: Whitespace cleanup .. Phabricator config: Whitespace cleanup Change-Id: Ic46c0b2c483ff9d6196316159b2ec0695c4

[MediaWiki-commits] [Gerrit] Keep parallel tools up to date automatically - change (mediawiki/vagrant)

2015-06-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/216122 Change subject: Keep parallel tools up to date automatically .. Keep parallel tools up to date automatically Change-Id: Ife0639f7ce25c7e207a2e06

[MediaWiki-commits] [Gerrit] Phab: Ensure /var/repo exists so we can store repo data - change (mediawiki/vagrant)

2015-06-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/216156 Change subject: Phab: Ensure /var/repo exists so we can store repo data .. Phab: Ensure /var/repo exists so we can store repo data Change-Id: I7

[MediaWiki-commits] [Gerrit] Phab: Disable max file size for development - change (mediawiki/vagrant)

2015-06-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/216158 Change subject: Phab: Disable max file size for development .. Phab: Disable max file size for development Change-Id: I456c2bf5687f413224b79cd86

[MediaWiki-commits] [Gerrit] Refactored entry points to have uniform shutdown handling - change (mediawiki/core)

2015-06-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/216298 Change subject: Refactored entry points to have uniform shutdown handling .. Refactored entry points to have uniform shutdown handling * Added d

[MediaWiki-commits] [Gerrit] Refactored entry points to have uniform shutdown handling - change (mediawiki/core)

2015-06-05 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Refactored entry points to have uniform shutdown handling .. Refactored entry points to have uniform shutdown handling * Added doPreOutputCommit() and doPostOutp

[MediaWiki-commits] [Gerrit] Move several unit tests to directly subclass PHPUnit_Framewo... - change (mediawiki/core)

2015-06-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/217013 Change subject: Move several unit tests to directly subclass PHPUnit_Framework_TestCase .. Move several unit tests to directly subclass PHPUnit_

[MediaWiki-commits] [Gerrit] Use context's $out instead of undefined $wgOut - change (mediawiki...SecurePoll)

2015-09-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235494 Change subject: Use context's $out instead of undefined $wgOut .. Use context's $out instead of undefined $wgOut Bug: T111206 Change-Id: I7fd796

[MediaWiki-commits] [Gerrit] PrefixSearch: Avoid passing non-strings to Title::newFromText() - change (mediawiki/core)

2015-09-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235675 Change subject: PrefixSearch: Avoid passing non-strings to Title::newFromText() .. PrefixSearch: Avoid passing non-strings to Title::newFromText(

[MediaWiki-commits] [Gerrit] Add -s option to my .ackrc - change (operations/puppet)

2015-09-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235738 Change subject: Add -s option to my .ackrc .. Add -s option to my .ackrc Change-Id: Ie0f3904bd04963a280d286a7fc089b962abfb9ae --- M modules/admi

[MediaWiki-commits] [Gerrit] Phab (labs): Move sshd to 2222, easier to remember than 222 - change (operations/puppet)

2015-09-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235777 Change subject: Phab (labs): Move sshd to , easier to remember than 222 .. Phab (labs): Move sshd to , easier to remember than 222 Chang

[MediaWiki-commits] [Gerrit] Phab: clean up role, remove ::config and ::main abstraction - change (operations/puppet)

2015-09-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235778 Change subject: Phab: clean up role, remove ::config and ::main abstraction .. Phab: clean up role, remove ::config and ::main abstraction The w

[MediaWiki-commits] [Gerrit] Use Phab urls instead of Gitblit (comments only) - change (operations/puppet)

2015-09-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235857 Change subject: Use Phab urls instead of Gitblit (comments only) .. Use Phab urls instead of Gitblit (comments only) Change-Id: I74d6cb74528aae0

[MediaWiki-commits] [Gerrit] Phabricator: Remove php5 from manifest - change (operations/puppet)

2015-07-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223351 Change subject: Phabricator: Remove php5 from manifest .. Phabricator: Remove php5 from manifest It's redundant as all the various extensions wi

[MediaWiki-commits] [Gerrit] Phabricator: Clean up vcs manifest with proper dependencies - change (operations/puppet)

2015-07-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223353 Change subject: Phabricator: Clean up vcs manifest with proper dependencies .. Phabricator: Clean up vcs manifest with proper dependencies We ca

[MediaWiki-commits] [Gerrit] Clean up empty result set scenario - change (mediawiki...CirrusSearch)

2015-07-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223380 Change subject: Clean up empty result set scenario .. Clean up empty result set scenario Provide an empty result set wrapper that allows us to s

[MediaWiki-commits] [Gerrit] APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadat... - change (mediawiki/core)

2015-07-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223824 Change subject: APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block .. APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'met

[MediaWiki-commits] [Gerrit] Beta: Move wikidata.beta.wmflabs.org to static mappings - change (operations/mediawiki-config)

2015-07-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224100 Change subject: Beta: Move wikidata.beta.wmflabs.org to static mappings .. Beta: Move wikidata.beta.wmflabs.org to static mappings Like we do in

[MediaWiki-commits] [Gerrit] Prevent race condition when writing settings to cache - change (operations/mediawiki-config)

2015-07-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224107 Change subject: Prevent race condition when writing settings to cache .. Prevent race condition when writing settings to cache fopen() with 'w'

[MediaWiki-commits] [Gerrit] Protect against non-text output from StripState going into T... - change (mediawiki/core)

2015-07-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224124 Change subject: Protect against non-text output from StripState going into Title::newFromText() .. Protect against non-text output from StripSta

[MediaWiki-commits] [Gerrit] Credit where credit is due - change (mediawiki...CirrusSearch)

2015-07-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224130 Change subject: Credit where credit is due .. Credit where credit is due Yay Erik B! Change-Id: Ib0a2978e580af359e05958bf6cf7028455d884dc --- M

[MediaWiki-commits] [Gerrit] Update README: drop silly master version that DNE - change (search/repository-swift)

2015-07-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224433 Change subject: Update README: drop silly master version that DNE .. Update README: drop silly master version that DNE Change-Id: Iee0c4a0c5cd42

[MediaWiki-commits] [Gerrit] es-tool: Restart ganglia after restarting Elasticsearch - change (operations/puppet)

2015-07-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224435 Change subject: es-tool: Restart ganglia after restarting Elasticsearch .. es-tool: Restart ganglia after restarting Elasticsearch I can't wait

[MediaWiki-commits] [Gerrit] Default to eqiad, not pmtpa - change (mediawiki...scap)

2015-07-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/224449 Change subject: Default to eqiad, not pmtpa .. Default to eqiad, not pmtpa Change-Id: Ifb9e9ae10cd0cdfe427b48dc5eebee36d8f6564d --- M scap.cfg M

[MediaWiki-commits] [Gerrit] Point download.wiki(m|p)edia.org at text-lb - change (operations/dns)

2015-08-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/233659 Change subject: Point download.wiki(m|p)edia.org at text-lb .. Point download.wiki(m|p)edia.org at text-lb I2c46661 should land in puppet first

[MediaWiki-commits] [Gerrit] Whitespace tidy up. Git keeps ending up with a dirty copy on me - change (operations...mariadb)

2015-08-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/233991 Change subject: Whitespace tidy up. Git keeps ending up with a dirty copy on me .. Whitespace tidy up. Git keeps ending up with a dirty copy on m

[MediaWiki-commits] [Gerrit] Setup Gerrit role account for Phabricator actions - change (operations/puppet)

2015-08-27 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/234332 Change subject: Setup Gerrit role account for Phabricator actions .. Setup Gerrit role account for Phabricator actions Includes convenience clas

[MediaWiki-commits] [Gerrit] Stop sending purges to deployment-cache-bits04 - change (operations/mediawiki-config)

2015-09-01 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235282 Change subject: Stop sending purges to deployment-cache-bits04 .. Stop sending purges to deployment-cache-bits04 It doesn't exist anymore ;-) C

[MediaWiki-commits] [Gerrit] Decom bits caches from beta/staging - change (operations/puppet)

2015-09-01 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/235284 Change subject: Decom bits caches from beta/staging .. Decom bits caches from beta/staging They're not used anymore Change-Id: Ife10e3213477fb6

[MediaWiki-commits] [Gerrit] phabricator::vcs: Fix package name to git-core - change (operations/puppet)

2015-07-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/225070 Change subject: phabricator::vcs: Fix package name to git-core .. phabricator::vcs: Fix package name to git-core Change-Id: Id7b527f8e39575466c3

[MediaWiki-commits] [Gerrit] update .gitmodules to include branch tracking details - change (mediawiki/core)

2015-07-16 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: update .gitmodules to include branch tracking details .. update .gitmodules to include branch tracking details Bug: T105994 Change-Id: I3a7b116b6920e5004ce8efbde

[MediaWiki-commits] [Gerrit] Update Namespaces, SpecialPageAliases and MagicWords for Sou... - change (mediawiki/core)

2015-07-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update Namespaces, SpecialPageAliases and MagicWords for South Azerbaijani (azb) .. Update Namespaces, SpecialPageAliases and MagicWords for South Azerbaijani (a

[MediaWiki-commits] [Gerrit] Elastic: Unify default plugins directory in /srv/deployment - change (operations/puppet)

2015-06-29 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/221766 Change subject: Elastic: Unify default plugins directory in /srv/deployment .. Elastic: Unify default plugins directory in /srv/deployment We se

[MediaWiki-commits] [Gerrit] Phabricator: Turn on diffusion.allow-http-auth - change (operations/puppet)

2015-07-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223067 Change subject: Phabricator: Turn on diffusion.allow-http-auth .. Phabricator: Turn on diffusion.allow-http-auth This will allow pushing to repo

[MediaWiki-commits] [Gerrit] Gerrit: remove ::old role - change (operations/puppet)

2015-07-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223161 Change subject: Gerrit: remove ::old role .. Gerrit: remove ::old role It's old. Unused. Change-Id: Ied1e0cd538320abc816190f7b473774a07a246a8 -

[MediaWiki-commits] [Gerrit] Gerrit: Remove ::labs role - change (operations/puppet)

2015-07-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223171 Change subject: Gerrit: Remove ::labs role .. Gerrit: Remove ::labs role It never really worked beyond a test instance that has long since been

[MediaWiki-commits] [Gerrit] Gerrit: Remove $extra_groups from replicationdest, nothing u... - change (operations/puppet)

2015-07-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223169 Change subject: Gerrit: Remove $extra_groups from replicationdest, nothing uses it .. Gerrit: Remove $extra_groups from replicationdest, nothing

[MediaWiki-commits] [Gerrit] Gitblit: Remove ssl cert stuff - change (operations/puppet)

2015-07-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/223170 Change subject: Gitblit: Remove ssl cert stuff .. Gitblit: Remove ssl cert stuff Gitblit doesn't support running its own cert stuff anymore, nee

[MediaWiki-commits] [Gerrit] Add new CirrusSearch logs - change (operations/mediawiki-config)

2014-01-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107503 Change subject: Add new CirrusSearch logs .. Add new CirrusSearch logs Not deployed yet, but config can go out whenever Change-Id: I2b04bccc2a

[MediaWiki-commits] [Gerrit] Move boost-templates into other operator handling - change (mediawiki...CirrusSearch)

2014-01-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107505 Change subject: Move boost-templates into other operator handling .. Move boost-templates into other operator handling Untested, but interestin

[MediaWiki-commits] [Gerrit] Two fixups to SearchResult - change (mediawiki/core)

2014-01-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107520 Change subject: Two fixups to SearchResult .. Two fixups to SearchResult - Make variables protected. Only class that uses these is LuceneResult

[MediaWiki-commits] [Gerrit] Make getElasticsearchVersion() not static - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107611 Change subject: Make getElasticsearchVersion() not static .. Make getElasticsearchVersion() not static Change-Id: I3940529d0560e4c8e8390c1e0bc3

[MediaWiki-commits] [Gerrit] Typofix that was causing all kinds of profiling errors - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107613 Change subject: Typofix that was causing all kinds of profiling errors .. Typofix that was causing all kinds of profiling errors Change-Id: I04

[MediaWiki-commits] [Gerrit] Make function not static and remove static class variable - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107614 Change subject: Make function not static and remove static class variable .. Make function not static and remove static class variable getIgnor

[MediaWiki-commits] [Gerrit] Remove DeletePagesJob::build() - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107615 Change subject: Remove DeletePagesJob::build() .. Remove DeletePagesJob::build() Pointless wrapper when we only call it once Change-Id: Ia358c

[MediaWiki-commits] [Gerrit] Refactor all external index tracking into OtherIndex class - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107617 Change subject: Refactor all external index tracking into OtherIndex class .. Refactor all external index tracking into OtherIndex class Change

[MediaWiki-commits] [Gerrit] Avoid loading revisions for every search result - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107621 Change subject: Avoid loading revisions for every search result .. Avoid loading revisions for every search result The core SearchResult implem

[MediaWiki-commits] [Gerrit] Localisation updates from https://translatewiki.net. - change (wikimedia/wikimania-scholarships)

2014-01-15 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: I7be0db6ad369ecb886f565ba80cd6a234f016481

[MediaWiki-commits] [Gerrit] Less static Result(Set) - change (mediawiki...CirrusSearch)

2014-01-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107729 Change subject: Less static Result(Set) .. Less static Result(Set) Change-Id: Ifa5523a55c9716151afce07eebd193fdc05f29ad --- M includes/Result.p

[MediaWiki-commits] [Gerrit] Fix undefined variable - change (mediawiki...CirrusSearch)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107867 Change subject: Fix undefined variable .. Fix undefined variable Change-Id: Ie51ad6eaa78c19497f0c18e061064dfa52cb2025 --- M includes/Elasticsea

[MediaWiki-commits] [Gerrit] Ehcache more like mehcache - change (mediawiki/core)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107880 Change subject: Ehcache more like mehcache .. Ehcache more like mehcache Change-Id: Ief5728b4c61bb5ad8f5a5f0b55415b23ef6727eb --- M includes/Au

[MediaWiki-commits] [Gerrit] Remove DBABagOStuff - change (mediawiki/core)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107891 Change subject: Remove DBABagOStuff .. Remove DBABagOStuff Isn't useful outside of testing as the comments state, but it's barely even useful f

[MediaWiki-commits] [Gerrit] Remove commented defines - change (mediawiki/core)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107906 Change subject: Remove commented defines .. Remove commented defines Change-Id: I0447646127e05d80c87db5b88942105d41d802bd --- M includes/Define

[MediaWiki-commits] [Gerrit] Split cirrusSearchLinksUpdate into two jobs - change (mediawiki...CirrusSearch)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107927 Change subject: Split cirrusSearchLinksUpdate into two jobs .. Split cirrusSearchLinksUpdate into two jobs We were doing this based on a 'prima

[MediaWiki-commits] [Gerrit] Clean up RevisionDelete hook to use LinksUpdate code - change (mediawiki...CirrusSearch)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107983 Change subject: Clean up RevisionDelete hook to use LinksUpdate code .. Clean up RevisionDelete hook to use LinksUpdate code The UpdatePagesJob

  1   2   3   4   5   6   7   8   9   10   >