Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/406013 )
Change subject: CommentNode: Protect against call after teardown
..
CommentNode: Protect against call after teardown
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405943 )
Change subject: Sync tempWikitextEditor just before building target, not on
every change
..
Sync tempWikitextEditor just before building
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405940 )
Change subject: Toolbars: Replace $.height with clientHeight/offsetHeight
..
Toolbars: Replace $.height with clientHeight/offsetHeight
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405934 )
Change subject: Toolbars: Replace $.width with clientWidth/offsetWidth
..
Toolbars: Replace $.width with clientWidth/offsetWidth
Bug:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405931 )
Change subject: Toolbars: Replace $.width with clientWidth/offsetWidth
..
Toolbars: Replace $.width with clientWidth/offsetWidth
Bug:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405816 )
Change subject: Don't hide notification popup when scrolling
..
Don't hide notification popup when scrolling
hideWhenOutOfView is for
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405815 )
Change subject: Use child selectors for menuLayout
..
Use child selectors for menuLayout
Prevents broken layouts when menus are nested.
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405814 )
Change subject: Workaround missing child selector in OOUI for menuLayout
..
Workaround missing child selector in OOUI for menuLayout
Bug:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405810 )
Change subject: Remove metadata from unit tests
..
Remove metadata from unit tests
Metadata is being removed from VE.
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405809 )
Change subject: Remove
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405758 )
Change subject: Fix help icon negative margin in Apex
..
Fix help icon negative margin in Apex
Bug: T185529
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405753 )
Change subject: Remove Firefox support comment
..
Remove Firefox support comment
This line isn't solely for supporting FF52, that is the
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405752 )
Change subject: Implement simple methods from $.textSelection API
..
Implement simple methods from $.textSelection API
This should make
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405748 )
Change subject: Simplify textSelection overrides using 'register' and
'unregister'
..
Simplify textSelection overrides using 'register'
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405747 )
Change subject: Fix NWE integration to use new tempWikitextEditor
..
Fix NWE integration to use new tempWikitextEditor
Bug: T185279
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405746 )
Change subject: Public API for the tempWikitextEditor
..
Public API for the tempWikitextEditor
Allows users to know when the widget has
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405668 )
Change subject: Use textSelection API to modify textarea
..
Use textSelection API to modify textarea
Bug: T73363
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405662 )
Change subject: NWE: Don't attempt to set selection on unattached textarea
..
NWE: Don't attempt to set selection on unattached textarea
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405626 )
Change subject: Remove JSCS comments
..
Remove JSCS comments
Change-Id: I5ed4ae64800f2ba508302256ee85274ba7a0f5dd
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405260 )
Change subject: NWE: Fix padding in Vector
..
NWE: Fix padding in Vector
Bug: T185299
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404962 )
Change subject: Restore isSupported as deprecated dummy function
..
Restore isSupported as deprecated dummy function
Bug: T185143
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404699 )
Change subject: Resize link context item after getting description
..
Resize link context item after getting description
Descriptions can
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404673 )
Change subject: getSelectedItem() -> findSelectedItem()
..
getSelectedItem() -> findSelectedItem()
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404671 )
Change subject: getSelectedItem() -> findSelectedItem()
..
getSelectedItem() -> findSelectedItem()
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404670 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I92912debb177ad7d920e2a32899e5bb770f6ad21
---
M package.json
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404669 )
Change subject: getSelectedItem() -> findSelectedItem()
..
getSelectedItem() -> findSelectedItem()
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404667 )
Change subject: getSelectedItem() -> findSelectedItem()
..
getSelectedItem() -> findSelectedItem()
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404666 )
Change subject: getSelectedItem() -> findSelectedItem()
..
getSelectedItem() -> findSelectedItem()
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404659 )
Change subject: Remember preferred diff viewer
..
Remember preferred diff viewer
Separate the preference by surface mode, so you can
use
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404660 )
Change subject: Make visual diffs the default in visual mode
..
Make visual diffs the default in visual mode
Bug: T178248
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404164 )
Change subject: Don't pass wikitext to requestPageData if unmodified
..
Don't pass wikitext to requestPageData if unmodified
Bug: T184875
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403935 )
Change subject: Use MultilineTextInputWidget in PHP demos
..
Use MultilineTextInputWidget in PHP demos
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403934 )
Change subject: Follow-Up I0f1d9c1f: Update usages of getSelectedItem ->
findSelectedItem
..
Follow-Up I0f1d9c1f: Update usages of
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403710 )
Change subject: Catch timeout errors in screenshot scripts
..
Catch timeout errors in screenshot scripts
Bug: T184724
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403656 )
Change subject: Fix auto-height when CodeMirror not available
..
Fix auto-height when CodeMirror not available
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403651 )
Change subject: Mark es6 file as such
..
Mark es6 file as such
Change-Id: I981ac80d93c81a2256c6bc5e519e653c8400d63b
---
M Gruntfile.js
1
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403650 )
Change subject: Document monospace hack
..
Document monospace hack
Change-Id: Ia27dccdb9dc2de6ca66e08c54c62eb91302a381c
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403645 )
Change subject: Document monospace hack
..
Document monospace hack
Change-Id: I236e6e59bf4c7f58d47b108bd483b3dca6c03cd2
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403644 )
Change subject: Allow note-language to be unset in VE, and use as default
..
Allow note-language to be unset in VE, and use as default
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403643 )
Change subject: Unbreak widgets: 'findSelectedItem' -> 'getSelectedItem'
..
Unbreak widgets: 'findSelectedItem' -> 'getSelectedItem'
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403636 )
Change subject: Fix capitalisation of 'LilyPond'
..
Fix capitalisation of 'LilyPond'
Change-Id: Ia91b65c0da9371f13417770e335fa8035125cede
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403472 )
Change subject: WIP Create transactions for changes to tempWikitextEditor
..
WIP Create transactions for changes to tempWikitextEditor
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403441 )
Change subject: Ubreak CSS selector for fallback input widget
..
Ubreak CSS selector for fallback input widget
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402851 )
Change subject: Emit deprecation warnings when old modules are used
..
Emit deprecation warnings when old modules are used
Bug: T184194
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402842 )
Change subject: MWImageModel: Check selectedNode exists before asking for
property
..
MWImageModel: Check selectedNode exists before
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402142 )
Change subject: Remove unused module alias "unicodejs.wordbreak"
..
Remove unused module alias "unicodejs.wordbreak"
Deprecated for
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402066 )
Change subject: build: Update stylelint
..
build: Update stylelint
Change-Id: Id911ed1119d6b74c5fb61562505cf9aa3c33f82c
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402042 )
Change subject: Use editfont in mobile.editor
..
Use editfont in mobile.editor
Also preserve existing slightly larger font size of 16px
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402036 )
Change subject: Remove support for classic toolbar (mediawiki.toolbar)
..
Remove support for classic toolbar (mediawiki.toolbar)
The
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402034 )
Change subject: Make NWE integration background transparent
..
Make NWE integration background transparent
Allows for VE's placeholder
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402033 )
Change subject: Fix WikiEditor dependencies
..
Fix WikiEditor dependencies
Change-Id: Ibaa17e581ada5fcb202217797e70f9fed2510ec4
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402032 )
Change subject: Expect that deprecated mediawiki.toolbar may not be available
..
Expect that deprecated mediawiki.toolbar may not be
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402028 )
Change subject: Match font and size to other source editors
..
Match font and size to other source editors
All of our other source
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402025 )
Change subject: Make all old modules aliases of 'ext.wikiEditor'
..
Make all old modules aliases of 'ext.wikiEditor'
Many of these
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401807 )
Change subject: Fix WikiEditor dependencies
..
Fix WikiEditor dependencies
Change-Id: I5ac6f0cde0a1c321196c63b62b662d95f6bf616c
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401792 )
Change subject: Fix WikiEditor dependencies
..
Fix WikiEditor dependencies
Change-Id: I81b90a8f1791f1664000637fb90e54f8741eac9a
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401760 )
Change subject: Add useEditFont param to TextAreaField
..
Add useEditFont param to TextAreaField
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401751 )
Change subject: Convert single nbsp's to plain spaces on paste
..
Convert single nbsp's to plain spaces on paste
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401587 )
Change subject: Fix editfont size in source mode
..
Fix editfont size in source mode
Bug: T182320
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401503 )
Change subject: MWReferenceNode: Generate 'sup' tags by default
..
MWReferenceNode: Generate 'sup' tags by default
Bug: T45094
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401501 )
Change subject: Allow mw-ref rules apply to any element
..
Allow mw-ref rules apply to any element
i.e. span or sub.
Bug: T45094
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401500 )
Change subject: Balance padding around logo
..
Balance padding around logo
Change-Id: I09a9a0533249f7987298c8efde0dc9ad09bec421
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401498 )
Change subject: Fix border colour used for textarea
..
Fix border colour used for textarea
Prevents FOUC when WikiEditor finishes
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401395 )
Change subject: Expand templates: Change 'text' to 'wikitext'
..
Expand templates: Change 'text' to 'wikitext'
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401394 )
Change subject: Expand templates: Use editfont on wikitext inputs
..
Expand templates: Use editfont on wikitext inputs
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401381 )
Change subject: Use editfont on wikitext input
..
Use editfont on wikitext input
Change-Id: I0afc58b75821bd7f61d8d5f488f845081b910293
---
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401380 )
Change subject: Use OOUI form on special page
..
Use OOUI form on special page
Change-Id: Ia3a8f4b2452ed823a79e62c050de53d7a3f832fb
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400705 )
Change subject: Save/restore selection in all browsers
..
Save/restore selection in all browsers
Previously this wasn't required due to
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400697 )
Change subject: Remove browser compatibility checks
..
Remove browser compatibility checks
WikiEditor works in all browsers that MW
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399616 )
Change subject: Remove font-size now it is set by editfont
..
Remove font-size now it is set by editfont
Bug: T180678
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399395 )
Change subject: Don't depend on ArticleTarget for source editor
..
Don't depend on ArticleTarget for source editor
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399394 )
Change subject: Fix editor switcher inheritance
..
Fix editor switcher inheritance
Inherit from the non-ve.ui version of the tool as that
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399177 )
Change subject: ve.ce.DocumentNode: Documentation fix
..
ve.ce.DocumentNode: Documentation fix
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398601 )
Change subject: Remove mw-ui-item from page-selector
..
Remove mw-ui-item from page-selector
Not required, and causes height issues with
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398600 )
Change subject: Use .then(success,fail) when using .then
..
Use .then(success,fail) when using .then
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398449 )
Change subject: SourcePageSelector: Remove $sourcInputs wrapper
..
SourcePageSelector: Remove $sourcInputs wrapper
No longer necessary as
Hello Bartosz Dziewoński, Florianschmidtwelzow, jenkins-bot, Siebrand,
Jforrester,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/398071
to review the following change.
Change subject: Revert "Revert "Special:Preferences: Use OOjs UI" and
follow-ups"
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397866 )
Change subject: Enable spellchecking on media caption inputs
..
Enable spellchecking on media caption inputs
Bug: T182393
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397862 )
Change subject: Only resolve wikitext promise when progress dialog has closed
..
Only resolve wikitext promise when progress dialog has
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397861 )
Change subject: Allow access to a fragment's async state
..
Allow access to a fragment's async state
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397570 )
Change subject: Remove duplicate editfont size definition
..
Remove duplicate editfont size definition
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/396005 )
Change subject: Standardize editfont size across browsers/OSes
..
Standardize editfont size across browsers/OSes
Bug: T176636
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395975 )
Change subject: Pass editor mode (visual/source) to tracking code
..
Pass editor mode (visual/source) to tracking code
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395777 )
Change subject: Track action=loaded when the editor is *fully* ready
..
Track action=loaded when the editor is *fully* ready
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395739 )
Change subject: Remove .mw-ui-item from SourcePageSelector
..
Remove .mw-ui-item from SourcePageSelector
Not required, and float:left
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394745 )
Change subject: MWTable: Cleanup events and prevent fire after teardown
..
MWTable: Cleanup events and prevent fire after teardown
Bug:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394398 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I14e5e99d3fb9bbeeb9a12f8ad35207b7e89f98b6
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394397 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I461330305e8c66e82decb9ffcd9859f94c17e298
---
M package.json
1
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394395 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: If7da945e8790a1f1223c7455b329855386456785
---
M package.json
1
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394393 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I92f658cdb4806e7b1000c9306114072477fc9651
---
M package.json
1
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394392 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I6d5da6c02c598f1ad0f360e551e9a3ebbf7f3085
---
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394345 )
Change subject: Remove unwrapping code from ve.ce.MWTransclusionNode
..
Remove unwrapping code from ve.ce.MWTransclusionNode
Has been
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394337 )
Change subject: Disable WebkitTextFillColor in Firefox+OSX
..
Disable WebkitTextFillColor in Firefox+OSX
Avoids opaque selection covering
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394336 )
Change subject: Fix typo in name of non-webkit hide class
..
Fix typo in name of non-webkit hide class
Also increase opacity to 40% so
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394076 )
Change subject: mw.postEdit: Use mw.notify to display message
..
mw.postEdit: Use mw.notify to display message
Further unifies our
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394077 )
Change subject: mw.notify: Remove rules duplicated from core
..
mw.notify: Remove rules duplicated from core
Change-Id:
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394074 )
Change subject: mw.notifiction: Bring in some rules from Vector
..
mw.notifiction: Bring in some rules from Vector
The larger padding
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394066 )
Change subject: build: Update linters
..
build: Update linters
Change-Id: I45540db95711b461ded3630894bd1f149c24ff19
---
M package.json
M
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393222 )
Change subject: Highlight table caption when table cells selected
..
Highlight table caption when table cells selected
Bug: T181173
Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393077 )
Change subject: Create MW tables with captions by default
..
Create MW tables with captions by default
Bug: T181173
Change-Id:
1 - 100 of 4342 matches
Mail list logo
