[MediaWiki-commits] [Gerrit] Add more AbuseFilter vars - change (mediawiki...Flow)

2014-01-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/106688 Change subject: Add more AbuseFilter vars .. Add more AbuseFilter vars AbuseFilter::getEditVars adds a couple of new vars (e.g.

[MediaWiki-commits] [Gerrit] Parse error messages - change (mediawiki...Flow)

2014-01-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/106690 Change subject: Parse error messages .. Parse error messages Error messages can contain wikitext, so should be parsed. E.g.

[MediaWiki-commits] [Gerrit] Fix warning - change (mediawiki...Flow)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107150 Change subject: Fix warning .. Fix warning Change-Id: Ic8571c84d815b9e543f30d32c335d798e5186d94 --- M

[MediaWiki-commits] [Gerrit] Make error reporting more verbose. - change (mediawiki...Flow)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107149 Change subject: Make error reporting more verbose. .. Make error reporting more verbose. Based on $wgShowExceptionDetails,

[MediaWiki-commits] [Gerrit] Fix MultiGetList results from cache - change (mediawiki...Flow)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107152 Change subject: Fix MultiGetList results from cache .. Fix MultiGetList results from cache getByKey will try to load data from

[MediaWiki-commits] [Gerrit] Create stub post object instead of failing completely - change (mediawiki...Flow)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107151 Change subject: Create stub post object instead of failing completely .. Create stub post object instead of failing completely Bug:

[MediaWiki-commits] [Gerrit] Fix notice due to incorrect capitalization - change (operations/mediawiki-config)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107186 Change subject: Fix notice due to incorrect capitalization .. Fix notice due to incorrect capitalization Notice: Undefined

[MediaWiki-commits] [Gerrit] Refactor edit-header JavaScript - change (mediawiki...Flow)

2014-01-13 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107187 Change subject: Refactor edit-header JavaScript .. Refactor edit-header JavaScript This had recently been refactored, but it's

[MediaWiki-commits] [Gerrit] Don't use complex datatypes as CAS tokens - change (mediawiki/core)

2014-01-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107348 Change subject: Don't use complex datatypes as CAS tokens .. Don't use complex datatypes as CAS tokens For caches where CAS is not

[MediaWiki-commits] [Gerrit] If we fail to CAS, remove cached data so it's re-read from DB - change (mediawiki...Flow)

2014-01-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107377 Change subject: If we fail to CAS, remove cached data so it's re-read from DB .. If we fail to CAS, remove cached data so it's

[MediaWiki-commits] [Gerrit] Don't use complex datatypes as CAS tokens - change (mediawiki/core)

2014-01-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107380 Change subject: Don't use complex datatypes as CAS tokens .. Don't use complex datatypes as CAS tokens For caches where CAS is not

[MediaWiki-commits] [Gerrit] Strip binary data from values to be json_encode'ed - change (mediawiki/core)

2014-01-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107408 Change subject: Strip binary data from values to be json_encode'ed .. Strip binary data from values to be json_encode'ed Currently,

[MediaWiki-commits] [Gerrit] Add fromStorageRow - toStorageRow roundtrip test - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107560 Change subject: Add fromStorageRow - toStorageRow roundtrip test .. Add fromStorageRow - toStorageRow roundtrip test Meanwhile

[MediaWiki-commits] [Gerrit] Move tests to Flow\Tests namespace - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107561 Change subject: Move tests to Flow\Tests namespace .. Move tests to Flow\Tests namespace Change-Id:

[MediaWiki-commits] [Gerrit] Use PostRevisionTestCase helper method to build PostRevision... - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107563 Change subject: Use PostRevisionTestCase helper method to build PostRevision object .. Use PostRevisionTestCase helper method to

[MediaWiki-commits] [Gerrit] Tests for SpamRegex SpamBlacklist integration - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107568 Change subject: Tests for SpamRegex SpamBlacklist integration .. Tests for SpamRegex SpamBlacklist integration Change-Id:

[MediaWiki-commits] [Gerrit] Test for SpamBlacklist integration - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107569 Change subject: Test for SpamBlacklist integration .. Test for SpamBlacklist integration Change-Id:

[MediaWiki-commits] [Gerrit] Test for AbuseFilter integration - change (mediawiki...Flow)

2014-01-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/107623 Change subject: Test for AbuseFilter integration .. Test for AbuseFilter integration Change-Id:

[MediaWiki-commits] [Gerrit] Add clarification comment about PostRevision recursive vars - change (mediawiki...Flow)

2014-01-17 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108034 Change subject: Add clarification comment about PostRevision recursive vars .. Add clarification comment about PostRevision

[MediaWiki-commits] [Gerrit] Fix leftover - change (mediawiki...Flow)

2014-01-17 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108037 Change subject: Fix leftover .. Fix leftover Change-Id: I5eabcc171811211dda61c905b44cc118a2533de8 --- M includes/Model/Header.php 1

[MediaWiki-commits] [Gerrit] Move flow( 'setupEditForm' ) to base/action.js - change (mediawiki...Flow)

2014-01-20 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108535 Change subject: Move flow( 'setupEditForm' ) to base/action.js .. Move flow( 'setupEditForm' ) to base/action.js * Renamed all

[MediaWiki-commits] [Gerrit] Move flow( 'loadReplyForm' ) to base/action.js - change (mediawiki...Flow)

2014-01-20 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108634 Change subject: Move flow( 'loadReplyForm' ) to base/action.js .. Move flow( 'loadReplyForm' ) to base/action.js Change-Id:

[MediaWiki-commits] [Gerrit] Alternative way of dealing with edit conflicts - change (mediawiki...Flow)

2014-01-20 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108635 Change subject: Alternative way of dealing with edit conflicts .. Alternative way of dealing with edit conflicts getFormHandler

[MediaWiki-commits] [Gerrit] Restore confirmation msgs - change (mediawiki...Flow)

2014-01-21 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108700 Change subject: Restore confirmation msgs .. Restore confirmation msgs * Gender support was broken, as reported by Amir on

[MediaWiki-commits] [Gerrit] Whitelisted actions (like procted, unprotect) should be link... - change (mediawiki...Flow)

2014-01-22 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/108903 Change subject: Whitelisted actions (like procted, unprotect) should be linked to .. Whitelisted actions (like procted, unprotect)

[MediaWiki-commits] [Gerrit] Let all handlers return deferred objects - change (mediawiki...Flow)

2014-11-20 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/174707 Change subject: Let all handlers return deferred objects .. Let all handlers return deferred objects This would allow us to attach

[MediaWiki-commits] [Gerrit] Make sure there are no datatype mismatches when doing updates - change (mediawiki...Flow)

2014-11-25 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/175694 Change subject: Make sure there are no datatype mismatches when doing updates .. Make sure there are no datatype mismatches when

[MediaWiki-commits] [Gerrit] Move CacheWarmers ShardAllocation validators into own folder - change (mediawiki...CirrusSearch)

2014-11-25 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/175716 Change subject: Move CacheWarmers ShardAllocation validators into own folder .. Move CacheWarmers ShardAllocation validators into

[MediaWiki-commits] [Gerrit] Remove unused autoExpand animationtime - change (mediawiki...Flow)

2014-11-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171140 Change subject: Remove unused autoExpand animationtime .. Remove unused autoExpand animationtime Change-Id:

[MediaWiki-commits] [Gerrit] Get rid of .offset() undefined error - change (mediawiki...Flow)

2014-11-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171141 Change subject: Get rid of .offset() undefined error .. Get rid of .offset() undefined error Been getting an error because $form was

[MediaWiki-commits] [Gerrit] Fix undoing topic moderation - change (mediawiki...Flow)

2014-11-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171146 Change subject: Fix undoing topic moderation .. Fix undoing topic moderation It was calling a wrong handler Change-Id:

[MediaWiki-commits] [Gerrit] Execute deferred updates in tests - change (mediawiki...Flow)

2014-11-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171181 Change subject: Execute deferred updates in tests .. Execute deferred updates in tests Meanwhile also throwing exceptions in

[MediaWiki-commits] [Gerrit] blank page/503 output viewing a deleted topic if you don't h... - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171310 Change subject: blank page/503 output viewing a deleted topic if you don't have rights .. blank page/503 output viewing a deleted

[MediaWiki-commits] [Gerrit] Hygiene: Move RecentChangeListener to Listener namespace - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Hygiene: Move RecentChangeListener to Listener namespace .. Hygiene: Move RecentChangeListener to Listener namespace receck Change-Id:

[MediaWiki-commits] [Gerrit] Hygiene: Use real objects instead of mocks - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Hygiene: Use real objects instead of mocks .. Hygiene: Use real objects instead of mocks The IRCLineUrlFormatter really shouldn't be mocking up a

[MediaWiki-commits] [Gerrit] Add mExtra['pageStatus'] to RC object - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171327 Change subject: Add mExtra['pageStatus'] to RC object .. Add mExtra['pageStatus'] to RC object RecentChange::save expects this key

[MediaWiki-commits] [Gerrit] Execute deferred updates in tests - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Execute deferred updates in tests .. Execute deferred updates in tests Meanwhile also throwing exceptions in NotificationListener. I'd rather have

[MediaWiki-commits] [Gerrit] Bump workflow cache version number - change (mediawiki...Flow)

2014-11-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171470 Change subject: Bump workflow cache version number .. Bump workflow cache version number I7c759b46995c045405426239e95f40147e8aaecb

[MediaWiki-commits] [Gerrit] Show more descriptive message when unable to unmoderate - change (mediawiki...Flow)

2014-11-06 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171598 Change subject: Show more descriptive message when unable to unmoderate .. Show more descriptive message when unable to unmoderate

[MediaWiki-commits] [Gerrit] Show error message when unable to undo moderation - change (mediawiki...Flow)

2014-11-06 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171597 Change subject: Show error message when unable to undo moderation .. Show error message when unable to undo moderation Change-Id:

[MediaWiki-commits] [Gerrit] Fix fatal on watchlist - change (mediawiki...Flow)

2014-11-06 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171611 Change subject: Fix fatal on watchlist .. Fix fatal on watchlist Bug: 73074 Change-Id: If914a36c097f1df81ac9d5e12052dbcbeca5bd55 ---

[MediaWiki-commits] [Gerrit] [WIP] Log Flow topic and post actions (FlowReplies) - change (mediawiki...Flow)

2014-11-06 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171791 Change subject: [WIP] Log Flow topic and post actions (FlowReplies) .. [WIP] Log Flow topic and post actions (FlowReplies) Todo: *

[MediaWiki-commits] [Gerrit] Consistent indents for db patch - change (mediawiki...Flow)

2014-11-07 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171857 Change subject: Consistent indents for db patch .. Consistent indents for db patch Change-Id:

[MediaWiki-commits] [Gerrit] Hygiene: Add missing use - change (mediawiki...Flow)

2014-11-07 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171869 Change subject: Hygiene: Add missing use .. Hygiene: Add missing use Not really breaking anythin; it's only used in PHPDoc, but

[MediaWiki-commits] [Gerrit] Always show errors, not just for POST - change (mediawiki...Flow)

2014-11-07 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/171883 Change subject: Always show errors, not just for POST .. Always show errors, not just for POST Change-Id:

[MediaWiki-commits] [Gerrit] Temporary remove UserTuple id ip restriction - change (mediawiki...Flow)

2014-11-07 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Temporary remove UserTuple id ip restriction .. Temporary remove UserTuple id ip restriction We currently have some bad data in the database that

[MediaWiki-commits] [Gerrit] Logged-in users should save null values to rev_user_id - change (mediawiki...Flow)

2014-11-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/172429 Change subject: Logged-in users should save null values to rev_user_id .. Logged-in users should save null values to rev_user_id

[MediaWiki-commits] [Gerrit] Move validateAnalyzers code into separate class - change (mediawiki...CirrusSearch)

2014-11-26 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176000 Change subject: Move validateAnalyzers code into separate class .. Move validateAnalyzers code into separate class Meanwhile also

[MediaWiki-commits] [Gerrit] Move validateIndexSettings code into 3 separate classes - change (mediawiki...CirrusSearch)

2014-11-26 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/175999 Change subject: Move validateIndexSettings code into 3 separate classes .. Move validateIndexSettings code into 3 separate classes

[MediaWiki-commits] [Gerrit] Bug: action=purge doesnt purge the topic list sorted by last... - change (mediawiki...Flow)

2014-11-27 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Bug: action=purge doesnt purge the topic list sorted by last update .. Bug: action=purge doesnt purge the topic list sorted by last update

[MediaWiki-commits] [Gerrit] Move validateMapping code into separate class - change (mediawiki...CirrusSearch)

2014-11-27 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176285 Change subject: Move validateMapping code into separate class .. Move validateMapping code into separate class Meanwhile removed the

[MediaWiki-commits] [Gerrit] Make Validator::validate methods return Status object - change (mediawiki...CirrusSearch)

2014-11-27 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176286 Change subject: Make Validator::validate methods return Status object .. Make Validator::validate methods return Status object This

[MediaWiki-commits] [Gerrit] [WIP] Move validateSpecificAlias and validateAllAlias into s... - change (mediawiki...CirrusSearch)

2014-12-01 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176682 Change subject: [WIP] Move validateSpecificAlias and validateAllAlias into separate classes .. [WIP] Move validateSpecificAlias and

[MediaWiki-commits] [Gerrit] Move validateAllAlias code into separate class - change (mediawiki...CirrusSearch)

2014-12-02 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176946 Change subject: Move validateAllAlias code into separate class .. Move validateAllAlias code into separate class This has a minor

[MediaWiki-commits] [Gerrit] Only bind to keep-editing button once - change (mediawiki...Flow)

2014-12-02 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/176949 Change subject: Only bind to keep-editing button once .. Only bind to keep-editing button once Every time preview is launched, this

[MediaWiki-commits] [Gerrit] Make ElasticaConnection a real singleton - change (mediawiki...Elastica)

2014-12-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/177212 Change subject: Make ElasticaConnection a real singleton .. Make ElasticaConnection a real singleton 2 reasons to make it a real

[MediaWiki-commits] [Gerrit] Move reindex code into separate class - change (mediawiki...CirrusSearch)

2014-12-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/177222 Change subject: Move reindex code into separate class .. Move reindex code into separate class This depends on

[MediaWiki-commits] [Gerrit] Move validateSpecificAlias code into separate class - change (mediawiki...CirrusSearch)

2014-12-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/177223 Change subject: Move validateSpecificAlias code into separate class .. Move validateSpecificAlias code into separate class

[MediaWiki-commits] [Gerrit] Move validateIndex code into separate class - change (mediawiki...CirrusSearch)

2014-12-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/177551 Change subject: Move validateIndex code into separate class .. Move validateIndex code into separate class Change-Id:

[MediaWiki-commits] [Gerrit] [WIP] Take remaining logic out of UpdateOneSearchIndexConfig... - change (mediawiki...CirrusSearch)

2014-12-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/179924 Change subject: [WIP] Take remaining logic out of UpdateOneSearchIndexConfig and into separate class .. [WIP] Take remaining logic

[MediaWiki-commits] [Gerrit] Break 2 mappingconfigbuilder arguments out of constructor - change (mediawiki...CirrusSearch)

2014-12-15 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/179923 Change subject: Break 2 mappingconfigbuilder arguments out of constructor .. Break 2 mappingconfigbuilder arguments out of

[MediaWiki-commits] [Gerrit] Update autoload.php - change (mediawiki...Flow)

2014-12-16 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180191 Change subject: Update autoload.php .. Update autoload.php `make autoload` had some changes Change-Id:

[MediaWiki-commits] [Gerrit] Don't hardcode PHP executable path version - change (mediawiki...Flow)

2014-12-16 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180194 Change subject: Don't hardcode PHP executable path version .. Don't hardcode PHP executable path version Mine is

[MediaWiki-commits] [Gerrit] Fix JS timestamp; shows up as 45 years ago (epoch) - change (mediawiki...Flow)

2014-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/172772 Change subject: Fix JS timestamp; shows up as 45 years ago (epoch) .. Fix JS timestamp; shows up as 45 years ago (epoch) Change-Id:

[MediaWiki-commits] [Gerrit] Timestamps should link to topic history - change (mediawiki...Flow)

2014-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/172773 Change subject: Timestamps should link to topic history .. Timestamps should link to topic history Change-Id:

[MediaWiki-commits] [Gerrit] Make $.findWithParent work with a set of comma-separated sel... - change (mediawiki...Flow)

2014-11-12 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/172935 Change subject: Make $.findWithParent work with a set of comma-separated selectors .. Make $.findWithParent work with a set of

[MediaWiki-commits] [Gerrit] Make it possible to add interactiveHandlers to elements on f... - change (mediawiki...Flow)

2014-11-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/173325 Change subject: Make it possible to add interactiveHandlers to elements on focus .. Make it possible to add interactiveHandlers to

[MediaWiki-commits] [Gerrit] Expand/compress textareas via CSS instead of swapping nodes - change (mediawiki...Flow)

2014-11-14 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/173324 Change subject: Expand/compress textareas via CSS instead of swapping nodes .. Expand/compress textareas via CSS instead of swapping

[MediaWiki-commits] [Gerrit] Hide inputs on preview - change (mediawiki...Flow)

2014-12-18 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180738 Change subject: Hide inputs on preview .. Hide inputs on preview Fixes T78725 Bug: T78725 Change-Id:

[MediaWiki-commits] [Gerrit] Make rollover state a link to topic history - change (mediawiki...Flow)

2014-12-18 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180754 Change subject: Make rollover state a link to topic history .. Make rollover state a link to topic history We add a link to history

[MediaWiki-commits] [Gerrit] Make rollover state a link to topic history - change (mediawiki...Flow)

2014-12-18 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180753 Change subject: Make rollover state a link to topic history .. Make rollover state a link to topic history We only linked to history

[MediaWiki-commits] [Gerrit] JS-generated timestamps have no hover, only displays readabl... - change (mediawiki...Flow)

2014-12-18 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180755 Change subject: JS-generated timestamps have no hover, only displays readable time .. JS-generated timestamps have no hover, only

[MediaWiki-commits] [Gerrit] Page linked by another user : link to the original article - change (mediawiki...Echo)

2014-12-18 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/180761 Change subject: Page linked by another user : link to the original article .. Page linked by another user : link to the original

[MediaWiki-commits] [Gerrit] Disable Flow EventLogging by default - change (mediawiki...Flow)

2014-12-08 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178188 Change subject: Disable Flow EventLogging by default .. Disable Flow EventLogging by default I think opt-in makes more sense than

[MediaWiki-commits] [Gerrit] Defer toStorageRow until we need it for update - change (mediawiki...Flow)

2014-12-08 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178193 Change subject: Defer toStorageRow until we need it for update .. Defer toStorageRow until we need it for update Change-Id:

[MediaWiki-commits] [Gerrit] Increase navigator font size - change (mediawiki...Flow)

2014-12-08 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178202 Change subject: Increase navigator font size .. Increase navigator font size In patch Ied9724ac96d77e9de134a95010f64ff7bf600a7a, I

[MediaWiki-commits] [Gerrit] Remove resize handle in compressed textareas - change (mediawiki...Flow)

2014-12-08 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178203 Change subject: Remove resize handle in compressed textareas .. Remove resize handle in compressed textareas This removes the small

[MediaWiki-commits] [Gerrit] Hygiene: Don't use !important for shrinking compressed texta... - change (mediawiki...Flow)

2014-12-09 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178452 Change subject: Hygiene: Don't use !important for shrinking compressed textarea height .. Hygiene: Don't use !important for

[MediaWiki-commits] [Gerrit] Clarify alert/messages meaning - change (mediawiki...Echo)

2014-12-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/178851 Change subject: Clarify alert/messages meaning .. Clarify alert/messages meaning Bug: T72255 Change-Id:

[MediaWiki-commits] [Gerrit] Introduce a new hook that allows extensions to add to My Con... - change (mediawiki/core[master])

2012-07-02 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Introduce a new hook that allows extensions to add to My Contributions .. Introduce a new hook that allows extensions to add to My Contributions Meanwhile

[MediaWiki-commits] [Gerrit] Bug 38112 - Article Feedback - Turn off all click-tracking - change (mediawiki...ArticleFeedbackv5[master])

2012-07-02 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Bug 38112 - Article Feedback - Turn off all click-tracking .. Bug 38112 - Article Feedback - Turn off all click-tracking Change-Id:

[MediaWiki-commits] [Gerrit] Update MyContribs hook to reflect the changes in code: - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Update MyContribs hook to reflect the changes in code: .. Update MyContribs hook to reflect the changes in code: - added parameter - moved article

[MediaWiki-commits] [Gerrit] Bug 38021 - Article Feedback Page - Activity Log: Fix Text C... - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Bug 38021 - Article Feedback Page - Activity Log: Fix Text Color .. Bug 38021 - Article Feedback Page - Activity Log: Fix Text Color Change-Id:

[MediaWiki-commits] [Gerrit] lower AFTv4 odds to display AFTv5 at 5% (inverse odds) - change (operations/mediawiki-config[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: lower AFTv4 odds to display AFTv5 at 5% (inverse odds) .. lower AFTv4 odds to display AFTv5 at 5% (inverse odds) Change-Id:

[MediaWiki-commits] [Gerrit] lower AFTv4 odds to display AFTv5 at 10% (inverse odds) - change (operations/mediawiki-config[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: lower AFTv4 odds to display AFTv5 at 10% (inverse odds) .. lower AFTv4 odds to display AFTv5 at 10% (inverse odds) Change-Id:

[MediaWiki-commits] [Gerrit] Don't display feedback that's been hidden, in MyContribs - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Don't display feedback that's been hidden, in MyContribs .. Don't display feedback that's been hidden, in MyContribs Change-Id:

[MediaWiki-commits] [Gerrit] Don't display feedback that's been hidden, in MyContribs - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Don't display feedback that's been hidden, in MyContribs .. Don't display feedback that's been hidden, in MyContribs Change-Id:

[MediaWiki-commits] [Gerrit] Introduce a new hook that allows extensions to add to My Con... - change (mediawiki/core[wmf/1.20wmf6])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Introduce a new hook that allows extensions to add to My Contributions .. Introduce a new hook that allows extensions to add to My Contributions Meanwhile

[MediaWiki-commits] [Gerrit] Pass $classes in the ContributionsLineEnding hook - change (mediawiki/core[wmf/1.20wmf6])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Pass $classes in the ContributionsLineEnding hook .. Pass $classes in the ContributionsLineEnding hook Originally part of

[MediaWiki-commits] [Gerrit] Update ArticleFeedbackv5, AbuseFilter, FlaggedRevs to master - change (mediawiki/core[wmf/1.20wmf6])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Update ArticleFeedbackv5, AbuseFilter, FlaggedRevs to master .. Update ArticleFeedbackv5, AbuseFilter, FlaggedRevs to master Change-Id:

[MediaWiki-commits] [Gerrit] blacklist AFTv5 whitelist for AFTv4 on test as well - change (operations/mediawiki-config[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: blacklist AFTv5 whitelist for AFTv4 on test as well .. blacklist AFTv5 whitelist for AFTv4 on test as well Change-Id:

[MediaWiki-commits] [Gerrit] fix message now showing up due to incorrect usage of case - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: fix message now showing up due to incorrect usage of case .. fix message now showing up due to incorrect usage of case Change-Id:

[MediaWiki-commits] [Gerrit] Update ArticleFeedbackv5 to master - change (mediawiki/core[wmf/1.20wmf6])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Update ArticleFeedbackv5 to master .. Update ArticleFeedbackv5 to master Change-Id: I09bf980295271781a054edb57d32890ea6acf3a2 --- M

[MediaWiki-commits] [Gerrit] Update ArticleFeedbackv5 to master - change (mediawiki/core[wmf/1.20wmf6])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged. Change subject: Update ArticleFeedbackv5 to master .. Update ArticleFeedbackv5 to master Change-Id: I09bf980295271781a054edb57d32890ea6acf3a2 --- M

[MediaWiki-commits] [Gerrit] fix message now showing up due to incorrect usage of case - ... - change (mediawiki...ArticleFeedbackv5[master])

2012-07-03 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: fix message now showing up due to incorrect usage of case - pt 2 .. fix message now showing up due to incorrect usage of case - pt 2 Change-Id:

[MediaWiki-commits] [Gerrit] Bug 36649 - Article Feedback Page - Show the user's last pos... - change (mediawiki...ArticleFeedbackv5[master])

2012-07-04 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Bug 36649 - Article Feedback Page - Show the user's last post at the top of the page .. Bug 36649 - Article Feedback Page - Show the user's last post at the

[MediaWiki-commits] [Gerrit] Bug 36773 - Article Feedback - My Contributions - change (mediawiki...ArticleFeedbackv5[master])

2012-07-05 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Bug 36773 - Article Feedback - My Contributions .. Bug 36773 - Article Feedback - My Contributions Change-Id: I366a90537d63ffedef1ef7b0b67521024e5abf5b --- M

[MediaWiki-commits] [Gerrit] Bug 37025 - Article Feedback Tool - Font Sizes - change (mediawiki...ArticleFeedbackv5[master])

2012-07-06 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Bug 37025 - Article Feedback Tool - Font Sizes .. Bug 37025 - Article Feedback Tool - Font Sizes Change-Id: Ic36d915ea08cee8fc5d1d254dd49dbc5eab54abe --- M

[MediaWiki-commits] [Gerrit] Update ArticleFeedbackv5 to master - change (mediawiki/core[wmf/1.20wmf6])

2012-07-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Update ArticleFeedbackv5 to master .. Update ArticleFeedbackv5 to master Change-Id: I17164a601ba198a902405fd580a440fa8290c53c --- M

[MediaWiki-commits] [Gerrit] Update ArticleFeedbackv5 to master - change (mediawiki/core[wmf/1.20wmf7])

2012-07-10 Thread Matthias Mullie (Code Review)
Matthias Mullie has uploaded a new change for review. Change subject: Update ArticleFeedbackv5 to master .. Update ArticleFeedbackv5 to master Change-Id: I1b396251dba70e9b4d9c8d45fa6a476f35276394 --- M

  1   2   3   4   5   6   7   8   9   10   >