[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: API classes require permissions defined by ChangeOps they use

2017-07-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365624 ) Change subject: API classes require permissions defined by ChangeOps they use .. API classes require permissions defined by ChangeOps

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Handle storage exception from custom entities in EntityStora...

2017-07-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364228 ) Change subject: Handle storage exception from custom entities in EntityStorageHelper .. Handle storage exception from custom entities

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Relase 2.2.2

2017-07-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364239 ) Change subject: Relase 2.2.2 .. Relase 2.2.2 Change-Id: I274a137805e3eae01a74ff949d893be01c5a755d --- M README.md 1 file changed, 4

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Lint JS with eslint

2017-07-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364235 ) Change subject: Lint JS with eslint .. Lint JS with eslint Bug: T165843 Change-Id: I5930ac47a1291d2af83eb4181cc2178fbd3e8c4b --- R

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM][EXPERIMENT] Require *-term permissions to edit entity ...

2017-07-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365259 ) Change subject: [DNM][EXPERIMENT] Require *-term permissions to edit entity terms using wbeditentity .. [DNM][EXPERIMENT] Require

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Automatically check indentation of JS files

2017-07-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365229 ) Change subject: Automatically check indentation of JS files .. Automatically check indentation of JS files Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Rename incorrectly named Api\SetAliases and Api\SetDescripti...

2017-07-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365230 ) Change subject: Rename incorrectly named Api\SetAliases and Api\SetDescription tests .. Rename incorrectly named Api\SetAliases and

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add test verifying editing entity terms using Api\EditEntity...

2017-07-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365231 ) Change subject: Add test verifying editing entity terms using Api\EditEntity requires *-term permissions .. Add test verifying editing

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Fix demo page populators

2017-07-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365223 ) Change subject: Fix demo page populators .. Fix demo page populators Use item ids in item reference statements. Set random GUID for

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: [WIP] Do not turn empty strings to undefined

2017-07-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364191 ) Change subject: [WIP] Do not turn empty strings to undefined .. [WIP] Do not turn empty strings to undefined Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: EntityContentFactory does not implement EntityPermissionChecker

2017-06-29 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362241 ) Change subject: EntityContentFactory does not implement EntityPermissionChecker .. EntityContentFactory does not implement

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove entity creation permission logic checks from Api\Edit...

2017-06-29 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362239 ) Change subject: Remove entity creation permission logic checks from Api\EditEntity .. Remove entity creation permission logic checks

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix foreign IDs handling in SqlEntityInfoBuilder

2017-07-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363149 ) Change subject: Fix foreign IDs handling in SqlEntityInfoBuilder .. Fix foreign IDs handling in SqlEntityInfoBuilder Database queries

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Switch all arrays to short syntax

2017-07-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363167 ) Change subject: Switch all arrays to short syntax .. Switch all arrays to short syntax Done by running phpcbf with

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Change signature of SpecialNewLexeme::createSummary

2017-07-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363184 ) Change subject: Change signature of SpecialNewLexeme::createSummary .. Change signature of SpecialNewLexeme::createSummary Following

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set Wikibase readFullEntityIdColumn to false

2017-07-03 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362986 ) Change subject: Set Wikibase readFullEntityIdColumn to false .. Set Wikibase readFullEntityIdColumn to false

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Revert "(temporarily) disable use of client services in repo"

2017-07-03 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362999 ) Change subject: Revert "(temporarily) disable use of client services in repo" .. Revert "(temporarily) disable use of client services

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove user permission logic from RedirectCreationInteractor

2017-07-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363303 ) Change subject: Remove user permission logic from RedirectCreationInteractor .. Remove user permission logic from

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove user permission logic from ItemMergeInteractor

2017-07-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363304 ) Change subject: Remove user permission logic from ItemMergeInteractor .. Remove user permission logic from ItemMergeInteractor Just

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use EntityPermissionChecker for checking term modify permiss...

2017-07-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363305 ) Change subject: Use EntityPermissionChecker for checking term modify permissions on relevant Special pages .. Use

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use EntityPermissionChecker::PERMISSION_EDIT constant in Edi...

2017-07-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363302 ) Change subject: Use EntityPermissionChecker::PERMISSION_EDIT constant in EditEntity .. Use EntityPermissionChecker::PERMISSION_EDIT

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Removed unused EditEntity::addRequiredPermission

2017-07-06 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363576 ) Change subject: Removed unused EditEntity::addRequiredPermission .. Removed unused EditEntity::addRequiredPermission As adding

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Simplified ModifyEntity::checkPermissions

2017-07-06 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363575 ) Change subject: Simplified ModifyEntity::checkPermissions .. Simplified ModifyEntity::checkPermissions Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Use WikiPageEntityStorePermissionChecker as WikibaseRe...

2017-06-28 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361889 ) Change subject: [WIP] Use WikiPageEntityStorePermissionChecker as WikibaseRepo permission checker .. [WIP] Use

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Adjust the contructor of SpecialNewLexeme

2017-04-27 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350540 ) Change subject: Adjust the contructor of SpecialNewLexeme .. Adjust the contructor of SpecialNewLexeme Parent class constructor has

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Remove special page aliases file

2017-04-24 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349926 ) Change subject: Remove special page aliases file .. Remove special page aliases file As long as there are no aliases, this file is not

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: DO NOT MERGE Demo only

2017-04-28 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350827 ) Change subject: DO NOT MERGE Demo only .. DO NOT MERGE Demo only This shows a possible way to test Wikibase RDF-related services as

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Fix item-property statements on Leiter demo page

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369396 ) Change subject: Fix item-property statements on Leiter demo page .. Fix item-property statements on Leiter demo page Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Make headers of Statements section for form and sense a big ...

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369391 ) Change subject: Make headers of Statements section for form and sense a big bigger .. Make headers of Statements section for form and

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Pass EntityIdComposer to RepostioryServiceContainer

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363627 ) Change subject: Pass EntityIdComposer to RepostioryServiceContainer .. Pass EntityIdComposer to RepostioryServiceContainer

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add headers to the fields in the "gloss table"

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369402 ) Change subject: Add headers to the fields in the "gloss table" .. Add headers to the fields in the "gloss table" Bug: T172191

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: When expecting English message in SpecialModifyTermTestCase ...

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368996 ) Change subject: When expecting English message in SpecialModifyTermTestCase use English as request language too .. When expecting

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove create action from EntityPermissionChecker interface

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368998 ) Change subject: Remove create action from EntityPermissionChecker interface .. Remove create action from EntityPermissionChecker

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add labels to fields of the form representation widget

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369410 ) Change subject: Add labels to fields of the form representation widget .. Add labels to fields of the form representation widget Bug:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Move form representation styles to the separate file

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369405 ) Change subject: Move form representation styles to the separate file .. Move form representation styles to the separate file

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add headers to fields of the lemma widget

2017-08-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369412 ) Change subject: Add headers to fields of the lemma widget .. Add headers to fields of the lemma widget Bug: T172197 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Temporarily add class alias for EntityRevision

2017-08-09 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370949 ) Change subject: Temporarily add class alias for EntityRevision .. Temporarily add class alias for EntityRevision Apparently there are

[MediaWiki-commits] [Gerrit] integration/config[master]: Add Chris Neuroth to the list of users triggering +2 voting ...

2017-08-22 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373077 ) Change subject: Add Chris Neuroth to the list of users triggering +2 voting checks .. Add Chris Neuroth to the list of users

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use the StringNormalizer instance provided by WikibaseServic...

2017-08-22 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373098 ) Change subject: Use the StringNormalizer instance provided by WikibaseServices in Client and (optionally) repo .. Use the

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: MultipleRepositoryAwareWikibaseServices creates service cont...

2017-08-22 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373094 ) Change subject: MultipleRepositoryAwareWikibaseServices creates service containers itself .. MultipleRepositoryAwareWikibaseServices

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use LFChainFactory instance provided by WikibaseServices in ...

2017-08-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373275 ) Change subject: Use LFChainFactory instance provided by WikibaseServices in Client and (optionally) Repo .. Use LFChainFactory

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove no longer used WikibaseClient::getEntityContentDataCodec

2017-08-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373288 ) Change subject: Remove no longer used WikibaseClient::getEntityContentDataCodec .. Remove no longer used

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move ForbiddenSerializer to DataAccess component

2017-08-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373289 ) Change subject: Move ForbiddenSerializer to DataAccess component .. Move ForbiddenSerializer to DataAccess component As it is no

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use a single SnakSerializer instance in ConstraintParameterP...

2017-08-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372514 ) Change subject: Use a single SnakSerializer instance in ConstraintParameterParserTest .. Use a single SnakSerializer instance in

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use CdnCacheUpdate instead of deprecated SquidUpdate

2017-08-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372524 ) Change subject: Use CdnCacheUpdate instead of deprecated SquidUpdate .. Use CdnCacheUpdate instead of deprecated SquidUpdate

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove no longer needed EntityRevision alias

2017-08-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372520 ) Change subject: Remove no longer needed EntityRevision alias .. Remove no longer needed EntityRevision alias

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Install MW core dev dependencies in Travis CI builds

2017-08-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372532 ) Change subject: Install MW core dev dependencies in Travis CI builds .. Install MW core dev dependencies in Travis CI builds Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Bump data-values/geo version requirement to 2.0.0

2017-05-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353022 ) Change subject: Bump data-values/geo version requirement to 2.0.0 .. Bump data-values/geo version requirement to 2.0.0 Hashes have

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Renamed DispatchingServiceFactory to DispatchingServiceConta...

2017-05-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353323 ) Change subject: Renamed DispatchingServiceFactory to DispatchingServiceContainer .. Renamed DispatchingServiceFactory to

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add WikibaseServices interface and the "dispatching-aware" i...

2017-05-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353299 ) Change subject: Add WikibaseServices interface and the "dispatching-aware" implementation .. Add WikibaseServices interface and the

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Rename EntityDataRetrievalServiceFactory to DispatchingDataA...

2017-05-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353322 ) Change subject: Rename EntityDataRetrievalServiceFactory to DispatchingDataAccessServices .. Rename EntityDataRetrievalServiceFactory

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP]Move PropertyInfoLookup and Store, and their implementa...

2017-05-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353327 ) Change subject: [WIP]Move PropertyInfoLookup and Store, and their implementation to Data Access component .. [WIP]Move

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Test TermSqlIndex::deleteTermsOfEntity in the read full ID mode

2017-05-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354093 ) Change subject: Test TermSqlIndex::deleteTermsOfEntity in the read full ID mode .. Test TermSqlIndex::deleteTermsOfEntity in the read

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix the signature of SpecialNewEntity::getCopyrightHTML

2017-05-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354104 ) Change subject: Fix the signature of SpecialNewEntity::getCopyrightHTML .. Fix the signature of SpecialNewEntity::getCopyrightHTML

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix method reference in WikibaseSettings class docs

2017-05-17 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354112 ) Change subject: Fix method reference in WikibaseSettings class docs .. Fix method reference in WikibaseSettings class docs Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use WikibaseSettings methods instead of directly checking na...

2017-05-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353982 ) Change subject: Use WikibaseSettings methods instead of directly checking named constants .. Use WikibaseSettings methods instead of

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Simplify data provider in DirectSqlStoreTest

2017-05-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353981 ) Change subject: Simplify data provider in DirectSqlStoreTest .. Simplify data provider in DirectSqlStoreTest Moved a special case

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make TermSqlIndexBuilder only rebuild entity terms when nece...

2017-06-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358387 ) Change subject: Make TermSqlIndexBuilder only rebuild entity terms when necessary .. Make TermSqlIndexBuilder only rebuild entity

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Clean up documentation in Form JS data model and view classes

2017-06-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359473 ) Change subject: Clean up documentation in Form JS data model and view classes .. Clean up documentation in Form JS data model and view

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Take account for sense in JS Lexeme Deserializer

2017-06-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360626 ) Change subject: Take account for sense in JS Lexeme Deserializer .. Take account for sense in JS Lexeme Deserializer Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Serialize statements on Senses in LexemeSerializer

2017-06-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360624 ) Change subject: Serialize statements on Senses in LexemeSerializer .. Serialize statements on Senses in LexemeSerializer Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add JS implementation of Sense data model class

2017-06-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/360625 ) Change subject: Add JS implementation of Sense data model class .. Add JS implementation of Sense data model class This is to the most

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make readFullEntityIdColumn enabled by default

2017-06-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361072 ) Change subject: Make readFullEntityIdColumn enabled by default .. Make readFullEntityIdColumn enabled by default The full entity ID

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fetch all site link data from item to show badges in Other P...

2017-06-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361071 ) Change subject: Fetch all site link data from item to show badges in Other Project Sidebar .. Fetch all site link data from item to

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update several DataValues libraries to current bug fix releases

2017-06-26 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361406 ) Change subject: Update several DataValues libraries to current bug fix releases .. Update several DataValues libraries to current bug

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Populate full entity ID column and only once on wb_terms sch...

2017-06-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361052 ) Change subject: Populate full entity ID column and only once on wb_terms schema update .. Populate full entity ID column and only once

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Add WikiPageEntityStorePermissionChecker for consisten...

2017-06-27 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/361693 ) Change subject: [WIP] Add WikiPageEntityStorePermissionChecker for consistent permission checks .. [WIP] Add

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Lint JS with jslint instead of jscs and jshint

2017-05-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354696 ) Change subject: Lint JS with jslint instead of jscs and jshint .. Lint JS with jslint instead of jscs and jshint Bug: T165843

[MediaWiki-commits] [Gerrit] integration/config[master]: [DNM] Reduce the number of Wikibase jobs

2017-05-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354725 ) Change subject: [DNM] Reduce the number of Wikibase jobs .. [DNM] Reduce the number of Wikibase jobs Bug: T160989 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use single spaces in JS code

2017-05-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354674 ) Change subject: Use single spaces in JS code .. Use single spaces in JS code Change-Id: Id85d6b89adef125374259a917da51a47f97b1519 ---

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-23 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355224 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Renamed EntityDataRetrievalServiceFactory to DataAccessServices

2017-05-24 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355450 ) Change subject: Renamed EntityDataRetrievalServiceFactory to DataAccessServices .. Renamed EntityDataRetrievalServiceFactory to

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata.org[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354989 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354973 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQuality[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354979 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaBadges[master]: Use eslint to lint JavaScript instead of jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354991 ) Change subject: Use eslint to lint JavaScript instead of jshint .. Use eslint to lint JavaScript instead of jshint Bug: T165843

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityExternalValidation[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354981 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Use eslint to lint JavaScript instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354986 ) Change subject: Use eslint to lint JavaScript instead of jscs and jshint .. Use eslint to lint JavaScript instead of jscs and jshint

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Send Travis notification emails to wikidata ci status email

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354944 ) Change subject: Send Travis notification emails to wikidata ci status email .. Send Travis notification emails to wikidata ci status

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Fix exclude path for stylelint grunt job

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354953 ) Change subject: Fix exclude path for stylelint grunt job .. Fix exclude path for stylelint grunt job Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Lint JavaScript with eslint instead of jscs and jshint

2017-05-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354952 ) Change subject: Lint JavaScript with eslint instead of jscs and jshint .. Lint JavaScript with eslint instead of jscs and jshint Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM] Assert badge data is added in OtherProjectsSidebarGene...

2017-06-07 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357572 ) Change subject: [DNM] Assert badge data is added in OtherProjectsSidebarGeneratorTest .. [DNM] Assert badge data is added in

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update documentation of badge data structure in SidebarLinkB...

2017-06-07 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357575 ) Change subject: Update documentation of badge data structure in SidebarLinkBadgeDisplay .. Update documentation of badge data

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Adjust wiring file paths in docs/options.wiki

2017-06-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356613 ) Change subject: Adjust wiring file paths in docs/options.wiki .. Adjust wiring file paths in docs/options.wiki Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add composer cs script for convenience

2017-06-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356554 ) Change subject: Add composer cs script for convenience .. Add composer cs script for convenience Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Display senses of the lexeme on the Lexeme page

2017-06-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356573 ) Change subject: Display senses of the lexeme on the Lexeme page .. Display senses of the lexeme on the Lexeme page Currently senses

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add Sense and SenseId

2017-06-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356572 ) Change subject: Add Sense and SenseId .. Add Sense and SenseId Also add sense list to the Lexeme entity Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do not use empty property datatype in tests

2017-06-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356574 ) Change subject: Do not use empty property datatype in tests .. Do not use empty property datatype in tests As it is considered invalid

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Allow setting the start position of SqlEntityIdPager

2017-06-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357812 ) Change subject: Allow setting the start position of SqlEntityIdPager .. Allow setting the start position of SqlEntityIdPager E.g. in

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Re-phrase the message shown after a page linking an entity w...

2017-06-09 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358038 ) Change subject: Re-phrase the message shown after a page linking an entity was removed .. Re-phrase the message shown after a page

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Only load entity data TermSqlIndexBuilder when necessary

2017-06-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358531 ) Change subject: Only load entity data TermSqlIndexBuilder when necessary .. Only load entity data TermSqlIndexBuilder when necessary

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [WIP] Display statements on Senses

2017-06-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358541 ) Change subject: [WIP] Display statements on Senses .. [WIP] Display statements on Senses TODO: browser test Bug: TODO add Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move default value of localClientDatabases to repo default c...

2017-06-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359151 ) Change subject: Move default value of localClientDatabases to repo default config .. Move default value of localClientDatabases to

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update the default value of showExternalRecentChanges setting

2017-06-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359153 ) Change subject: Update the default value of showExternalRecentChanges setting .. Update the default value of showExternalRecentChanges

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix typo in docs of RecentChangeFactory::SRC_WIKIBASE

2017-06-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359154 ) Change subject: Fix typo in docs of RecentChangeFactory::SRC_WIKIBASE .. Fix typo in docs of RecentChangeFactory::SRC_WIKIBASE

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Register MediaInfo talk namespace

2017-05-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351272 ) Change subject: Register MediaInfo talk namespace .. Register MediaInfo talk namespace As noticed in the comment T159709#3200587 talk

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Add tests for CognateStore's Read Only mode.

2017-05-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351831 ) Change subject: Add tests for CognateStore's Read Only mode. .. Add tests for CognateStore's Read Only mode. Also fixes the call of

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move EntityDataRetrievalServiceFactory and related classes t...

2017-05-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352599 ) Change subject: Move EntityDataRetrievalServiceFactory and related classes to Data Access component .. Move

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: JS LexemeDeserializer also deserializes statements on forms

2017-05-24 Thread WMDE-leszek (Code Review)
WMDE-leszek has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354231 ) Change subject: JS LexemeDeserializer also deserializes statements on forms .. JS LexemeDeserializer also deserializes

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add myself as a recipient of Travis failure notification emails

2017-09-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378002 ) Change subject: Add myself as a recipient of Travis failure notification emails .. Add myself as a recipient of Travis failure

<    1   2   3   4   5   6   >