[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove duplicate 'hiwiktionary' in s3.dblist

2018-01-19 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405337 ) Change subject: Remove duplicate 'hiwiktionary' in s3.dblist .. Remove duplicate 'hiwiktionary' in s3.dblist Also sort the list (with LANG=C

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialLog: Don't ignore offender when it's a nonexistent us...

2018-01-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404696 ) Change subject: SpecialLog: Don't ignore offender when it's a nonexistent username .. SpecialLog: Don't ignore offender when it's a nonexist

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiQueryTags: Remove unused tgprop value

2018-01-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404684 ) Change subject: ApiQueryTags: Remove unused tgprop value .. ApiQueryTags: Remove unused tgprop value While a tgprop=name has been defined si

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Non-MySQL comment table updates

2018-01-16 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404506 ) Change subject: Non-MySQL comment table updates .. Non-MySQL comment table updates Follows up Ic3a434c06. Add schema for MSSQL and Oracle,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiSandbox: Use OO.ui.getDefaultOverlay()

2018-01-12 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403932 ) Change subject: ApiSandbox: Use OO.ui.getDefaultOverlay() .. ApiSandbox: Use OO.ui.getDefaultOverlay() Mostly via the shortcut of passing tr

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add tests for RevisionStore::newMutableRevisionFromArray and...

2018-01-11 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403759 ) Change subject: Add tests for RevisionStore::newMutableRevisionFromArray and legacy encoding .. Add tests for RevisionStore::newMutableRevis

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiQueryImageInfo: Don't return URLs if the archived file is...

2018-01-09 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403174 ) Change subject: ApiQueryImageInfo: Don't return URLs if the archived file is missing .. ApiQueryImageInfo: Don't return URLs if the archived

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Populate ar_rev_id and make it non-nullable

2018-01-08 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402932 ) Change subject: Populate ar_rev_id and make it non-nullable .. Populate ar_rev_id and make it non-nullable Revisions deleted before MediaWik

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Don't apply size limit to action=compare

2018-01-08 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402834 ) Change subject: API: Don't apply size limit to action=compare .. API: Don't apply size limit to action=compare Some diffs can be really huge

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add options and join conds to MediaWikiTestCase::assertSelect

2018-01-05 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402376 ) Change subject: Add options and join conds to MediaWikiTestCase::assertSelect .. Add options and join conds to MediaWikiTestCase::assertSelec

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix typo in PostgresUpdater in I30a3a983

2018-01-03 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401774 ) Change subject: Fix typo in PostgresUpdater in I30a3a983 .. Fix typo in PostgresUpdater in I30a3a983 Bug: T174028 Change-Id: I916c8e693e477e

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add tests for ApiFormatBase

2018-01-03 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401770 ) Change subject: Add tests for ApiFormatBase .. Add tests for ApiFormatBase Ensuring proper behavior of the base class lets comprehensive tes

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiComparePages: Add 'fromsection' and 'tosection' parameters

2017-12-30 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401090 ) Change subject: ApiComparePages: Add 'fromsection' and 'tosection' parameters .. ApiComparePages: Add 'fromsection' and 'tosection' parameter

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: Add missing visibility declarations

2017-12-30 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401089 ) Change subject: Add missing visibility declarations .. Add missing visibility declarations And re-enable Squiz.Scope.MethodScope.Missing Ch

[MediaWiki-commits] [Gerrit] mediawiki...ApiFeatureUsage[master]: Add missing visibility declarations

2017-12-30 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401088 ) Change subject: Add missing visibility declarations .. Add missing visibility declarations And re-enable Squiz.Scope.MethodScope.Missing Ch

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399913 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available .. Use 'unwrap' post-cache transfor

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399914 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) .. Use 'unwrap' post-cache transform instead of set

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove wrapclass from parser cache key

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399908 ) Change subject: Remove wrapclass from parser cache key .. Remove wrapclass from parser cache key This will result in an exception from WikiP

[MediaWiki-commits] [Gerrit] mediawiki...ParsoidBatchAPI[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399911 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available .. Use 'unwrap' post-cache transfor

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399910 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ), when available .. Use 'unwrap' post-cache transfor

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add 'unwrap' ParserOutput post-cache transform

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399907 ) Change subject: Add 'unwrap' ParserOutput post-cache transform .. Add 'unwrap' ParserOutput post-cache transform And deprecate passing false

[MediaWiki-commits] [Gerrit] mediawiki...CiteThisPage[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399909 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) .. Use 'unwrap' post-cache transform instead of set

[MediaWiki-commits] [Gerrit] mediawiki...TemplateStyles[master]: Use 'unwrap' post-cache transform instead of setWrapOutputCl...

2017-12-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399912 ) Change subject: Use 'unwrap' post-cache transform instead of setWrapOutputClass( false ) .. Use 'unwrap' post-cache transform instead of set

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use new TagMultiselectWidget in ApiSandbox

2017-12-20 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399427 ) Change subject: Use new TagMultiselectWidget in ApiSandbox .. Use new TagMultiselectWidget in ApiSandbox It seems to be generally a 1:1 repl

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiBlock: Improve username validation

2017-12-19 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399190 ) Change subject: ApiBlock: Improve username validation .. ApiBlock: Improve username validation The current username validation lets any inva

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiMain: Fix call to Linker::makeHeadline()

2017-12-18 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398850 ) Change subject: ApiMain: Fix call to Linker::makeHeadline() .. ApiMain: Fix call to Linker::makeHeadline() It's required that the $attribs p

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix typo in ImportHandleUnknownUser hook documentation

2017-12-15 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398512 ) Change subject: Fix typo in ImportHandleUnknownUser hook documentation .. Fix typo in ImportHandleUnknownUser hook documentation Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix 'sql' script for multi-instance hosts

2017-12-12 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397912 ) Change subject: Fix 'sql' script for multi-instance hosts .. Fix 'sql' script for multi-instance hosts It needs to extract the port, if one

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add --replica parameter to sql script

2017-12-12 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397913 ) Change subject: Add --replica parameter to sql script .. Add --replica parameter to sql script I've often had a need to connect to a specifi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP: Migrate HistoryBlob to alternatives without PHP seriali...

2017-12-11 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397632 ) Change subject: WIP: Migrate HistoryBlob to alternatives without PHP serialization .. WIP: Migrate HistoryBlob to alternatives without PHP s

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat

2017-12-08 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396427 ) Change subject: Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat .. Fix MWDebugTest::testAppendDebugInfoToApiResultXmlFormat When th

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ApiQueryBase: Fix addWhereFld for PHP 7.2

2017-12-08 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396426 ) Change subject: ApiQueryBase: Fix addWhereFld for PHP 7.2 .. ApiQueryBase: Fix addWhereFld for PHP 7.2 Idfe23a07d didn't go far enough with

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: ImageListPager: Don't stomp on $join_conds

2017-12-07 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396035 ) Change subject: ImageListPager: Don't stomp on $join_conds .. ImageListPager: Don't stomp on $join_conds When adding a join to the oldimage

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ImageListPager: Don't stomp on $join_conds

2017-12-07 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396019 ) Change subject: ImageListPager: Don't stomp on $join_conds .. ImageListPager: Don't stomp on $join_conds When adding a join to the oldimage

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Set wgCommentTableSchemaMigrationStage = MIGRATION_W...

2017-12-04 Thread Anomie (Code Review)
Hello Legoktm, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/395077 to review the following change. Change subject: Revert "Set wgCommentTableSchemaMigrationStage = MIGRATION_WRITE_BOTH on test wikis" ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set wgCommentTableSchemaMigrationStage = MIGRATION_WRITE_BOT...

2017-12-04 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395073 ) Change subject: Set wgCommentTableSchemaMigrationStage = MIGRATION_WRITE_BOTH on test wikis .. Set wgCommentTableSchemaMigrationStage = MIGR

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Account for PHP 7.2 change

2017-12-04 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395064 ) Change subject: API: Account for PHP 7.2 change .. API: Account for PHP 7.2 change PHP 7.2 broke existing functionality in making count( nul

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Avoid passing null to count()

2017-12-04 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395023 ) Change subject: Avoid passing null to count() .. Avoid passing null to count() PHP 7.2 made the questionable decision to raise a warning for

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove 'wbIsEditView' JS config var

2017-12-01 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394642 ) Change subject: Remove 'wbIsEditView' JS config var .. Remove 'wbIsEditView' JS config var The PHP code doesn't know any longer whether the

[MediaWiki-commits] [Gerrit] mediawiki...TemplateStyles[master]: Cache processed stylesheets during the parse

2017-11-30 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394369 ) Change subject: Cache processed stylesheets during the parse .. Cache processed stylesheets during the parse If we've already processed a st

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix timestamps in ImportTest

2017-11-30 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394321 ) Change subject: Fix timestamps in ImportTest .. Fix timestamps in ImportTest They need to be passed through $db->timestamp(). Bug: T75174 C

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Database: Fix degenerate parenthesized joins

2017-11-29 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394140 ) Change subject: Database: Fix degenerate parenthesized joins .. Database: Fix degenerate parenthesized joins The SQL standard supports paren

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add wfWaitForSlaves() to maintenance/migrateComments.php

2017-11-29 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394121 ) Change subject: Add wfWaitForSlaves() to maintenance/migrateComments.php .. Add wfWaitForSlaves() to maintenance/migrateComments.php Change-

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Drop archive.ar_text and ar_flags

2017-11-28 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393929 ) Change subject: Drop archive.ar_text and ar_flags .. Drop archive.ar_text and ar_flags This should have been done long ago. Now it is being

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Migrate ar_text to modern storage

2017-11-28 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393928 ) Change subject: Migrate ar_text to modern storage .. Migrate ar_text to modern storage This really should have been done a very long time ag

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DNM

2017-11-28 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393790 ) Change subject: DNM .. DNM Testing something. Change-Id: Ib112f5ec43a23caf6b77d3d11665f77384e9890b --- M tests/phpunit/includes/api/ApiMain

[MediaWiki-commits] [Gerrit] mediawiki...TemplateStyles[master]: Deduplicate embedded style rules

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393285 ) Change subject: Deduplicate embedded style rules .. Deduplicate embedded style rules Use the facility added in core change I055abdf4d to ded

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ParserOutput: Add 'deduplicateStyles' post-cache transformation

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393284 ) Change subject: ParserOutput: Add 'deduplicateStyles' post-cache transformation .. ParserOutput: Add 'deduplicateStyles' post-cache transform

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: ApiMobileView: Disable 'deduplicateStyles' ParserOutput::get...

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393283 ) Change subject: ApiMobileView: Disable 'deduplicateStyles' ParserOutput::getText() transformation .. ApiMobileView: Disable 'deduplicateStyl

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Don't repeat the default in test setup

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393281 ) Change subject: Don't repeat the default in test setup .. Don't repeat the default in test setup For a new ParserOptions object, ->setEditSe

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393278 ) Change subject: Use ParserOutput stateless transforms when available .. Use ParserOutput stateless transforms when available See MediaWiki c

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Handle ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393276 ) Change subject: Handle ParserOutput stateless transforms .. Handle ParserOutput stateless transforms See MediaWiki core changes Ied5fe1a61 a

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393271 ) Change subject: Use ParserOutput stateless transforms when available .. Use ParserOutput stateless transforms when available See MediaWiki c

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393270 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Change-Id: I28b46cf4da66cc6e1f04045939a243faa

[MediaWiki-commits] [Gerrit] mediawiki...FeaturedFeeds[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393266 ) Change subject: Use ParserOutput stateless transforms when available .. Use ParserOutput stateless transforms when available See MediaWiki c

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393265 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms See MediaWiki core change Ied5fe1a61. There's

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393273 ) Change subject: Use ParserOutput stateless transforms when available .. Use ParserOutput stateless transforms when available See MediaWiki c

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393274 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms For IndexContent, we just include __NOEDITSEC

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ParserOutput: Add stateless transforms to getText()

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393260 ) Change subject: ParserOutput: Add stateless transforms to getText() .. ParserOutput: Add stateless transforms to getText() The stateful tran

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393272 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms See MediaWiki core change Ied5fe1a61. There's

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: Don't use ParserOutput::setTOCEnabled() to try to hide the toc

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393280 ) Change subject: Don't use ParserOutput::setTOCEnabled() to try to hide the toc .. Don't use ParserOutput::setTOCEnabled() to try to hide the

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393268 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Change-Id: Ia54a9e3d11c9ab28975947148d0841819

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393277 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Depends-On: I78b62ec33fcb8273acb9b3b4e9012215

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use ParserOutputPostCacheTransform hook to avoid splitting c...

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393279 ) Change subject: Use ParserOutputPostCacheTransform hook to avoid splitting cache on 'editsection' .. Use ParserOutputPostCacheTransform hook

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393275 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Change-Id: Id6ad08a0b1f8575e7ee98916217a84c09

[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393269 ) Change subject: Use ParserOutput stateless transforms when available .. Use ParserOutput stateless transforms when available See MediaWiki c

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393267 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Change-Id: I404f064b93573e80b61a228e3cf2b5d2a

[MediaWiki-commits] [Gerrit] mediawiki...CiteThisPage[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393264 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms Depends-On: I78b62ec33fcb8273acb9b3b4e9012215

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Hard-deprecate ParserOutput stateful transform methods

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393263 ) Change subject: Hard-deprecate ParserOutput stateful transform methods .. Hard-deprecate ParserOutput stateful transform methods This also r

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Warn if stateful ParserOutput transforms are used

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393262 ) Change subject: Warn if stateful ParserOutput transforms are used .. Warn if stateful ParserOutput transforms are used This should help clea

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use ParserOutput stateless transforms

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393261 ) Change subject: Use ParserOutput stateless transforms .. Use ParserOutput stateless transforms We still set the state in many cases for bene

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Remove use of OutputPage::parserOptions() as a setter

2017-11-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392905 ) Change subject: Remove use of OutputPage::parserOptions() as a setter .. Remove use of OutputPage::parserOptions() as a setter It's only bei

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Deprecate OutputPage::parserOptions() as a setter

2017-11-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392903 ) Change subject: Deprecate OutputPage::parserOptions() as a setter .. Deprecate OutputPage::parserOptions() as a setter The only known caller

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: Remove use of OutputPage::parserOptions() as a setter

2017-11-22 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392904 ) Change subject: Remove use of OutputPage::parserOptions() as a setter .. Remove use of OutputPage::parserOptions() as a setter It's only bei

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "[MCR] Readd various field & cond method tests for Re...

2017-11-19 Thread Anomie (Code Review)
Hello Daniel Kinzler, Addshore, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/392362 to review the following change. Change subject: Revert "[MCR] Readd various field & cond method tests for Revision" ..

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix FlaggedRevision query

2017-11-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392088 ) Change subject: Fix FlaggedRevision query .. Fix FlaggedRevision query It was missing needed join conditions. Change-Id: I45b8c05b6564891c0

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set wgCommentTableSchemaMigrationStage = MIGRATION_WRITE_BOT...

2017-11-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392082 ) Change subject: Set wgCommentTableSchemaMigrationStage = MIGRATION_WRITE_BOTH on Beta Cluster .. Set wgCommentTableSchemaMigrationStage = MI

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Set blocker in unit tests

2017-11-16 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391907 ) Change subject: Set blocker in unit tests .. Set blocker in unit tests MediaWiki core is going to start rejecting blocks without a valid blo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clean up RELEASE-NOTES-1.31

2017-11-15 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391583 ) Change subject: Clean up RELEASE-NOTES-1.31 .. Clean up RELEASE-NOTES-1.31 A few recent changes introduced entries with bad spacing, and the

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: PostgreSQL: Use correct PK name so patch-site_stats-pk.sql i...

2017-11-14 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391261 ) Change subject: PostgreSQL: Use correct PK name so patch-site_stats-pk.sql isn't run when not needed .. PostgreSQL: Use correct PK name so p

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Put page_is_new back into ContribsPager query

2017-11-01 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387794 ) Change subject: Put page_is_new back into ContribsPager query .. Put page_is_new back into ContribsPager query Accidentally removed in Idcfd

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Remove back-compat code paths

2017-10-31 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387566 ) Change subject: Remove back-compat code paths .. Remove back-compat code paths Per T178092, AbuseFilter now maintains compatibility with old

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove Article static methods deprecated in 1.24

2017-10-26 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386639 ) Change subject: Remove Article static methods deprecated in 1.24 .. Remove Article static methods deprecated in 1.24 The Article::selectFiel

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Update for core interwiki user handling change

2017-10-26 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386626 ) Change subject: Update for core interwiki user handling change .. Update for core interwiki user handling change MediaWiki core change I5401

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set $wgCentralAuthGlobalBlockInterwikiPrefix

2017-10-26 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386627 ) Change subject: Set $wgCentralAuthGlobalBlockInterwikiPrefix .. Set $wgCentralAuthGlobalBlockInterwikiPrefix See Ieae5d24f9. There's no harm

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid DB rows with usable names but ID = 0 by introducing "i...

2017-10-26 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386625 ) Change subject: Avoid DB rows with usable names but ID = 0 by introducing "interwiki" usernames .. Avoid DB rows with usable names but ID =

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: LocalFile: Fix copy-paste error

2017-10-23 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386005 ) Change subject: LocalFile: Fix copy-paste error .. LocalFile: Fix copy-paste error No idea how that got through. Change-Id: Ic7eebe62443400

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Have CommentStore limit the maximum character length of comm...

2017-10-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384725 ) Change subject: Have CommentStore limit the maximum character length of comments .. Have CommentStore limit the maximum character length of c

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Fix PostgreSQL patch-add-3d.sql by replacing it

2017-10-17 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384724 ) Change subject: Fix PostgreSQL patch-add-3d.sql by replacing it .. Fix PostgreSQL patch-add-3d.sql by replacing it Follows-up 6260545fee, a2

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Database: Support parenthesized JOINs

2017-10-13 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384092 ) Change subject: Database: Support parenthesized JOINs .. Database: Support parenthesized JOINs SQL supports parentheses for grouping in the

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383919 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383923 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383924 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383925 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383927 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add deprecation notices for selectFields() methods deprecate...

2017-10-12 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383930 ) Change subject: Add deprecation notices for selectFields() methods deprecated in Idcfd1556 .. Add deprecation notices for selectFields() met

[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383920 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383929 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383928 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Update for deprecation of selectFields() methods

2017-10-12 Thread Anomie (Code Review)
Hello Daniel Kinzler, Tim Starling, Legoktm, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/383926 to review the following change. Change subject: Update for deprecation of selectFields() methods ..

  1   2   3   4   5   6   7   8   9   10   >