[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Admin UI campaign editor: Isolate and selectively load js/css

2017-04-06 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/346034 ) Change subject: Admin UI campaign editor: Isolate and selectively load js/css .. Admin UI campaign editor: Isolate and

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Admin UI: Consolidate common css

2017-04-06 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/346033 ) Change subject: Admin UI: Consolidate common css .. Admin UI: Consolidate common css Bug: T144453 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...process-control[master]: Comments from thcipriani

2017-03-17 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343389 ) Change subject: Comments from thcipriani .. Comments from thcipriani Releng writes a lot of python Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: process payment before popping out of iframe

2017-02-17 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338410 ) Change subject: process payment before popping out of iframe .. process payment before popping out of iframe Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: WIP deprecate globalcollect resultswitcher

2017-01-04 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330635 ) Change subject: WIP deprecate globalcollect resultswitcher .. WIP deprecate globalcollect resultswitcher just comments so far

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Pull composer changes from deployment

2017-01-03 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330310 ) Change subject: Pull composer changes from deployment .. Pull composer changes from deployment Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Revert "Update PHPmailer for CVE-2016-10045 and CVE-2016-10033"

2017-01-03 Thread Cdentinger (Code Review)
Hello jenkins-bot, Ejegg, Eileen, Awight, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/330253 to review the following change. Change subject: Revert "Update PHPmailer for CVE-2016-10045 and CVE-2016-10033"

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: update DonationInterface submodule

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329536 ) Change subject: update DonationInterface submodule .. update DonationInterface submodule Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...vendor[master]: Update phpmailer (and restore smash-pig)

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329534 ) Change subject: Update phpmailer (and restore smash-pig) .. Update phpmailer (and restore smash-pig) Make smash-pig match

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Update (only) phpmailer

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329527 ) Change subject: Update (only) phpmailer .. Update (only) phpmailer Change-Id: Ibabce5112b3160d25bf192960809e3772bbeaa03 --- M

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Revert "update phpmailer for CVE"

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329526 ) Change subject: Revert "update phpmailer for CVE" .. Revert "update phpmailer for CVE" This reverts commit

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Revert "Update phpmailer for CVE-2016-10045 and CVE-2016-10033"

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329521 ) Change subject: Revert "Update phpmailer for CVE-2016-10045 and CVE-2016-10033" .. Revert "Update phpmailer for CVE-2016-10045 and

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Revert "Update phpmailer for CVE-2016-10045 and CVE-2016-10033"

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329520 ) Change subject: Revert "Update phpmailer for CVE-2016-10045 and CVE-2016-10033" .. Revert "Update phpmailer for CVE-2016-10045 and

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Revert "update phpmailer for CVE"

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329519 ) Change subject: Revert "update phpmailer for CVE" .. Revert "update phpmailer for CVE" This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: update composer.lock

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329517 ) Change subject: update composer.lock .. update composer.lock Change-Id: I1d7aa560d7c501da5e640992921c4cae739ed264 --- M composer.lock 1

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: REVERT "DEPLOYMENT ONLY: Short-circuit everything to disable...

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329515 ) Change subject: REVERT "DEPLOYMENT ONLY: Short-circuit everything to disable listeners, per T154209" .. REVERT "DEPLOYMENT ONLY:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Update phpmailer for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329514 ) Change subject: Update phpmailer for CVE-2016-10045 and CVE-2016-10033 .. Update phpmailer for CVE-2016-10045 and CVE-2016-10033

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: update phpmailer for CVE

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329513 ) Change subject: update phpmailer for CVE .. update phpmailer for CVE Change-Id: I21168da04c03d5a5d8eea29f159e58d4f3374676 --- M

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Revert "update libs"

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329512 ) Change subject: Revert "update libs" .. Revert "update libs" This reverts commit c1ebacd623ce6a6d0b553f92ad978bfeb83132e2. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Update vendor submodule for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329508 ) Change subject: Update vendor submodule for CVE-2016-10045 and CVE-2016-10033 .. Update vendor submodule for CVE-2016-10045 and

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: update libs

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329507 ) Change subject: update libs .. update libs Change-Id: I7a7cd9f2f797511409496d116d34c5b85a094ea1 --- M autoload.php A

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: update libs

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329507 ) Change subject: update libs .. update libs Change-Id: I7a7cd9f2f797511409496d116d34c5b85a094ea1 --- M autoload.php M

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: update phpmailer for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329505 ) Change subject: update phpmailer for CVE-2016-10045 and CVE-2016-10033 .. update phpmailer for CVE-2016-10045 and CVE-2016-10033

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Update phpmailer for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329502 ) Change subject: Update phpmailer for CVE-2016-10045 and CVE-2016-10033 .. Update phpmailer for CVE-2016-10045 and CVE-2016-10033

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Update phpmailer for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329499 ) Change subject: Update phpmailer for CVE-2016-10045 and CVE-2016-10033 .. Update phpmailer for CVE-2016-10045 and CVE-2016-10033

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Ran composer update

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329498 ) Change subject: Ran composer update .. Ran composer update composer.lock has been hacked into oblivion Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Update PHPmailer for CVE-2016-10045 and CVE-2016-10033

2016-12-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329497 ) Change subject: Update PHPmailer for CVE-2016-10045 and CVE-2016-10033 .. Update PHPmailer for CVE-2016-10045 and CVE-2016-10033

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: WIP: Process payment before popping out of iframe

2016-12-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328725 ) Change subject: WIP: Process payment before popping out of iframe .. WIP: Process payment before popping out of iframe I'm sure it's

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Adyen iframe form fields should be white on mobile

2016-12-15 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327661 ) Change subject: Adyen iframe form fields should be white on mobile .. Adyen iframe form fields should be white on mobile Also remove

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Allow force reinstall of node_modules directory

2016-12-12 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326472 ) Change subject: Allow force reinstall of node_modules directory .. Allow force reinstall of node_modules directory Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: reject some address_names

2016-12-06 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/325607 Change subject: reject some address_names .. reject some address_names If someone's business name is set to their name it looks weird in

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: WIP add dash to crm role

2016-12-05 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/325515 Change subject: WIP add dash to crm role .. WIP add dash to crm role Suffering from unrelated vagrant provision error: Error: Could not

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Restrict financial_txn rows

2016-12-02 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/325085 Change subject: Restrict financial_txn rows .. Restrict financial_txn rows Bug: T152238 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update donationinterface submodule

2016-11-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/322968 Change subject: Update donationinterface submodule .. Update donationinterface submodule change max-width queries to max-device-width

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-11-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/322965 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + b4b51c791b853f5ab4693e7094b397b037dded03

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: s/max-device-width/max-width/

2016-11-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/322957 Change subject: s/max-device-width/max-width/ .. s/max-device-width/max-width/ Change-Id: I0ab287490c93babf4001bd1adfb79115a55926c5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-11-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/322949 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 698c7c5653d07fc1d2cefda34d7e5c7af02021ad

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-11-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/322945 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + aa6dc17d340e381a7e1fd9a721df9034c7fffee6

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-16 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/321954 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + a51d4a893c893c8a50ee4e8f719f240e14e29145

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-14 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/321555 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment ++

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Couple more # comments

2016-11-14 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/321553 Change subject: Couple more # comments .. Couple more # comments Change-Id: I45333963e0b09be4116b5814466d96dfeedf2d2d --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-11-14 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/321545 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 1a2a99c6a7e632867dc3ebe8825101e75086470d

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Don't throw exception on IPN verify failure

2016-11-11 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/321016 Change subject: Don't throw exception on IPN verify failure .. Don't throw exception on IPN verify failure It's being super annoying with

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-11-10 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320815 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + d51584fd473e1f15f90aaf51348fdeeed0cb8148

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: update DI submodule

2016-11-10 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320816 Change subject: update DI submodule .. update DI submodule Change-Id: I0db77fdcc6ec8afcfd4454fdf6ec2aabf59ec6be --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: only add @ to dates if is_numeric

2016-11-09 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320719 Change subject: only add @ to dates if is_numeric .. only add @ to dates if is_numeric Bug: T147603 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: auto focus fname field

2016-11-09 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320717 Change subject: auto focus fname field .. auto focus fname field Bug: T149803 Change-Id: Iff2f72337b17d0c6b4e8c4053351a678151cac62 --- M

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Add civicrm logging db

2016-11-08 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320438 Change subject: Add civicrm logging db .. Add civicrm logging db Change-Id: I00de7e21c9cc7844508f07bade2576789ea3652a --- M

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: s/Unresctricted/Unrestricted/

2016-11-07 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/320327 Change subject: s/Unresctricted/Unrestricted/ .. s/Unresctricted/Unrestricted/ Change-Id: I25462dcb6111c0a0cb101b6e2fd9a36c306de3c6 --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: don't error on missing type

2016-10-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/318319 Change subject: don't error on missing type .. don't error on missing type had one of these come in, looks like a refund to me

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-10-26 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/318127 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 46e1b62577f6e0ee457f505f2c1e0f4e35651b09

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Increase paypal log mail to 8192 bytes

2016-10-26 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/318125 Change subject: Increase paypal log mail to 8192 bytes .. Increase paypal log mail to 8192 bytes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: add fredge-db to fundraising config

2016-10-24 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/317569 Change subject: add fredge-db to fundraising config .. add fredge-db to fundraising config Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Don't complain about AtomicReadBuffer

2016-10-21 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/317194 Change subject: Don't complain about AtomicReadBuffer .. Don't complain about AtomicReadBuffer Predis isn't one. Unless it is in a later

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: API validate messages on front-end

2016-10-19 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/316842 Change subject: API validate messages on front-end .. API validate messages on front-end The consumer is very slow because of all these

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: adds 'rejects' to smashpig paypal config

2016-10-19 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/316822 Change subject: adds 'rejects' to smashpig paypal config .. adds 'rejects' to smashpig paypal config conditions which if they are true we

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add test for retry exception

2016-10-13 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/315897 Change subject: Add test for retry exception .. Add test for retry exception Change-Id: I37f6426ec46c7885e68acfc93e2e442ebef8e793 --- A

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-10-13 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/315678 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment Fix subscr_cancel error Deleted tests

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix subscr_cancel error

2016-10-12 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/315613 Change subject: Fix subscr_cancel error .. Fix subscr_cancel error Also fix the way the test loops over the different transactions. It's

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Some logging in PP listener

2016-10-11 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/315336 Change subject: Some logging in PP listener .. Some logging in PP listener Change-Id: I0f8780c254c8184a486566aa983c2d40a110703d --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: stop mirroring verified

2016-10-05 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/314326 Change subject: stop mirroring verified .. stop mirroring verified SourceFields expects messages to be an array so we'll have to change

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-10-01 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 2ee864f0a5d3c93d7cc81e3980340ec1e85dbf22 s/gross/currency/ Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-10-01 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313681 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 2ee864f0a5d3c93d7cc81e3980340ec1e85dbf22

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: s/gross/currency/

2016-10-01 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313678 Change subject: s/gross/currency/ .. s/gross/currency/ Change-Id: I7e56e2af9e755182812d401ac9d7c954c4ebd924 --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Remove Configuration::setDefaultConfig()

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313551 Change subject: Remove Configuration::setDefaultConfig() .. Remove Configuration::setDefaultConfig() This seems like a tiny reduction in

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 09ebe0a7c04c1093348517516fb11b1b79a7747f Revert "Don't escape unicode

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313439 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + 09ebe0a7c04c1093348517516fb11b1b79a7747f

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: REVERT fb4b4427cdc67a656408b8f947bbbefb7396fe25

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313435 Change subject: REVERT fb4b4427cdc67a656408b8f947bbbefb7396fe25 .. REVERT fb4b4427cdc67a656408b8f947bbbefb7396fe25 JSON_UNESCAPED_UNICODE

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into 'deployment'

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. Change subject: Merge branch 'master' into 'deployment' .. Merge branch 'master' into 'deployment' + fef9bcd8321ddbf7b82bd7fc8aa5a01423c33957 Put an ampersand on it,

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into 'deployment'

2016-09-29 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313427 Change subject: Merge branch 'master' into 'deployment' .. Merge branch 'master' into 'deployment' +

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-28 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + fb4b4427cdc67a656408b8f947bbbefb7396fe25 Don't escape unicode while

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-28 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313342 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + fb4b4427cdc67a656408b8f947bbbefb7396fe25

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Explicitly create test tables in sqlite

2016-09-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313127 Change subject: Explicitly create test tables in sqlite .. Explicitly create test tables in sqlite Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: update php-queue to 7834573f5dc2ab8935684259661b4a1fa83978cf

2016-09-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313124 Change subject: update php-queue to 7834573f5dc2ab8935684259661b4a1fa83978cf .. update php-queue to

[MediaWiki-commits] [Gerrit] wikimedia...php-queue[master]: Return null from php-queue\PDO() when missing table

2016-09-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313059 Change subject: Return null from php-queue\PDO() when missing table .. Return null from php-queue\PDO() when missing table Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Return null from php-queue\PDO() when missing table

2016-09-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313053 Change subject: Return null from php-queue\PDO() when missing table .. Return null from php-queue\PDO() when missing table Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Remove 'p' from the request after routing

2016-09-27 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/313046 Change subject: Remove 'p' from the request after routing .. Remove 'p' from the request after routing This is added by the web server on

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Just respond 200 to GET requests

2016-09-26 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/312941 Change subject: Just respond 200 to GET requests .. Just respond 200 to GET requests The app monitor software is spamming redis

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix undefined date warning

2016-09-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/312311 Change subject: Fix undefined date warning .. Fix undefined date warning Change-Id: Id85458d4dd4936189745bddf6d01a88af2950e00 --- M

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add some sparse logging to PayPal listener.

2016-09-22 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/312273 Change subject: Add some sparse logging to PayPal listener. .. Add some sparse logging to PayPal listener. Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add recurring PayPal test

2016-09-21 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/312175 Change subject: Add recurring PayPal test .. Add recurring PayPal test Also fix a notice about date not being set. And use a foreach loop

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-21 Thread Cdentinger (Code Review)
Cdentinger has submitted this change and it was merged. Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + eb9ac8a38fe6db251c120f7a6d3504e408adde93 Tweak normalized field names +

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[deployment]: Merge branch 'master' into deployment

2016-09-21 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/312118 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + eb9ac8a38fe6db251c120f7a6d3504e408adde93

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Return true from job()

2016-09-20 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/311910 Change subject: Return true from job() .. Return true from job() The listener script expects it Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Make PayPal tests get queues directly from config

2016-09-20 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/311893 Change subject: Make PayPal tests get queues directly from config .. Make PayPal tests get queues directly from config Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Use config for test queue instantiation

2016-09-20 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/311892 Change subject: Use config for test queue instantiation .. Use config for test queue instantiation Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Test PayPal verified message transform

2016-09-20 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/311874 Change subject: Test PayPal verified message transform .. Test PayPal verified message transform This will probably need to change

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Test failure path

2016-09-15 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/310942 Change subject: Test failure path .. Test failure path Pulls a few things into helper functions that can get overridden Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Get rid of $pathParts

2016-08-24 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/306605 Change subject: Get rid of $pathParts .. Get rid of $pathParts Am I crazy or is this not used for anything? Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP working on paypal listener, 1st test passes

2016-08-19 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/305761 Change subject: WIP working on paypal listener, 1st test passes .. WIP working on paypal listener, 1st test passes doesn't actually have

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP smashpig paypal listener

2016-08-16 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/305172 Change subject: WIP smashpig paypal listener .. WIP smashpig paypal listener just getting the hang of it need to learn how to test this

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Replace question with answer.

2016-08-10 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/304057 Change subject: Replace question with answer. .. Replace question with answer. Change-Id: Ic026b334bcdab2d97133cf939bb83b276b678e06 --- M

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Add ActiveMQ headers to Redis messages

2016-08-08 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/303699 Change subject: Add ActiveMQ headers to Redis messages .. Add ActiveMQ headers to Redis messages Bug: T141948 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[fundraising/REL1_27]: Update DonationInterface submodule.

2016-08-04 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/302959 Change subject: Update DonationInterface submodule. .. Update DonationInterface submodule. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[deployment]: Merge branch 'master' into deployment

2016-08-04 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/302956 Change subject: Merge branch 'master' into deployment .. Merge branch 'master' into deployment + cc54c6b0845048a4e33ac3b22f927e74c9410372

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: List countries for Amex so it stops appearing for ZA

2016-08-04 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/302946 Change subject: List countries for Amex so it stops appearing for ZA .. List countries for Amex so it stops appearing for ZA I think this

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: [WIP] remove queueMessageToNormalized

2016-07-29 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/301865 Change subject: [WIP] remove queueMessageToNormalized .. [WIP] remove queueMessageToNormalized I was hoping some tests would fail when I

[MediaWiki-commits] [Gerrit] use composer-merge-plugin - change (mediawiki/core)

2016-07-21 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/300471 Change subject: use composer-merge-plugin .. use composer-merge-plugin Change-Id: Ie1f13954a899e27ea5828465627b831dc5fb5a8f --- M

[MediaWiki-commits] [Gerrit] WIP: move PendingQueue into a library - change (mediawiki...DonationInterface)

2016-07-21 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/300429 Change subject: WIP: move PendingQueue into a library .. WIP: move PendingQueue into a library Temporarily on my github. I envision

[MediaWiki-commits] [Gerrit] WIP: Write all limbo queues to new pending queue. - change (mediawiki...DonationInterface)

2016-07-19 Thread Cdentinger (Code Review)
Cdentinger has uploaded a new change for review. https://gerrit.wikimedia.org/r/299797 Change subject: WIP: Write all limbo queues to new pending queue. .. WIP: Write all limbo queues to new pending queue. TODO: on/off

  1   2   3   4   >