[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Allow enabling of tls/ssl (keep default of none for ...

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406145 ) Change subject: Gerrit: Allow enabling of tls/ssl (keep default of none for now) .. Gerrit: Allow enabling of tls/ssl (keep default of none

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove hardcoding of the smtp port

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406144 ) Change subject: Gerrit: Remove hardcoding of the smtp port .. Gerrit: Remove hardcoding of the smtp port Gerrit uses sane defaults: 25 if not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Add ldap.connectTimeout

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406143 ) Change subject: Gerrit: Add ldap.connectTimeout .. Gerrit: Add ldap.connectTimeout No timeout is kinda insane. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set groups.newGroupsVisibleToAll = true

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406140 ) Change subject: Gerrit: Set groups.newGroupsVisibleToAll = true .. Gerrit: Set groups.newGroupsVisibleToAll = true Why shouldn't they be? Can

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set gc.aggressive = true

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406139 ) Change subject: Gerrit: Set gc.aggressive = true .. Gerrit: Set gc.aggressive = true We're not re-enabling auto-gc just yet, but I want to so

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set changeCleanup.startTime

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406138 ) Change subject: Gerrit: Set changeCleanup.startTime .. Gerrit: Set changeCleanup.startTime We don't have changeCleanup.abandonChanges set to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Shut up completely useless WARN-level spam from Even...

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406137 ) Change subject: Gerrit: Shut up completely useless WARN-level spam from EventUtil .. Gerrit: Shut up completely useless WARN-level spam from

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove arbitrary SSH thread settings

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406052 ) Change subject: Gerrit: Remove arbitrary SSH thread settings .. Gerrit: Remove arbitrary SSH thread settings They're from a long long time

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Default to HTTPS on basically all links

2018-01-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405379 ) Change subject: Default to HTTPS on basically all links .. Default to HTTPS on basically all links WMF supports them, as does CC. No need for

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Move standard tar ignores to .gitattributes so `git archive`...

2018-01-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405355 ) Change subject: Move standard tar ignores to .gitattributes so `git archive` works .. Move standard tar ignores to .gitattributes so `git

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Move standard tar ignores to .gitattributes so `git archive`...

2018-01-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405354 ) Change subject: Move standard tar ignores to .gitattributes so `git archive` works .. Move standard tar ignores to .gitattributes so `git

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Move standard tar ignores to .gitattributes so `git archive`...

2018-01-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405353 ) Change subject: Move standard tar ignores to .gitattributes so `git archive` works .. Move standard tar ignores to .gitattributes so `git

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: Swap tar/gzip pipe for `git archive`

2018-01-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405347 ) Change subject: releases: Swap tar/gzip pipe for `git archive` .. releases: Swap tar/gzip pipe for `git archive` By using .gitattributes, we

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move standard tar ignores to .gitattributes so `git archive`...

2018-01-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405214 ) Change subject: Move standard tar ignores to .gitattributes so `git archive` works .. Move standard tar ignores to .gitattributes so `git

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-release: Simplify excludes, just drop all .dotfiles

2018-01-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405213 ) Change subject: make-release: Simplify excludes, just drop all .dotfiles .. make-release: Simplify excludes, just drop all .dotfiles

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Fix data payload for REST call, also add .netrc f...

2018-01-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405056 ) Change subject: branch.py: Fix data payload for REST call, also add .netrc fallback .. branch.py: Fix data payload for REST call, also add

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update my dotfiles

2018-01-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405025 ) Change subject: Update my dotfiles .. Update my dotfiles Change-Id: I40e001b48404a16222614a34b0ebc45e6ee1eca9 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: WIP: Sync security patches for MW from deployment to nightli...

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404892 ) Change subject: WIP: Sync security patches for MW from deployment to nightlies server .. WIP: Sync security patches for MW from deployment to

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: makerelease: Simplify a few things

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404883 ) Change subject: makerelease: Simplify a few things .. makerelease: Simplify a few things Change-Id: I778521e93eda8fd4e1df6cb25a4b1c30fc81f207

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: makerelease.py: Simplify file output

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404876 ) Change subject: makerelease.py: Simplify file output .. makerelease.py: Simplify file output Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Make config useful

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404829 ) Change subject: Make config useful .. Make config useful Change-Id: Ia7602043e971401733c688b374e175d33bc84084 --- M make-release/.gitignore M

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Add some docs to shut up pylint

2018-01-17 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404808 ) Change subject: Add some docs to shut up pylint .. Add some docs to shut up pylint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Add some docs to shut up pylint

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404808 ) Change subject: Add some docs to shut up pylint .. Add some docs to shut up pylint Change-Id: I09567fce2aab44feb0c6f1f99a101b0495fd0cb9 --- M

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Fix all kinds of egregious errors

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404807 ) Change subject: branch.py: Fix all kinds of egregious errors .. branch.py: Fix all kinds of egregious errors Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Use pygerrit2 not pygerrit, also env for py3

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404804 ) Change subject: branch.py: Use pygerrit2 not pygerrit, also env for py3 .. branch.py: Use pygerrit2 not pygerrit, also env for py3 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[refs/meta/config]: Allow vendor to subscribe to mediawiki/core

2018-01-17 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404798 ) Change subject: Allow vendor to subscribe to mediawiki/core .. Allow vendor to subscribe to mediawiki/core Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[refs/meta/config]: Allow vendor to subscribe to mediawiki/core

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404798 ) Change subject: Allow vendor to subscribe to mediawiki/core .. Allow vendor to subscribe to mediawiki/core Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Add $wgVersion fixing in DefaultSettings

2018-01-17 Thread Chad (Code Review)
Hello Thcipriani, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/404787 to review the following change. Change subject: branch.py: Add $wgVersion fixing in DefaultSettings .. branch.py:

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP: Create docker image for linting refs/meta/config

2018-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404753 ) Change subject: WIP: Create docker image for linting refs/meta/config .. WIP: Create docker image for linting refs/meta/config Starts with a

[MediaWiki-commits] [Gerrit] at-ease[refs/meta/config]: Allow mediawiki group to push signed tags

2018-01-17 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404745 ) Change subject: Allow mediawiki group to push signed tags .. Allow mediawiki group to push signed tags Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Stop committing weird sub-submodule branching

2018-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404600 ) Change subject: make-wmf-branch: Stop committing weird sub-submodule branching .. make-wmf-branch: Stop committing weird sub-submodule

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Add force to special submodules

2018-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404532 ) Change subject: make-wmf-branch: Add force to special submodules .. make-wmf-branch: Add force to special submodules Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Clone submodules with --depth=1

2018-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404529 ) Change subject: make-wmf-branch: Clone submodules with --depth=1 .. make-wmf-branch: Clone submodules with --depth=1 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Simplify/speed up clean plugin submodule handling

2018-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404527 ) Change subject: Simplify/speed up clean plugin submodule handling .. Simplify/speed up clean plugin submodule handling Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Follow-up and provide full path for CN

2018-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404520 ) Change subject: make-wmf-branch: Follow-up and provide full path for CN .. make-wmf-branch: Follow-up and provide full path for CN Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove --list-bundled option, pointless

2018-01-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404052 ) Change subject: Remove --list-bundled option, pointless .. Remove --list-bundled option, pointless Made sense before we put them as

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove pointless have_i18n variable, add some missing docstr...

2018-01-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404050 ) Change subject: Remove pointless have_i18n variable, add some missing docstrings .. Remove pointless have_i18n variable, add some missing

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: makerelease: Fix up return on all code paths, pylint complains

2018-01-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404044 ) Change subject: makerelease: Fix up return on all code paths, pylint complains .. makerelease: Fix up return on all code paths, pylint

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: make patch_dir configurable (and only configurable)

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403563 to review the following change. Change subject: releases: make patch_dir configurable (and only configurable) ..

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: release: Remove upload tar, dubiously useful

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403561 to review the following change. Change subject: release: Remove upload tar, dubiously useful .. release: Remove upload

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: Unify root_dir/build_dir

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403564 to review the following change. Change subject: releases: Unify root_dir/build_dir .. releases: Unify root_dir/build_dir

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: release: patchfile refactoring

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403562 to review the following change. Change subject: release: patchfile refactoring .. release: patchfile refactoring Adopt

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: use os.path.join() in a few places

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403565 to review the following change. Change subject: releases: use os.path.join() in a few places .. releases: use

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: release: move get_git() to function, fix up export_dir

2018-01-10 Thread Chad (Code Review)
Hello Reedy, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/403566 to review the following change. Change subject: release: move get_git() to function, fix up export_dir .. release: move

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: grumble grumble submodules

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403220 ) Change subject: grumble grumble submodules .. grumble grumble submodules Change-Id: I39d2a9196722bf468c574e388a5321a25e923616 --- M

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Cleanup/prep for sub-submodule support

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403219 ) Change subject: branch.py: Cleanup/prep for sub-submodule support .. branch.py: Cleanup/prep for sub-submodule support Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: deployment-prep: Commit hiera config for etcd

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403205 ) Change subject: deployment-prep: Commit hiera config for etcd .. deployment-prep: Commit hiera config for etcd Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: First half of sub-submodule support

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403173 ) Change subject: branch.py: First half of sub-submodule support .. branch.py: First half of sub-submodule support Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: basically make-wmf-branch now

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403165 ) Change subject: branch.py: basically make-wmf-branch now .. branch.py: basically make-wmf-branch now The only thing it doesn't do is that

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Simplify

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403162 ) Change subject: branch.py: Simplify .. branch.py: Simplify Also start work on the "add submodules and futz with DefaultSettings" bit See

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Fix branch.py

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403155 ) Change subject: Fix branch.py .. Fix branch.py - Support bundles other than base - Protect core branching with a flag - Require explicit

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: server path code duplication

2018-01-09 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403142 ) Change subject: releases: server path code duplication .. releases: server path code duplication Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Remove patching support

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403154 ) Change subject: make-wmf-branch: Remove patching support .. make-wmf-branch: Remove patching support Patching is a post-branching activity.

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Combine skins/vendor to extension logic

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403148 ) Change subject: make-wmf-branch: Combine skins/vendor to extension logic .. make-wmf-branch: Combine skins/vendor to extension logic Same

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: releases: server path code duplication

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403142 ) Change subject: releases: server path code duplication .. releases: server path code duplication Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Drop export_ext() as dumb wrapper around patching

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403141 ) Change subject: Drop export_ext() as dumb wrapper around patching .. Drop export_ext() as dumb wrapper around patching Just call patch

[MediaWiki-commits] [Gerrit] operations/puppet[production]: CI: Add php7.0-zip stretch and beyond

2018-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403138 ) Change subject: CI: Add php7.0-zip stretch and beyond .. CI: Add php7.0-zip stretch and beyond We already install it for Jessie, no reason

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move BaseDump into includes/export/

2018-01-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402936 ) Change subject: Move BaseDump into includes/export/ .. Move BaseDump into includes/export/ There's no reason for this to have to live in

[MediaWiki-commits] [Gerrit] mediawiki...ActiveAbstract[master]: Properly register noredirect filter

2018-01-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402911 ) Change subject: Properly register noredirect filter .. Properly register noredirect filter I118b92dd, Ie4b10659 moved classes to their own

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Updating interwiki cache

2018-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402664 ) Change subject: Updating interwiki cache .. Updating interwiki cache Change-Id: Ia06c50cc5fb576f46e393b6578ef09452f69a69a --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: updateinterwikicache: check_valid_syntax was moved to lint

2018-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402663 ) Change subject: updateinterwikicache: check_valid_syntax was moved to lint .. updateinterwikicache: check_valid_syntax was moved to lint

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.15]: Fix Maintenance::output when called very early

2018-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402662 ) Change subject: Fix Maintenance::output when called very early .. Fix Maintenance::output when called very early If a maintenance script is

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases: Include all contint PHP packages

2018-01-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402430 ) Change subject: Releases: Include all contint PHP packages .. Releases: Include all contint PHP packages Right now I'm missing php-mbstring,

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[wmf/1.31.0-wmf.15]: Catch ConstraintParameterException in SparqlHelper

2018-01-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402427 ) Change subject: Catch ConstraintParameterException in SparqlHelper .. Catch ConstraintParameterException in SparqlHelper When an invalid

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Undeploy EducationProgram from test2wiki

2018-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402170 ) Change subject: Undeploy EducationProgram from test2wiki .. Undeploy EducationProgram from test2wiki Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Drop unused docroots

2018-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402091 ) Change subject: Drop unused docroots .. Drop unused docroots Bug: T126306 Depends-On: I88989e5a4dc4d1cafd7ec5757e2b2ca3c90fe2b4 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Moving all docroots to standard-docroot

2018-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402090 ) Change subject: Moving all docroots to standard-docroot .. Moving all docroots to standard-docroot Now that we've unified all the docroots,

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Add hooks plugin @ 2.13.9

2018-01-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401697 ) Change subject: Add hooks plugin @ 2.13.9 .. Add hooks plugin @ 2.13.9 Bug: T183792 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ActiveAbstract[wmf/1.31.0-wmf.15]: Revert "Simplify use of --plugin argument of BackupDumper"

2018-01-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/402063 ) Change subject: Revert "Simplify use of --plugin argument of BackupDumper" .. Revert "Simplify use of --plugin argument of

[MediaWiki-commits] [Gerrit] mediawiki...ActiveAbstract[wmf/1.31.0-wmf.15]: Revert "Move classes to own files"

2018-01-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/402062 ) Change subject: Revert "Move classes to own files" .. Revert "Move classes to own files" This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...ActiveAbstract[wmf/1.31.0-wmf.15]: Revert "Simplify use of --plugin argument of BackupDumper"

2018-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402063 ) Change subject: Revert "Simplify use of --plugin argument of BackupDumper" .. Revert "Simplify use of --plugin argument of BackupDumper" This

[MediaWiki-commits] [Gerrit] mediawiki...ActiveAbstract[wmf/1.31.0-wmf.15]: Revert "Move classes to own files"

2018-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402062 ) Change subject: Revert "Move classes to own files" .. Revert "Move classes to own files" This reverts commit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases: Install composer alongside Jenkins

2018-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401804 ) Change subject: Releases: Install composer alongside Jenkins .. Releases: Install composer alongside Jenkins Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Group1 to wmf.15

2018-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401763 ) Change subject: Group1 to wmf.15 .. Group1 to wmf.15 Change-Id: Iddfbf3d66eb033243921d26e9efcc39e126d7de5 --- M php M wikiversions.json 2

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[wmf/1.31.0-wmf.15]: Revert "Do not collapse references on diffs/old revisions"

2018-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401753 ) Change subject: Revert "Do not collapse references on diffs/old revisions" .. Revert "Do not collapse references on diffs/old revisions" This

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Add hooks plugin @ 2.13.9

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401697 ) Change subject: Add hooks plugin @ 2.13.9 .. Add hooks plugin @ 2.13.9 Bug: T183792 Change-Id: I04e249756eca097d931fdba716ebc0977a86a4b0 ---

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: branch.py: Assume python3

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401676 ) Change subject: branch.py: Assume python3 .. branch.py: Assume python3 Change-Id: I496015c676d5ebe06b7b878aa364ca6f266de3f3 --- M

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove unused shell scripts

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401660 ) Change subject: Remove unused shell scripts .. Remove unused shell scripts - runtests.sh isn't useful anymore since we migrated to py.test -

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP: Add bundled extensions as submodules of core

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401659 ) Change subject: WIP: Add bundled extensions as submodules of core .. WIP: Add bundled extensions as submodules of core Couple of reasons: -

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Migrate to pytest, remove some junk old tests

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401630 ) Change subject: Migrate to pytest, remove some junk old tests .. Migrate to pytest, remove some junk old tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove pre-SemVer support

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401623 ) Change subject: Remove pre-SemVer support .. Remove pre-SemVer support Change-Id: I30aaad71633436e637ba953407ff49c679efeeda --- M

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Do composer update after cloning

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401624 ) Change subject: Do composer update after cloning .. Do composer update after cloning Change-Id: I4d9567d12874b47eeeacacec470812a85b740579 ---

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Better grouping for can't-figure-out-what-caused-match error

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401613 ) Change subject: Better grouping for can't-figure-out-what-caused-match error .. Better grouping for can't-figure-out-what-caused-match error

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove support for mediawiki < 1.27

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401577 ) Change subject: Remove support for mediawiki < 1.27 .. Remove support for mediawiki < 1.27 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Stop branching vendor

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401574 ) Change subject: Stop branching vendor .. Stop branching vendor Bug: T172927 Change-Id: I879a9d5578e036f42238f3c587b5b434e6abcffa --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: group0 to wmf.15

2018-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401559 ) Change subject: group0 to wmf.15 .. group0 to wmf.15 Change-Id: I3b949d27e6adf522f1f46777ab3e1187818f7b86 --- M wikiversions.json 1 file

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove trailing slash, $prefix already does that

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399892 ) Change subject: Remove trailing slash, $prefix already does that .. Remove trailing slash, $prefix already does that Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-release: Actually make snapshot names sensible

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399889 ) Change subject: make-release: Actually make snapshot names sensible .. make-release: Actually make snapshot names sensible Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SemanticPageSeries[master]: Remove unused $wgCommandLineMode

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399859 ) Change subject: Remove unused $wgCommandLineMode .. Remove unused $wgCommandLineMode Change-Id: Ie304644ea790d3d8437b0c4ba8be01ca44d278ea ---

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Drop vendor from MW release branch

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399852 ) Change subject: Drop vendor from MW release branch .. Drop vendor from MW release branch Bug:T172927 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Drop vendor from MW release branch

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399849 ) Change subject: Drop vendor from MW release branch .. Drop vendor from MW release branch Bug:T172927 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Don't pin a specific python3 version in tox

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399846 ) Change subject: Don't pin a specific python3 version in tox .. Don't pin a specific python3 version in tox Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove emacs file from make-release. We don't commit editor ...

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399845 ) Change subject: Remove emacs file from make-release. We don't commit editor files .. Remove emacs file from make-release. We don't commit

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Scap clean: simplify logic and actually delete thigns again

2017-12-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399814 ) Change subject: Scap clean: simplify logic and actually delete thigns again .. Scap clean: simplify logic and actually delete thigns again

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-release: Pylint basically everything

2017-12-20 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399550 ) Change subject: make-release: Pylint basically everything .. make-release: Pylint basically everything Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit replication: don't bother trying to create repos on g...

2017-12-20 Thread Chad (Code Review)
Hello Hashar, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/399533 to review the following change. Change subject: gerrit replication: don't bother trying to create repos on github ..

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove MoodBar from multiversion/submodules.json

2017-12-20 Thread Chad (Code Review)
Chad has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396475 ) Change subject: Remove MoodBar from multiversion/submodules.json .. Remove MoodBar from multiversion/submodules.json See T131340

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Nightly server: let MW releasers manage Jenkins

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399123 ) Change subject: Nightly server: let MW releasers manage Jenkins .. Nightly server: let MW releasers manage Jenkins Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: All kinds of pylint and other style fixes

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399117 ) Change subject: All kinds of pylint and other style fixes .. All kinds of pylint and other style fixes Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove unfinished/broken branch plugin

2017-12-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399116 ) Change subject: Remove unfinished/broken branch plugin .. Remove unfinished/broken branch plugin Change-Id:

  1   2   3   4   5   6   7   8   9   10   >