[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skip #default#behaviorName when detecting local files

2017-04-27 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350746 ) Change subject: Skip #default#behaviorName when detecting local files .. Skip #default#behaviorName when detecting local files Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Live Preview: Attach to the DOM before 'wikipage.content'

2017-04-17 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348657 ) Change subject: Live Preview: Attach to the DOM before 'wikipage.content' .. Live Preview: Attach to the DOM before 'wikipage.content'

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Update mapPin-progressive icons with OOjs UI version

2017-04-17 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348646 ) Change subject: Update mapPin-progressive icons with OOjs UI version .. Update mapPin-progressive icons with OOjs UI version Bug: T152573

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Clean up backward compatibility code that is no longer needed

2017-04-17 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348643 ) Change subject: Clean up backward compatibility code that is no longer needed .. Clean up backward compatibility code that is no longer

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Disable VE when features are not supported

2017-03-28 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345272 ) Change subject: Disable VE when features are not supported .. Disable VE when features are not supported TODO: * double click on the item

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Multiply all rem values by 1.6 to scale to 1rem = 10px

2017-03-23 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344558 ) Change subject: Multiply all rem values by 1.6 to scale to 1rem = 10px .. Multiply all rem values by 1.6 to scale to 1rem = 10px Bug:

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Prevents the callback from being called twice

2017-03-21 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344062 ) Change subject: Prevents the callback from being called twice .. Prevents the callback from being called twice Bug: T161061 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Add dir attribute to each language in the top10 section

2017-03-16 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343214 ) Change subject: Add dir attribute to each language in the top10 section .. Add dir attribute to each language in the top10 section

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Replace diversity of sizes with predictable rem-based sizes

2017-03-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342976 ) Change subject: Replace diversity of sizes with predictable rem-based sizes .. Replace diversity of sizes with predictable rem-based sizes

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Replace colors with corresponding CSS variables

2017-03-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342296 ) Change subject: Replace colors with corresponding CSS variables .. Replace colors with corresponding CSS variables * The highlighted

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Remove pieces of CSS not used on wikipedia.org

2017-03-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342289 ) Change subject: Remove pieces of CSS not used on wikipedia.org .. Remove pieces of CSS not used on wikipedia.org Bug: T160222 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Re-arrange CSS, clean up when required, add FIXMEs

2017-03-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342286 ) Change subject: Re-arrange CSS, clean up when required, add FIXMEs .. Re-arrange CSS, clean up when required, add FIXMEs This is a first

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Remove code that translates the slogan and use jsl10n

2017-03-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341932 ) Change subject: Remove code that translates the slogan and use jsl10n .. Remove code that translates the slogan and use jsl10n Since we

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Refactor getPropFromPath

2017-03-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341934 ) Change subject: Refactor getPropFromPath .. Refactor getPropFromPath Change-Id: Ida40f07a691c5fc6e05ead2d3488c7046dba681a --- M

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Fix typo in code

2017-03-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341933 ) Change subject: Fix typo in code .. Fix typo in code Thankfully this seems to be fixed during minification? Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Fix "lang" attribute incorrectly set

2017-03-07 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341728 ) Change subject: Fix "lang" attribute incorrectly set .. Fix "lang" attribute incorrectly set Bug: T154349 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Remove href attribute (non-js fallback) once the map is inte...

2017-02-24 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339789 ) Change subject: Remove href attribute (non-js fallback) once the map is interactive .. Remove href attribute (non-js fallback) once the

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: Upgrade stylelint-config-wikimedia to v0.4.1

2017-02-22 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339243 ) Change subject: Upgrade stylelint-config-wikimedia to v0.4.1 .. Upgrade stylelint-config-wikimedia to v0.4.1 Bug: T158797 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix Y offset not being applied correctly

2017-02-17 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338399 ) Change subject: Fix Y offset not being applied correctly .. Fix Y offset not being applied correctly Bug: T158438 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Open the sidebar "More details" by default at high resolutions

2017-02-16 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338305 ) Change subject: Open the sidebar "More details" by default at high resolutions .. Open the sidebar "More details" by default at high

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Bump wikimedia-mapdata lib to v4.0.0

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336938 ) Change subject: Bump wikimedia-mapdata lib to v4.0.0 .. Bump wikimedia-mapdata lib to v4.0.0 * Adds geomask attributions * Adds commons

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fall back to Special:Map page when js is disabled

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336937 ) Change subject: Fall back to Special:Map page when js is disabled .. Fall back to Special:Map page when js is disabled Bug: T157748

[MediaWiki-commits] [Gerrit] mapdata[master]: Parse attributions for geomask groups

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336930 ) Change subject: Parse attributions for geomask groups .. Parse attributions for geomask groups * Also fixes broken group name in

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add a collapse button next to the close button

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336921 ) Change subject: Add a collapse button next to the close button .. Add a collapse button next to the close button * Makes the "close"

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Map attributions should be visible when sidebar is open

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336912 ) Change subject: Map attributions should be visible when sidebar is open .. Map attributions should be visible when sidebar is open Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Make attributions more visible on static snapshot

2017-02-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336905 ) Change subject: Make attributions more visible on static snapshot .. Make attributions more visible on static snapshot * And fix

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Red links must appear in red

2017-01-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331508 ) Change subject: Red links must appear in red .. Red links must appear in red Bug: T154918 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add static name property to map dialog window

2017-01-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331395 ) Change subject: Add static name property to map dialog window .. Add static name property to map dialog window Bug: T154716 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Upgrade mapdata lib to add Commons attributions

2017-01-04 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330429 ) Change subject: Upgrade mapdata lib to add Commons attributions .. Upgrade mapdata lib to add Commons attributions Bug: T154582

[MediaWiki-commits] [Gerrit] mapdata[master]: Add attributions for Commons external data

2017-01-04 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330427 ) Change subject: Add attributions for Commons external data .. Add attributions for Commons external data Bug: T154582 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Upgrade mapdata lib to fix a bug on rowiki

2017-01-03 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330320 ) Change subject: Upgrade mapdata lib to fix a bug on rowiki .. Upgrade mapdata lib to fix a bug on rowiki Bug: T154117 Change-Id:

[MediaWiki-commits] [Gerrit] mapdata[master]: Fix the for...in loop that should be a for loop

2017-01-03 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330316 ) Change subject: Fix the for...in loop that should be a for loop .. Fix the for...in loop that should be a for loop Bug: T154117

[MediaWiki-commits] [Gerrit] mediawiki...Graph[master]: Add a softer transition to the white overlay

2017-01-03 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330246 ) Change subject: Add a softer transition to the white overlay .. Add a softer transition to the white overlay Bug: T154366 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Revert "Remove /* @noflip */ Leaflet's CSS fixes"

2017-01-03 Thread JGirault (Code Review)
Hello Divadsn, Aklapper, MaxSem, jenkins-bot, Yurik, Samtar, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/330220 to review the following change. Change subject: Revert "Remove /* @noflip */ Leaflet's CSS fixes"

[MediaWiki-commits] [Gerrit] mediawiki...JsonConfig[master]: Improve tabular data styling and bring consistency with M82

2016-12-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327671 ) Change subject: Improve tabular data styling and bring consistency with M82 .. Improve tabular data styling and bring consistency with M82

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Update attribution text and add it to static frames

2016-12-13 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327015 ) Change subject: Update attribution text and add it to static frames .. Update attribution text and add it to static frames Bug: T151906

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix fullscreen map not closing properly

2016-12-13 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327012 ) Change subject: Fix fullscreen map not closing properly .. Fix fullscreen map not closing properly Bug: T153100 Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia/portals[master]: build: Replace jshint+jscs with eslint

2016-12-06 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/325727 Change subject: build: Replace jshint+jscs with eslint .. build: Replace jshint+jscs with eslint Bug: T152579 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Log whether the event is the first interaction with the map

2016-12-06 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/325599 Change subject: Log whether the event is the first interaction with the map .. Log whether the event is the first interaction with the map

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Increase user sampling rate from 1% yo 10%

2016-12-05 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/325362 Change subject: Increase user sampling rate from 1% yo 10% .. Increase user sampling rate from 1% yo 10% Bug: T152174 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix closing map by going back sometimes not working

2016-12-01 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/324849 Change subject: Fix closing map by going back sometimes not working .. Fix closing map by going back sometimes not working Bug: T151915

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Fix the event sampling being overriden by other events

2016-12-01 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/324846 Change subject: Fix the event sampling being overriden by other events .. Fix the event sampling being overriden by other events Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Implement third phase of event logging (Wikivoyage specific)

2016-12-01 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/324843 Change subject: Implement third phase of event logging (Wikivoyage specific) .. Implement third phase of event logging (Wikivoyage specific)

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Implement second phase of event logging

2016-11-29 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/324245 Change subject: Implement second phase of event logging .. Implement second phase of event logging Bug: T149834 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Implement second phase of event logging

2016-11-29 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/324244 Change subject: Implement second phase of event logging .. Implement second phase of event logging Bug: T149834 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Maplink icon with a hole of smaller size

2016-11-18 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/322369 Change subject: Maplink icon with a hole of smaller size .. Maplink icon with a hole of smaller size Bug: T150924 Change-Id:

[MediaWiki-commits] [Gerrit] mapdata[master]: Bump eslint-config-wikimedia

2016-11-16 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/321918 Change subject: Bump eslint-config-wikimedia .. Bump eslint-config-wikimedia Change-Id: I96fbbf0858e09a5f3c9d6f4d63c63b3dd3414784 --- M

[MediaWiki-commits] [Gerrit] mapdata[master]: eslint: Re-enable wrap-iife and partially enable dot-notation

2016-11-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/321739 Change subject: eslint: Re-enable wrap-iife and partially enable dot-notation .. eslint: Re-enable wrap-iife and partially enable

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Import wmui-base.less and override leaflet style to match wi...

2016-11-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/320936 Change subject: Import wmui-base.less and override leaflet style to match wikimedia style. .. Import wmui-base.less and override leaflet

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix interactive mapframe not interactive in embed mode

2016-11-10 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/320817 Change subject: Fix interactive mapframe not interactive in embed mode .. Fix interactive mapframe not interactive in embed mode Bug:

[MediaWiki-commits] [Gerrit] mapdata[master]: build: Replace jscs+jshint with eslint

2016-11-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/320714 Change subject: build: Replace jscs+jshint with eslint .. build: Replace jscs+jshint with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Gracefully handle broken ExternalData groups, by not crashin...

2016-11-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/320538 Change subject: Gracefully handle broken ExternalData groups, by not crashing and displaying a user-friendly warning .. Gracefully handle

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Search .mw-body instead of #content to support all the skins

2016-11-07 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/320303 Change subject: Search .mw-body instead of #content to support all the skins .. Search .mw-body instead of #content to support all the skins

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fixes frameless right alignment not being applied

2016-11-04 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/319964 Change subject: Fixes frameless right alignment not being applied .. Fixes frameless right alignment not being applied Bug: T150063

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Sets font size to 14px for both static and interactive maps

2016-11-02 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/319488 Change subject: Sets font size to 14px for both static and interactive maps .. Sets font size to 14px for both static and interactive maps

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix static mapframes not showing as block

2016-11-02 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/319382 Change subject: Fix static mapframes not showing as block .. Fix static mapframes not showing as block Bug: T149831 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show MapPin icon next to all links

2016-11-01 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/319247 Change subject: Show MapPin icon next to all links .. Show MapPin icon next to all links * VW maplinks with counter are not impacted by

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Use unique dom tag for static and interactive mapframe

2016-10-27 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/318469 Change subject: Use unique dom tag for static and interactive mapframe .. Use unique dom tag for static and interactive mapframe Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Disable hash update temporarily, to avoid polluting browser ...

2016-10-27 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/318425 Change subject: Disable hash update temporarily, to avoid polluting browser history .. Disable hash update temporarily, to avoid polluting

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Remove static background image once the map is interactive

2016-10-26 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/318115 Change subject: Remove static background image once the map is interactive .. Remove static background image once the map is interactive

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Implement first phase of Kartographer event logging.

2016-10-25 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317996 Change subject: Implement first phase of Kartographer event logging. .. Implement first phase of Kartographer event logging. Bug: T149140

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Implement first phase of map event logging.

2016-10-25 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317995 Change subject: Implement first phase of map event logging. .. Implement first phase of map event logging. * Uses mw.track to track

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fixes dialog concurrent setup events, skip openFullScreen wh...

2016-10-24 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317558 Change subject: Fixes dialog concurrent setup events, skip openFullScreen when updating hash .. Fixes dialog concurrent setup events, skip

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: WIP: Upgrade mapbox.js to v3.0 (upgrade leaflet to 1.0)

2016-10-24 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317546 Change subject: WIP: Upgrade mapbox.js to v3.0 (upgrade leaflet to 1.0) .. WIP: Upgrade mapbox.js to v3.0 (upgrade leaflet to 1.0) Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show the More details button when map is loaded

2016-10-21 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317297 Change subject: Show the More details button when map is loaded .. Show the More details button when map is loaded Bug: T148882 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: WV: Make sure mw.storage is loaded before using it

2016-10-21 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317198 Change subject: WV: Make sure mw.storage is loaded before using it .. WV: Make sure mw.storage is loaded before using it Bug: T148865

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Upgrade data lib to fix bug when API returns no data for groups

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317092 Change subject: Upgrade data lib to fix bug when API returns no data for groups .. Upgrade data lib to fix bug when API returns no data for

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix mapbox and other map scripts always loaded by VE

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317080 Change subject: Fix mapbox and other map scripts always loaded by VE .. Fix mapbox and other map scripts always loaded by VE Bug: T148511

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Enable double click zoom in full screen mode

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317078 Change subject: Enable double click zoom in full screen mode .. Enable double click zoom in full screen mode Bug: T148671 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix how Wikivoyage shows external groups in the layers dropdown

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317076 Change subject: Fix how Wikivoyage shows external groups in the layers dropdown .. Fix how Wikivoyage shows external groups in the layers

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Force non-breaking space with CSS

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317067 Change subject: Force non-breaking space with CSS .. Force non-breaking space with CSS Bug: T147943 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Use map snapshot service until user interacts

2016-10-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/317018 Change subject: Use map snapshot service until user interacts .. Use map snapshot service until user interacts Bug: T148070 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fixes maplink external groups being applied multiple times

2016-10-19 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/316903 Change subject: Fixes maplink external groups being applied multiple times .. Fixes maplink external groups being applied multiple times

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Introduce map sidebar, for displaying map details and extern...

2016-09-20 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/311709 Change subject: Introduce map sidebar, for displaying map details and external map services. .. Introduce map sidebar, for displaying map

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: WIP: Add module for collecting Kartographer metrics

2016-09-19 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/311462 Change subject: WIP: Add module for collecting Kartographer metrics .. WIP: Add module for collecting Kartographer metrics Pending: *

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Double click on map opens full screen at same position

2016-09-16 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/311145 Change subject: Double click on map opens full screen at same position .. Double click on map opens full screen at same position Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add missing mediawiki.api dep to extension.json

2016-09-16 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/311132 Change subject: Add missing mediawiki.api dep to extension.json .. Add missing mediawiki.api dep to extension.json Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Data option should be carried over to the full screen map

2016-09-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310883 Change subject: Data option should be carried over to the full screen map .. Data option should be carried over to the full screen map

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Disable click on map links until JavaScript is ready.

2016-09-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310882 Change subject: Disable click on map links until JavaScript is ready. .. Disable click on map links until JavaScript is ready. Bug: T144459

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Move CloseFullScreenControl to the dialog module.

2016-09-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310850 Change subject: Move CloseFullScreenControl to the dialog module. .. Move CloseFullScreenControl to the dialog module. Bug: T145774

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix map popup CSS

2016-09-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310842 Change subject: Fix map popup CSS .. Fix map popup CSS Bug: T145716 Change-Id: I59faad1a7ebd8b2794bd07f22d904c5438a4de19 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add missing close button title message

2016-09-15 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310833 Change subject: Add missing close button title message .. Add missing close button title message Bug: T145774 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Map should take viewport width/height instead of body width/...

2016-09-14 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310559 Change subject: Map should take viewport width/height instead of body width/height .. Map should take viewport width/height instead of body

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show globe icon next to all links

2016-09-12 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309997 Change subject: Show globe icon next to all links .. Show globe icon next to all links * Uses MIT licensed globe icon from Ionicons icon

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Rename globe icon

2016-09-12 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/310043 Change subject: Rename globe icon .. Rename globe icon Bug: T145176 Change-Id: Ibf282a1d8c60527fb9550289a7fd99e9a4d70f9f --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Wake the map after 500ms instead of 1s

2016-09-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309546 Change subject: Wake the map after 500ms instead of 1s .. Wake the map after 500ms instead of 1s Bug: T145169 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: VE: Fix "Done" disabled state when moving the map

2016-09-09 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309545 Change subject: VE: Fix "Done" disabled state when moving the map .. VE: Fix "Done" disabled state when moving the map Bug: T145154

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show current zoom in edit preview & VE mode

2016-09-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309349 Change subject: Show current zoom in edit preview & VE mode .. Show current zoom in edit preview & VE mode Bug: T129875 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Show snapshot map image as background for non-js clients

2016-09-08 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309321 Change subject: Show snapshot map image as background for non-js clients .. Show snapshot map image as background for non-js clients Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fixes call to addDataLayer() when using Kartographer API dir...

2016-09-07 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/309020 Change subject: Fixes call to addDataLayer() when using Kartographer API directly .. Fixes call to addDataLayer() when using Kartographer

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Set initial zoom to 13 only when it makes sense.

2016-09-05 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/308603 Change subject: Set initial zoom to 13 only when it makes sense. .. Set initial zoom to 13 only when it makes sense. Bug: T144766

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix map dialog not displaying properly in RTL mode

2016-09-01 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/307962 Change subject: Fix map dialog not displaying properly in RTL mode .. Fix map dialog not displaying properly in RTL mode Bug: T144498

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix map overlapping on mobile

2016-08-31 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/307884 Change subject: Fix map overlapping on mobile .. Fix map overlapping on mobile Change-Id: Ied52fedd71b2d4adbbbd88bad7c5ac0b72bc468c --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Fix map position when switching from align=right to align=ce...

2016-08-31 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/307722 Change subject: Fix map position when switching from align=right to align=center .. Fix map position when switching from align=right to

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Map should be destroyed as soon as the dialog closes.

2016-08-29 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/307299 Change subject: Map should be destroyed as soon as the dialog closes. .. Map should be destroyed as soon as the dialog closes. Bug: T144072

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: WV: Clicking "nearby articles" toggles data layers

2016-08-26 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/306947 Change subject: WV: Clicking "nearby articles" toggles data layers .. WV: Clicking "nearby articles" toggles data layers Bug: T137357

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Upgrading leaflet.sleep fixes mapframes in IE11

2016-08-26 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/306942 Change subject: Upgrading leaflet.sleep fixes mapframes in IE11 .. Upgrading leaflet.sleep fixes mapframes in IE11 Bug: T143883 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: VE: map should always be interactive within the dialog

2016-08-26 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/306932 Change subject: VE: map should always be interactive within the dialog .. VE: map should always be interactive within the dialog Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Import wmui-base.less and override leaflet styling to match ...

2016-08-24 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/306557 Change subject: Import wmui-base.less and override leaflet styling to match wikimedia style. .. Import wmui-base.less and override leaflet

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Nearby markers and popups style should be consistent.

2016-08-24 Thread JGirault (Code Review)
JGirault has uploaded a new change for review. https://gerrit.wikimedia.org/r/306558 Change subject: Nearby markers and popups style should be consistent. .. Nearby markers and popups style should be consistent. Bug: T143835

  1   2   3   >