[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Adjust the HTML output of the ArticlePlaceholder structure

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Adjust the HTML output of the ArticlePlaceholder structure
..


Adjust the HTML output of the ArticlePlaceholder structure

In order to make the placeholders are semantically well structured, removed 
unnecessary classes and div/p tag.

Bug: T144589
Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
---
M includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
M 
modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
2 files changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua 
b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
index ee7c6ba..018245f 100644
--- a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
+++ b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
@@ -30,7 +30,7 @@
   end
 end
   end
-  return result .. '' .. mainsnak .. '' .. reference .. 
'' .. qualifier
+  return result .. '' .. mainsnak .. 
reference .. qualifier .. ''
 end
 
 -- Get a function which is bound to the given entityrenderer.
diff --git 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
index 2205ecb..38dd701 100644
--- 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
+++ 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
@@ -59,15 +59,6 @@
   margin-top: 1.5em;
 }
 
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-}
-
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-  margin-left: 1.5em;
-}
-
 .articleplaceholder-qualifier {
   margin-left: 1em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/309954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Adjust the HTML output of the ArticlePlaceholder structure

[Lucie Kaffee (Code Review)]

Lucie Kaffee has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/309954

Change subject: Adjust the HTML output of the ArticlePlaceholder structure
..

Adjust the HTML output of the ArticlePlaceholder structure

In order to make the placeholders are semantically well structured, removed 
unnecessary classes and div/p tag.

Bug: T144589
Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
---
M includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
M 
modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
2 files changed, 1 insertion(+), 10 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder 
refs/changes/54/309954/1

diff --git a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua 
b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
index ee7c6ba..83efc85 100644
--- a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
+++ b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
@@ -30,7 +30,7 @@
   end
 end
   end
-  return result .. '' .. mainsnak .. '' .. reference .. 
'' .. qualifier
+return result .. '' .. mainsnak .. 
reference .. qualifier .. ''
 end
 
 -- Get a function which is bound to the given entityrenderer.
diff --git 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
index 2205ecb..38dd701 100644
--- 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
+++ 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
@@ -59,15 +59,6 @@
   margin-top: 1.5em;
 }
 
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-}
-
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-  margin-left: 1.5em;
-}
-
 .articleplaceholder-qualifier {
   margin-left: 1em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/309954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits