[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Don't use ES6 Number.isNaN

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374376 )

Change subject: Don't use ES6 Number.isNaN
..


Don't use ES6 Number.isNaN

Number.isNaN is a new function introduced in ECMAScript 6.
MediaWiki only requires ECMAScript 5 supports from browsers.
Notably, Opera 12 does not have Number.isNaN. Instead, use
the global isNaN function (which behaves the same except for
non-numeric inputs).

Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/userSettings.js
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/374376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Don't use ES6 Number.isNaN

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/374376 )

Change subject: Don't use ES6 Number.isNaN
..

Don't use ES6 Number.isNaN

Number.isNaN is a new function introduced in ECMAScript 6.
MediaWiki only requires ECMAScript 5 supports from browsers.
Notably, Opera 12 does not have Number.isNaN. Instead, use
the global isNaN function (which behaves the same except for
non-numeric inputs).

Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e
---
M src/userSettings.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/76/374376/1

diff --git a/src/userSettings.js b/src/userSettings.js
index f63a096..244552e 100644
--- a/src/userSettings.js
+++ b/src/userSettings.js
@@ -83,7 +83,7 @@
count = parseInt( result, 10 );
 
// stored number is not a zero, override it to zero and 
store new value
-   if ( Number.isNaN( count ) ) {
+   if ( isNaN( count ) ) {
count = 0;
this.setPreviewCount( count );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/374376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits