[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn...

2017-07-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364846 )

Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn 
sniff
..


Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn sniff

Bug: T168384
Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
---
M includes/PopupsContext.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/includes/PopupsContext.php b/includes/PopupsContext.php
index d508fb8..e6ffc6a 100644
--- a/includes/PopupsContext.php
+++ b/includes/PopupsContext.php
@@ -149,7 +149,7 @@
/**
 * Are Page previews visible on User Preferences Page
 *
-* return @bool
+* @return bool
 */
public function showPreviewsOptInOnPreferencesPage() {
return !$this->isBetaFeatureEnabled()
diff --git a/phpcs.xml b/phpcs.xml
index ce0878d..d29b557 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,7 +1,6 @@
 
 

-   




-- 
To view, visit https://gerrit.wikimedia.org/r/364846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn...

2017-07-12 Thread Pmiazga (Code Review) 
Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364846 )

Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn 
sniff
..

Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn sniff

Bug: T168384
Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
---
M includes/PopupsContext.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/46/364846/1

diff --git a/includes/PopupsContext.php b/includes/PopupsContext.php
index f3408b8..da58f29 100644
--- a/includes/PopupsContext.php
+++ b/includes/PopupsContext.php
@@ -148,7 +148,7 @@
/**
 * Are Page previews visible on User Preferences Page
 *
-* return @bool
+* @return bool
 */
public function showPreviewsOptInOnPreferencesPage() {
return !$this->isBetaFeatureEnabled()
diff --git a/phpcs.xml b/phpcs.xml
index 26c9398..4a1221a 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,7 +3,6 @@



-   




-- 
To view, visit https://gerrit.wikimedia.org/r/364846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits