[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Give a text label to the Feed overflow menu button.

2016-09-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Give a text label to the Feed overflow menu button.
..


Give a text label to the Feed overflow menu button.

Because our "custom" overflow button uses @null as its title, it can lead
to some unexpected behavior. For example, in the rare case when this
button is forced to overflow into the "real" overflow menu provided by
Android, the resulting menu item appears empty.

This patch simply provides a text label for the custom overflow button, so
that if it overflows "for real", it will at least have a label.

Bug: T145911
Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
---
M app/src/main/res/menu/menu_feed.xml
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
3 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Niedzielski: Looks good to me, approved



diff --git a/app/src/main/res/menu/menu_feed.xml 
b/app/src/main/res/menu/menu_feed.xml
index 2cabd05..8900889 100644
--- a/app/src/main/res/menu/menu_feed.xml
+++ b/app/src/main/res/menu/menu_feed.xml
@@ -10,7 +10,7 @@
 android:title="@string/menu_page_show_tabs"
 app:showAsAction="ifRoom"/>
 
 
diff --git a/app/src/main/res/values-qq/strings.xml 
b/app/src/main/res/values-qq/strings.xml
index d78bf1c..ce57ed1 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -384,6 +384,7 @@
   Menu item used for hiding a certain 
item in the list of feed cards.
   Message to inform the user that the 
selected item has been hidden.
   Text included as the 
subject when a user shares an image from the Today\'s Featured Image feed 
card.
+  Label for toolbar menu item that 
shows the user more options, such as logging in and accessing the app 
settings.
   Menu item label for exploring Wikipedia content through 
Feed cards.
 {{Identical|Explore}}
   Feed card button label for requesting 
more similar cards.
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index c545333..9e21e10 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -311,6 +311,7 @@
 Download
 Hide this card
 Card hidden.
+More options
 
 Featured image from 
Wikimedia Commons
 Explore

-- 
To view, visit https://gerrit.wikimedia.org/r/311413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Give a text label to the Feed overflow menu button.

2016-09-19 Thread Dbrant (Code Review) 
Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311413

Change subject: Give a text label to the Feed overflow menu button.
..

Give a text label to the Feed overflow menu button.

Because our "custom" overflow button uses @null as its title, it can lead
to some unexpected behavior. For example, in the rare case when this
button is forced to overflow into the "real" overflow menu provided by
Android, the resulting menu item appears empty.

This patch simply provides a text label for the custom overflow button, so
that if it overflows "for real", it will at least have a label.

Bug: T145911
Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
---
M app/src/main/res/menu/menu_feed.xml
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
3 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/13/311413/1

diff --git a/app/src/main/res/menu/menu_feed.xml 
b/app/src/main/res/menu/menu_feed.xml
index 2cabd05..8900889 100644
--- a/app/src/main/res/menu/menu_feed.xml
+++ b/app/src/main/res/menu/menu_feed.xml
@@ -10,7 +10,7 @@
 android:title="@string/menu_page_show_tabs"
 app:showAsAction="ifRoom"/>
 
 
diff --git a/app/src/main/res/values-qq/strings.xml 
b/app/src/main/res/values-qq/strings.xml
index d78bf1c..ce57ed1 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -384,6 +384,7 @@
   Menu item used for hiding a certain 
item in the list of feed cards.
   Message to inform the user that the 
selected item has been hidden.
   Text included as the 
subject when a user shares an image from the Today\'s Featured Image feed 
card.
+  Label for toolbar menu item that 
shows the user more options, such as logging in and accessing the app 
settings.
   Menu item label for exploring Wikipedia content through 
Feed cards.
 {{Identical|Explore}}
   Feed card button label for requesting 
more similar cards.
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index c545333..9e21e10 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -311,6 +311,7 @@
 Download
 Hide this card
 Card hidden.
+More options
 
 Featured image from 
Wikimedia Commons
 Explore

-- 
To view, visit https://gerrit.wikimedia.org/r/311413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits