[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Remove obsolete 'position' annotations from ResourceLoader m...

2018-01-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404898 )

Change subject: Remove obsolete 'position' annotations from ResourceLoader 
module definitons
..


Remove obsolete 'position' annotations from ResourceLoader module definitons

Defining the position of where the ResourceLoader module should be
loaded has been obsolete since 1.29.0 and now load asynchronously.
See: I6c21e3e47c23df33a04c42ce94bd4c1964599c7f

Change-Id: I7360e259647c9024482374af455b4ec7d13ee883
---
M SocialProfile.php
M SystemGifts/extension.json
M UserActivity/extension.json
M UserBoard/extension.json
M UserGifts/extension.json
M UserProfile/UserProfile.php
M UserRelationship/extension.json
M UserStats/extension.json
M UserWelcome/extension.json
9 files changed, 24 insertions(+), 52 deletions(-)

Approvals:
  Jack Phoenix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SocialProfile.php b/SocialProfile.php
index 7bd5de6..405f2e8 100644
--- a/SocialProfile.php
+++ b/SocialProfile.php
@@ -118,14 +118,12 @@
 // General
 $wgResourceModules['ext.socialprofile.clearfix'] = array(
'styles' => 'clearfix.css',
-   'position' => 'top',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
 
 $wgResourceModules['ext.socialprofile.responsive'] = array(
'styles' => 'responsive.less',
-   'position' => 'top',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
@@ -135,14 +133,12 @@
 // @see https://phabricator.wikimedia.org/T100025
 $wgResourceModules['ext.socialprofile.flash'] = array(
'scripts' => 'flash.js',
-   'position' => 'bottom',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
 
 $wgResourceModules['ext.socialprofile.LightBox'] = array(
'scripts' => 'LightBox.js',
-   'position' => 'bottom',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
diff --git a/SystemGifts/extension.json b/SystemGifts/extension.json
index 2e84d47..271cc90 100644
--- a/SystemGifts/extension.json
+++ b/SystemGifts/extension.json
@@ -60,32 +60,25 @@
},
"ResourceModules": {
"ext.socialprofile.systemgifts.css": {
-   "styles": "SystemGift.css",
-   "position": "top"
+   "styles": "SystemGift.css"
},
"ext.socialprofile.special.removemastersystemgift.css": {
-   "styles": "SpecialRemoveMasterSystemGift.css",
-   "position": "top"
+   "styles": "SpecialRemoveMasterSystemGift.css"
},
"ext.socialprofile.special.systemgiftmanager.css": {
-   "styles": "SpecialSystemGiftManager.css",
-   "position": "top"
+   "styles": "SpecialSystemGiftManager.css"
},
"ext.socialprofile.special.systemgiftmanagerlogo.css": {
-   "styles": "SpecialSystemGiftManagerLogo.css",
-   "position": "top"
+   "styles": "SpecialSystemGiftManagerLogo.css"
},
"ext.socialprofile.special.topawards.css": {
-   "styles": "SpecialTopAwards.css",
-   "position": "top"
+   "styles": "SpecialTopAwards.css"
},
"ext.socialprofile.special.viewsystemgift.css": {
-   "styles": "SpecialViewSystemGift.css",
-   "position": "top"
+   "styles": "SpecialViewSystemGift.css"
},
"ext.socialprofile.special.viewsystemgifts.css": {
-   "styles": "SpecialViewSystemGifts.css",
-   "position": "top"
+   "styles": "SpecialViewSystemGifts.css"
}
},
"ResourceFileModulePaths": {
diff --git a/UserActivity/extension.json b/UserActivity/extension.json
index 2df8cfc..35736f1 100644
--- a/UserActivity/extension.json
+++ b/UserActivity/extension.json
@@ -29,8 +29,7 @@
},
"ResourceModules": {
"ext.socialprofile.useractivity.css": {
-   "styles": "UserActivity.css",
-   "position": "top"
+   "styles": "UserActivity.css"
}
},
"ResourceFileModulePaths": {
diff --git a/UserBoard/extension.json b/UserBoard/extension.json
index fc922b9..0dbc920 100644
--- a/UserBoard/extension.json
+++ b/UserBoard/extension.json
@@ -50,12 +50,10 @@
]
},
"ext.socialprofile.userboard.css": {
-   "styles": "UserBoard.css",
-

[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Remove obsolete 'position' annotations from ResourceLoader m...

2018-01-17 Thread SamanthaNguyen (Code Review) 
SamanthaNguyen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404898 )

Change subject: Remove obsolete 'position' annotations from ResourceLoader 
module definitons
..

Remove obsolete 'position' annotations from ResourceLoader module definitons

Defining the position of where the ResourceLoader module should be
loaded has been obsolete since 1.29.0 and now load asynchronously.
See: I6c21e3e47c23df33a04c42ce94bd4c1964599c7f

Change-Id: I7360e259647c9024482374af455b4ec7d13ee883
---
M SocialProfile.php
M SystemGifts/extension.json
M UserActivity/extension.json
M UserBoard/extension.json
M UserGifts/extension.json
M UserProfile/UserProfile.php
M UserRelationship/extension.json
M UserStats/extension.json
M UserWelcome/extension.json
9 files changed, 24 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile 
refs/changes/98/404898/1

diff --git a/SocialProfile.php b/SocialProfile.php
index 7bd5de6..405f2e8 100644
--- a/SocialProfile.php
+++ b/SocialProfile.php
@@ -118,14 +118,12 @@
 // General
 $wgResourceModules['ext.socialprofile.clearfix'] = array(
'styles' => 'clearfix.css',
-   'position' => 'top',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
 
 $wgResourceModules['ext.socialprofile.responsive'] = array(
'styles' => 'responsive.less',
-   'position' => 'top',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
@@ -135,14 +133,12 @@
 // @see https://phabricator.wikimedia.org/T100025
 $wgResourceModules['ext.socialprofile.flash'] = array(
'scripts' => 'flash.js',
-   'position' => 'bottom',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
 
 $wgResourceModules['ext.socialprofile.LightBox'] = array(
'scripts' => 'LightBox.js',
-   'position' => 'bottom',
'localBasePath' => __DIR__ . '/shared',
'remoteExtPath' => 'SocialProfile/shared',
 );
diff --git a/SystemGifts/extension.json b/SystemGifts/extension.json
index 2e84d47..271cc90 100644
--- a/SystemGifts/extension.json
+++ b/SystemGifts/extension.json
@@ -60,32 +60,25 @@
},
"ResourceModules": {
"ext.socialprofile.systemgifts.css": {
-   "styles": "SystemGift.css",
-   "position": "top"
+   "styles": "SystemGift.css"
},
"ext.socialprofile.special.removemastersystemgift.css": {
-   "styles": "SpecialRemoveMasterSystemGift.css",
-   "position": "top"
+   "styles": "SpecialRemoveMasterSystemGift.css"
},
"ext.socialprofile.special.systemgiftmanager.css": {
-   "styles": "SpecialSystemGiftManager.css",
-   "position": "top"
+   "styles": "SpecialSystemGiftManager.css"
},
"ext.socialprofile.special.systemgiftmanagerlogo.css": {
-   "styles": "SpecialSystemGiftManagerLogo.css",
-   "position": "top"
+   "styles": "SpecialSystemGiftManagerLogo.css"
},
"ext.socialprofile.special.topawards.css": {
-   "styles": "SpecialTopAwards.css",
-   "position": "top"
+   "styles": "SpecialTopAwards.css"
},
"ext.socialprofile.special.viewsystemgift.css": {
-   "styles": "SpecialViewSystemGift.css",
-   "position": "top"
+   "styles": "SpecialViewSystemGift.css"
},
"ext.socialprofile.special.viewsystemgifts.css": {
-   "styles": "SpecialViewSystemGifts.css",
-   "position": "top"
+   "styles": "SpecialViewSystemGifts.css"
}
},
"ResourceFileModulePaths": {
diff --git a/UserActivity/extension.json b/UserActivity/extension.json
index 2df8cfc..35736f1 100644
--- a/UserActivity/extension.json
+++ b/UserActivity/extension.json
@@ -29,8 +29,7 @@
},
"ResourceModules": {
"ext.socialprofile.useractivity.css": {
-   "styles": "UserActivity.css",
-   "position": "top"
+   "styles": "UserActivity.css"
}
},
"ResourceFileModulePaths": {
diff --git a/UserBoard/extension.json b/UserBoard/extension.json
index fc922b9..0dbc920 100644
--- a/UserBoard/extension.json
+++ b/UserBoard/extension.json
@@ -50,12 +50,10 @@
]
},
"ext.socialprofile.userboard.css": {
-   "styles":