Hi Dave,
Thank you for these ideas.Since I posted this the code has got longer
as I have dived in and added more comments and docstrings to all the
properties. Once I have finished commenting and documenting the
functional code I will look at breaking it out in to separate files. I
could pr
Hello Alaa,
First off I must apologise for not responding earlier, gmail insists on
filing all my melbourne-pug emails way over there hidden away from my
normal inbox!
Thank you for looking at the code and providing feedback! This is the sort
of useful information I was hoping to get! Once I
Hey David,
I've been working on something similar for the Sungrow SH5K inverter
talking through the Modbus protocol. From looking over your code briefly,
it's an almost 2000 line script, I can't easily make sense of what your
logic is.
I'd take the long list of initializations out as a dictionary
Hi David,
I am not sure what kind of code review you're after but I had a quick
look at the code and though I can't comment on the functionality, there
are a few things that stand out.
1- That's a lot of code to sit in a single file, you might want to
consider splitting it up over multiple f
On 18 May 2018 at 13:40, paul sorenson wrote:
> My inverter came with a CD-ROM which would push a cloud somewhere but I
> reckon it would be fun to crowd source really granular data.
>
The ability to push clouds is a great feature for a solar inverter to have.
--
William Leslie
Notice:
Likely
Hey David,
I probably can't run that on my inverter but I wrote some similar code
for Aurora brand a while back.
My inverter came with a CD-ROM which would push a cloud somewhere but I
reckon it would be fun to crowd source really granular data.
cheers
On 05/17/2018 04:35 PM, David Crisp wrote
Hi David,
I can’t speak for everyone on the list but for me this is exactly the kind of
stuff I want to see on here: cool Python solutions to problems affecting global
and, particularly, local challenges. We’re going to put solar on our house
sometime in the next year, and the availability of P
