Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

Yuya Nishihara a écrit : > This is totally unrelated topic, but how would we do if we want to support > non-contiguous range? > > -L file,a:b,c:d > > is ambiguous because file may contain ",". I guess we could iteratively rsplit(",", 1) the file pattern and try to parse "from:to" until it

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

The series looks good to me, thanks for doing that work! Just a few notes about these todos. Yuya Nishihara a écrit : # HG changeset patch # User Yuya Nishihara # Date 1516521882 -32400 # Sun Jan 21 17:04:42 2018 +0900 # Node ID 3dd9becb635b9e077b53f140c65f349cb0776991 #

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

dlax added a comment. sangeet259 (Sangeet Kumar Mishra) wrote: > @dlax https://phab.mercurial-scm.org/p/dlax/ Yes, but the short > summary didn't say what it does! It just says "include the specified > changeset". I agree it's not super-clear. Perhaps we could say "clone only

[PATCH 2 of 2 v2] log: make --line-range and --graph options work together

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518369441 -3600 # Sun Feb 11 18:17:21 2018 +0100 # Node ID ceacb9e94803aafae2f1a677ccaa63068c3c4ed7 # Parent f994010b9f093a1645875b4e905fcf9d21a5eaa9 # EXP-Topic log/linerange-graph log: make --line-range and -

[PATCH 1 of 2 v2] tests: fix check for --graph option in test-log-linerange.t

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518356135 -3600 # Sun Feb 11 14:35:35 2018 +0100 # Node ID f994010b9f093a1645875b4e905fcf9d21a5eaa9 # Parent f91b7f26c68ac87961aa6ef883ba96e5a2822ad3 # EXP-Topic log/linerange-graph tests: fix check for --graph

Re: [PATCH 2 of 2] log: make --line-range and --graph options work together

Denis Laxalde a écrit : # HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518356534 -3600 # Sun Feb 11 14:42:14 2018 +0100 # Node ID 72ad5a53d41102d5e67a925cabc1aa9635d1fda8 # Parent 50e9309bc899d5366811e8da9fe4dcc303aa4796 # EXP-Topic log/linerange-graph log

[PATCH 2 of 2] log: make --line-range and --graph options work together

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518356534 -3600 # Sun Feb 11 14:42:14 2018 +0100 # Node ID 72ad5a53d41102d5e67a925cabc1aa9635d1fda8 # Parent 50e9309bc899d5366811e8da9fe4dcc303aa4796 # EXP-Topic log/linerange-graph log: make --line-range and -

[PATCH 1 of 2] tests: fix check for --graph option in test-log-linerange.t

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518356135 -3600 # Sun Feb 11 14:35:35 2018 +0100 # Node ID 50e9309bc899d5366811e8da9fe4dcc303aa4796 # Parent de0666564bde7c67c4d40a44dcf50515fef2f367 # EXP-Topic log/linerange-graph tests: fix check for --graph

[PATCH] rebase: make "successors" a set in _computeobsoletenotrebased()

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518287599 -3600 # Sat Feb 10 19:33:19 2018 +0100 # Node ID fd7d3104bc3e199c7894ebed5413a86d4825ca11 # Parent de0666564bde7c67c4d40a44dcf50515fef2f367 # EXP-Topic issue5782 rebase: make "succes

[PATCH 2 of 3] rebase: eliminate node from successors early in _computeobsoletenotrebased()

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518209116 -3600 # Fri Feb 09 21:45:16 2018 +0100 # Node ID 864f2bc67aa90f1ae762206925906950b6258c2f # Parent 12c15d19266ee99f4d7de6c308286aa5c8a602a6 # EXP-Topic issue5782 rebase: eliminate node from successors

[PATCH 1 of 3] rebase: add a test case for issue5782

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1518001573 -3600 # Wed Feb 07 12:06:13 2018 +0100 # Node ID 12c15d19266ee99f4d7de6c308286aa5c8a602a6 # Parent 2912bed9b0c7d02a1cac6f56584c0c0a2f9debe4 # EXP-Topic issue5782 rebase: add a test case for iss

[PATCH 3 of 3] rebase: do not consider extincts for divergence detection (issue5782)

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1518212960 -3600 # Fri Feb 09 22:49:20 2018 +0100 # Node ID efb6929261e3fc640941c1b8fc9b0e378722d379 # Parent 864f2bc67aa90f1ae762206925906950b6258c2f # EXP-Topic issue5782 rebase: do not consider extincts for dive

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

dlax added a comment. As mentioned in the issue, there's already an explanation paragraph help: To pull only a subset of changesets, specify one or more revisions identifiers with -r/--rev or branches with -b/--branch. The resulting clone will contain only the specified

Re: [PATCH 6 of 6] log: pack filematcher and hunksfilter into changesetdiffer object

Yuya Nishihara a écrit : > # HG changeset patch > # User Yuya Nishihara > # Date 1516517658 -32400 > # Sun Jan 21 15:54:18 2018 +0900 > # Node ID 5f9dcb5d72da427abbfa2c304bdbe4dd555e0c7d > # Parent f95d0d1e012a512550de945350e08f3dc7db090f > log: pack filematcher and

D1616: rebase: disable `inmemory` if the rebaseset contains the working copy

dlax added a comment. In https://phab.mercurial-scm.org/D1616#27819, @durin42 wrote: > @dlax I see a request changes here, but I don't see any commentary as to why? I meant to comment that the first hunks (i.e. those above the big comment block) seem unrelated and to ask for

D1249: rebase: rerun a rebase on-disk if IMM merge conflicts arise

dlax added inline comments. INLINE COMMENTS > durin42 wrote in rebase.py:667 > Avoiding the recursion seems like a nice thing to me. I prefer what Phil has > to just doing recursion... Why would that be nice? Do you foresee any problem? It just makes the code harder to follow, IMHO. Besides,

D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase

dlax added a comment. dlax (Denis Laxalde) wrote: > Also, would be nice to have some test coverage. Unless I missed it, there's still no test at all for the --inmemory option in this series. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1

D1249: rebase: rerun a rebase on-disk if IMM merge conflicts arise

dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rebase.py:667 > + > +def _origrebase(ui, repo, **opts): > """move changeset (and descendants) to a different branch Do we need to make another function?

D1245: rebase: pass wctx to rebasenode()

dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rebase.py:995 > > -def rebasenode(repo, rev, p1, base, state, collapse, dest): > +def rebasenode(repo, rev, p1, base, state, collapse, dest, wctx=None): >

D1246: rebase: do not update if IMM; instead, set the overlaywctx's parents

dlax requested changes to this revision. dlax added a comment. This revision now requires changes to proceed. Needs test. INLINE COMMENTS > rebase.py:1003 > # Update to destination and merge it with local > -if repo['.'].rev() != p1: > -repo.ui.debug(" update to %d:%s\n" %

D1244: overlayworkingctx: invalidate the manifest cache when changing parents

dlax added inline comments. INLINE COMMENTS > context.py:2003 > +# Drop old manifest cache: > +self._invalidate() > Wouldn't `util.clearcachedproperty(self, '_manifest')` work? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1244 To: phillco,

D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase

dlax added inline comments. INLINE COMMENTS > rebase.py:738 > +if 'inmemory' not in opts: > +opts['inmemory'] = False > rbsrt = rebaseruntime(repo, ui, opts) This is useless because "inmemory" will be in `opts` and because you wrote `opts.get('inmemory', False)` in

Re: [PATCH 2 of 2 evolve-ext V2] help: fix output for `hg help -e evolve` wrt 'touch' command

Kyle Lippincott via Mercurial-devel a écrit : > # HG changeset patch > # User Kyle Lippincott > # Date 1512519068 28800 > # Tue Dec 05 16:11:08 2017 -0800 > # Node ID d584dfa21ea0bfa8a0fde0800978e8e682fa7544 > # Parent 21abe1e218b87428e4249e67990c345c63d521f6 > help:

D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase

dlax requested changes to this revision. dlax added a comment. This revision now requires changes to proceed. > In the future, the --inmemory flag might be deprecated in favor of something more intelligent Perhaps the option should be flagged experimental then? Also, would be nice

D939: remotenames: add functionality to store remotenames under .hg/hgremotenames/

dlax added a comment. pulkit (Pulkit Goyal) a écrit : > Updated the series with new differentials https://phab.mercurial-scm.org/D1547 > https://phab.mercurial-scm.org/D1547 to https://phab.mercurial-scm.org/D1551 > https://phab.mercurial-scm.org/D1551. Why creating new

D1502: rewriteutil: add utility function to check if we can create new unstable cset

dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rewriteutil.py:20 > +To allow new unstable changesets, set the config: > +`experimental.evolution.allounstable=True` > +""" typo: allounstable

D1502: rewriteutil: add utility function to check if we can create new unstable cset

dlax added a comment. > This rewriteutil.py introduced in this patch and the utility functions added in the upcoming patches exists in the evolve extension are being ported from there. Is it worth porting this alone if nothing in core makes use of this module? Or is there a larger

Re: [PATCH v3] cmdutil: add within-line color diff capacity

matthieu.laneuvi...@octobus.net a écrit : # HG changeset patch # User Matthieu Laneuville # Date 1508944418 -32400 # Thu Oct 26 00:13:38 2017 +0900 # Node ID e4b4d581af0fc4e39a28150470b5a658d8315a3f # Parent 75013952d8d9608f73cd45f68405fbd6ec112bf2 #

D1483: globalopts: make special flags ineffective after '--' (BC)

dlax added inline comments. INLINE COMMENTS > dispatch.py:715 > +return True > +return False > + I find the algorithm a bit clumsy (usage of both `in` and `.index()` for the same value), how about a for loop like that: for arg in args: if arg == optname:

Re: [PATCH] templates: reword 'back to filelog' link anchor text

Jordi Gutiérrez Hermoso a écrit : # HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1511206254 18000 # Mon Nov 20 14:30:54 2017 -0500 # Node ID 9f2ad7bc901216d6340952f463ab06568fc82dfb # Parent 75013952d8d9608f73cd45f68405fbd6ec112bf2 templates: reword 'back

Re: [PATCH] hgweb: show commit phase if it's not public

Gregory Szorc a écrit : On Thu, Nov 16, 2017 at 7:53 PM, Anton Shestakov wrote: # HG changeset patch # User Anton Shestakov # Date 1510842063 -28800 # Thu Nov 16 22:21:03 2017 +0800 # Node ID f1e997d4a24fb59ddd33c3780104dc002f870f5c # Parent

[PATCH v2] rebase: exclude descendants of obsoletes w/o a successor in dest (issue5300)

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510695970 -3600 # Tue Nov 14 22:46:10 2017 +0100 # Node ID 5dae1b5b2877b300c224011233fcc9cb6aaa9144 # Parent 0564e7c7f4cdbb98ea0ffb3f2c26946dbc0599ac # EXP-Topic rebase-obsolete rebase: exclude descendants of obsolet

Re: [PATCH 4 of 4] rebase: exclude obsoletes without a successor in destination (issue5300)

Martin von Zweigbergk a écrit : On Tue, Nov 14, 2017 at 3:24 AM, Denis Laxalde <de...@laxalde.org> wrote: Martin von Zweigbergk a écrit : On Mon, Nov 13, 2017 at 3:07 PM, Augie Fackler <r...@durin42.com> wrote: On Sun, Nov 12, 2017 at 06:06:37PM +0100, Denis Laxalde wrote: #

Re: [PATCH 4 of 4] rebase: exclude obsoletes without a successor in destination (issue5300)

Martin von Zweigbergk a écrit : On Mon, Nov 13, 2017 at 3:07 PM, Augie Fackler <r...@durin42.com> wrote: On Sun, Nov 12, 2017 at 06:06:37PM +0100, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510489041 -3600 # Sun Nov 12 13:17:2

D1358: remotenames: store journal entry for bookmarks if journal is loaded

dlax added a comment. The state of this stack is not quite clear: there are abandoned revisions and the first changeset (introducing "mercurial/remotenames.py" file) seems to be missing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1358 To: pulkit,

D1371: global: remove redundant parenthesis

dlax added a comment. LGTM modulo a few nits. Nice cleanup. INLINE COMMENTS > hgk.py:79 > ('S', 'search', "", _('search'))], > -('[OPTION]... NODE1 NODE2 [FILE]...'), > + '[OPTION]... NODE1 NODE2 [FILE]...', > inferrepo=True) Why this extra indentation? > hgk.py:337 >

D1378: bundlerepo: assign bundle attributes in bundle type blocks

dlax added inline comments. INLINE COMMENTS > bundlerepo.py:298 > > -self._handlebundle2part(part) > +self._handlebundle2part(bundle, part) > Within `_handlebundle2part`, there's still a `self._bundle = changegroup.getunbundler(...)` statement. Perhaps, it'd

[PATCH 4 of 4] rebase: exclude obsoletes without a successor in destination (issue5300)

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510489041 -3600 # Sun Nov 12 13:17:21 2017 +0100 # Node ID 25d1891bd300bc527cb7e878532c8512ff5489de # Parent 1d16e28225e01d2fac9f31ed058ae1f4c00bb9da # EXP-Topic rebase-obsolete rebase: exclude obsoletes w

[PATCH 2 of 4] tests: conditionally display obsfate in test-rebase-obsolete log output

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510002482 -3600 # Mon Nov 06 22:08:02 2017 +0100 # Node ID 11248bc63ec98b3105f8476557ae8da0ced994ac # Parent 8ee0103a7206e30a08c1587962122b5cb239bc9b # EXP-Topic rebase-obsolete tests: conditionally display obsfate i

[PATCH 3 of 4] tests: add a couple of 'hg log' calls in test-rebase-obsolete.t

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510424732 -3600 # Sat Nov 11 19:25:32 2017 +0100 # Node ID 1d16e28225e01d2fac9f31ed058ae1f4c00bb9da # Parent 11248bc63ec98b3105f8476557ae8da0ced994ac # EXP-Topic rebase-obsolete tests: add a couple of 'hg log'

[PATCH 1 of 4] tests: clarify a comment in test-rebase-obsolete.t

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1510424611 -3600 # Sat Nov 11 19:23:31 2017 +0100 # Node ID 8ee0103a7206e30a08c1587962122b5cb239bc9b # Parent 407ec7f3ff02ae357074104fe892adc2b12b42a7 # EXP-Topic rebase-obsolete tests: clarify a comment in test-

D1372: bundlerepo: make methods agree with base class

dlax added a comment. > For methods that are implemented, we change arguments to match the base. Alternatively, we could use `**kwargs` for keywords arguments unused in a method. I think that's a common pattern and it avoids confusing the reader with unused arguments. REPOSITORY rHG

Re: [PATCH 2 of 2] tests: use jshint when available to check .js files

LGTM. Anton Shestakov a écrit : # HG changeset patch # User Anton Shestakov # Date 1510384041 -28800 # Sat Nov 11 15:07:21 2017 +0800 # Node ID 42809ebcbc783e0d27385c6ea1e1731df44a4f4e # Parent 36e26161d81233a8ef18e40b4198d86b23113159 tests: use jshint when available

Re: [PATCH 3 of 3] hgweb: add missing semicolons to followlines.js

The series looks good to me, thanks. Anton Shestakov a écrit : # HG changeset patch # User Anton Shestakov # Date 1510312446 -28800 # Fri Nov 10 19:14:06 2017 +0800 # Node ID 981d7ebd7dc74a88493f39982649a52ed09a199b # Parent 95cb67784e3c0d05e24e387acda45fd1c8aa4653

D1348: histedit: add support to output nodechanges using formatter

dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > histedit.py:920 > + ('r', 'rev', [], _('first revision to be edited'), _('REV'))] + > + cmdutil.templateopts, > _("[OPTIONS] ([ANCESTOR] |

[PATCH] revert: do not reverse hunks in interactive when REV is not parent (issue5096)

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1509716857 -3600 # Fri Nov 03 14:47:37 2017 +0100 # Node ID 095ef7f12cb36330d5e2b35b6c93fe27f6c1aacc # Parent 7ebf850d3166a64ff33b4b85adb481b533ddbf86 # Available At http://hg.logilab.org/users/dlaxa

Re: [PATCH RFC] revert: no longer mark --interactive as experimental

Martin von Zweigbergk a écrit : On Thu, Nov 2, 2017 at 7:16 AM, Denis Laxalde <de...@laxalde.org> wrote: Augie Fackler a écrit : On Nov 2, 2017, at 09:39, Martin von Zweigbergk via Mercurial-devel < mercurial-devel@mercurial-scm.org> wrote: Can we still change the behavior o

Re: [PATCH RFC] revert: no longer mark --interactive as experimental

g that could be used instead. On Thu, Nov 2, 2017, 05:47 Yuya Nishihara <y...@tcha.org> wrote: On Thu, 2 Nov 2017 10:03:44 +0100, Denis Laxalde wrote: Augie Fackler a écrit : # HG changeset patch # User Augie Fackler <au...@google.com> # Date 150939

Re: [PATCH RFC] revert: no longer mark --interactive as experimental

Augie Fackler a écrit : # HG changeset patch # User Augie Fackler # Date 1509399967 14400 # Mon Oct 30 17:46:07 2017 -0400 # Node ID a2fc2086ac3116c63ab890180697b2695c50d9f4 # Parent 3ce0e4b51f789eff195ec900a07c1fa5e8d5c5f2 revert: no longer mark --interactive as

D1270: help: adding a topic on flags

dlax added inline comments. INLINE COMMENTS > flags.txt:30 > +In order to set a default value for a flag in an hgrc file, set it under the > +[defaults] section of the hgrc file:: > + `hg help config` says that "defaults" are deprecated and that aliases should be used instead. REPOSITORY

[PATCH 3 of 5] log: disable bare file patterns with --line-range

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1508415169 -7200 # Thu Oct 19 14:12:49 2017 +0200 # Node ID ce22c9db68b10ac17086a4f213b22d3304f09bad # Parent 252117224ee9e8c3ab488575203ed27c292752bd # EXP-Topic followlines-cli log: disable bare file pa

[PATCH 2 of 5] log: switch to FROMLINE:TOLINE syntax for -L/--line-range

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1508409446 -7200 # Thu Oct 19 12:37:26 2017 +0200 # Node ID 252117224ee9e8c3ab488575203ed27c292752bd # Parent a5f0f523e960a7aa3ded8dd5d120058bc2a37044 # EXP-Topic followlines-cli log: switch to FROMLINE:TOLINE

[PATCH 5 of 5] log: add an assertion about fctx not being None in patch.diff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1508418393 -7200 # Thu Oct 19 15:06:33 2017 +0200 # Node ID e2b8b1cb1eaf17739d7af35479b853214daad35d # Parent d07a2cce2a4826f69cf2a6db12cc6721d95002a2 # EXP-Topic followlines-cli log: add an assertion abou

[PATCH 4 of 5] log: handle removed files with --line-range patterns

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1508417710 -7200 # Thu Oct 19 14:55:10 2017 +0200 # Node ID d07a2cce2a4826f69cf2a6db12cc6721d95002a2 # Parent ce22c9db68b10ac17086a4f213b22d3304f09bad # EXP-Topic followlines-cli log: handle removed files with

[PATCH 1 of 5] log: handle binary files in --line-range patterns

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1508346033 -7200 # Wed Oct 18 19:00:33 2017 +0200 # Node ID a5f0f523e960a7aa3ded8dd5d120058bc2a37044 # Parent 315e04247750ad4983d648d3ba002eb328624b70 # EXP-Topic followlines-cli log: handle binary files in --line

D1173: rebase: add support to output nodechanges

dlax accepted this revision. dlax added a comment. Looks good to me, much nicer than the previous version. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1173 To: pulkit, #hg-reviewers, dlax Cc: dlax, mercurial-devel

[PATCH 1 of 4 v4] revset: extract a parsefollowlinespattern helper function

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507123663 -7200 # Wed Oct 04 15:27:43 2017 +0200 # Node ID 73dcd7f479a2481be007de11b03e834aec334ffd # Parent 68e0bcb903572cb3641c1b1ac11bdcf47d4ff5ac # EXP-Topic followlines-cli revset: e

[PATCH 4 of 4 v4] log: add -L/--line-range option to follow file history by line range

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1508267731 -7200 # Tue Oct 17 21:15:31 2017 +0200 # Node ID 601ab53301506bc35ab75adc8de9f611af9b3d80 # Parent 909a69f31ef323ded6fef8dd56fb44dc97f4cd89 # EXP-Topic followlines-cli log: add -L/--line-range

[PATCH 3 of 4 v4] diff: pass a diff hunks filter function from changeset_printer to patch.diff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507293917 -7200 # Fri Oct 06 14:45:17 2017 +0200 # Node ID 909a69f31ef323ded6fef8dd56fb44dc97f4cd89 # Parent c73893dd6cfb5693029f5d9dcf1d537197b40a4a # EXP-Topic followlines-cli diff: pass a diff hunks

[PATCH 2 of 4 v4] diff: also yield file context objects in patch.trydiff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507231208 -7200 # Thu Oct 05 21:20:08 2017 +0200 # Node ID c73893dd6cfb5693029f5d9dcf1d537197b40a4a # Parent 73dcd7f479a2481be007de11b03e834aec334ffd # EXP-Topic followlines-cli diff: also yield file context o

[PATCH] show: use labelcset() template alias for work (and stack) views

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1508264743 -7200 # Tue Oct 17 20:25:43 2017 +0200 # Node ID 9af9aa26a601cf26aca9320d0384857fe09fa28b # Parent 68e0bcb903572cb3641c1b1ac11bdcf47d4ff5ac # EXP-Topic show-obs-info show: use labelcset() template alias fo

Re: [PATCH] tests: update output for no-symlink platforms

Matt Harbison a écrit : # HG changeset patch # User Matt Harbison # Date 1508101054 14400 # Sun Oct 15 16:57:34 2017 -0400 # Node ID 22d774b9dbab4689b186afc8acbca3165cd2a660 # Parent cfb054a7ecc45bcaac95f1e64b644dd0411ffe41 tests: update output for no-symlink

D1063: rebase: enable multidest by default

dlax added a comment. In https://phab.mercurial-scm.org/D1063#18725, @durin42 wrote: > (Note that I'd still welcome feedback from non-BigCo contributors here - is this something we should make permanent? Have people been testing this? Etc.) I have never tested this but it seems

Re: [PATCH 4 of 4 v3] log: add -L/--line-range option to follow file history by line range

Augie Fackler a écrit : (+jordigh, themystic, indygreg in case one of them has an opinion or inspiration) On Oct 13, 2017, at 10:24 AM, Yuya Nishihara <y...@tcha.org> wrote: On Fri, 13 Oct 2017 10:02:07 +0200, Denis Laxalde wrote: Yuya Nishihara a écrit : On Tue, 10 Oct 2017 17:37:27

[PATCH] transaction-summary: use a revset to filter obsoletes in reportnewcs()

# HG changeset patch # User Denis Laxalde <de...@laxalde.org> # Date 1508160908 -7200 # Mon Oct 16 15:35:08 2017 +0200 # Node ID 4454e61fb17068293bbe3cc273e21400e9eb784a # Parent 115efdd9708811859c466c363311f93b3500a72e # Available At http://hg.logilab.org/users/dlaxalde/hg #

D1074: branch: add a --rev flag to change branch name of given revisions

dlax added inline comments. INLINE COMMENTS > cmdutil.py:749 > +if len(heads) < 1: > +raise error.Abort(_("cannot change branch in betwen the stack")) > + typo: betwen Also, I'm not sure "between" is appropriate here. Maybe "cannot change branch in the middle of a stack"? >

D1082: split: new extension to split changesets

dlax added inline comments. INLINE COMMENTS > split.py:53 > + > +Repetitively prompt changes and commit message for new changesets until > +there is nothing left in the original changeset. Not sure "repetitively" exists. Maybe "repeatedly"? REPOSITORY rHG Mercurial REVISION DETAIL

D1073: commands: move a bunch of statements into if True for next patch

dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > commands.py:1048 > scmutil.checknewlabel(repo, label, 'branch') > -repo.dirstate.setbranch(label) > -ui.status(_('marked

D1072: tersestatus: rework dirnode and tersedir docstrings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG23eb03f46929: tersestatus: rework dirnode and tersedir docstrings (authored by dlax, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 5 of 6] templates: introduce labelcset() function in map-cmdline.default as example

Yuya Nishihara a écrit : # HG changeset patch # User Yuya Nishihara # Date 1507973041 -32400 # Sat Oct 14 18:24:01 2017 +0900 # Node ID 1fa8afb93739b8233c6744c2b59fec6e9dee073a # Parent 48c3ed364bcac4e271d21cc1cde1c73704641b0c templates: introduce labelcset() function in

D1072: tersestatus: rework dirnode and tersedir docstrings

dlax created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Follow-up on refactorings https://phab.mercurial-scm.org/rHG3d6d4b12128e8056f988bf36be1fc46e4c7b29dc and

D1042: tersestatus: make methods part of the dirnode class

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d6d4b12128e: tersestatus: make methods part of the dirnode class (authored by dlax, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1043: tersestatus: avoid modifying tersedict

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5d98674df18a: tersestatus: avoid modifying tersedict (authored by dlax, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1043?vs=2647=2718

D985: tersestatus: re-implement the functionality to terse the status

dlax added a comment. In https://phab.mercurial-scm.org/D985#17380, @pulkit wrote: > The next two patches https://phab.mercurial-scm.org/D1042 and https://phab.mercurial-scm.org/D1043, though sent by me are patches by Denis. They were some good cleanups which I think was wrong to fold

D1047: tweakdefaults: add restack command

dlax added a comment. As an end user, I'd probably not use this; it's too much magic. INLINE COMMENTS > ui.py:56 > +# Destination revset explanation: > +# - max(roots(ALLSRC) & ::SRC)^ > +# The obsoleted changeset that the SRC stack is based on. Maybe also explain what `ALLSRC` and `SRC`

D1044: bisect: add --abort flag

dlax added inline comments. INLINE COMMENTS > commands.py:809 > +hbisect.resetstate(repo) > +ui.warn(_('bisect aborted\n')) > +return This "bisect aborted" message is not very useful (especially at "warning" level): either the command fails with a message or it succeeds

Re: [PATCH 4 of 4 v3] log: add -L/--line-range option to follow file history by line range

Yuya Nishihara a écrit : On Tue, 10 Oct 2017 17:37:27 +0200, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507290475 -7200 # Fri Oct 06 13:47:55 2017 +0200 # Node ID a05d3b45319a9ec28205f19dd7012b206a2b200f #

Re: [PATCH v2] transaction-summary: show the range of new revisions upon pull/unbundle (BC)

Kevin Bullock a écrit : On Oct 12, 2017, at 03:13, Denis Laxalde <de...@laxalde.org> wrote: # HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507793990 -7200 # Thu Oct 12 09:39:50 2017 +0200 # Node ID 48cca33a1b611c82a2bd72a2f72b80f321604

D985: tersestatus: re-implement the functionality to terse the status

dlax added inline comments. INLINE COMMENTS > pulkit wrote in cmdutil.py:558 > Well I agree with you on this. Yesterday I accidentally stumbled on your repo > at hg.logilab.org/ by clicking a link in one of the commit message and saw > that you have the above feedback implemented yourself.

Re: [PATCH 2 of 2 V2] test: add an extra case for obsolescence distributed case

Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1506807440 -3600 # Sat Sep 30 22:37:20 2017 +0100 # Node ID 10194608efe05c44ebcd86e618a313942a65a167 # Parent 74998bff9b03f613236c22422b0305a25834ef9e # EXP-Topic obs-tests # Available

D937: remotenames: move function to pull remotenames from the remoterepo to core

dlax added inline comments. INLINE COMMENTS > ryanmce wrote in remotenames.py:11-16 > nit: for multiline docblocks, I prefer to leave the first line empty: > > """ > pulls bookmarks and branches information of the remote repo during a > pull or clone operation. > > localrepo is our

Re: [PATCH 2 of 2] test: add an extra case for obsolescence distributed case

Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1506807440 -3600 # Sat Sep 30 22:37:20 2017 +0100 # Node ID cf572fd4e79604e0f774869c11e24b05f1d3517f # Parent 8252157034b4e4f9f851f328633ef86df44cc9cf # EXP-Topic obs-tests # Available At

Re: [PATCH 1 of 2] test: add a test file dedicated to an important distributed case

Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1506711555 -3600 # Fri Sep 29 19:59:15 2017 +0100 # Node ID 8252157034b4e4f9f851f328633ef86df44cc9cf # Parent 60213a2eca81af4e1daa3ef9e44af859ba1e5756 # EXP-Topic obs-tests # Available At

D985: tersestatus: re-implement the functionality to terse the status

dlax added inline comments. INLINE COMMENTS > pulkit wrote in commands.py:4794 > I can implement your suggestion using following ways: > > 1. add 'clean' and 'unknown' to `show` variable and take them out later as > that variable is used later also > > 2. add a new variable which handles

Re: [PATCH 3 of 3] transaction-summary: display the range of new revisions upon pull/unbundle

Augie Fackler a écrit : On Wed, Oct 04, 2017 at 06:52:45PM +0200, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507135871 -7200 # Wed Oct 04 18:51:11 2017 +0200 # Node ID ae007b70b03657bbb92f4b73e6e0c807669dae10 #

D1016: repoview: remove incorrect documentation of the function

dlax added inline comments. INLINE COMMENTS > repoview.py:104 > - > -Secret and hidden changeset should not pretend to be here.""" > assert not repo.changelog.filteredrevs Maybe update the docstring instead of removing? REPOSITORY rHG Mercurial REVISION DETAIL

D1012: repoview: add two new filternames to be used for accessing hidden commits

dlax added a comment. In https://phab.mercurial-scm.org/D1012#17020, @dlax wrote: > (Also having an actual use of the new behavior in the patch series would help understanding the intent.) Hm, I now see it's used in some other differentials but they do not appear in this stack

D1012: repoview: add two new filternames to be used for accessing hidden commits

dlax requested changes to this revision. dlax added a comment. This revision now requires changes to proceed. The idea of using different names to control the behavior of the filter function sounds strange to me. Maybe `repoview.filterrevs()` could accept `**kwargs` that would be passed to

D1011: localrepo: add a _pinnedrevs attribute

dlax added inline comments. INLINE COMMENTS > repoview.py:38 > pinned.update([par.rev() for par in repo[None].parents()]) > pinned.update([cl.rev(bm) for bm in repo._bookmarks.values()]) > Updating a "private" attribute of an object outside the class is not nice. Not sure about

[PATCH 3 of 4 v3] diff: pass a diff hunks filter function from changeset_printer to patch.diff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507293917 -7200 # Fri Oct 06 14:45:17 2017 +0200 # Node ID 86a055d1c06f55daeb5d725187b61522974d24e3 # Parent a19df8faa9a949376ead8de088a026667fdeed5a # Available At http://hg.logilab.org/users/dlaxa

[PATCH 4 of 4 v3] log: add -L/--line-range option to follow file history by line range

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507290475 -7200 # Fri Oct 06 13:47:55 2017 +0200 # Node ID a05d3b45319a9ec28205f19dd7012b206a2b200f # Parent 86a055d1c06f55daeb5d725187b61522974d24e3 # Available At http://hg.logilab.org/users/dlaxa

[PATCH 2 of 4 v3] diff: also yield file context objects in patch.trydiff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507231208 -7200 # Thu Oct 05 21:20:08 2017 +0200 # Node ID a19df8faa9a949376ead8de088a026667fdeed5a # Parent ed448196d36e77587bf8471405dc46df39320e2e # Available At http://hg.logilab.org/users/dlaxa

[PATCH 1 of 4 v3] revset: extract a parsefollowlinespattern helper function

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507123663 -7200 # Wed Oct 04 15:27:43 2017 +0200 # Node ID ed448196d36e77587bf8471405dc46df39320e2e # Parent e41138bb56bcde3db4d5277b31eca03007119ead # Available At http://hg.logilab.org/users/dlaxa

Re: [PATCH 1 of 4] patch: rename "header" variable into "hdr" in diff()

Augie Fackler a écrit : On Wed, Oct 04, 2017 at 05:03:59PM +0200, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1506442667 -7200 # Tue Sep 26 18:17:47 2017 +0200 # Node ID 3d8ed7dafee4676b49922a3dde0edf1b1fad63ec #

Re: [PATCH 11 of 11] obsfate: add obsfate to default mapfile

Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1507305216 -7200 # Fri Oct 06 17:53:36 2017 +0200 # Node ID ab0796c0fbce5d8314511bf08ea5b6b4cf0b9dfc # Parent 1943f74e8e4cb6bd1d44910898fffcaec7a56ca1 # EXP-Topic obsfatekeyword # Available At

Re: [PATCH 3 of 5] bookmark: add a dedicated pretxnclose-bookmark hook

Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1507481414 -7200 # Sun Oct 08 18:50:14 2017 +0200 # Node ID c7b1a3b41823e4e4969e17feefaaede4c89fe48c # Parent 7a2a2f58094560b307ba7980904dd4fc0087eddb # EXP-Topic b2.phases.hooks # Available At

D985: tersestatus: re-implement the functionality to terse the status

dlax requested changes to this revision. dlax added a comment. This revision now requires changes to proceed. Just a couple of comments (mostly Python things) based on a first quick read. I haven't closely looked at the algorithm yet. Thanks for working back on this! INLINE COMMENTS >

[PATCH 1 of 4 v2] revset: extract a parsefollowlinespattern helper function

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507123663 -7200 # Wed Oct 04 15:27:43 2017 +0200 # Node ID 947254876fc535ab622a8eff43b88fe88df90924 # Parent 2fd06499dc8e6a5a784b1334b925c289d7b54e4e # EXP-Topic followlines-cli/v2 revset: e

[PATCH 2 of 4 v2] diff: also yield file context objects in patch.trydiff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507231208 -7200 # Thu Oct 05 21:20:08 2017 +0200 # Node ID 2727029988a085830fb9eac444d7b37b7d8b98ed # Parent 947254876fc535ab622a8eff43b88fe88df90924 # EXP-Topic followlines-cli/v2 diff: also yield file c

[PATCH 3 of 4 v2] diff: pass a diff hunks filter function from changeset_printer to patch.diff()

# HG changeset patch # User Denis Laxalde <denis.laxa...@logilab.fr> # Date 1507293917 -7200 # Fri Oct 06 14:45:17 2017 +0200 # Node ID 60ec507b90ea07a43f1e5d572f0b990128909eb8 # Parent 2727029988a085830fb9eac444d7b37b7d8b98ed # EXP-Topic followlines-cli/v2 diff: pass a diff hunks

<    1   2   3   4   5   6   >