D8265: git: key off `git` in .hg/requires rather than separate file

durin42 retitled this revision from "git: key off `git` in .hg/requirements rather than separate file" to "git: key off `git` in .hg/requires rather than separate file". durin42 marked an inline comment as done. durin42 updated this revision to Diff 20669. REPOSITORY rHG Mercurial CHANGES

D8271: git: correctly handle p1() on dirstate when underlying git repo is empty

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This shows up in my next change, which ends up making an empty git repo and then running hg. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 added inline comments. durin42 marked 4 inline comments as done. INLINE COMMENTS > martinvonz wrote in test-git-interop.t:5-11 > `$` prefix on these too since you're cleaning up anyway? My understanding is that the > will cause the lines to all happen in the same shell invocation,

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in __init__.py:89 > Why not use `.hg/requires`? Because I have the dumb. Will fix shortly. > pulkit wrote in dirstate.py:79 > looks like unrelated change which should be in separate patch? Sigh, you're right, and I'm being

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 updated this revision to Diff 20667. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20666=20667 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8265

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 marked an inline comment as done. durin42 updated this revision to Diff 20666. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20665=20666 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 added inline comments. durin42 marked an inline comment as done. INLINE COMMENTS > mharbison72 wrote in __init__.py:104 > Shouldn't it be an error if `git` is in requirements, but `.git` doesn't > exist? Or is there something in the original function that will raise an > error in this

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 updated this revision to Diff 20665. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20664=20665 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8265

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 updated this revision to Diff 20664. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8265?vs=20614=20664 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8265/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8265

D8266: localrepo: add git extension to autoextensions list

Closed by commit rHG8407f8678a77: localrepo: add git extension to autoextensions list (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8266?vs=20615=20622

D8264: gitlog: implement __iter__ on changelog

Closed by commit rHG3e5293769f22: gitlog: implement __iter__ on changelog (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8264?vs=20613=20621 CHANGES SINCE

D8263: gitlog: fix embarassing bug that prevented log from showing correct parents

Closed by commit rHG559e31eabc3d: gitlog: fix embarassing bug that prevented log from showing correct parents (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8262: git: add readfast() method to manifest

Closed by commit rHGff465d38cf45: git: add readfast() method to manifest (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8262?vs=20611=20619 CHANGES SINCE

D8254: nodemap: fix missing r-prefix on regular expression

Closed by commit rHG50b570f04abb: nodemap: fix missing r-prefix on regular expression (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8254?vs=20569=20617

D8266: localrepo: add git extension to autoextensions list

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8266 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D8265: git: key off `git` in .hg/requirements rather than separate file

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8265 AFFECTED FILES hgext/git/__init__.py CHANGE DETAILS diff --git

D8264: gitlog: implement __iter__ on changelog

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows `hg phase --force --draft -r .` to work, for example. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8263: gitlog: fix embarassing bug that prevented log from showing correct parents

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We had the correct parents in the database, but the changelog was always returning p1 for all parents. Oops. REPOSITORY rHG Mercurial BRANCH default

D8262: git: add readfast() method to manifest

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Mysteriously, on a different system a handful of things don't work without this, including log. This is especially odd to be because log works in the test. In

D8261: git: hack around import checker being confused about the provenance of pygit2

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8261 AFFECTED FILES hgext/git/index.py CHANGE DETAILS diff --git

D8260: git: hide pygit2 imports from gendoc and other scripts not using demandimport

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, I can't seem to build a working rpm for my fedora machine. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D6734: git: skeleton of a new extension to _directly_ operate on git repos

Closed by commit rHG62165f6c5a1a: git: skeleton of a new extension to _directly_ operate on git repos (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 updated this revision to Diff 20573. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20572=20573 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734

D8255: cleanup: run pyupgrade on our source tree to clean up varying things

Closed by commit rHG9d2b2df2c2ba: cleanup: run pyupgrade on our source tree to clean up varying things (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 marked 3 inline comments as done. durin42 updated this revision to Diff 20572. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20536=20572 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in gitlog.py:150 > I think I asked because I noticed that the `shortest()` template function > always returned the full hash and things were really slow (I assume that was > because of the byte string on line 173, not here).

D8255: cleanup: run pyupgrade on our source tree to clean up varying things

durin42 created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: martinvonz. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Built with: hg files 'set:**.py - mercurial/thirdparty/** -

D8254: nodemap: fix missing r-prefix on regular expression

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looking at this regular expression, it's pretty obvious from reading it that it wanted to match literal ., but since the r was missing on the pattern it was

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 added a comment. Alright, TODO.md updated. Let me know if there's anything missing. I'm motivated to land this, since I'm now getting more than one patch /a week/ for this code and managing it is tricky. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 updated this revision to Diff 20536. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20471=20536 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734

D8222: commands: switch one call of check_at_most_one_arg to strings

Closed by commit rHG5a5aee8ba980: commands: switch one call of check_at_most_one_arg to strings (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8200: pull: add `--confirm` flag to confirm before writing changes

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. (marking as needs-changes since we've got consensus) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8200/new/ REVISION DETAIL

D8215: rust-status: move to recursive traversal to prepare for parallel traversal

durin42 added a comment. I'm broadly happy with this series, but: 1. I get test-check-rust-format.t errors 2. I don't seem to be having any luck running the tests. It looks like the rust module policy doesn't cause the right things to get installed? In particular,

D8136: phabricator: add a `phabimport` command

durin42 added inline comments. INLINE COMMENTS > mharbison72 wrote in phabricator.py:1693 > I'm not quite sure the context. I didn't realize this until recently, but > apparently `+` is a valid operator like with revsets. That said, I strung > together two heads with common ancestors, `+`,

D8210: debugbackupbundle: make py3 fixes and add `test-` prefix to test file

durin42 added a comment. durin42 added a reviewer: pulkit. durin42 commandeered this revision. Folding into that revision per request. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8210/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8210 To:

D8222: commands: switch one call of check_at_most_one_arg to strings

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This opts hasn't been through the byteskwargs mulcher, so we can just use strings here instead of bytes. Fixes the test changes from D8204

D8138: phabricator: add a config knob to create obsolete markers when importing

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. I'm on the fence about this, but overall it seems fine. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8138/new/ REVISION

D8137: phabricator: add a config knob to import in the secret phase

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. Seems fine. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8137/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8137

D8136: phabricator: add a `phabimport` command

durin42 added a comment. durin42 accepted this revision as: durin42. I like this, but have a question about a pony I kind of want as a follow-up. Will let someone else queue... INLINE COMMENTS > phabricator.py:1693 > +[(b'', b'stack', False, _(b'import dependencies as well'))], > +

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in __init__.py:38-39 > What blocks that? I've added a TODO.md that documents what needs to happen here (missing an interface.) > martinvonz wrote in __init__.py:68-72 > Or maybe pygit2 takes care of locking while it updates? So

D8217: hgit: make sure repository has store attribute before checking for type

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Could you rebase this on the new version of 6734? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8217/new/ REVISION DETAIL

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 marked 4 inline comments as done. durin42 updated this revision to Diff 20471. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20300=20471 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D8216: hgit: add addparentchangecallback() to dirstate

durin42 added a comment. durin42 added a reviewer: pulkit. durin42 commandeered this revision. Folded into D6734 , thanks REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8216/new/ REVISION DETAIL

D8177: hgit: fix some issues spotted by pylint integration with editor

durin42 added a comment. durin42 added a reviewer: pulkit. durin42 commandeered this revision. Folded this into the base revision, many thanks. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8177/new/ REVISION DETAIL

D7189: git: use bytes in command name, not unicode

durin42 added a comment. durin42 added a reviewer: maho. durin42 commandeered this revision. I've folded these into the base rev, thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7189/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7189

D7188: git: force using bytes in command name

durin42 added a comment. durin42 added a reviewer: maho. durin42 commandeered this revision. I've folded these into the base rev, thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7188/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7188

D8125: transactions: convert changes['phases'] to list of ranges

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Overall seems fine, some structural nits on the code. INLINE COMMENTS > phases.py:232 > + > +def insert(data, idx, rev, t): > +merge_before = False It doesn't look

D8200: pull: add `--confirm` flag to confirm before writing changes

durin42 added inline comments. INLINE COMMENTS > exchange.py:1807 > with wlock, repo.lock(), pullop.trmanager: > +if repo.ui.configbool(b"pull", b"confirm"): > +add_confirm_callback(repo, pullop) I think this should probably respect HGPLAIN. Thoughts? (Note that doing

D7922: rust-matchers: add function to generate a regex matcher function

durin42 added a comment. durin42 accepted this revision as: durin42. I think this looks good, but I want Martin to ack that his concern is adequately resolved. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL

D6825: hgext: start building a library for simple hooks

durin42 added a comment. durin42 added subscribers: marmoute, yuja, martinvonz. durin42 accepted this revision as: durin42. I'm happy with this, modulo my one question for other maintainers. If anyone else is happy, please feel encouraged to push it. INLINE COMMENTS > __init__.py:1 >

D6734: git: skeleton of a new extension to _directly_ operate on git repos

durin42 updated this revision to Diff 20300. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20230=20300 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734

D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote)

durin42 added a comment. I'm enthusiastic about this change, and in general a fan of declaring misfeatures in bookmarks exchange bugs. I think it's pretty clear the existing bookmarks exchange behavior isn't right to the point of being buggy. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 added a comment. This is now ready for review: I would be happy to see this land, and have others contribute towards it. I don't know that I have time to do all that needs doing, but would be delighted to mentor others that want to help! REPOSITORY rHG Mercurial CHANGES SINCE

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 20230. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20226=20230 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 updated this revision to Diff 20226. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20225=20226 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 updated this revision to Diff 20225. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20224=20225 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 20224. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=20144=20224 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D8115: rebase: show bug when rebasing merge with obsoleted revs on both sides

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY By inspection, the rebase should be fine: "just" omit 8 and 10 from the rebase. This is a simplified case of something we're seeing at Google. DO NOT

D8113: debugcommands: add templated command for reading the merge state for e.g. IDEs

durin42 added a comment. Why can't we add templater support to `debugmergestate` instead? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8113/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8113 To: martinvonz, #hg-reviewers Cc: durin42,

D8035: copy: add support for marking committed copies

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. In D8035#119861 , @marmoute wrote: > See my comment in D8030 , the feature is interresting, but it

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. Nevermind, I misread. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8034/new/ REVISION DETAIL

D8034: check-code: allow `hg cp -r`, by using a negative lookbehind

durin42 added a comment. I think this is obsolete now? Maybe? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8034/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8034 To: martinvonz, #hg-reviewers Cc: durin42, marmoute, mercurial-devel

D8033: copy: move argument validation a little earlier

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. Oddly, this had some rejects (I didn't look why) but i"d be happy to see this earlier in the series. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION

D8030: copy: add support for unmarking committed copies

durin42 added a comment. durin42 accepted this revision. I remain happy with this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8030/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8030 To: martinvonz, #hg-reviewers, durin42, marmoute Cc:

D8029: copy: add option to unmark file as copied

durin42 added a comment. durin42 accepted this revision. LGTM, would like @marmoute to chime in. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8029/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8029 To: martinvonz, #hg-reviewers, durin42,

D7932: debugstripbackups: introduce command to interact with strip backups

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. I think I'd prefer debugbackupbundle per marmoute's suggestion. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7932/new/ REVISION

D7258: makefile: use Python 3 by default outside of Windows (BC)

durin42 added a comment. durin42 accepted this revision. I like this, but I'm too chicken to queue it. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7258/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7258 To: indygreg,

D7796: rust-nodemap: input/output primitives

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. I'm just not comfortable with the `unsafe` block here, especially with the comments from @kevincox . That said, if the `unsafe` can't disappear, it probably needs a pretty

D7795: rust-nodemap: insert method

durin42 added a comment. In D7795#119774 , @marmoute wrote: > The change seesm good to me. However kevincox proposal to use `#[cfg(test)]` for `pad_node` seems worth applying inflight. For future reference, I'm going to add it here, but

D7972: recover: don't verify by default

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. In D7972#120504 , @valentin.gatienbaron wrote: >> I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. (Marking this as wanting changes per discussions about adding some headline numbers in the log message so I stop looking at it until that happens.) REPOSITORY rHG Mercurial

D8109: context: use manifest.find() instead of two separate calls

Closed by commit rHG2e2cfc3bea0b: context: use manifest.find() instead of two separate calls (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 added a comment. durin42 planned changes to this revision. Planned changes: - Fix up writing files not at repo root - Code formatting Uploaded mainly so people don't despair. I'm much happier with the manifest implementation now, and I think we're close to having something

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 20144. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=18757=20144 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D8109: context: use manifest.find() instead of two separate calls

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I noticed this while debugging an extension that's implementing the manifest interface. Always nice to save a function call. REPOSITORY rHG Mercurial BRANCH

D8085: manifest: move matches method to be outside the interface

Closed by commit rHG0bf3b5e80d30: manifest: move matches method to be outside the interface (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8107: tags: fix some type confusion exposed in python 3

Closed by commit rHGe80da7a63264: tags: fix some type confusion exposed in python 3 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8107?vs=20127=20140

D8108: tags: use modern // operator for division

Closed by commit rHG8ec186c1ccfe: tags: use modern // operator for division (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8108?vs=20128=20141 CHANGES SINCE

D8107: tags: fix some type confusion exposed in python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just b-prefix and %-format cleanup, no meaningful change REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8108: tags: use modern // operator for division

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes a test on Python 3. 1. skip-blame only correcting a division operator, not a substantive change REPOSITORY rHG Mercurial BRANCH default REVISION

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. In D7894#120247 , @marmoute wrote: > More throughful benchmarking has arrived. > This is a large win all over the board. The

D7842: nodemap: use an explicit "Block" object in the reference implementation

durin42 added inline comments. INLINE COMMENTS > nodemap.py:224 > + > +pass > + nit: you could have omitted this superfluous pass statement REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7842/new/ REVISION DETAIL

D8085: manifest: move matches method to be outside the interface

durin42 updated this revision to Diff 20101. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8085?vs=19928=20101 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8085/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8085

D8104: cleanup: re-run black on the codebase

Closed by commit rHGa0ec05d93c8e: cleanup: re-run black on the codebase (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar

durin42 added a comment. In D7960#120242 , @mharbison72 wrote: > I forgot to reply to this last week- I was concerned when the subsequent part of the stack went in without suppressing the per file progress bars here, that the displayed

D8104: cleanup: re-run black on the codebase

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like a few patches have landed without having been blackened. I strongly suspect I should write a patch for baymax that blackens things on the way in...

D7966: remotefilelog: only prefetch history in linkrevfixup

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Terrible damage: cd tests && python run-tests.py test-remotefilelog-linknodes.t running 1 tests using 1 parallel processes ---

D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar

durin42 added a comment. In D7960#119477 , @mharbison72 wrote: > In D7960#119446 , @marmoute wrote: > >> (also, the double sending is very sad, could we have a small wireprotocol command

D8100: help: add a mechanism to change flags' help depending on config

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. I'm a huge fan. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8100/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8100

D8099: lfs: use str for the open() mode when opening a blob for py3

durin42 added a comment. Forgot to say: I'd be a big fan of unwinding pycompat.open() now that we're done with the module transformer. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8099/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8099

D8099: lfs: use str for the open() mode when opening a blob for py3

durin42 added a comment. durin42 accepted this revision. Looks fine to me for default, queued. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8099/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8099 To: mharbison72, #hg-reviewers, pulkit,

D7972: recover: don't verify by default

durin42 added a comment. durin42 accepted this revision as: durin42. In D7972#120111 , @pulkit wrote: > Sorry for late reply. By changing the default, I am afraid about the cases where a user has broken repository and we only recover the

D8084: merge: use manifestdict.walk() instead of manifestdict.matches()

Closed by commit rHG0e5f6c70aeb4: merge: use manifestdict.walk() instead of manifestdict.matches() (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8084?vs=20004=20006#toc REPOSITORY rHG

D8082: manifest: rewrite filesnotin to not make superfluous manifest copies

Closed by commit rHGa4e045740619: manifest: rewrite filesnotin to not make superfluous manifest copies (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8082?vs=19925=20005#toc REPOSITORY

D8084: merge: use manifestdict.walk() instead of manifestdict.matches()

durin42 updated this revision to Diff 20004. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8084?vs=19927=20004 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8084/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8084

D8090: archival: use walk() instead of matches() on manifest

Closed by commit rHG3e6ac7ce1e2c: archival: use walk() instead of matches() on manifest (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8090?vs=19967=20003

D8081: manifest: fix _very_ subtle bug with exact matchers passed to walk()

Closed by commit rHG48a1a974a92c: manifest: fix _very_ subtle bug with exact matchers passed to walk() (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8090: archival: use walk() instead of matches() on manifest

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All we care about is the filepaths, so this avoids a pointless copy of the manifest that we only used to extract matching filenames. REPOSITORY rHG Mercurial

D8083: archival: use walk() instead of matches() on manifest

durin42 updated this revision to Diff 19966. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8083?vs=19952=19966 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8083/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8083

D8080: context: use manifest.walk() instead of manifest.match() to get file list

Closed by commit rHGbeea86e4d332: context: use manifest.walk() instead of manifest.match() to get file list (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

<    1   2   3   4   5   6   7   8   9   10   >